@wistia/eslint-config 2.4.5 → 2.4.7

package/.github/workflows/publish-branch-package.yml

@@ -29,7 +29,7 @@ jobs:
         uses: ./.github/actions/setup-node-env
 
       - name: Publish branch package to npm
-        uses: wistia/publish-branch-to-npm@v2.3.5
+        uses: wistia/publish-branch-to-npm@v2.3.6
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           npm_token: ${{ secrets.NPM_AUTH_TOKEN }}

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.7
+
+### Patch Changes
+
+- [#463](https://github.com/wistia/eslint-config/pull/463) [`96f0593`](https://github.com/wistia/eslint-config/commit/96f0593748b91e9501ac31a77b8fca7c1f96fbdc) Thanks [@okize](https://github.com/okize)! - fix: disable `non-nullable-type-assertion-style` to resolve conflict with `no-non-null-assertion`
+
+## 2.4.6
+
+### Patch Changes
+
+- [#460](https://github.com/wistia/eslint-config/pull/460) [`f64171a`](https://github.com/wistia/eslint-config/commit/f64171a08af79506c27f8612511285ad2e253d24) Thanks [@okize](https://github.com/okize)! - fix: disable `@typescript-eslint/init-declarations` because conflict with `no-useless-assignment`
+
 ## 2.4.5
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.5",
+  "version": "2.4.7",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",
@@ -42,8 +42,8 @@
     "@eslint/compat": "^2.0.3",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
-    "@typescript-eslint/eslint-plugin": "^8.57.2",
-    "@typescript-eslint/parser": "^8.57.2",
+    "@typescript-eslint/eslint-plugin": "^8.58.0",
+    "@typescript-eslint/parser": "^8.58.0",
     "@vitest/eslint-plugin": "^1.6.13",
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.4",
@@ -64,7 +64,7 @@
     "eslint-plugin-styled-components-a11y": "^2.2.1",
     "eslint-plugin-testing-library": "^7.16.2",
     "globals": "^17.4.0",
-    "globals-vitest": "^4.1.0"
+    "globals-vitest": "^4.1.2"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.6.0",
@@ -78,7 +78,7 @@
     "prettier": "^3.8.1",
     "storybook": "^10.3.3",
     "typescript": "^6.0.2",
-    "vitest": "^4.1.1"
+    "vitest": "^4.1.2"
   },
   "peerDependencies": {
     "eslint": ">= 10",

package/src/rules/typescript.mjs

@@ -204,7 +204,9 @@ export default {
 
   // Require or disallow initialization in variable declarations
   // https://typescript-eslint.io/rules/init-declarations
-  '@typescript-eslint/init-declarations': 'error',
+  // decision: disabled because it conflicts with `no-useless-assignment` — forcing initializers on
+  // `let` declarations that are immediately overwritten creates dead stores and obscures real bugs
+  '@typescript-eslint/init-declarations': 'off',
 
   // Enforce a maximum number of parameters in function definitions
   // https://typescript-eslint.io/rules/max-params
@@ -521,7 +523,9 @@ export default {
 
   // Enforce non-null assertions over explicit type casts
   // https://typescript-eslint.io/rules/non-nullable-type-assertion-style
-  '@typescript-eslint/non-nullable-type-assertion-style': 'error',
+  // decision: disabled because it conflicts with `no-non-null-assertion` — this rule's autofix
+  // rewrites `value as T` to `value!`, which `no-non-null-assertion` then rejects
+  '@typescript-eslint/non-nullable-type-assertion-style': 'off',
 
   // Disallow throwing non-Error values as exceptions
   // https://typescript-eslint.io/rules/only-throw-error

package/test/__snapshots__/javascript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.2",
+    "parser": "typescript-eslint/parser@8.58.0",
     "parserOptions": {
       "requireConfigFile": false,
     },

package/test/__snapshots__/typescript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.2",
+    "parser": "typescript-eslint/parser@8.58.0",
     "parserOptions": {
       "ecmaVersion": 2024,
       "project": "./tsconfig.json",
@@ -78,7 +78,7 @@
   "plugins": [
     "@",
     "@stylistic:@stylistic/eslint-plugin@5.10.0",
-    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.57.2",
+    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.58.0",
     "barrel-files:eslint-plugin-barrel-files@3.0.1",
     "filenames",
     "import-x:eslint-plugin-import-x@4.16.2",
@@ -737,7 +737,7 @@
       2,
     ],
     "@typescript-eslint/init-declarations": [
-      2,
+      0,
     ],
     "@typescript-eslint/max-params": [
       0,
@@ -1004,7 +1004,7 @@
       2,
     ],
     "@typescript-eslint/non-nullable-type-assertion-style": [
-      2,
+      0,
     ],
     "@typescript-eslint/only-throw-error": [
       2,