@wistia/eslint-config 2.4.4 → 2.4.6

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.6
+
+### Patch Changes
+
+- [#460](https://github.com/wistia/eslint-config/pull/460) [`f64171a`](https://github.com/wistia/eslint-config/commit/f64171a08af79506c27f8612511285ad2e253d24) Thanks [@okize](https://github.com/okize)! - fix: disable `@typescript-eslint/init-declarations` because conflict with `no-useless-assignment`
+
+## 2.4.5
+
+### Patch Changes
+
+- [#458](https://github.com/wistia/eslint-config/pull/458) [`b5f69cb`](https://github.com/wistia/eslint-config/commit/b5f69cb7fc61550f2f6c498bdbe1a370007604c2) Thanks [@okize](https://github.com/okize)! - fix: set `import-x/no-cycle` maxDepth to 2 for perofmance improvement
+
 ## 2.4.4
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.4",
+  "version": "2.4.6",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",
@@ -42,8 +42,8 @@
     "@eslint/compat": "^2.0.3",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
-    "@typescript-eslint/eslint-plugin": "^8.57.2",
-    "@typescript-eslint/parser": "^8.57.2",
+    "@typescript-eslint/eslint-plugin": "^8.57.3-alpha.2",
+    "@typescript-eslint/parser": "^8.57.3-alpha.2",
     "@vitest/eslint-plugin": "^1.6.13",
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.4",

package/src/rules/import.mjs

@@ -5,7 +5,8 @@ export default {
 
   // Forbid cyclical dependencies between modules
   // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-cycle.md
-  'import-x/no-cycle': ['error', { maxDepth: '∞' }],
+  // decision: set `maxDepth` to 2 because setting it higher is too much of a performance hit
+  'import-x/no-cycle': ['error', { maxDepth: 2 }],
 
   // ensure imports point to files/modules that can be resolved
   // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md

package/src/rules/typescript.mjs

@@ -204,7 +204,9 @@ export default {
 
   // Require or disallow initialization in variable declarations
   // https://typescript-eslint.io/rules/init-declarations
-  '@typescript-eslint/init-declarations': 'error',
+  // decision: disabled because it conflicts with `no-useless-assignment` — forcing initializers on
+  // `let` declarations that are immediately overwritten creates dead stores and obscures real bugs
+  '@typescript-eslint/init-declarations': 'off',
 
   // Enforce a maximum number of parameters in function definitions
   // https://typescript-eslint.io/rules/max-params

package/src/rules/vitest.mjs

@@ -222,7 +222,7 @@ export default {
   // Prefer vi.importActual/vi.importMock in vi.mock factories
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-import-in-mock.md
   // decision: potentially helpful but causes too many type errors
-  'vitest/prefer-import-in-mock': 'error',
+  'vitest/prefer-import-in-mock': 'off',
 
   // Prefer importing vitest globals instead of using them implicitly
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-importing-vitest-globals.md

package/test/__snapshots__/javascript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.2",
+    "parser": "typescript-eslint/parser@8.57.3-alpha.2",
     "parserOptions": {
       "requireConfigFile": false,
     },
@@ -915,7 +915,7 @@
       {
         "allowUnsafeDynamicCyclicDependency": false,
         "ignoreExternal": false,
-        "maxDepth": "∞",
+        "maxDepth": 2,
       },
     ],
     "import-x/no-default-export": [

package/test/__snapshots__/typescript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.2",
+    "parser": "typescript-eslint/parser@8.57.3-alpha.2",
     "parserOptions": {
       "ecmaVersion": 2024,
       "project": "./tsconfig.json",
@@ -78,7 +78,7 @@
   "plugins": [
     "@",
     "@stylistic:@stylistic/eslint-plugin@5.10.0",
-    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.57.2",
+    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.57.3-alpha.2",
     "barrel-files:eslint-plugin-barrel-files@3.0.1",
     "filenames",
     "import-x:eslint-plugin-import-x@4.16.2",
@@ -737,7 +737,7 @@
       2,
     ],
     "@typescript-eslint/init-declarations": [
-      2,
+      0,
     ],
     "@typescript-eslint/max-params": [
       0,
@@ -1375,7 +1375,7 @@
       {
         "allowUnsafeDynamicCyclicDependency": false,
         "ignoreExternal": false,
-        "maxDepth": "∞",
+        "maxDepth": 2,
       },
     ],
     "import-x/no-default-export": [

package/test/__snapshots__/vitest.mjs.snap

@@ -237,7 +237,7 @@
       2,
     ],
     "vitest/prefer-import-in-mock": [
-      2,
+      0,
       {
         "fixable": true,
       },