@wistia/eslint-config 2.4.4 → 2.4.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,11 @@
1
1
  # @wistia/eslint-config
2
2
 
3
+ ## 2.4.5
4
+
5
+ ### Patch Changes
6
+
7
+ - [#458](https://github.com/wistia/eslint-config/pull/458) [`b5f69cb`](https://github.com/wistia/eslint-config/commit/b5f69cb7fc61550f2f6c498bdbe1a370007604c2) Thanks [@okize](https://github.com/okize)! - fix: set `import-x/no-cycle` maxDepth to 2 for perofmance improvement
8
+
3
9
  ## 2.4.4
4
10
 
5
11
  ### Patch Changes
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@wistia/eslint-config",
3
- "version": "2.4.4",
3
+ "version": "2.4.5",
4
4
  "description": "Wistia's ESLint configurations",
5
5
  "packageManager": "yarn@4.12.0",
6
6
  "type": "module",
@@ -5,7 +5,8 @@ export default {
5
5
 
6
6
  // Forbid cyclical dependencies between modules
7
7
  // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-cycle.md
8
- 'import-x/no-cycle': ['error', { maxDepth: '∞' }],
8
+ // decision: set `maxDepth` to 2 because setting it higher is too much of a performance hit
9
+ 'import-x/no-cycle': ['error', { maxDepth: 2 }],
9
10
 
10
11
  // ensure imports point to files/modules that can be resolved
11
12
  // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md
@@ -222,7 +222,7 @@ export default {
222
222
  // Prefer vi.importActual/vi.importMock in vi.mock factories
223
223
  // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-import-in-mock.md
224
224
  // decision: potentially helpful but causes too many type errors
225
- 'vitest/prefer-import-in-mock': 'error',
225
+ 'vitest/prefer-import-in-mock': 'off',
226
226
 
227
227
  // Prefer importing vitest globals instead of using them implicitly
228
228
  // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-importing-vitest-globals.md
@@ -915,7 +915,7 @@
915
915
  {
916
916
  "allowUnsafeDynamicCyclicDependency": false,
917
917
  "ignoreExternal": false,
918
- "maxDepth": "∞",
918
+ "maxDepth": 2,
919
919
  },
920
920
  ],
921
921
  "import-x/no-default-export": [
@@ -1375,7 +1375,7 @@
1375
1375
  {
1376
1376
  "allowUnsafeDynamicCyclicDependency": false,
1377
1377
  "ignoreExternal": false,
1378
- "maxDepth": "∞",
1378
+ "maxDepth": 2,
1379
1379
  },
1380
1380
  ],
1381
1381
  "import-x/no-default-export": [
@@ -237,7 +237,7 @@
237
237
  2,
238
238
  ],
239
239
  "vitest/prefer-import-in-mock": [
240
- 2,
240
+ 0,
241
241
  {
242
242
  "fixable": true,
243
243
  },