@wistia/eslint-config 2.4.3 → 2.4.5

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.5
+
+### Patch Changes
+
+- [#458](https://github.com/wistia/eslint-config/pull/458) [`b5f69cb`](https://github.com/wistia/eslint-config/commit/b5f69cb7fc61550f2f6c498bdbe1a370007604c2) Thanks [@okize](https://github.com/okize)! - fix: set `import-x/no-cycle` maxDepth to 2 for perofmance improvement
+
+## 2.4.4
+
+### Patch Changes
+
+- [#456](https://github.com/wistia/eslint-config/pull/456) [`ffbb63a`](https://github.com/wistia/eslint-config/commit/ffbb63ace5d18924098a1d239b469bf1a935bd33) Thanks [@okize](https://github.com/okize)! - fix: disable `vitest/prefer-import-in-mock` rule
+
 ## 2.4.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.3",
+  "version": "2.4.5",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",

package/src/rules/import.mjs

@@ -5,7 +5,8 @@ export default {
 
   // Forbid cyclical dependencies between modules
   // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-cycle.md
-  'import-x/no-cycle': ['error', { maxDepth: '∞' }],
+  // decision: set `maxDepth` to 2 because setting it higher is too much of a performance hit
+  'import-x/no-cycle': ['error', { maxDepth: 2 }],
 
   // ensure imports point to files/modules that can be resolved
   // https://github.com/un-ts/eslint-plugin-import-x/blob/master/docs/rules/no-unresolved.md

package/src/rules/react.mjs

@@ -195,6 +195,7 @@ export default {
   '@eslint-react/no-useless-fragment': 'error',
 
   // Enforce consistent usage of destructuring assignment of props, state, and context
+  // decision: best left up to the implementer
   '@eslint-react/prefer-destructuring-assignment': 'off',
 
   // Enforce importing React via a namespace import

package/src/rules/vitest.mjs

@@ -221,7 +221,8 @@ export default {
 
   // Prefer vi.importActual/vi.importMock in vi.mock factories
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-import-in-mock.md
-  'vitest/prefer-import-in-mock': 'error',
+  // decision: potentially helpful but causes too many type errors
+  'vitest/prefer-import-in-mock': 'off',
 
   // Prefer importing vitest globals instead of using them implicitly
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-importing-vitest-globals.md

package/test/__snapshots__/javascript.mjs.snap

@@ -915,7 +915,7 @@
       {
         "allowUnsafeDynamicCyclicDependency": false,
         "ignoreExternal": false,
-        "maxDepth": "∞",
+        "maxDepth": 2,
       },
     ],
     "import-x/no-default-export": [

package/test/__snapshots__/typescript.mjs.snap

@@ -1375,7 +1375,7 @@
       {
         "allowUnsafeDynamicCyclicDependency": false,
         "ignoreExternal": false,
-        "maxDepth": "∞",
+        "maxDepth": 2,
       },
     ],
     "import-x/no-default-export": [

package/test/__snapshots__/vitest.mjs.snap

@@ -237,7 +237,7 @@
       2,
     ],
     "vitest/prefer-import-in-mock": [
-      2,
+      0,
       {
         "fixable": true,
       },