@wistia/eslint-config 2.4.2 → 2.4.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.4
+
+### Patch Changes
+
+- [#456](https://github.com/wistia/eslint-config/pull/456) [`ffbb63a`](https://github.com/wistia/eslint-config/commit/ffbb63ace5d18924098a1d239b469bf1a935bd33) Thanks [@okize](https://github.com/okize)! - fix: disable `vitest/prefer-import-in-mock` rule
+
+## 2.4.3
+
+### Patch Changes
+
+- [#454](https://github.com/wistia/eslint-config/pull/454) [`37dde02`](https://github.com/wistia/eslint-config/commit/37dde02aff28e4f30537b3404c46d92952824391) Thanks [@okize](https://github.com/okize)! - fix: update `valid-title` rule to avoid conflict with `prefer-describe-function-title`
+
 ## 2.4.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.2",
+  "version": "2.4.4",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",

package/src/rules/react.mjs

@@ -195,6 +195,7 @@ export default {
   '@eslint-react/no-useless-fragment': 'error',
 
   // Enforce consistent usage of destructuring assignment of props, state, and context
+  // decision: best left up to the implementer
   '@eslint-react/prefer-destructuring-assignment': 'off',
 
   // Enforce importing React via a namespace import

package/src/rules/vitest.mjs

@@ -221,6 +221,7 @@ export default {
 
   // Prefer vi.importActual/vi.importMock in vi.mock factories
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-import-in-mock.md
+  // decision: potentially helpful but causes too many type errors
   'vitest/prefer-import-in-mock': 'error',
 
   // Prefer importing vitest globals instead of using them implicitly
@@ -311,5 +312,6 @@ export default {
 
   // Enforce valid titles
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/valid-title.md
-  'vitest/valid-title': 'error',
+  // decision: `allowArguments` avoids conflict with `prefer-describe-function-title` rule, which is enabled
+  'vitest/valid-title': ['error', { allowArguments: true }],
 };

package/test/__snapshots__/vitest.mjs.snap

@@ -330,7 +330,7 @@
     "vitest/valid-title": [
       2,
       {
-        "allowArguments": false,
+        "allowArguments": true,
         "disallowedWords": [],
         "ignoreTypeOfDescribeName": false,
       },