@wistia/eslint-config 2.4.1 → 2.4.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.3
+
+### Patch Changes
+
+- [#454](https://github.com/wistia/eslint-config/pull/454) [`37dde02`](https://github.com/wistia/eslint-config/commit/37dde02aff28e4f30537b3404c46d92952824391) Thanks [@okize](https://github.com/okize)! - fix: update `valid-title` rule to avoid conflict with `prefer-describe-function-title`
+
+## 2.4.2
+
+### Patch Changes
+
+- [#452](https://github.com/wistia/eslint-config/pull/452) [`a7fba62`](https://github.com/wistia/eslint-config/commit/a7fba62c91213c3bd03806b7b5bd4aa8a1b885a0) Thanks [@okize](https://github.com/okize)! - fix: disable `vitest/prefer-called-once` rule since it conflicts
+
 ## 2.4.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.1",
+  "version": "2.4.3",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",

package/src/rules/vitest.mjs

@@ -172,7 +172,8 @@ export default {
 
   // Prefer toHaveBeenCalledOnce() over toHaveBeenCalledTimes(1)
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-once.md
-  'vitest/prefer-called-once': 'error',
+  // decision: this conflicts with `prefer-called-times` rule, which is enabled
+  'vitest/prefer-called-once': 'off',
 
   // Prefer toHaveBeenCalledTimes over multiple assertions
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-times.md
@@ -310,5 +311,6 @@ export default {
 
   // Enforce valid titles
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/valid-title.md
-  'vitest/valid-title': 'error',
+  // decision: `allowArguments` avoids conflict with `prefer-describe-function-title` rule, which is enabled
+  'vitest/valid-title': ['error', { allowArguments: true }],
 };

package/test/__snapshots__/vitest.mjs.snap

@@ -196,7 +196,7 @@
       2,
     ],
     "vitest/prefer-called-once": [
-      2,
+      0,
     ],
     "vitest/prefer-called-times": [
       2,
@@ -330,7 +330,7 @@
     "vitest/valid-title": [
       2,
       {
-        "allowArguments": false,
+        "allowArguments": true,
         "disallowedWords": [],
         "ignoreTypeOfDescribeName": false,
       },