@wistia/eslint-config 2.4.0 → 2.4.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 2.4.2
+
+### Patch Changes
+
+- [#452](https://github.com/wistia/eslint-config/pull/452) [`a7fba62`](https://github.com/wistia/eslint-config/commit/a7fba62c91213c3bd03806b7b5bd4aa8a1b885a0) Thanks [@okize](https://github.com/okize)! - fix: disable `vitest/prefer-called-once` rule since it conflicts
+
+## 2.4.1
+
+### Patch Changes
+
+- [#450](https://github.com/wistia/eslint-config/pull/450) [`cb96151`](https://github.com/wistia/eslint-config/commit/cb961517b3538afe1cc27d98aa147ce3c407a15a) Thanks [@okize](https://github.com/okize)! - fix: switch import-x/resolver to import-x/resolver-next for ESLint 10 compatibility
+
 ## 2.4.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.4.0",
+  "version": "2.4.2",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",
@@ -42,8 +42,8 @@
     "@eslint/compat": "^2.0.3",
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.10.0",
-    "@typescript-eslint/eslint-plugin": "^8.57.1",
-    "@typescript-eslint/parser": "^8.57.1",
+    "@typescript-eslint/eslint-plugin": "^8.57.2",
+    "@typescript-eslint/parser": "^8.57.2",
     "@vitest/eslint-plugin": "^1.6.13",
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.4",
@@ -62,7 +62,7 @@
     "eslint-plugin-ssr-friendly": "^1.3.0",
     "eslint-plugin-storybook": "^10.3.3",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
-    "eslint-plugin-testing-library": "^7.16.1",
+    "eslint-plugin-testing-library": "^7.16.2",
     "globals": "^17.4.0",
     "globals-vitest": "^4.1.0"
   },

package/src/configs/node.mjs

@@ -1,6 +1,6 @@
 import globals from 'globals';
 import nodePlugin from 'eslint-plugin-n';
-import { importX as importPlugin } from 'eslint-plugin-import-x';
+import { importX as importPlugin, createNodeResolver } from 'eslint-plugin-import-x';
 import nodeRules from '../rules/node.mjs';
 
 export default [
@@ -14,6 +14,9 @@ export default [
       n: nodePlugin,
       'import-x': importPlugin,
     },
+    settings: {
+      'import-x/resolver-next': [createNodeResolver()],
+    },
     rules: {
       ...nodeRules,
     },

package/src/configs/typescript.mjs

@@ -5,6 +5,7 @@ import { fixupPluginRules } from '@eslint/compat';
 import stylisticPlugin from '@stylistic/eslint-plugin';
 import filenamesPlugin from 'eslint-plugin-filenames';
 import { importX as importPlugin } from 'eslint-plugin-import-x';
+import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
 import barrelFilesPlugin from 'eslint-plugin-barrel-files';
 import prettierPlugin from 'eslint-plugin-prettier';
 import promisePlugin from 'eslint-plugin-promise';
@@ -53,19 +54,15 @@ export default [
         '@typescript-eslint/parser': ['.ts', '.cts', '.mts', '.tsx'],
       },
 
-      'import-x/resolver': {
-        typescript: {
-          node: {
-            extensions: ['.ts', '.cts', '.mts', '.tsx', '.js', '.jsx', '.mjs', '.cjs'],
-          },
-
+      'import-x/resolver-next': [
+        createTypeScriptImportResolver({
           // always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/lodash`
           alwaysTryTypes: true,
 
           // use <root>/path/to/folder/tsconfig.json
           project: '<root>/tsconfig.json',
-        },
-      },
+        }),
+      ],
     },
     rules: {
       ...baseRules,

package/src/rules/vitest.mjs

@@ -172,7 +172,8 @@ export default {
 
   // Prefer toHaveBeenCalledOnce() over toHaveBeenCalledTimes(1)
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-once.md
-  'vitest/prefer-called-once': 'error',
+  // decision: this conflicts with `prefer-called-times` rule, which is enabled
+  'vitest/prefer-called-once': 'off',
 
   // Prefer toHaveBeenCalledTimes over multiple assertions
   // https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-called-times.md

package/test/__snapshots__/node.mjs.snap

@@ -237,4 +237,13 @@
       2,
     ],
   },
+  "settings": {
+    "import-x/resolver-next": [
+      {
+        "interfaceVersion": 3,
+        "name": "eslint-plugin-import-x:node",
+        "resolve": "<function>",
+      },
+    ],
+  },
 }

package/test/__snapshots__/testing-library.mjs.snap

@@ -13,7 +13,7 @@
   },
   "plugins": [
     "@",
-    "testing-library:eslint-plugin-testing-library@7.16.1",
+    "testing-library:eslint-plugin-testing-library@7.16.2",
     "jest-dom:eslint-plugin-jest-dom@5.5.0",
   ],
   "rules": {

package/test/__snapshots__/typescript.mjs.snap

@@ -2690,23 +2690,12 @@
         ".tsx",
       ],
     },
-    "import-x/resolver": {
-      "typescript": {
-        "alwaysTryTypes": true,
-        "node": {
-          "extensions": [
-            ".ts",
-            ".cts",
-            ".mts",
-            ".tsx",
-            ".js",
-            ".jsx",
-            ".mjs",
-            ".cjs",
-          ],
-        },
-        "project": "<root>/tsconfig.json",
+    "import-x/resolver-next": [
+      {
+        "interfaceVersion": 3,
+        "name": "eslint-import-resolver-typescript",
+        "resolve": "<function>",
       },
-    },
+    ],
   },
 }

package/test/__snapshots__/vitest.mjs.snap

@@ -196,7 +196,7 @@
       2,
     ],
     "vitest/prefer-called-once": [
-      2,
+      0,
     ],
     "vitest/prefer-called-times": [
       2,