@wistia/eslint-config 2.2.0 → 2.3.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @wistia/eslint-config
 
+## 2.3.0
+
+### Minor Changes
+
+- [#442](https://github.com/wistia/eslint-config/pull/442) [`adc7fe4`](https://github.com/wistia/eslint-config/commit/adc7fe4e8cc21f8fecaee08d254220a97f3584d5) Thanks [@okize](https://github.com/okize)! - feat: remove jest config & rules
+
 ## 2.2.0
 
 ### Minor Changes

package/package.json

@@ -1,18 +1,17 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",
   "main": "index.mjs",
   "engines": {
-    "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
+    "node": "^20.19.0 || ^22.13.0 || >=24"
   },
   "exports": {
     "./package.json": "./package.json",
     ".": "./src/configs/javascript.mjs",
     "./javascript": "./src/configs/javascript.mjs",
-    "./jest": "./src/configs/jest.mjs",
     "./node": "./src/configs/node.mjs",
     "./playwright": "./src/configs/playwright.mjs",
     "./react": "./src/configs/react.mjs",
@@ -50,9 +49,7 @@
     "eslint-plugin-barrel-files": "^3.0.1",
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import-x": "^4.16.2",
-    "eslint-plugin-jest": "^29.15.0",
     "eslint-plugin-jest-dom": "^5.5.0",
-    "eslint-plugin-jest-formatting": "^3.1.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-n": "^17.24.0",
     "eslint-plugin-no-only-tests": "^3.3.0",

package/test/__snapshots__/javascript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.1",
+    "parser": "typescript-eslint/parser@8.57.2",
     "parserOptions": {
       "requireConfigFile": false,
     },

package/test/__snapshots__/typescript.mjs.snap

@@ -64,7 +64,7 @@
       "undefined": false,
       "unescape": false,
     },
-    "parser": "typescript-eslint/parser@8.57.1",
+    "parser": "typescript-eslint/parser@8.57.2",
     "parserOptions": {
       "ecmaVersion": 2024,
       "project": "./tsconfig.json",
@@ -78,7 +78,7 @@
   "plugins": [
     "@",
     "@stylistic:@stylistic/eslint-plugin@5.10.0",
-    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.57.1",
+    "@typescript-eslint:@typescript-eslint/eslint-plugin@8.57.2",
     "barrel-files:eslint-plugin-barrel-files@3.0.1",
     "filenames",
     "import-x:eslint-plugin-import-x@4.16.2",

package/src/configs/jest.mjs

@@ -1,22 +0,0 @@
-import jestPlugin from 'eslint-plugin-jest';
-import jestFormattingPlugin from 'eslint-plugin-jest-formatting';
-import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests';
-import jestRules from '../rules/jest.mjs';
-import jestFormattingRules from '../rules/jest-formatting.mjs';
-
-export default [
-  {
-    languageOptions: {
-      globals: jestPlugin.environments.globals.globals,
-    },
-    plugins: {
-      jest: jestPlugin,
-      'jest-formatting': jestFormattingPlugin,
-      'no-only-tests': noOnlyTestsPlugin,
-    },
-    rules: {
-      ...jestRules,
-      ...jestFormattingRules,
-    },
-  },
-];

package/src/rules/jest-formatting.mjs

@@ -1,36 +0,0 @@
-// only add jest-formatting rules (plugin works for vitest as well as jest)
-// see: https://github.com/dangreenisrael/eslint-plugin-jest-formatting#rule-documentation
-
-export default {
-  // This rule enforces a line of padding before and after 1 or more `afterAll` statements.
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-after-all-blocks.md
-  'jest-formatting/padding-around-after-all-blocks': 'error',
-
-  // This rule enforces a line of padding before and after 1 or more `afterEach` statements.
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-after-each-blocks.md
-  'jest-formatting/padding-around-after-each-blocks': 'error',
-
-  // This rule enforces a line of padding before and after `beforeAll` statements.
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-before-all-blocks.md
-  'jest-formatting/padding-around-before-all-blocks': 'error',
-
-  // This rule enforces a line of padding before and after 1 or more `beforeEach` statements
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-before-each-blocks.md
-  'jest-formatting/padding-around-before-each-blocks': 'error',
-
-  // This rule enforces a line of padding before and after 1 or more `expect` statements
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-expect-groups.md
-  'jest-formatting/padding-around-expect-groups': 'error',
-
-  // This rule enforces a line of padding before and after 1 or more `describe` statements
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-describe-blocks.md
-  'jest-formatting/padding-around-describe-blocks': 'error',
-
-  // This rule enforces a line of padding before and after 1 or more `test`/`it` statements
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-test-blocks.md
-  'jest-formatting/padding-around-test-blocks': 'error',
-
-  // This is a meta rule that simply enables all of the previous rules
-  // https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/docs/rules/padding-around-all.md
-  'jest-formatting/padding-around-all': 'off',
-};

package/src/rules/jest.mjs

@@ -1,203 +0,0 @@
-// only add jest rules
-// see: https://github.com/jest-community/eslint-plugin-jest#rules
-
-export default {
-  // Prevent focused tests (.only)
-  // https://github.com/levibuzolic/eslint-plugin-no-only-tests#usage
-  'no-only-tests/no-only-tests': 'error',
-
-  // Have control over `test` and `it` usages
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/consistent-test-it.md
-  'jest/consistent-test-it': 'error',
-
-  // Enforce assertion to be made in a test body
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/expect-expect.md
-  'jest/expect-expect': 'error',
-
-  // Enforces a maximum number assertion calls in a test body
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/max-expects.md
-  'jest/max-expects': [
-    'error',
-    {
-      max: 15,
-    },
-  ],
-
-  // Enforces a maximum depth to nested describe calls
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/max-nested-describe.md
-  'jest/max-nested-describe': 'error',
-
-  // Disallow alias methods
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-alias-methods.md
-  'jest/no-alias-methods': 'error',
-
-  // Disallow commented out tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-commented-out-tests.md
-  'jest/no-commented-out-tests': 'error',
-
-  // Prevent calling `expect` conditionally
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-conditional-expect.md
-  'jest/no-conditional-expect': 'error',
-
-  // Disallow conditional logic in tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-conditional-in-test.md
-  'jest/no-conditional-in-test': 'error',
-
-  // Disallow use of deprecated functions
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-deprecated-functions.md
-  'jest/no-deprecated-functions': 'error',
-
-  // Disallow disabled tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-disabled-tests.md
-  // decision: it is often useful to be allowed to add a .skip
-  'jest/no-disabled-tests': 'off',
-
-  // Avoid using a callback in asynchronous tests and hooks
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-done-callback.md
-  'jest/no-done-callback': 'error',
-
-  // Disallow duplicate setup and teardown hooks
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-duplicate-hooks.md
-  'jest/no-duplicate-hooks': 'error',
-
-  // Disallow using `exports` in files containing tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-export.md
-  'jest/no-export': 'error',
-
-  // Disallow focused tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-focused-tests.md
-  // decision: turned off in favor of the `no-only-tests` rule
-  'jest/no-focused-tests': 'off',
-
-  // Disallow setup and teardown hooks
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-hooks.md
-  // decision: hooks are useful even though they *potentially* promote shared state between tests
-  'jest/no-hooks': 'off',
-
-  // Disallow identical titles
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-identical-title.md
-  'jest/no-identical-title': 'error',
-
-  // Disallow string interpolation inside snapshots
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-interpolation-in-snapshots.md
-  'jest/no-interpolation-in-snapshots': 'error',
-
-  // Disallow Jasmine globals
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-jasmine-globals.md
-  'jest/no-jasmine-globals': 'error',
-
-  // disallow large snapshots
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-large-snapshots.md
-  // decision: arbitrary but reasonable size limit; although we suggest not writing snapshot tests with the
-  // `no-snapshot-testing` rule, in cases where we decide to allow them, this rule is beneficial
-  'jest/no-large-snapshots': ['error', { maxSize: 500 }],
-
-  // Disallow manually importing from `__mocks__`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-mocks-import.md
-  'jest/no-mocks-import': 'error',
-
-  // Disallow specific matchers & modifiers
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-restricted-matchers.md
-  'jest/no-restricted-matchers': ['error', {}],
-
-  // Disallow using `expect` outside of `it` or `test` blocks
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-standalone-expect.md
-  'jest/no-standalone-expect': 'error',
-
-  // Use `.only` and `.skip` over `f` and `x`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-test-prefixes.md
-  'jest/no-test-prefixes': 'error',
-
-  // Disallow explicitly returning from tests
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-test-return-statement.md
-  'jest/no-test-return-statement': 'error',
-
-  // Suggest using `toBeCalledWith()` or `toHaveBeenCalledWith()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-called-with.md
-  'jest/prefer-called-with': 'error',
-
-  // Suggest using the built-in comparison matchers
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-comparison-matcher.md
-  'jest/prefer-comparison-matcher': 'error',
-
-  // Suggest using the built-in equality matchers
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-equality-matcher.md
-  'jest/prefer-equality-matcher': 'error',
-
-  // Suggest using `expect.assertions()` OR `expect.hasAssertions()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-expect-assertions.md
-  'jest/prefer-expect-assertions': 'off',
-
-  // Prefer `await expect(...).resolves` over `expect(await ...)` syntax
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-expect-resolves.md
-  'jest/prefer-expect-resolves': 'error',
-
-  // Prefer having hooks in a consistent order
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-hooks-in-order.md
-  'jest/prefer-hooks-in-order': 'error',
-
-  // Suggest having hooks before any test cases
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-hooks-on-top.md
-  'jest/prefer-hooks-on-top': 'error',
-
-  // Enforce lowercase test names
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-lowercase-title.md
-  // decision: descriptions are often named after React components which are capitalized
-  'jest/prefer-lowercase-title': 'off',
-
-  // Prefer including a hint with external snapshots
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-snapshot-hint.md
-  'jest/prefer-snapshot-hint': 'error',
-
-  // Suggest using `jest.spyOn()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-spy-on.md
-  'jest/prefer-spy-on': 'error',
-
-  // Suggest using `toStrictEqual()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-strict-equal.md
-  'jest/prefer-strict-equal': 'error',
-
-  // Suggest using `toBe()` for primitive literals
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-to-be.md
-  'jest/prefer-to-be': 'error',
-
-  // Suggest using `toContain()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-to-contain.md
-  'jest/prefer-to-contain': 'error',
-
-  // Suggest using `toHaveLength()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-to-have-length.md
-  'jest/prefer-to-have-length': 'error',
-
-  // Suggest using `test.todo`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-todo.md
-  'jest/prefer-todo': 'error',
-
-  // Require setup and teardown code to be within a hook
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-hook.md
-  'jest/require-hook': 'error',
-
-  // Require a message for `toThrow()`
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-to-throw-message.md
-  'jest/require-to-throw-message': 'error',
-
-  // Require test cases and hooks to be inside a `describe` block
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/require-top-level-describe.md
-  'jest/require-top-level-describe': 'error',
-
-  // Enforce valid `describe()` callback
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-describe-callback.md
-  'jest/valid-describe-callback': 'error',
-
-  // Enforce valid `expect()` usage
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-expect.md
-  'jest/valid-expect': 'error',
-
-  // Ensure promises that have expectations in their chain are valid
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-expect-in-promise.md
-  'jest/valid-expect-in-promise': 'error',
-
-  // Enforce valid titles
-  // https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/valid-title.md
-  'jest/valid-title': 'error',
-};