@wistia/eslint-config 1.5.0 → 1.5.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @wistia/eslint-config
 
+## 1.5.2
+
+### Patch Changes
+
+- [#418](https://github.com/wistia/eslint-config/pull/418) [`7ad0310`](https://github.com/wistia/eslint-config/commit/7ad03102734ff7f50677f3a938bea6c9e0b17166) Thanks [@okize](https://github.com/okize)! - fix: temporarily disable `@typescript-eslint/no-useless-default-assignment` rule'
+
+## 1.5.1
+
+### Patch Changes
+
+- [#416](https://github.com/wistia/eslint-config/pull/416) [`516a7ab`](https://github.com/wistia/eslint-config/commit/516a7ab19ce5b2a4bd44ecf25e9a2adad5e3b729) Thanks [@okize](https://github.com/okize)! - fix: disable `styled-components-a11y/lang` rule since it is causing issues
+
 ## 1.5.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "1.5.0",
+  "version": "1.5.2",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",

package/src/rules/react-a11y.mjs

@@ -3,12 +3,12 @@
 
 export default {
   // ensure emoji are accessible
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md
   // disabled; rule is deprecated
   // 'jsx-a11y/accessible-emoji': 'off',
 
   // Enforce that all elements that require alternative text have meaningful information
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md
   'jsx-a11y/alt-text': [
     'error',
     {
@@ -21,11 +21,11 @@ export default {
   ],
 
   // Enforce that anchors have content
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-has-content.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-has-content.md
   'jsx-a11y/anchor-has-content': ['error', { components: [] }],
 
   // ensure <a> tags are valid
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/0745af376cdc8686d85a361ce36952b1fb1ccf6e/docs/rules/anchor-is-valid.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/0745af376cdc8686d85a361ce36952b1fb1ccf6e/docs/rules/anchor-is-valid.md
   'jsx-a11y/anchor-is-valid': [
     'error',
     {
@@ -36,24 +36,24 @@ export default {
   ],
 
   // elements with aria-activedescendant must be tabbable
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-activedescendant-has-tabindex.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-activedescendant-has-tabindex.md
   'jsx-a11y/aria-activedescendant-has-tabindex': 'error',
 
   // Enforce all aria-* props are valid.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
   'jsx-a11y/aria-props': 'error',
 
   // Enforce ARIA state and property values are valid.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-proptypes.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-proptypes.md
   'jsx-a11y/aria-proptypes': 'error',
 
   // Require ARIA roles to be valid and non-abstract
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md
   'jsx-a11y/aria-role': ['error', { ignoreNonDOM: false }],
 
   // Enforce that elements that do not support ARIA roles, states, and
   // properties do not have those attributes.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md
   'jsx-a11y/aria-unsupported-elements': 'error',
 
   // Ensure the autocomplete attribute is correct and suitable for the form field it is used with
@@ -66,11 +66,11 @@ export default {
   ],
 
   // require onClick be accompanied by onKeyUp/onKeyDown/onKeyPress
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
   'jsx-a11y/click-events-have-key-events': 'error',
 
   // Enforce that a control (an interactive element) has a text label.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/control-has-associated-label.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/control-has-associated-label.md
   'jsx-a11y/control-has-associated-label': [
     'error',
     {
@@ -94,27 +94,27 @@ export default {
   ],
 
   // ensure <hX> tags have content and are not aria-hidden
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
   'jsx-a11y/heading-has-content': ['error', { components: [''] }],
 
   // require HTML elements to have a "lang" prop
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/html-has-lang.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/html-has-lang.md
   'jsx-a11y/html-has-lang': 'error',
 
   // ensure iframe elements have a unique title
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/iframe-has-title.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/iframe-has-title.md
   'jsx-a11y/iframe-has-title': 'error',
 
   // Prevent img alt text from containing redundant words like "image", "picture", or "photo"
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md
   'jsx-a11y/img-redundant-alt': 'error',
 
   // Elements with an interactive role and interaction handlers must be focusable
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/interactive-supports-focus.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/interactive-supports-focus.md
   'jsx-a11y/interactive-supports-focus': 'error',
 
   // Enforce that a label tag has a text label and an associated control.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/docs/rules/label-has-associated-control.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/docs/rules/label-has-associated-control.md
   'jsx-a11y/label-has-associated-control': [
     'error',
     {
@@ -127,11 +127,11 @@ export default {
   ],
 
   // require HTML element's lang prop to be valid
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
   'jsx-a11y/lang': 'error',
 
   // media elements must have captions
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/media-has-caption.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/media-has-caption.md
   'jsx-a11y/media-has-caption': [
     'error',
     {
@@ -142,19 +142,19 @@ export default {
   ],
 
   // require that mouseover/out come with focus/blur, for keyboard-only users
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
   'jsx-a11y/mouse-events-have-key-events': 'error',
 
   // Prevent use of `accessKey`
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md
   'jsx-a11y/no-access-key': 'error',
 
   // prohibit autoFocus prop
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-autofocus.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-autofocus.md
   'jsx-a11y/no-autofocus': ['error', { ignoreNonDOM: true }],
 
   // prevent distracting elements, like <marquee> and <blink>
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-distracting-elements.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-distracting-elements.md
   'jsx-a11y/no-distracting-elements': [
     'error',
     {
@@ -163,7 +163,7 @@ export default {
   ],
 
   // WAI-ARIA roles should not be used to convert an interactive element to non-interactive
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-interactive-element-to-noninteractive-role.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-interactive-element-to-noninteractive-role.md
   'jsx-a11y/no-interactive-element-to-noninteractive-role': [
     'error',
     {
@@ -172,7 +172,7 @@ export default {
   ],
 
   // A non-interactive element does not support event handlers (mouse and key handlers)
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-interactions.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-interactions.md
   'jsx-a11y/no-noninteractive-element-interactions': [
     'error',
     {
@@ -181,7 +181,7 @@ export default {
   ],
 
   // WAI-ARIA roles should not be used to convert a non-interactive element to interactive
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-to-interactive-role.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-to-interactive-role.md
   'jsx-a11y/no-noninteractive-element-to-interactive-role': [
     'error',
     {
@@ -194,7 +194,7 @@ export default {
   ],
 
   // Tab key navigation should be limited to elements on the page that can be interacted with.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-tabindex.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-tabindex.md
   'jsx-a11y/no-noninteractive-tabindex': [
     'error',
     {
@@ -204,18 +204,18 @@ export default {
   ],
 
   // require onBlur instead of onChange
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-onchange.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-onchange.md
   // decision: This rule is deprecated. This rule is based on reports of behavior of old
   // browsers (eg. IE 10 and below). In the meantime, this behavior has been corrected,
   // both in newer versions of browsers as well as in the DOM spec.
   // 'jsx-a11y/no-onchange': 'off',
 
   // ensure HTML elements do not specify redundant ARIA roles
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-redundant-roles.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-redundant-roles.md
   'jsx-a11y/no-redundant-roles': 'error',
 
   // Enforce that DOM elements without semantic behavior not have interaction handlers
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md
   'jsx-a11y/no-static-element-interactions': [
     'error',
     {
@@ -225,20 +225,20 @@ export default {
 
   // Enforce that elements with ARIA roles must have all required attributes
   // for that role.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-has-required-aria-props.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-has-required-aria-props.md
   'jsx-a11y/role-has-required-aria-props': 'error',
 
   // Enforce that elements with explicit or implicit roles defined contain
   // only aria-* properties supported by that role.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-supports-aria-props.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-supports-aria-props.md
   'jsx-a11y/role-supports-aria-props': 'error',
 
   // only allow <th> to have the "scope" attr
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/scope.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/scope.md
   'jsx-a11y/scope': 'error',
 
   // Enforce tabIndex value is not greater than zero.
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/tabindex-no-positive.md
+  // https://github.com/infofarmer/eslint-plugin-jsx-a11y/blob/master/docs/rules/tabindex-no-positive.md
   'jsx-a11y/tabindex-no-positive': 'error',
 
   // Enforce <a> text to not exactly match "click here", "here", "link", or "a link"

package/src/rules/styled-components.mjs

@@ -3,7 +3,6 @@
 
 export default {
   // plugin does not provide definitions
-  'styled-components-a11y/lang': 'error',
   'styled-components-a11y/alt-text': 'error',
   'styled-components-a11y/anchor-has-content': 'error',
   'styled-components-a11y/anchor-is-valid': 'error',
@@ -76,4 +75,6 @@ export default {
   'styled-components-a11y/role-supports-aria-props': 'error',
   'styled-components-a11y/scope': 'error',
   'styled-components-a11y/tabindex-no-positive': 'error',
+  // disabled because there appears to be an eslint bug with this rule
+  'styled-components-a11y/lang': 'off',
 };

package/src/rules/typescript.mjs

@@ -712,5 +712,7 @@ export default {
 
   // Disallow default values that will never be used
   // https://typescript-eslint.io/rules/no-useless-default-assignment/
-  '@typescript-eslint/no-useless-default-assignment': 'error',
+  // decision: temporarily disabled because of bug
+  // see: https://github.com/typescript-eslint/typescript-eslint/issues/11849
+  '@typescript-eslint/no-useless-default-assignment': 'off',
 };

package/test/__snapshots__/styled-components.mjs.snap

@@ -111,7 +111,7 @@
       2,
     ],
     "styled-components-a11y/lang": [
-      2,
+      0,
     ],
     "styled-components-a11y/media-has-caption": [
       2,

package/test/__snapshots__/typescript.mjs.snap

@@ -732,7 +732,7 @@
       2,
     ],
     "@typescript-eslint/no-useless-default-assignment": [
-      2,
+      0,
     ],
     "@typescript-eslint/no-useless-empty-export": [
       2,