@wistia/eslint-config 1.3.1 → 1.4.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @wistia/eslint-config
 
+## 1.4.0
+
+### Minor Changes
+
+- [#412](https://github.com/wistia/eslint-config/pull/412) [`ab09493`](https://github.com/wistia/eslint-config/commit/ab094933364da1b9152b81a248c12bbaca733b5f) Thanks [@okize](https://github.com/okize)! - feat: add `preserve-caught-error` & `no-unassigned-vars` to base ruleset
+
 ## 1.3.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "1.3.1",
+  "version": "1.4.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.12.0",
   "type": "module",

package/src/rules/base.mjs

@@ -197,7 +197,11 @@ export default {
 
   // Disallow unmodified loop conditions
   // https://eslint.org/docs/rules/no-unmodified-loop-condition
-  'no-unmodified-loop-condition': 'off',
+  'no-unmodified-loop-condition': 'error',
+
+  // Disallow let or var variables that are read but never assigned
+  // https://eslint.org/docs/latest/rules/no-unassigned-vars
+  'no-unassigned-vars': 'error',
 
   // Disallow unreachable code after return, throw, continue, and break statements
   // https://eslint.org/docs/rules/no-unreachable
@@ -987,6 +991,12 @@ export default {
   // https://eslint.org/docs/rules/prefer-template
   'prefer-template': 'error',
 
+  // Disallow losing originally caught error when re-throwing custom errors
+  // https://eslint.org/docs/latest/rules/preserve-caught-error
+  'preserve-caught-error': ['error', {
+    'requireCatchParameter': false
+  }],
+
   // Enforce the consistent use of the radix argument when using parseInt()
   // https://eslint.org/docs/rules/radix
   radix: 'error',

package/test/__snapshots__/javascript.mjs.snap

@@ -1563,6 +1563,9 @@
     "no-throw-literal": [
       2,
     ],
+    "no-unassigned-vars": [
+      2,
+    ],
     "no-undef": [
       2,
       {
@@ -1593,7 +1596,7 @@
       0,
     ],
     "no-unmodified-loop-condition": [
-      0,
+      2,
     ],
     "no-unneeded-ternary": [
       2,
@@ -1812,6 +1815,12 @@
     "prefer-template": [
       2,
     ],
+    "preserve-caught-error": [
+      2,
+      {
+        "requireCatchParameter": false,
+      },
+    ],
     "prettier/prettier": [
       2,
     ],

package/test/__snapshots__/typescript.mjs.snap

@@ -2017,6 +2017,9 @@
     "no-throw-literal": [
       0,
     ],
+    "no-unassigned-vars": [
+      2,
+    ],
     "no-undef": [
       0,
       {
@@ -2047,7 +2050,7 @@
       0,
     ],
     "no-unmodified-loop-condition": [
-      0,
+      2,
     ],
     "no-unneeded-ternary": [
       2,
@@ -2242,6 +2245,12 @@
     "prefer-template": [
       2,
     ],
+    "preserve-caught-error": [
+      2,
+      {
+        "requireCatchParameter": false,
+      },
+    ],
     "prettier/prettier": [
       2,
     ],