@wistia/eslint-config 0.9.3 → 0.10.0

package/configs/eslint/default.js

@@ -3,11 +3,6 @@ require('@rushstack/eslint-patch/modern-module-resolution');
 module.exports = {
   parser: '@babel/eslint-parser',
 
-  env: {
-    es2022: true,
-    node: true,
-  },
-
   parserOptions: {
     sourceType: 'module',
     ecmaFeatures: {
@@ -17,6 +12,11 @@ module.exports = {
     ecmaVersion: 13,
   },
 
+  env: {
+    es2022: true,
+    node: true,
+  },
+
   extends: [
     '../../rules/eslint/best-practices',
     '../../rules/eslint/errors',

package/configs/eslint/react.js

@@ -5,8 +5,6 @@ module.exports = {
     browser: true,
   },
 
-  parser: '@babel/eslint-parser',
-
   extends: [
     '../../rules/eslint/react',
     '../../rules/eslint/react-a11y',

package/configs/eslint/typescript.js

@@ -0,0 +1,27 @@
+require('@rushstack/eslint-patch/modern-module-resolution');
+
+module.exports = {
+  parser: '@typescript-eslint/parser',
+
+  parserOptions: {
+    sourceType: 'module',
+    ecmaVersion: 13,
+  },
+
+  env: {
+    es2022: true,
+    node: true,
+  },
+
+  extends: [
+    '../../rules/eslint/best-practices',
+    '../../rules/eslint/errors',
+    '../../rules/eslint/es6',
+    '../../rules/eslint/node',
+    '../../rules/eslint/imports',
+    '../../rules/eslint/style',
+    '../../rules/eslint/variables',
+    '../../rules/eslint/typescript',
+    '../../rules/eslint/typescript-imports',
+  ].map(require.resolve),
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.9.3",
+  "version": "0.10.0",
   "description": "Wistia's ESLint configurations",
   "main": "react.js",
   "exports": {
@@ -15,7 +15,8 @@
     "./stylelint": "./configs/stylelint/default.js",
     "./stylelint/scss": "./configs/stylelint/scss.js",
     "./stylelint/styled-components": "./configs/stylelint/styled-components.js",
-    "./testing-library": "./configs/eslint/testing-library.js"
+    "./testing-library": "./configs/eslint/testing-library.js",
+    "./typescript": "./configs/eslint/typescript.js"
   },
   "scripts": {
     "lint": "eslint --fix .",
@@ -34,6 +35,7 @@
     "confusing-browser-globals": "^1.0.11",
     "eslint": "^8.20.0",
     "eslint-config-prettier": "^8.5.0",
+    "eslint-import-resolver-typescript": "^3.3.0",
     "eslint-plugin-better-styled-components": "^1.1.2",
     "eslint-plugin-cypress": "^2.12.1",
     "eslint-plugin-import": "^2.26.0",

package/rules/eslint/imports.js

@@ -7,7 +7,7 @@ module.exports = {
         extensions: ['.js', '.mjs', '.cjs', '.json'],
       },
     },
-    'import/extensions': ['.js', '.jsx', '.mjs', '.cjs'],
+    'import/extensions': ['.js', '.jsx', '.ts', '.tsx', '.mjs', '.cjs'],
     'import/core-modules': [],
     'import/ignore': ['node_modules', '\\.(coffee|scss|css|less|svg|json)$'],
   },
@@ -128,6 +128,8 @@ module.exports = {
         js: 'never',
         mjs: 'never',
         jsx: 'never',
+        ts: 'never',
+        tsx: 'never',
       },
     ],
 

package/rules/eslint/react.js

@@ -346,7 +346,8 @@ module.exports = {
 
     // only .jsx files may have JSX
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
-    'react/jsx-filename-extension': ['error', { extensions: ['.jsx'] }],
+    // decision: include typescript extensions to allow interop
+    'react/jsx-filename-extension': ['error', { extensions: ['.jsx', '.tsx'] }],
 
     // prevent accidental JS comments from being injected into JSX as text
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
@@ -628,7 +629,7 @@ module.exports = {
   settings: {
     'import/resolver': {
       node: {
-        extensions: ['.js', '.jsx', '.json'],
+        extensions: ['.js', '.jsx', '.ts', '.tsx', '.json'],
       },
     },
     react: {

package/rules/eslint/typescript-imports.js

@@ -0,0 +1,21 @@
+module.exports = {
+  plugins: ['import'],
+
+  rules: {
+    // turn on errors for missing imports
+    'import/no-unresolved': 'error',
+  },
+
+  settings: {
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts', '.tsx'],
+    },
+
+    'import/resolver': {
+      typescript: {
+        // always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
+        alwaysTryTypes: true,
+      },
+    },
+  },
+};

package/rules/eslint/typescript.js

@@ -0,0 +1,8 @@
+// only add typescript rules
+// see: https://typescript-eslint.io/rules/
+
+module.exports = {
+  plugins: ['@typescript-eslint'],
+
+  rules: {},
+};