@wistia/eslint-config 0.7.0 → 0.7.1-beta.b88ec0ae.dff4a6b

package/base.js

@@ -17,5 +17,4 @@ module.exports = {
     './rules/eslint/prettier',
     'eslint-config-prettier',
   ].map(require.resolve),
-  rules: {},
 };

package/cypress.js

@@ -1,11 +1,3 @@
-const testRules = require('./rules/eslint/cypress');
-
 module.exports = {
-  plugins: ['eslint-plugin-cypress'],
-  env: {
-    'cypress/globals': true,
-  },
-  rules: {
-    ...testRules,
-  },
+  extends: ['./rules/eslint/cypress'].map(require.resolve),
 };

package/jest.js

@@ -1,11 +1,3 @@
-const testRules = require('./rules/eslint/jest');
-
 module.exports = {
-  plugins: ['eslint-plugin-jest', 'eslint-plugin-jest-formatting'],
-  env: {
-    jest: true,
-  },
-  rules: {
-    ...testRules,
-  },
+  extends: ['./rules/eslint/jest'].map(require.resolve),
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.7.0",
+  "version": "0.7.1-beta.b88ec0ae.dff4a6b",
   "description": "Wistia's ESLint configurations",
   "main": "react.js",
   "scripts": {

package/react.js

@@ -8,11 +8,12 @@ module.exports = {
     // base
     './rules/eslint/best-practices',
     './rules/eslint/errors',
+    './rules/eslint/es6',
+    './rules/eslint/globals',
+    './rules/eslint/imports',
     './rules/eslint/node',
     './rules/eslint/style',
     './rules/eslint/variables',
-    './rules/eslint/es6',
-    './rules/eslint/imports',
     // react
     './rules/eslint/react',
     './rules/eslint/react-a11y',
@@ -20,5 +21,4 @@ module.exports = {
     './rules/eslint/prettier',
     'eslint-config-prettier',
   ].map(require.resolve),
-  rules: {},
 };

package/rules/eslint/cypress.js

@@ -2,11 +2,19 @@
 // see: https://github.com/cypress-io/eslint-plugin-cypress#rules
 
 module.exports = {
-  'cypress/no-assigning-return-values': 'error',
-  'cypress/no-unnecessary-waiting': 'error',
-  'cypress/no-async-tests': 'error',
-  'cypress/no-force': 'error',
-  'cypress/assertion-before-screenshot': 'error',
-  'cypress/require-data-selectors': 'error',
-  'cypress/no-pause': 'error',
+  env: {
+    'cypress/globals': true,
+  },
+
+  plugins: ['eslint-plugin-cypress'],
+
+  rules: {
+    'cypress/no-assigning-return-values': 'error',
+    'cypress/no-unnecessary-waiting': 'error',
+    'cypress/no-async-tests': 'error',
+    'cypress/no-force': 'error',
+    'cypress/assertion-before-screenshot': 'error',
+    'cypress/require-data-selectors': 'error',
+    'cypress/no-pause': 'error',
+  },
 };

package/rules/eslint/imports.js

@@ -99,7 +99,7 @@ module.exports = {
 
     // disallow require()
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md
-    'import/no-commonjs': 'off',
+    'import/no-commonjs': 'error',
 
     // disallow AMD require/define
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-amd.md

package/rules/eslint/jest.js

@@ -3,58 +3,66 @@
 // see: https://github.com/dangreenisrael/eslint-plugin-jest-formatting#rule-documentation
 
 module.exports = {
-  // authoring rules for tests
-  'jest/consistent-test-it': 'error',
-  'jest/expect-expect': 'off',
-  'jest/no-alias-methods': 'error',
-  'jest/no-commented-out-tests': 'error',
-  'jest/no-conditional-expect': 'error',
-  'jest/no-deprecated-functions': 'error',
-  // it is often useful to be allowed to add a .skip
-  'jest/no-disabled-tests': 'off',
-  'jest/no-done-callback': 'error',
-  'jest/no-duplicate-hooks': 'error',
-  'jest/no-export': 'error',
-  'jest/no-focused-tests': 'error',
-  // hooks are useful even though they *potentially* promote shared state between tests
-  'jest/no-hooks': 'off',
-  'jest/no-identical-title': 'error',
-  'jest/no-if': 'error',
-  'jest/no-interpolation-in-snapshots': 'error',
-  'jest/no-jasmine-globals': 'error',
-  'jest/no-jest-import': 'error',
-  // reasonable but arbitrary size limit
-  'jest/no-large-snapshots': ['error', { maxSize: 500 }],
-  'jest/no-mocks-import': 'error',
-  'jest/no-restricted-matchers': 'error',
-  'jest/no-standalone-expect': 'error',
-  'jest/no-test-prefixes': 'error',
-  'jest/no-test-return-statement': 'error',
-  'jest/prefer-called-with': 'error',
-  'jest/prefer-expect-assertions': 'error',
-  'jest/prefer-hooks-on-top': 'error',
-  // descriptions are often named after React components which are capitalized
-  'jest/prefer-lowercase-title': 'off',
-  'jest/prefer-spy-on': 'error',
-  'jest/prefer-strict-equal': 'error',
-  'jest/prefer-to-be': 'error',
-  'jest/prefer-to-contain': 'error',
-  'jest/prefer-to-have-length': 'error',
-  'jest/prefer-todo': 'error',
-  'jest/require-to-throw-message': 'error',
-  'jest/require-top-level-describe': 'error',
-  'jest/valid-describe-callback': 'error',
-  'jest/valid-expect': 'error',
-  'jest/valid-expect-in-promise': 'error',
-  'jest/valid-title': 'error',
+  env: {
+    jest: true,
+  },
 
-  // formatting rules for tests
-  'jest-formatting/padding-around-after-all-blocks': 'error',
-  'jest-formatting/padding-around-after-each-blocks': 'error',
-  'jest-formatting/padding-around-before-all-blocks': 'error',
-  'jest-formatting/padding-around-before-each-blocks': 'error',
-  'jest-formatting/padding-around-expect-groups': 'error',
-  'jest-formatting/padding-around-describe-blocks': 'error',
-  'jest-formatting/padding-around-test-blocks': 'error',
-  'jest-formatting/padding-around-all': 'error',
+  plugins: ['eslint-plugin-jest', 'eslint-plugin-jest-formatting'],
+
+  rules: {
+    // authoring rules for tests
+    'jest/consistent-test-it': 'error',
+    'jest/expect-expect': 'off',
+    'jest/no-alias-methods': 'error',
+    'jest/no-commented-out-tests': 'error',
+    'jest/no-conditional-expect': 'error',
+    'jest/no-deprecated-functions': 'error',
+    // it is often useful to be allowed to add a .skip
+    'jest/no-disabled-tests': 'off',
+    'jest/no-done-callback': 'error',
+    'jest/no-duplicate-hooks': 'error',
+    'jest/no-export': 'error',
+    'jest/no-focused-tests': 'error',
+    // hooks are useful even though they *potentially* promote shared state between tests
+    'jest/no-hooks': 'off',
+    'jest/no-identical-title': 'error',
+    'jest/no-if': 'error',
+    'jest/no-interpolation-in-snapshots': 'error',
+    'jest/no-jasmine-globals': 'error',
+    'jest/no-jest-import': 'error',
+    // reasonable but arbitrary size limit
+    'jest/no-large-snapshots': ['error', { maxSize: 500 }],
+    'jest/no-mocks-import': 'error',
+    'jest/no-restricted-matchers': 'error',
+    'jest/no-standalone-expect': 'error',
+    'jest/no-test-prefixes': 'error',
+    'jest/no-test-return-statement': 'error',
+    'jest/prefer-called-with': 'error',
+    'jest/prefer-expect-assertions': 'error',
+    'jest/prefer-hooks-on-top': 'error',
+    // descriptions are often named after React components which are capitalized
+    'jest/prefer-lowercase-title': 'off',
+    'jest/prefer-spy-on': 'error',
+    'jest/prefer-strict-equal': 'error',
+    'jest/prefer-to-be': 'error',
+    'jest/prefer-to-contain': 'error',
+    'jest/prefer-to-have-length': 'error',
+    'jest/prefer-todo': 'error',
+    'jest/require-to-throw-message': 'error',
+    'jest/require-top-level-describe': 'error',
+    'jest/valid-describe-callback': 'error',
+    'jest/valid-expect': 'error',
+    'jest/valid-expect-in-promise': 'error',
+    'jest/valid-title': 'error',
+
+    // formatting rules for tests
+    'jest-formatting/padding-around-after-all-blocks': 'error',
+    'jest-formatting/padding-around-after-each-blocks': 'error',
+    'jest-formatting/padding-around-before-all-blocks': 'error',
+    'jest-formatting/padding-around-before-each-blocks': 'error',
+    'jest-formatting/padding-around-expect-groups': 'error',
+    'jest-formatting/padding-around-describe-blocks': 'error',
+    'jest-formatting/padding-around-test-blocks': 'error',
+    'jest-formatting/padding-around-all': 'error',
+  },
 };

package/rules/eslint/sonar.js

@@ -2,39 +2,42 @@
 // see: https://github.com/SonarSource/eslint-plugin-sonarjs#rules
 
 module.exports = {
-  // bug detection
-  'sonarjs/no-all-duplicated-branches': 'error',
-  'sonarjs/no-element-overwrite': 'error',
-  'sonarjs/no-empty-collection': 'error',
-  'sonarjs/no-extra-arguments': 'error',
-  'sonarjs/no-identical-conditions': 'error',
-  'sonarjs/no-identical-expressions': 'error',
-  'sonarjs/no-ignored-return': 'error',
-  'sonarjs/no-one-iteration-loop': 'error',
-  'sonarjs/no-use-of-empty-return-value': 'error',
-  'sonarjs/non-existent-operator': 'error',
+  plugins: ['eslint-plugin-sonarjs'],
+  rules: {
+    // bug detection
+    'sonarjs/no-all-duplicated-branches': 'error',
+    'sonarjs/no-element-overwrite': 'error',
+    'sonarjs/no-empty-collection': 'error',
+    'sonarjs/no-extra-arguments': 'error',
+    'sonarjs/no-identical-conditions': 'error',
+    'sonarjs/no-identical-expressions': 'error',
+    'sonarjs/no-ignored-return': 'error',
+    'sonarjs/no-one-iteration-loop': 'error',
+    'sonarjs/no-use-of-empty-return-value': 'error',
+    'sonarjs/non-existent-operator': 'error',
 
-  // code smells
-  'sonarjs/cognitive-complexity': 'error',
-  'sonarjs/elseif-without-else': 'error',
-  'sonarjs/max-switch-cases': 'error',
-  'sonarjs/no-collapsible-if': 'error',
-  'sonarjs/no-collection-size-mischeck': 'error',
-  'sonarjs/no-duplicate-string': 'off',
-  'sonarjs/no-duplicated-branches': 'error',
-  'sonarjs/no-gratuitous-expressions': 'error',
-  'sonarjs/no-identical-functions': 'error',
-  'sonarjs/no-inverted-boolean-check': 'error',
-  'sonarjs/no-nested-switch': 'error',
-  'sonarjs/no-nested-template-literals': 'error',
-  'sonarjs/no-redundant-boolean': 'error',
-  'sonarjs/no-redundant-jump': 'error',
-  'sonarjs/no-same-line-conditional': 'error',
-  'sonarjs/no-small-switch': 'error',
-  'sonarjs/no-unused-collection': 'error',
-  'sonarjs/no-useless-catch': 'error',
-  'sonarjs/prefer-immediate-return': 'error',
-  'sonarjs/prefer-object-literal': 'error',
-  'sonarjs/prefer-single-boolean-return': 'error',
-  'sonarjs/prefer-while': 'error',
+    // code smells
+    'sonarjs/cognitive-complexity': 'error',
+    'sonarjs/elseif-without-else': 'error',
+    'sonarjs/max-switch-cases': 'error',
+    'sonarjs/no-collapsible-if': 'error',
+    'sonarjs/no-collection-size-mischeck': 'error',
+    'sonarjs/no-duplicate-string': 'off',
+    'sonarjs/no-duplicated-branches': 'error',
+    'sonarjs/no-gratuitous-expressions': 'error',
+    'sonarjs/no-identical-functions': 'error',
+    'sonarjs/no-inverted-boolean-check': 'error',
+    'sonarjs/no-nested-switch': 'error',
+    'sonarjs/no-nested-template-literals': 'error',
+    'sonarjs/no-redundant-boolean': 'error',
+    'sonarjs/no-redundant-jump': 'error',
+    'sonarjs/no-same-line-conditional': 'error',
+    'sonarjs/no-small-switch': 'error',
+    'sonarjs/no-unused-collection': 'error',
+    'sonarjs/no-useless-catch': 'error',
+    'sonarjs/prefer-immediate-return': 'error',
+    'sonarjs/prefer-object-literal': 'error',
+    'sonarjs/prefer-single-boolean-return': 'error',
+    'sonarjs/prefer-while': 'error',
+  },
 };

package/rules/eslint/styled-components.js

@@ -3,6 +3,89 @@
 // see: https://github.com/brendanmorrell/eslint-plugin-styled-components-a11y
 
 module.exports = {
-  // sort styled-component properties alphabetically
-  'better-styled-components/sort-declarations-alphabetically': 'error',
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+  rules: {
+    // sort styled-component properties alphabetically
+    'better-styled-components/sort-declarations-alphabetically': 'error',
+
+    'styled-components-a11y/accessible-emoji': 'error',
+    'styled-components-a11y/alt-text': 'error',
+    'styled-components-a11y/anchor-has-content': 'error',
+    'styled-components-a11y/anchor-is-valid': 'error',
+    'styled-components-a11y/aria-activedescendant-has-tabindex': 'error',
+    'styled-components-a11y/aria-props': 'error',
+    'styled-components-a11y/aria-proptypes': 'error',
+    'styled-components-a11y/aria-role': 'error',
+    'styled-components-a11y/aria-unsupported-elements': 'error',
+    'styled-components-a11y/autocomplete-valid': 'error',
+    'styled-components-a11y/click-events-have-key-events': 'error',
+    'styled-components-a11y/control-has-associated-label': [
+      'error',
+      {
+        ignoreElements: ['audio', 'canvas', 'embed', 'input', 'textarea', 'tr', 'video'],
+        ignoreRoles: [
+          'grid',
+          'listbox',
+          'menu',
+          'menubar',
+          'radiogroup',
+          'row',
+          'tablist',
+          'toolbar',
+          'tree',
+          'treegrid',
+        ],
+        includeRoles: ['alert', 'dialog'],
+      },
+    ],
+    'styled-components-a11y/heading-has-content': 'error',
+    'styled-components-a11y/html-has-lang': 'error',
+    'styled-components-a11y/iframe-has-title': 'error',
+    'styled-components-a11y/img-redundant-alt': 'error',
+    'styled-components-a11y/interactive-supports-focus': [
+      'error',
+      {
+        tabbable: [
+          'button',
+          'checkbox',
+          'link',
+          'progressbar',
+          'searchbox',
+          'slider',
+          'spinbutton',
+          'switch',
+          'textbox',
+        ],
+      },
+    ],
+    'styled-components-a11y/label-has-associated-control': 'error',
+    'styled-components-a11y/label-has-for': 'error',
+    'styled-components-a11y/media-has-caption': 'error',
+    'styled-components-a11y/mouse-events-have-key-events': 'error',
+    'styled-components-a11y/no-access-key': 'error',
+    'styled-components-a11y/no-autofocus': 'error',
+    'styled-components-a11y/no-distracting-elements': 'error',
+    'styled-components-a11y/no-interactive-element-to-noninteractive-role': 'error',
+    'styled-components-a11y/no-noninteractive-element-interactions': [
+      'error',
+      {
+        body: ['onError', 'onLoad'],
+        iframe: ['onError', 'onLoad'],
+        img: ['onError', 'onLoad'],
+      },
+    ],
+    'styled-components-a11y/no-noninteractive-element-to-interactive-role': 'error',
+    'styled-components-a11y/no-noninteractive-tabindex': 'error',
+    'styled-components-a11y/no-onchange': 'error',
+    'styled-components-a11y/no-redundant-roles': 'error',
+    'styled-components-a11y/no-static-element-interactions': 'error',
+    'styled-components-a11y/role-has-required-aria-props': 'error',
+    'styled-components-a11y/role-supports-aria-props': 'error',
+    'styled-components-a11y/scope': 'error',
+    'styled-components-a11y/tabindex-no-positive': 'error',
+  },
 };

package/rules/eslint/testing-library.js

@@ -3,56 +3,60 @@
 // see: https://github.com/testing-library/eslint-plugin-jest-dom#supported-rules
 
 module.exports = {
-  'testing-library/await-async-query': 'error',
-  'testing-library/await-async-utils': 'error',
-  'testing-library/await-fire-event': 'off', // vue only
-  'testing-library/consistent-data-testid': [
-    'error',
-    {
-      // should we have an opinion about this?
-      testIdPattern: '.*',
-      testIdAttribute: ['data-testid'],
-    },
-  ],
-  // since `user-event` v14 all its methods are async so we disable reporting them
-  // by setting the `eventModules` to just `"fire-event"`
-  'testing-library/no-await-sync-events': [
-    'error',
-    {
-      eventModules: ['fire-event'],
-    },
-  ],
-  'testing-library/no-await-sync-query': 'error',
-  'testing-library/no-container': 'error',
-  'testing-library/no-debugging-utils': 'error',
-  'testing-library/no-dom-import': 'error',
-  'testing-library/no-manual-cleanup': 'error',
-  'testing-library/no-node-access': 'error',
-  'testing-library/no-promise-in-fire-event': 'error',
-  'testing-library/no-render-in-setup': 'error',
-  'testing-library/no-unnecessary-act': 'error',
-  'testing-library/no-wait-for-empty-callback': 'error',
-  'testing-library/no-wait-for-multiple-assertions': 'error',
-  'testing-library/no-wait-for-side-effects': 'error',
-  'testing-library/no-wait-for-snapshot': 'error',
-  'testing-library/prefer-explicit-assert': 'error',
-  'testing-library/prefer-find-by': 'error',
-  'testing-library/prefer-presence-queries': 'error',
-  'testing-library/prefer-query-by-disappearance': 'error',
-  'testing-library/prefer-screen-queries': 'error',
-  'testing-library/prefer-user-event': 'error',
-  'testing-library/prefer-wait-for': 'error',
-  'testing-library/render-result-naming-convention': 'error',
+  plugins: ['eslint-plugin-testing-library', 'eslint-plugin-jest-dom'],
 
-  'jest-dom/prefer-checked': 'error',
-  'jest-dom/prefer-empty': 'error',
-  'jest-dom/prefer-enabled-disabled': 'error',
-  'jest-dom/prefer-focus': 'error',
-  'jest-dom/prefer-in-document': 'error',
-  'jest-dom/prefer-required': 'error',
-  'jest-dom/prefer-to-have-attribute': 'error',
-  'jest-dom/prefer-to-have-class': 'error',
-  'jest-dom/prefer-to-have-style': 'error',
-  'jest-dom/prefer-to-have-text-content': 'error',
-  'jest-dom/prefer-to-have-value': 'error',
+  rules: {
+    'testing-library/await-async-query': 'error',
+    'testing-library/await-async-utils': 'error',
+    'testing-library/await-fire-event': 'off', // vue only
+    'testing-library/consistent-data-testid': [
+      'error',
+      {
+        // should we have an opinion about this?
+        testIdPattern: '.*',
+        testIdAttribute: ['data-testid'],
+      },
+    ],
+    // since `user-event` v14 all its methods are async so we disable reporting them
+    // by setting the `eventModules` to just `"fire-event"`
+    'testing-library/no-await-sync-events': [
+      'error',
+      {
+        eventModules: ['fire-event'],
+      },
+    ],
+    'testing-library/no-await-sync-query': 'error',
+    'testing-library/no-container': 'error',
+    'testing-library/no-debugging-utils': 'error',
+    'testing-library/no-dom-import': 'error',
+    'testing-library/no-manual-cleanup': 'error',
+    'testing-library/no-node-access': 'error',
+    'testing-library/no-promise-in-fire-event': 'error',
+    'testing-library/no-render-in-setup': 'error',
+    'testing-library/no-unnecessary-act': 'error',
+    'testing-library/no-wait-for-empty-callback': 'error',
+    'testing-library/no-wait-for-multiple-assertions': 'error',
+    'testing-library/no-wait-for-side-effects': 'error',
+    'testing-library/no-wait-for-snapshot': 'error',
+    'testing-library/prefer-explicit-assert': 'error',
+    'testing-library/prefer-find-by': 'error',
+    'testing-library/prefer-presence-queries': 'error',
+    'testing-library/prefer-query-by-disappearance': 'error',
+    'testing-library/prefer-screen-queries': 'error',
+    'testing-library/prefer-user-event': 'error',
+    'testing-library/prefer-wait-for': 'error',
+    'testing-library/render-result-naming-convention': 'error',
+
+    'jest-dom/prefer-checked': 'error',
+    'jest-dom/prefer-empty': 'error',
+    'jest-dom/prefer-enabled-disabled': 'error',
+    'jest-dom/prefer-focus': 'error',
+    'jest-dom/prefer-in-document': 'error',
+    'jest-dom/prefer-required': 'error',
+    'jest-dom/prefer-to-have-attribute': 'error',
+    'jest-dom/prefer-to-have-class': 'error',
+    'jest-dom/prefer-to-have-style': 'error',
+    'jest-dom/prefer-to-have-text-content': 'error',
+    'jest-dom/prefer-to-have-value': 'error',
+  },
 };

package/rules/stylelint/scss.js

@@ -1,33 +1,35 @@
 // only add rules pertaining to scss
 
 module.exports = {
-  // disallow vendor prefixes
-  'at-rule-no-vendor-prefix': true,
-  'property-no-vendor-prefix': true,
-  'selector-no-vendor-prefix': true,
-  'value-no-vendor-prefix': true,
+  rules: {
+    // disallow vendor prefixes
+    'at-rule-no-vendor-prefix': true,
+    'property-no-vendor-prefix': true,
+    'selector-no-vendor-prefix': true,
+    'value-no-vendor-prefix': true,
 
-  // prefer single to double quotes for better js compat
-  'string-quotes': 'single',
+    // prefer single to double quotes for better js compat
+    'string-quotes': 'single',
 
-  // *** DISABLED RULES ***
-  // too many violations to fix so we just allow any pattern
-  'selector-class-pattern': '[a-zA-Z0-9]',
-  'selector-id-pattern': '[a-zA-Z0-9]',
+    // *** DISABLED RULES ***
+    // too many violations to fix so we just allow any pattern
+    'selector-class-pattern': '[a-zA-Z0-9]',
+    'selector-id-pattern': '[a-zA-Z0-9]',
 
-  // unfortunately these conflict with sass functions; hopefully someday we will be able to enable
-  'color-function-notation': null,
-  'alpha-value-notation': null,
+    // unfortunately these conflict with sass functions; hopefully someday we will be able to enable
+    'color-function-notation': null,
+    'alpha-value-notation': null,
 
-  // thousands of these errors, not realistically fixable
-  'no-descending-specificity': null,
+    // thousands of these errors, not realistically fixable
+    'no-descending-specificity': null,
 
-  // TODO: enable this?
-  'no-duplicate-selectors': null,
+    // TODO: enable this?
+    'no-duplicate-selectors': null,
 
-  'scss/at-extend-no-missing-placeholder': null,
-  'scss/at-mixin-pattern': null,
-  'scss/dollar-variable-pattern': null,
-  'scss/no-global-function-names': null,
-  'scss/percent-placeholder-pattern': null,
+    'scss/at-extend-no-missing-placeholder': null,
+    'scss/at-mixin-pattern': null,
+    'scss/dollar-variable-pattern': null,
+    'scss/no-global-function-names': null,
+    'scss/percent-placeholder-pattern': null,
+  },
 };

package/rules/stylelint/styled-components.js

@@ -1,26 +1,30 @@
 // only add rules pertaining to styled-components
 
 module.exports = {
-  // in css-in-js when variables are being passed around, this rule
-  // often leads to less readable code, even though it is more compact
-  'declaration-block-no-redundant-longhand-properties': null,
-  // this appears to conflict with styled-components keyframes method
-  'keyframes-name-pattern': null,
-  // without this pretty much every file will throw an error¯\_(ツ)_/¯
-  'no-empty-source': null,
-  // disallow property values that are ignored due to another property value in the same rule
-  'plugin/declaration-block-no-ignored-properties': true,
-  // prevent snake case from being used for class/id selectors but be otherwise flexible
-  'selector-class-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
-  'selector-id-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
-  // these selectors are used as placeholders by styled-components preprocessor
-  'selector-type-case': ['lower', { ignoreTypes: ['$dummyValue'] }],
-  'selector-type-no-unknown': [true, { ignoreTypes: ['$dummyValue', '/^-styled-/'] }],
-  'value-keyword-case': [
-    'lower',
-    { ignoreKeywords: [/dummyValue/], ignoreProperties: [/dummyValue/] },
-  ],
-  // styled-components adds vendor prefixes if necessary so we should avoid adding them in code
-  'value-no-vendor-prefix': true,
-  'property-no-vendor-prefix': true,
+  plugins: ['eslint-plugin-better-styled-components', 'eslint-plugin-styled-components-a11y'],
+
+  rules: {
+    // in css-in-js when variables are being passed around, this rule
+    // often leads to less readable code, even though it is more compact
+    'declaration-block-no-redundant-longhand-properties': null,
+    // this appears to conflict with styled-components keyframes method
+    'keyframes-name-pattern': null,
+    // without this pretty much every file will throw an error¯\_(ツ)_/¯
+    'no-empty-source': null,
+    // disallow property values that are ignored due to another property value in the same rule
+    'plugin/declaration-block-no-ignored-properties': true,
+    // prevent snake case from being used for class/id selectors but be otherwise flexible
+    'selector-class-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
+    'selector-id-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
+    // these selectors are used as placeholders by styled-components preprocessor
+    'selector-type-case': ['lower', { ignoreTypes: ['$dummyValue'] }],
+    'selector-type-no-unknown': [true, { ignoreTypes: ['$dummyValue', '/^-styled-/'] }],
+    'value-keyword-case': [
+      'lower',
+      { ignoreKeywords: [/dummyValue/], ignoreProperties: [/dummyValue/] },
+    ],
+    // styled-components adds vendor prefixes if necessary so we should avoid adding them in code
+    'value-no-vendor-prefix': true,
+    'property-no-vendor-prefix': true,
+  },
 };

package/sonar.js

@@ -1,8 +1,3 @@
-const sonarRules = require('./rules/eslint/sonar');
-
 module.exports = {
-  plugins: ['eslint-plugin-sonarjs'],
-  rules: {
-    ...sonarRules,
-  },
+  extends: ['./rules/eslint/sonar'].map(require.resolve),
 };

package/styled-components.js

@@ -1,9 +1,3 @@
-const styledComponentsRules = require('./rules/eslint/styled-components');
-
 module.exports = {
-  plugins: ['eslint-plugin-better-styled-components', 'eslint-plugin-styled-components-a11y'],
-  extends: ['plugin:styled-components-a11y/strict'],
-  rules: {
-    ...styledComponentsRules,
-  },
+  extends: ['./rules/eslint/styled-components'].map(require.resolve),
 };

package/stylelint/base.js

@@ -1,9 +1,8 @@
-const commonRules = require('../rules/stylelint/common');
-
 module.exports = {
   plugins: ['stylelint-prettier'],
-  extends: ['stylelint-config-standard', 'stylelint-config-prettier'],
+  extends: ['stylelint-config-standard', 'stylelint-config-prettier'].map(require.resolve),
   rules: {
-    ...commonRules,
+    // prettier configuration
+    'prettier/prettier': true,
   },
 };

package/stylelint/scss.js

@@ -1,11 +1,10 @@
-const commonRules = require('../rules/stylelint/common');
-const scssRules = require('../rules/stylelint/scss');
+// see: https://github.com/stylelint-scss/stylelint-config-standard-scss/blob/main/index.js
 
 module.exports = {
   plugins: ['stylelint-prettier', 'eslint-plugin-stylelint-scss'],
-  extends: ['stylelint-config-standard-scss'], // see: https://github.com/stylelint-scss/stylelint-config-standard-scss/blob/main/index.js
+  extends: ['stylelint-config-standard-scss', '../rules/stylelint/scss'].map(require.resolve),
   rules: {
-    ...commonRules,
-    ...scssRules,
+    // prettier configuration
+    'prettier/prettier': true,
   },
 };

package/stylelint/styled-components.js

@@ -1,13 +1,14 @@
-const commonRules = require('../rules/stylelint/common');
-const styledComponentRules = require('../rules/stylelint/styled-components');
-
 module.exports = {
   plugins: ['stylelint-prettier', 'stylelint-declaration-block-no-ignored-properties'],
-  extends: ['stylelint-config-standard-scss', 'stylelint-config-prettier'],
+  extends: [
+    'stylelint-config-standard-scss',
+    '../rules/stylelint/styled-components',
+    'stylelint-config-prettier',
+  ].map(require.resolve),
   customSyntax: 'postcss-scss',
   processors: ['stylelint-processor-styled-components'],
   rules: {
-    ...commonRules,
-    ...styledComponentRules,
+    // prettier configuration
+    'prettier/prettier': true,
   },
 };

package/testing-library.js

@@ -1,8 +1,3 @@
-const testRules = require('./rules/eslint/testing-library');
-
 module.exports = {
-  plugins: ['eslint-plugin-testing-library', 'eslint-plugin-jest-dom'],
-  rules: {
-    ...testRules,
-  },
+  extends: ['./rules/eslint/testing-library'].map(require.resolve),
 };

package/rules/stylelint/common.js

@@ -1,6 +0,0 @@
-// these rules are included in all config types
-
-module.exports = {
-  // prettier configuration
-  'prettier/prettier': true,
-};