@wistia/eslint-config 0.41.2 → 0.43.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.41.2",
+  "version": "0.43.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.9.2",
   "main": "react.js",
@@ -11,7 +11,6 @@
   "exports": {
     "./package.json": "./package.json",
     ".": "./configs/eslint/default.cjs",
-    "./cypress": "./configs/eslint/cypress.cjs",
     "./functional-programming": "./configs/eslint/functional-programming.cjs",
     "./jest": "./configs/eslint/jest.cjs",
     "./node": "./configs/eslint/node.cjs",
@@ -21,9 +20,6 @@
     "./storybook": "./configs/eslint/storybook.cjs",
     "./strict": "./configs/eslint/strict.cjs",
     "./styled-components": "./configs/eslint/styled-components.cjs",
-    "./stylelint": "./configs/stylelint/default.cjs",
-    "./stylelint/scss": "./configs/stylelint/scss.cjs",
-    "./stylelint/styled-components": "./configs/stylelint/styled-components.cjs",
     "./testing-library": "./configs/eslint/testing-library.cjs",
     "./typescript": "./configs/eslint/typescript.cjs",
     "./typescript-react": "./configs/eslint/typescript-react.cjs",
@@ -37,8 +33,7 @@
     "prepare": "husky",
     "release": "changeset publish",
     "test": "vitest run",
-    "test:export": "check-export-map",
-    "test:stylelint": "stylelint --print-config ./test/index.mjs"
+    "test:export": "check-export-map"
   },
   "engines": {
     "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
@@ -54,60 +49,51 @@
   "author": "Wistia Engineering",
   "license": "UNLICENSED",
   "dependencies": {
-    "@babel/core": "^7.27.4",
-    "@babel/eslint-parser": "^7.27.5",
+    "@babel/core": "^7.28.4",
+    "@babel/eslint-parser": "^7.28.4",
     "@babel/preset-react": "^7.27.1",
-    "@jantimon/stylelint-enforce-pseudo-ampersand": "^1.0.2",
-    "@rushstack/eslint-patch": "^1.11.0",
-    "@typescript-eslint/eslint-plugin": "^8.34.1",
-    "@typescript-eslint/parser": "^8.34.1",
+    "@rushstack/eslint-patch": "^1.14.0",
+    "@typescript-eslint/eslint-plugin": "^8.46.2",
+    "@typescript-eslint/parser": "^8.46.2",
     "confusing-browser-globals": "^1.0.11",
     "eslint": "^8.57.1",
-    "eslint-config-prettier": "^10.1.5",
-    "eslint-import-resolver-typescript": "^4.4.3",
-    "eslint-plugin-cypress": "^3.6.0",
+    "eslint-config-prettier": "^10.1.8",
+    "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-fp": "^2.3.0",
-    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest": "^28.14.0",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
-    "eslint-plugin-n": "^17.20.0",
+    "eslint-plugin-n": "^17.23.1",
     "eslint-plugin-no-only-tests": "^3.3.0",
     "eslint-plugin-no-snapshot-testing": "^1.0.61",
     "eslint-plugin-no-typeof-window-undefined": "^0.0.2",
     "eslint-plugin-observers": "^1.0.1",
-    "eslint-plugin-prettier": "^5.5.0",
+    "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-promise": "^7.2.1",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-compiler": "^19.1.0-rc.2",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint-plugin-react-hooks": "^7.0.0",
     "eslint-plugin-react-hooks-ssr": "^0.1.5",
     "eslint-plugin-sonarjs": "^1.0.4",
     "eslint-plugin-ssr-friendly": "^1.3.0",
     "eslint-plugin-storybook": "^0.12.0",
     "eslint-plugin-styled-components-a11y": "^2.2.1",
-    "eslint-plugin-testing-library": "^7.5.3",
+    "eslint-plugin-testing-library": "^7.13.3",
     "eslint-plugin-vitest": "^0.5.4",
     "eslint-plugin-vitest-globals": "^1.5.0",
-    "postcss": "^8.5.6",
-    "postcss-scss": "^4.0.9",
-    "postcss-styled-syntax": "^0.7.1",
-    "prettier": "^3.5.3",
-    "stylelint": "^16.21.0",
-    "stylelint-declaration-block-no-ignored-properties": "^2.8.0",
-    "stylelint-prettier": "^5.0.3",
-    "stylelint-scss": "^6.12.1"
+    "prettier": "^3.6.2"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.5.1",
-    "@changesets/cli": "^2.29.5",
-    "@commitlint/cli": "^19.8.1",
-    "@commitlint/config-conventional": "^19.8.1",
+    "@changesets/cli": "^2.29.7",
+    "@commitlint/cli": "^20.1.0",
+    "@commitlint/config-conventional": "^20.0.0",
     "check-export-map": "^1.3.1",
     "husky": "^9.1.7",
-    "typescript": "^5.8.3",
-    "vitest": "^3.2.4"
+    "typescript": "^5.9.3",
+    "vitest": "^4.0.1"
   }
 }

package/configs/eslint/cypress.cjs

@@ -1,9 +0,0 @@
-require('@rushstack/eslint-patch/modern-module-resolution');
-
-module.exports = {
-  env: {
-    'cypress/globals': true,
-  },
-
-  extends: ['../../rules/eslint/cypress.cjs'].map(require.resolve),
-};

package/configs/stylelint/default.cjs

@@ -1,8 +0,0 @@
-module.exports = {
-  plugins: ['stylelint-prettier', '@jantimon/stylelint-enforce-pseudo-ampersand'],
-  extends: ['../../rules/stylelint/css.cjs'].map(require.resolve),
-  rules: {
-    // prettier configuration
-    'prettier/prettier': true,
-  },
-};

package/configs/stylelint/scss.cjs

@@ -1,9 +0,0 @@
-module.exports = {
-  plugins: ['stylelint-prettier', 'stylelint-scss', '@jantimon/stylelint-enforce-pseudo-ampersand'],
-  extends: ['../../rules/stylelint/css.cjs', '../../rules/stylelint/scss.cjs'].map(require.resolve),
-  customSyntax: require('postcss-scss'),
-  rules: {
-    // prettier configuration
-    'prettier/prettier': true,
-  },
-};

package/configs/stylelint/styled-components.cjs

@@ -1,15 +0,0 @@
-module.exports = {
-  plugins: [
-    'stylelint-prettier',
-    'stylelint-declaration-block-no-ignored-properties',
-    '@jantimon/stylelint-enforce-pseudo-ampersand',
-  ],
-  extends: ['../../rules/stylelint/css.cjs', '../../rules/stylelint/styled-components.cjs'].map(
-    require.resolve,
-  ),
-  customSyntax: require('postcss-styled-syntax'),
-  rules: {
-    // prettier configuration
-    'prettier/prettier': true,
-  },
-};

package/rules/eslint/cypress.cjs

@@ -1,40 +0,0 @@
-// only add cypress rules
-// see: https://github.com/cypress-io/eslint-plugin-cypress#rules
-
-module.exports = {
-  plugins: ['eslint-plugin-no-only-tests', 'eslint-plugin-cypress'],
-
-  rules: {
-    // Prevent focused tests (.only)
-    // https://github.com/levibuzolic/eslint-plugin-no-only-tests#usage
-    'no-only-tests/no-only-tests': 'error',
-
-    // Prevent assigning return values of cy calls
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-assigning-return-values.md
-    'cypress/no-assigning-return-values': 'error',
-
-    // Prevent waiting for arbitrary time periods
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-unnecessary-waiting.md
-    'cypress/no-unnecessary-waiting': 'error',
-
-    // Prevent using async/await in Cypress test case
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-async-tests.md
-    'cypress/no-async-tests': 'error',
-
-    // Disallow using `force: true` with action commands
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-force.md
-    'cypress/no-force': 'error',
-
-    // Ensure screenshots are preceded by an assertion
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/assertion-before-screenshot.md
-    'cypress/assertion-before-screenshot': 'error',
-
-    // Only allow data-\* attribute selectors (require-data-selectors)
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/require-data-selectors.md
-    'cypress/require-data-selectors': 'error',
-
-    // Disallow `cy.pause()` parent command
-    // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/no-pause.md
-    'cypress/no-pause': 'error',
-  },
-};

package/rules/stylelint/css.cjs

@@ -1,172 +0,0 @@
-// only add rules pertaining to css
-
-module.exports = {
-  rules: {
-    // https://github.com/stylelint/stylelint-config-recommended/blob/main/index.js#L5
-    'annotation-no-unknown': true,
-    'at-rule-no-unknown': true,
-    'block-no-empty': true,
-    'color-no-invalid-hex': true,
-    'comment-no-empty': true,
-    'custom-property-no-missing-var-function': true,
-    'declaration-block-no-duplicate-custom-properties': true,
-    'declaration-block-no-duplicate-properties': [
-      true,
-      {
-        ignore: ['consecutive-duplicates-with-different-values'],
-      },
-    ],
-    'declaration-block-no-shorthand-property-overrides': true,
-    'font-family-no-duplicate-names': true,
-    'font-family-no-missing-generic-family-keyword': true,
-    'function-calc-no-unspaced-operator': true,
-    'function-linear-gradient-no-nonstandard-direction': true,
-    'function-no-unknown': true,
-    'keyframe-block-no-duplicate-selectors': true,
-    'keyframe-declaration-no-important': true,
-    'media-feature-name-no-unknown': true,
-    'named-grid-areas-no-invalid': true,
-    'no-descending-specificity': true,
-    'no-duplicate-at-import-rules': true,
-    'no-duplicate-selectors': true,
-    'no-empty-source': true,
-    'no-invalid-double-slash-comments': true,
-    'no-invalid-position-at-import-rule': true,
-    'no-irregular-whitespace': true,
-    'property-no-unknown': true,
-    'selector-anb-no-unmatchable': true,
-    'selector-pseudo-class-no-unknown': true,
-    'selector-pseudo-element-no-unknown': true,
-    'selector-type-no-unknown': [
-      true,
-      {
-        ignore: ['custom-elements'],
-      },
-    ],
-    'string-no-newline': true,
-    'unit-no-unknown': true,
-
-    // https://github.com/stylelint/stylelint-config-standard/blob/main/index.js#L5
-    'alpha-value-notation': [
-      'percentage',
-      {
-        exceptProperties: [
-          'opacity',
-          'fill-opacity',
-          'flood-opacity',
-          'stop-opacity',
-          'stroke-opacity',
-        ],
-      },
-    ],
-    'at-rule-empty-line-before': [
-      'always',
-      {
-        except: ['blockless-after-same-name-blockless', 'first-nested'],
-        ignore: ['after-comment'],
-      },
-    ],
-    'property-no-vendor-prefix': [
-      true,
-      {
-        /* non-standard but supported across mobile browsers */
-        ignoreProperties: [/appearance/, /text-size-adjust/],
-      },
-    ],
-    'color-function-notation': 'modern',
-    'color-hex-length': 'long',
-    'comment-empty-line-before': [
-      'always',
-      {
-        except: ['first-nested'],
-        ignore: ['stylelint-commands'],
-      },
-    ],
-    'comment-whitespace-inside': 'always',
-    'custom-property-empty-line-before': [
-      'always',
-      {
-        except: ['after-custom-property', 'first-nested'],
-        ignore: ['after-comment', 'inside-single-line-block'],
-      },
-    ],
-    'custom-media-pattern': [
-      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: (name) => `Expected custom media query name "${name}" to be kebab-case`,
-      },
-    ],
-    'custom-property-pattern': [
-      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: (name) => `Expected custom property name "${name}" to be kebab-case`,
-      },
-    ],
-    'declaration-block-no-redundant-longhand-properties': true,
-    'declaration-empty-line-before': [
-      'always',
-      {
-        except: ['after-declaration', 'first-nested'],
-        ignore: ['after-comment', 'inside-single-line-block'],
-      },
-    ],
-    'font-family-name-quotes': 'always-where-recommended',
-    'function-name-case': 'lower',
-    'function-url-quotes': 'always',
-    'hue-degree-notation': 'angle',
-    'import-notation': 'url',
-    'keyframe-selector-notation': 'percentage-unless-within-keyword-only-block',
-    'keyframes-name-pattern': [
-      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: (name) => `Expected keyframe name "${name}" to be kebab-case`,
-      },
-    ],
-    'length-zero-no-unit': [
-      true,
-      {
-        ignore: ['custom-properties'],
-      },
-    ],
-    'media-feature-name-no-vendor-prefix': true,
-    'media-feature-range-notation': 'prefix',
-    'number-max-precision': 4,
-    'property-no-vendor-prefix': true,
-    'rule-empty-line-before': [
-      'always-multi-line',
-      {
-        except: ['first-nested'],
-        ignore: ['after-comment'],
-      },
-    ],
-    'selector-attribute-quotes': 'always',
-    'selector-class-pattern': [
-      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: (selector) => `Expected class selector "${selector}" to be kebab-case`,
-      },
-    ],
-    'selector-id-pattern': [
-      '^([a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: (selector) => `Expected id selector "${selector}" to be kebab-case`,
-      },
-    ],
-    'selector-no-vendor-prefix': true,
-    'selector-not-notation': 'complex',
-    'selector-pseudo-element-colon-notation': 'double',
-    'selector-type-case': 'lower',
-    'shorthand-property-no-redundant-values': true,
-    'value-keyword-case': 'lower',
-    'value-no-vendor-prefix': [
-      true,
-      {
-        // `-webkit-box` is allowed as standard. See https://www.w3.org/TR/css-overflow-3/#webkit-line-clamp
-        ignoreValues: ['box', 'inline-box'],
-      },
-    ],
-
-    // https://github.com/jantimon/stylelint-enforce-pseudo-ampersand?tab=readme-ov-file#usage
-    'jantimon/stylelint-enforce-pseudo-ampersand': 'always',
-  },
-};

package/rules/stylelint/scss.cjs

@@ -1,80 +0,0 @@
-// only add rules pertaining to scss
-
-module.exports = {
-  rules: {
-    // adjust/disable some rules from css that cause issues
-    'at-rule-no-unknown': null,
-    'at-rule-empty-line-before': [
-      'always',
-      {
-        except: ['blockless-after-blockless', 'first-nested'],
-        ignore: ['after-comment'],
-        ignoreAtRules: ['else'],
-      },
-    ],
-    'function-no-unknown': null,
-    'import-notation': 'string',
-    'no-invalid-position-at-import-rule': [
-      true,
-      {
-        ignoreAtRules: ['use', 'forward'],
-      },
-    ],
-
-    // unfortunately these conflict with sass functions; hopefully someday we will be able to enable
-    'color-function-notation': null,
-    'alpha-value-notation': null,
-
-    'scss/at-else-closing-brace-newline-after': 'always-last-in-chain',
-    'scss/at-else-closing-brace-space-after': 'always-intermediate',
-    'scss/at-else-empty-line-before': 'never',
-    'scss/at-else-if-parentheses-space-before': 'always',
-    'scss/at-function-parentheses-space-before': 'never',
-    'scss/at-function-pattern': [
-      '^(-?[a-z][a-z0-9]*)(-[a-z0-9]+)*$',
-      {
-        message: 'Expected function name to be kebab-case',
-      },
-    ],
-    'scss/at-if-closing-brace-newline-after': 'always-last-in-chain',
-    'scss/at-if-closing-brace-space-after': 'always-intermediate',
-    'scss/at-mixin-argumentless-call-parentheses': 'never',
-    'scss/at-mixin-parentheses-space-before': 'never',
-    'scss/at-rule-conditional-no-parentheses': true,
-    'scss/dollar-variable-colon-space-after': 'always',
-    'scss/dollar-variable-colon-space-before': 'never',
-    'scss/dollar-variable-empty-line-before': [
-      'always',
-      {
-        except: ['after-dollar-variable', 'first-nested'],
-        ignore: ['after-comment', 'inside-single-line-block'],
-      },
-    ],
-    'scss/double-slash-comment-empty-line-before': [
-      'always',
-      {
-        except: ['first-nested'],
-        ignore: ['between-comments', 'stylelint-commands'],
-      },
-    ],
-    'scss/at-extend-no-missing-placeholder': null,
-    'scss/at-if-no-null': true,
-    'scss/at-import-no-partial-leading-underscore': true,
-    'scss/at-import-partial-extension': 'never',
-    'scss/at-mixin-pattern': null,
-    'scss/at-rule-no-unknown': true,
-    'scss/comment-no-empty': true,
-    'scss/declaration-nested-properties-no-divided-groups': true,
-    'scss/dollar-variable-no-missing-interpolation': true,
-    'scss/dollar-variable-pattern': null,
-    'scss/double-slash-comment-whitespace-inside': 'always',
-    'scss/function-quote-no-quoted-strings-inside': true,
-    'scss/function-unquote-no-unquoted-strings-inside': true,
-    'scss/no-duplicate-mixins': true,
-    'scss/no-global-function-names': null,
-    'scss/operator-no-newline-after': true,
-    'scss/operator-no-newline-before': true,
-    'scss/operator-no-unspaced': true,
-    'scss/percent-placeholder-pattern': null,
-  },
-};

package/rules/stylelint/styled-components.cjs

@@ -1,20 +0,0 @@
-// only add rules pertaining to styled-components
-
-module.exports = {
-  rules: {
-    // unfortunately this causes false positives
-    'block-no-empty': null,
-    // in css-in-js when variables are being passed around, this rule
-    // often leads to less readable code, even though it is more compact
-    'declaration-block-no-redundant-longhand-properties': null,
-    // this appears to conflict with styled-components keyframes method
-    'keyframes-name-pattern': null,
-    // without this pretty much every file will throw an error¯\_(ツ)_/¯
-    'no-empty-source': null,
-    // disallow property values that are ignored due to another property value in the same rule
-    'plugin/declaration-block-no-ignored-properties': true,
-    // prevent snake case from being used for class/id selectors but be otherwise flexible
-    'selector-class-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
-    'selector-id-pattern': '^[a-zA-Z0-9-]+(-[a-zA-Z0-9]+)*$',
-  },
-};