@wistia/eslint-config 0.40.2 → 0.41.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.40.2",
+  "version": "0.41.0",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.8.1",
   "main": "react.js",
@@ -14,7 +14,6 @@
     "./cypress": "./configs/eslint/cypress.cjs",
     "./functional-programming": "./configs/eslint/functional-programming.cjs",
     "./jest": "./configs/eslint/jest.cjs",
-    "./jsdoc": "./configs/eslint/jsdoc.cjs",
     "./node": "./configs/eslint/node.cjs",
     "./prettier": "./configs/eslint/prettier.cjs",
     "./react": "./configs/eslint/react.cjs",
@@ -72,7 +71,6 @@
     "eslint-plugin-jest": "^28.11.0",
     "eslint-plugin-jest-dom": "^5.5.0",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsdoc": "^50.6.9",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-n": "^17.17.0",
     "eslint-plugin-no-only-tests": "^3.3.0",

package/rules/eslint/best-practices.cjs

@@ -319,17 +319,19 @@ module.exports = {
     // https://eslint.org/docs/rules/no-restricted-globals
     'no-restricted-globals': [
       'error',
+      ...confusingBrowserGlobals.map((name) => ({
+        name,
+        message: `'${name}' should be written as 'window.${name}' or 'document.${name}' instead.`,
+      })),
       {
         name: 'isFinite',
-        message:
-          'Use Number.isFinite instead https://github.com/airbnb/javascript#standard-library--isfinite',
+        message: 'Use Number.isFinite instead...',
       },
       {
         name: 'isNaN',
-        message:
-          'Use Number.isNaN instead https://github.com/airbnb/javascript#standard-library--isnan',
+        message: 'Use Number.isNaN instead...',
       },
-    ].concat(confusingBrowserGlobals),
+    ],
 
     // disallow specific imports
     // https://eslint.org/docs/rules/no-restricted-imports

package/rules/eslint/testing-library.cjs

@@ -125,7 +125,8 @@ module.exports = {
 
     // Suggest using implicit assertions for getBy* & findBy* queries
     // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-implicit-assert.md
-    'testing-library/prefer-implicit-assert': 'error',
+    // decision: this is an alternative to `prefer-explicit-assert` and both cannot be used together
+    'testing-library/prefer-implicit-assert': 'off',
 
     // Prefer toBeChecked over checking attributes
     // https://github.com/testing-library/eslint-plugin-jest-dom/blob/main/docs/rules/prefer-checked.md

package/configs/eslint/jsdoc.cjs

@@ -1,9 +0,0 @@
-require('@rushstack/eslint-patch/modern-module-resolution');
-
-module.exports = {
-  env: {
-    node: true,
-  },
-
-  extends: ['../../rules/eslint/jsdoc.cjs'].map(require.resolve),
-};

package/rules/eslint/jsdoc.cjs

@@ -1,56 +0,0 @@
-// only add jsdocs rules
-// see: https://github.com/gajus/eslint-plugin-jsdoc#rules
-
-module.exports = {
-  plugins: ['eslint-plugin-jsdoc'],
-
-  rules: {
-    'jsdoc/check-access': 'error',
-    'jsdoc/check-alignment': 'error',
-    'jsdoc/check-examples': 'error',
-    'jsdoc/check-indentation': 'error',
-    'jsdoc/check-line-alignment': 'error',
-    'jsdoc/check-param-names': 'error',
-    'jsdoc/check-property-names': 'error',
-    'jsdoc/check-syntax': 'error',
-    'jsdoc/check-tag-names': 'error',
-    'jsdoc/check-types': 'error',
-    'jsdoc/check-values': 'error',
-    'jsdoc/empty-tags': 'error',
-    'jsdoc/implements-on-classes': 'error',
-    'jsdoc/match-description': 'error',
-    'jsdoc/multiline-blocks': 'error',
-    'jsdoc/newline-after-description': 'error',
-    'jsdoc/no-bad-blocks': 'error',
-    'jsdoc/no-defaults': 'error',
-    'jsdoc/no-missing-syntax': 'error',
-    'jsdoc/no-multi-asterisks': 'error',
-    'jsdoc/no-restricted-syntax': 'error',
-    'jsdoc/no-types': 'error',
-    'jsdoc/no-undefined-types': 'error',
-    'jsdoc/require-asterisk-prefix': 'error',
-    'jsdoc/require-description': 'error',
-    'jsdoc/require-description-complete-sentence': 'error',
-    'jsdoc/require-example': 'error',
-    'jsdoc/require-file-overview': 'error',
-    'jsdoc/require-hyphen-before-param-description': 'error',
-    'jsdoc/require-jsdoc': 'error',
-    'jsdoc/require-param': 'error',
-    'jsdoc/require-param-description': 'error',
-    'jsdoc/require-param-name': 'error',
-    'jsdoc/require-param-type': 'error',
-    'jsdoc/require-property': 'error',
-    'jsdoc/require-property-description': 'error',
-    'jsdoc/require-property-name': 'error',
-    'jsdoc/require-property-type': 'error',
-    'jsdoc/require-returns': 'error',
-    'jsdoc/require-returns-check': 'error',
-    'jsdoc/require-returns-description': 'error',
-    'jsdoc/require-returns-type': 'error',
-    'jsdoc/require-throws': 'error',
-    'jsdoc/require-yields': 'error',
-    'jsdoc/require-yields-check': 'error',
-    'jsdoc/tag-lines': 'error',
-    'jsdoc/valid-types': 'error',
-  },
-};