@wistia/eslint-config 0.40.0 → 0.40.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.40.0",
+  "version": "0.40.2",
   "description": "Wistia's ESLint configurations",
   "packageManager": "yarn@4.8.1",
   "main": "react.js",
@@ -35,7 +35,7 @@
     "lint": "ESLINT_USE_FLAT_CONFIG=true eslint --config eslint.config.mjs .",
     "lint:debug": "ESLINT_USE_FLAT_CONFIG=true eslint --config eslint.config.mjs --print-config eslint.config.mjs",
     "outdated": "yarn upgrade-interactive",
-    "prepare": "husky install",
+    "prepare": "husky",
     "release": "changeset publish",
     "test": "vitest run",
     "test:export": "check-export-map",

package/rules/eslint/react-a11y.cjs

@@ -247,13 +247,17 @@ module.exports = {
     // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/tabindex-no-positive.md
     'jsx-a11y/tabindex-no-positive': 'error',
 
-    // ----------------------------------------------------
-    // Rules that no longer exist in eslint-plugin-jsx-a11y
-    // ----------------------------------------------------
-
-    // require that JSX labels use "htmlFor"
-    // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
-    // deprecated: replaced by `label-has-associated-control` rule
-    'jsx-a11y/label-has-for': 'off',
+    // Enforce <a> text to not exactly match "click here", "here", "link", or "a link"
+    // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/anchor-ambiguous-text.md
+    'jsx-a11y/anchor-ambiguous-text': 'error',
+
+    // Disallow aria-hidden="true" from being set on focusable elements
+    // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/no-aria-hidden-on-focusable.md
+    'jsx-a11y/no-aria-hidden-on-focusable': 'error',
+
+    // Enforces using semantic DOM elements over the ARIA role property
+    // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/prefer-tag-over-role.md
+    // decision: best left to the implementer to decide on this
+    'jsx-a11y/prefer-tag-over-role': 'off',
   },
 };

package/rules/eslint/react.cjs

@@ -20,22 +20,22 @@ module.exports = {
       'error',
       {
         exceptMethods: [
-          'render',
-          'getInitialState',
-          'getDefaultProps',
-          'getChildContext',
-          'componentWillMount',
           'UNSAFE_componentWillMount',
-          'componentDidMount',
-          'componentWillReceiveProps',
           'UNSAFE_componentWillReceiveProps',
-          'shouldComponentUpdate',
-          'componentWillUpdate',
           'UNSAFE_componentWillUpdate',
+          'componentDidCatch',
+          'componentDidMount',
           'componentDidUpdate',
+          'componentWillMount',
+          'componentWillReceiveProps',
           'componentWillUnmount',
-          'componentDidCatch',
+          'componentWillUpdate',
+          'getChildContext',
+          'getDefaultProps',
+          'getInitialState',
           'getSnapshotBeforeUpdate',
+          'render',
+          'shouldComponentUpdate',
         ],
       },
     ],
@@ -628,7 +628,7 @@ module.exports = {
 
     // Enforce using `onChange` or `readonly` attribute when `checked` is used
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/checked-requires-onchange-or-readonly.md
-    // 'react/checked-requires-onchange-or-readonly': 'error',
+    'react/checked-requires-onchange-or-readonly': 'error',
 
     // Disallow usage of referential-type variables as default param in functional component
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-object-type-as-default-prop.md
@@ -638,6 +638,14 @@ module.exports = {
     // This rule is deprecated. It was replaced by `react/sort-default-props`
     // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-sort-default-props.md
     'react/jsx-sort-default-props': 'off',
+
+    // Require all forwardRef components include a ref parameter
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/forward-ref-uses-ref.md
+    'react/forward-ref-uses-ref': 'error',
+
+    // Disallow JSX prop spreading the same identifier multiple times
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spread-multi.md
+    'react/jsx-props-no-spread-multi': 'error',
   },
 
   settings: {

package/rules/eslint/testing-library.cjs

@@ -123,6 +123,10 @@ module.exports = {
     // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/render-result-naming-convention.md
     'testing-library/render-result-naming-convention': 'error',
 
+    // Suggest using implicit assertions for getBy* & findBy* queries
+    // https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/prefer-implicit-assert.md
+    'testing-library/prefer-implicit-assert': 'error',
+
     // Prefer toBeChecked over checking attributes
     // https://github.com/testing-library/eslint-plugin-jest-dom/blob/main/docs/rules/prefer-checked.md
     'jest-dom/prefer-checked': 'error',