@wistia/eslint-config 0.20.0 → 0.21.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.20.0",
+  "version": "0.21.0",
   "description": "Wistia's ESLint configurations",
   "main": "react.js",
   "exports": {
@@ -30,25 +30,25 @@
     "test:stylelint": "stylelint --print-config ./test/index.js"
   },
   "dependencies": {
-    "@babel/core": "^7.21.4",
-    "@babel/eslint-parser": "^7.21.3",
-    "@babel/preset-react": "^7.18.6",
-    "@rushstack/eslint-patch": "^1.2.0",
-    "@testing-library/dom": "^9.3.0",
-    "@typescript-eslint/eslint-plugin": "^5.58.0",
-    "@typescript-eslint/parser": "^5.58.0",
+    "@babel/core": "^7.22.9",
+    "@babel/eslint-parser": "^7.22.9",
+    "@babel/preset-react": "^7.22.5",
+    "@rushstack/eslint-patch": "^1.3.2",
+    "@testing-library/dom": "^9.3.1",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser": "^6.0.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint": "^8.41.0",
+    "eslint": "^8.45.0",
     "eslint-config-prettier": "^8.8.0",
     "eslint-import-resolver-typescript": "^3.5.5",
     "eslint-plugin-better-styled-components": "^1.1.2",
-    "eslint-plugin-cypress": "^2.13.2",
+    "eslint-plugin-cypress": "^2.13.3",
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import": "^2.27.5",
-    "eslint-plugin-jest": "^27.2.1",
+    "eslint-plugin-jest": "^27.2.3",
     "eslint-plugin-jest-dom": "^5.0.1",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsdoc": "^46.2.0",
+    "eslint-plugin-jsdoc": "^46.4.4",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-no-only-tests": "^3.1.0",
     "eslint-plugin-no-snapshot-testing": "^1.0.61",
@@ -58,27 +58,27 @@
     "eslint-plugin-react": "^7.32.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-sonarjs": "^0.19.0",
-    "eslint-plugin-storybook": "^0.6.11",
-    "eslint-plugin-styled-components-a11y": "^2.0.0",
-    "eslint-plugin-testing-library": "^5.10.2",
-    "postcss": "^8.4.21",
+    "eslint-plugin-storybook": "^0.6.12",
+    "eslint-plugin-styled-components-a11y": "^2.1.3",
+    "eslint-plugin-testing-library": "^5.11.0",
+    "postcss": "^8.4.26",
     "postcss-scss": "^4.0.6",
     "postcss-styled-syntax": "^0.4.0",
     "prettier": "^3.0.0",
-    "stylelint": "^15.4.0",
+    "stylelint": "^15.10.1",
     "stylelint-config-prettier": "^9.0.5",
     "stylelint-declaration-block-no-ignored-properties": "^2.7.0",
     "stylelint-prettier": "^4.0.0",
-    "stylelint-scss": "^5.0.0"
+    "stylelint-scss": "^5.0.1"
   },
   "devDependencies": {
-    "@commitlint/cli": "^17.5.1",
-    "@commitlint/config-conventional": "^17.4.4",
+    "@commitlint/cli": "^17.6.6",
+    "@commitlint/config-conventional": "^17.6.6",
     "check-export-map": "^1.3.0",
     "husky": "^8.0.3",
-    "jest": "^29.5.0",
+    "jest": "^29.6.1",
     "jest-specific-snapshot": "^8.0.0",
-    "typescript": "^5.0.4"
+    "typescript": "^5.1.6"
   },
   "engines": {
     "node": "^12.22.0 || ^14.17.0 || >=16.0.0"

package/rules/eslint/typescript.js

@@ -8,6 +8,9 @@ module.exports = {
     // the following rules are deliberately disabled (as they may be inherited from other rulesets (eg. best-practices.js)) because
     // they have equivalent rules below that are considered "extension rules" by @typescript-eslint
 
+    // prefer @typescript-eslint/block-spacing
+    'block-spacing': 'off',
+
     // prefer @typescript-eslint/default-param-last
     'default-param-last': 'off',
 
@@ -17,6 +20,12 @@ module.exports = {
     // prefer @typescript-eslint/init-declarations
     'init-declarations': 'off',
 
+    // prefer @typescript-eslint/key-spacing
+    'key-spacing': 'off',
+
+    // prefer @typescript-eslint/lines-around-comment
+    'lines-around-comment': 'off',
+
     // prefer @typescript-eslint/no-array-constructor
     'no-array-constructor': 'off',
 
@@ -219,10 +228,6 @@ module.exports = {
     // https://typescript-eslint.io/rules/no-for-in-array
     '@typescript-eslint/no-for-in-array': 'error',
 
-    // Disallow usage of the implicit <code>any</code> type in catch clauses
-    // https://typescript-eslint.io/rules/no-implicit-any-catch
-    '@typescript-eslint/no-implicit-any-catch': 'error',
-
     // Disallow explicit type declarations for variables or parameters initialized to a number, string, or boolean
     // https://typescript-eslint.io/rules/no-inferrable-types
     '@typescript-eslint/no-inferrable-types': 'error',
@@ -259,10 +264,6 @@ module.exports = {
     // https://typescript-eslint.io/rules/no-non-null-assertion
     '@typescript-eslint/no-non-null-assertion': 'error',
 
-    // Disallow the use of parameter properties in class constructors
-    // https://typescript-eslint.io/rules/no-parameter-properties
-    '@typescript-eslint/no-parameter-properties': 'error',
-
     // Disallow members of unions and intersections that do nothing or override type information
     // https://typescript-eslint.io/rules/no-redundant-type-constituents
     '@typescript-eslint/no-redundant-type-constituents': 'error',
@@ -421,10 +422,6 @@ module.exports = {
     // https://typescript-eslint.io/rules/restrict-template-expressions
     '@typescript-eslint/restrict-template-expressions': 'error',
 
-    // Enforce members of a type union/intersection to be sorted alphabetically
-    // https://typescript-eslint.io/rules/sort-type-union-intersection-members
-    '@typescript-eslint/sort-type-union-intersection-members': 'error',
-
     // Disallow certain types in boolean expressions
     // https://typescript-eslint.io/rules/strict-boolean-expressions
     '@typescript-eslint/strict-boolean-expressions': [
@@ -511,10 +508,6 @@ module.exports = {
     // https://typescript-eslint.io/rules/no-dupe-class-members
     '@typescript-eslint/no-dupe-class-members': 'error',
 
-    // Disallow duplicate imports
-    // https://typescript-eslint.io/rules/no-duplicate-imports
-    '@typescript-eslint/no-duplicate-imports': 'error',
-
     // Disallow empty functions
     // https://typescript-eslint.io/rules/no-empty-function
     '@typescript-eslint/no-empty-function': 'error',
@@ -633,5 +626,41 @@ module.exports = {
     // Require spacing around infix operators
     // https://typescript-eslint.io/rules/space-infix-ops
     '@typescript-eslint/space-infix-ops': 'off',
+
+    // Disallow duplicate constituents of union or intersection types
+    // https://typescript-eslint.io/rules/no-duplicate-type-constituents/
+    '@typescript-eslint/no-duplicate-type-constituents': 'error',
+
+    // Enforce the use of top-level import type qualifier when an import only has specifiers with inline type qualifiers
+    // https://typescript-eslint.io/rules/no-import-type-side-effects/
+    '@typescript-eslint/no-import-type-side-effects': 'error',
+
+    // Disallow enums from having both number and string members
+    // https://typescript-eslint.io/rules/no-mixed-enums/
+    '@typescript-eslint/no-mixed-enums': 'error',
+
+    // Disallow unsafe declaration merging
+    // https://typescript-eslint.io/rules/no-unsafe-declaration-merging/
+    '@typescript-eslint/no-unsafe-declaration-merging': 'error',
+
+    // Disallow comparing an enum value with a non-enum value
+    // https://typescript-eslint.io/rules/no-unsafe-enum-comparison/
+    '@typescript-eslint/no-unsafe-enum-comparison': 'error',
+
+    // Enforce constituents of a type union/intersection to be sorted alphabetically
+    // https://typescript-eslint.io/rules/sort-type-constituents/
+    '@typescript-eslint/sort-type-constituents': 'error',
+
+    // Disallow or enforce spaces inside of blocks after opening block and before closing block
+    // https://typescript-eslint.io/rules/block-spacing/
+    '@typescript-eslint/block-spacing': 'error',
+
+    // Enforce consistent spacing between property names and type annotations in types and interfaces
+    // https://typescript-eslint.io/rules/key-spacing/
+    '@typescript-eslint/key-spacing': 'error',
+
+    // Require empty lines around comments
+    // https://typescript-eslint.io/rules/lines-around-comment/
+    '@typescript-eslint/lines-around-comment': 'error',
   },
 };