@wistia/eslint-config 0.17.9 → 0.17.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.17.9",
+  "version": "0.17.10",
   "description": "Wistia's ESLint configurations",
   "main": "react.js",
   "exports": {
@@ -29,24 +29,24 @@
     "test:stylelint": "stylelint --print-config ./test/index.js"
   },
   "dependencies": {
-    "@babel/core": "^7.21.0",
-    "@babel/eslint-parser": "^7.19.1",
+    "@babel/core": "^7.21.4",
+    "@babel/eslint-parser": "^7.21.3",
     "@babel/preset-react": "^7.18.6",
     "@rushstack/eslint-patch": "^1.2.0",
-    "@typescript-eslint/eslint-plugin": "^5.53.0",
-    "@typescript-eslint/parser": "^5.53.0",
+    "@typescript-eslint/eslint-plugin": "^5.58.0",
+    "@typescript-eslint/parser": "^5.58.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint": "^8.34.0",
-    "eslint-config-prettier": "^8.6.0",
-    "eslint-import-resolver-typescript": "^3.5.3",
+    "eslint": "^8.38.0",
+    "eslint-config-prettier": "^8.8.0",
+    "eslint-import-resolver-typescript": "^3.5.5",
     "eslint-plugin-better-styled-components": "^1.1.2",
-    "eslint-plugin-cypress": "^2.12.1",
+    "eslint-plugin-cypress": "^2.13.2",
     "eslint-plugin-filenames": "^1.3.2",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-jest": "^27.2.1",
     "eslint-plugin-jest-dom": "^4.0.3",
     "eslint-plugin-jest-formatting": "^3.1.0",
-    "eslint-plugin-jsdoc": "^40.0.0",
+    "eslint-plugin-jsdoc": "^41.1.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
     "eslint-plugin-no-only-tests": "^3.1.0",
     "eslint-plugin-no-snapshot-testing": "^1.0.61",
@@ -61,22 +61,22 @@
     "eslint-plugin-testing-library": "^5.10.2",
     "postcss": "^8.4.21",
     "postcss-scss": "^4.0.6",
-    "prettier": "^2.8.4",
-    "stylelint": "^15.2.0",
+    "prettier": "^2.8.7",
+    "stylelint": "^15.4.0",
     "stylelint-config-prettier": "^9.0.5",
     "stylelint-declaration-block-no-ignored-properties": "^2.7.0",
     "stylelint-prettier": "^3.0.0",
     "stylelint-processor-styled-components": "^1.10.0",
-    "stylelint-scss": "^4.4.0"
+    "stylelint-scss": "^4.6.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "^17.4.4",
+    "@commitlint/cli": "^17.5.1",
     "@commitlint/config-conventional": "^17.4.4",
     "check-export-map": "^1.3.0",
     "husky": "^8.0.3",
-    "jest": "^29.4.3",
+    "jest": "^29.5.0",
     "jest-specific-snapshot": "^8.0.0",
-    "typescript": "^5.0.0"
+    "typescript": "^5.0.4"
   },
   "engines": {
     "node": "^12.22.0 || ^14.17.0 || >=16.0.0"

package/rules/eslint/best-practices.js

@@ -281,14 +281,11 @@ module.exports = {
         ignorePropertyModificationsFor: [
           'acc', // for reduce accumulators
           'accumulator', // for reduce accumulators
-          'e', // for e.returnvalue
-          'ctx', // for Koa routing
-          'context', // for Koa routing
+          'event', // for event.returnvalue
           'req', // for Express requests
           'request', // for Express requests
           'res', // for Express responses
           'response', // for Express responses
-          '$scope', // for Angular 1 scopes
           'staticContext', // for ReactRouter context
         ],
       },
@@ -540,7 +537,15 @@ module.exports = {
 
     // disallow declaration of variables that are not used in the code
     // https://eslint.org/docs/rules/no-unused-vars
-    'no-unused-vars': ['error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true }],
+    'no-unused-vars': [
+      'error',
+      {
+        args: 'after-used',
+        varsIgnorePattern: '^_',
+        argsIgnorePattern: '^_',
+        ignoreRestSiblings: true,
+      },
+    ],
 
     // disallow use of variables before they are defined
     // https://eslint.org/docs/rules/no-use-before-define

package/rules/eslint/typescript-imports.js

@@ -16,7 +16,7 @@ module.exports = {
     // turn on errors for missing imports
     'import/no-unresolved': 'error',
 
-    //
+    // this casues fall positives in typescript
     'import/no-unused-modules': 'off',
   },
 

package/rules/eslint/typescript.js

@@ -173,7 +173,12 @@ module.exports = {
 
     // Require expressions of type void to appear in statement position
     // https://typescript-eslint.io/rules/no-confusing-void-expression
-    '@typescript-eslint/no-confusing-void-expression': 'error',
+    '@typescript-eslint/no-confusing-void-expression': [
+      'error',
+      {
+        ignoreArrowShorthand: true,
+      },
+    ],
 
     // Disallow duplicate enum member values
     // https://typescript-eslint.io/rules/no-duplicate-enum-values
@@ -398,7 +403,8 @@ module.exports = {
 
     // Require <code>Array#sort</code> calls to always provide a <code>compareFunction</code>
     // https://typescript-eslint.io/rules/require-array-sort-compare
-    '@typescript-eslint/require-array-sort-compare': 'error',
+    // decision: allow simple alpha sorts on string arrays
+    '@typescript-eslint/require-array-sort-compare': ['error', { ignoreStringArrays: true }],
 
     // Require both operands of addition to have type <code>number</code> or <code>string</code>
     // https://typescript-eslint.io/rules/restrict-plus-operands
@@ -414,7 +420,12 @@ module.exports = {
 
     // Disallow certain types in boolean expressions
     // https://typescript-eslint.io/rules/strict-boolean-expressions
-    '@typescript-eslint/strict-boolean-expressions': 'error',
+    '@typescript-eslint/strict-boolean-expressions': [
+      'error',
+      {
+        allowNullableBoolean: true,
+      },
+    ],
 
     // Require switch-case statements to be exhaustive with union type
     // https://typescript-eslint.io/rules/switch-exhaustiveness-check
@@ -530,11 +541,13 @@ module.exports = {
     '@typescript-eslint/no-magic-numbers': [
       'error',
       {
-        ignore: [0, 1, 2, 3, 4, 5, 1000],
-        ignoreEnums: false,
-        ignoreNumericLiteralTypes: false,
-        ignoreReadonlyClassProperties: false,
-        ignoreTypeIndexes: false,
+        ignore: [-1, 0, 1, 2, 3, 4, 5, 1000, 2000, 3000, 4000, 5000],
+        ignoreArrayIndexes: true,
+        ignoreDefaultValues: true,
+        ignoreTypeIndexes: true,
+        ignoreReadonlyClassProperties: true,
+        ignoreEnums: true,
+        ignoreNumericLiteralTypes: true,
       },
     ],
 
@@ -560,7 +573,15 @@ module.exports = {
 
     // Disallow unused variables
     // https://typescript-eslint.io/rules/no-unused-vars
-    '@typescript-eslint/no-unused-vars': 'error',
+    '@typescript-eslint/no-unused-vars': [
+      'error',
+      {
+        args: 'after-used',
+        varsIgnorePattern: '^_',
+        argsIgnorePattern: '^_',
+        ignoreRestSiblings: true,
+      },
+    ],
 
     // Disallow the use of variables before they are defined
     // https://typescript-eslint.io/rules/no-use-before-define