@wistia/eslint-config 0.17.11 → 0.18.0

package/configs/eslint/typescript-react.js

@@ -0,0 +1,16 @@
+require('@rushstack/eslint-patch/modern-module-resolution');
+
+module.exports = {
+  parser: '@typescript-eslint/parser',
+
+  parserOptions: {
+    sourceType: 'module',
+    project: './tsconfig.json',
+  },
+
+  env: {
+    es2022: true,
+  },
+
+  extends: ['../../rules/eslint/react', '../../rules/eslint/typescript-react'].map(require.resolve),
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wistia/eslint-config",
-  "version": "0.17.11",
+  "version": "0.18.0",
   "description": "Wistia's ESLint configurations",
   "main": "react.js",
   "exports": {
@@ -19,7 +19,8 @@
     "./stylelint/scss": "./configs/stylelint/scss.js",
     "./stylelint/styled-components": "./configs/stylelint/styled-components.js",
     "./testing-library": "./configs/eslint/testing-library.js",
-    "./typescript": "./configs/eslint/typescript.js"
+    "./typescript": "./configs/eslint/typescript.js",
+    "./typescript-react": "./configs/eslint/typescript-react.js"
   },
   "scripts": {
     "lint": "eslint --fix .",

package/rules/eslint/typescript-react.js

@@ -0,0 +1,18 @@
+// only add typescript rules that concern react development
+
+module.exports = {
+  plugins: ['@typescript-eslint'],
+
+  rules: {
+    // Enforce a defaultProps definition for every prop that is not a required prop
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/require-default-props.md
+    // decision: default prop types shouldn't be necessary for optional parameters as they can just default to undefined
+    'react/require-default-props': 'off',
+
+    // Disallow JSX props spreading
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md
+    // decision: because we have type safety in TypeScript, this rule isn't necessary as we will see
+    // TS errors for prop spreading against mismatched (prop)type declarations
+    'react/jsx-props-no-spreading': 'off',
+  },
+};

package/rules/eslint/typescript.js

@@ -211,7 +211,7 @@ module.exports = {
 
     // Require Promise-like statements to be handled appropriately
     // https://typescript-eslint.io/rules/no-floating-promises
-    '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
+    '@typescript-eslint/no-floating-promises': 'error',
 
     // Disallow iterating over an array with a for-in loop
     // https://typescript-eslint.io/rules/no-for-in-array
@@ -546,7 +546,7 @@ module.exports = {
     '@typescript-eslint/no-magic-numbers': [
       'error',
       {
-        ignore: [-1, 0, 1, 2, 3, 4, 5, 1000, 2000, 3000, 4000, 5000],
+        ignore: [-1, 0, 1, 2, 3, 4, 5, 100, 1000, 2000, 3000, 4000, 5000],
         ignoreArrayIndexes: true,
         ignoreDefaultValues: true,
         ignoreTypeIndexes: true,