@wisdoverse/dsh-inline-media-viewer 1.0.3 → 1.0.6

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 1.0.6
+
+- Resolve workspace media from persisted session metadata when a historical
+  conversation is no longer attached to a live host session.
+
+## 1.0.5
+
+- Register the browser bundle under the scoped package name expected by the
+  DSH module loader.
+
+## 1.0.4
+
+- Read media candidates from the standard assistant-step projection so the
+  first inline preview renders reliably.
+- Avoid extracting duplicate paths from Markdown links, code spans, and URLs.
+
 ## 1.0.3
 
 - Clarify and enforce the transport split: workspace files use the DSH host,

package/client/client.js

@@ -1,5 +1,5 @@
 window.__ModuleLoader__.load({
-  id: "dsh-inline-media-viewer",
+  id: "@wisdoverse/dsh-inline-media-viewer",
   factory: (require) => {
     var module = { exports: {} };
     var exports = module.exports;
@@ -9,7 +9,6 @@ window.__ModuleLoader__.load({
     const { createElement: h, useEffect, useMemo, useState } = React;
     const CHANNEL = "/inline-media";
     const ENDPOINT = "read";
-    const DATA_KEY = "inlineMedia";
     const DISPLAY_CAP = 12;
     const SETTINGS_NAMESPACE = "inline-media";
     // Empty config = the host-side built-in default
@@ -88,79 +87,48 @@ window.__ModuleLoader__.load({
         found.push({ source, kind });
       };
 
-      for (const match of text.matchAll(/!?\[[^\]]*\]\(([^)]+)\)/g)) add(match[1]);
-      for (const match of text.matchAll(/`([^`\n]+)`/g)) add(match[1]);
-      for (const match of text.matchAll(/https?:\/\/[^\s<>"'`]+/gi)) add(match[0]);
+      let plain = text.replace(/!?\[[^\]]*\]\(([^)]+)\)/g, (match, source) => {
+        add(source);
+        return " ".repeat(match.length);
+      });
+      plain = plain.replace(/`([^`\n]+)`/g, (match, source) => {
+        add(source);
+        return " ".repeat(match.length);
+      });
+      plain = plain.replace(/https?:\/\/[^\s<>"'`]+/gi, (source) => {
+        add(source);
+        return " ".repeat(source.length);
+      });
 
       const ext = Array.from(MEDIA_EXTENSIONS).join("|");
       const pathPattern = new RegExp(
         String.raw`(?:\/|\.\.?\/|[\w.-]+\/)[^\s<>"'\x60()\[\]{}]+?\.(?:${ext})(?:\?[^\s<>"'\x60]*)?`,
         "gi",
       );
-      for (const match of text.matchAll(pathPattern)) add(match[0]);
+      for (const match of plain.matchAll(pathPattern)) add(match[0]);
       return found;
     }
 
-    function assistantText(event) {
-      if (event.type !== "assistant/message") return "";
-      const content = event.data && event.data.message && event.data.message.content;
-      if (!Array.isArray(content)) return "";
-      return content
-        .filter((block) => block && block.type === "text" && typeof block.text === "string")
-        .map((block) => block.text)
-        .join("\n");
-    }
-
-    const mediaDefinition = {
-      kind: DATA_KEY,
-      match(event) {
-        if (event.type === "turn/start") {
-          return { id: String(event.data.turn), role: "start" };
-        }
-        if (event.type === "assistant/message" && Number.isInteger(event.data && event.data.turn)) {
-          return { id: String(event.data.turn), role: "update" };
-        }
-        return null;
-      },
-      start(_context, match) {
-        return { turn: match.event.data.turn, candidates: [] };
-      },
-      update(context, match) {
-        const additions = extractCandidates(assistantText(match.event)).map((candidate) => ({
-          ...candidate,
-          seq: match.event.seq,
-        }));
-        if (additions.length === 0) return context.state;
-        const seen = new Set(context.state.candidates.map((candidate) => candidate.source));
-        const fresh = additions.filter((candidate) => {
-          if (seen.has(candidate.source)) return false;
-          seen.add(candidate.source);
-          return true;
-        });
-        if (fresh.length === 0) return context.state;
-        return {
-          ...context.state,
-          candidates: [...context.state.candidates, ...fresh].slice(0, DISPLAY_CAP),
-        };
-      },
-      buildLocationData(context, scope) {
-        if (scope !== "turn" || context.state === undefined) return null;
-        return {
-          kind: "turn",
-          turn: context.state.turn,
-          key: DATA_KEY,
-          value: { candidates: context.state.candidates },
-        };
-      },
-    };
-
     function selectMedia(owner) {
       const settings = readSettings();
       if (!settings.autoRender) return null;
-      const data = owner.turn.data.get(DATA_KEY);
-      if (!data || !Array.isArray(data.candidates)) return null;
-      const candidates = data.candidates.filter((candidate) => candidate.seq <= owner.seq);
-      return candidates.length === 0 ? null : candidates.slice(0, settings.displayCap);
+      const candidates = [];
+      const seen = new Set();
+      for (const step of owner.turn.steps) {
+        const assistant = step.data.get("assistant-step");
+        if (!assistant || !assistant.finalNode || assistant.finalNode.seq > owner.seq || !Array.isArray(assistant.blocks)) continue;
+        const text = assistant.blocks
+          .filter((block) => block && block.kind === "text" && typeof block.text === "string")
+          .map((block) => block.text)
+          .join("\n");
+        for (const candidate of extractCandidates(text)) {
+          if (seen.has(candidate.source)) continue;
+          seen.add(candidate.source);
+          candidates.push(candidate);
+          if (candidates.length === settings.displayCap) return candidates;
+        }
+      }
+      return candidates.length === 0 ? null : candidates;
     }
 
     function normalizeComfyOrigin(input) {
@@ -528,7 +496,7 @@ window.__ModuleLoader__.load({
     }
 
     const name = "dsh-inline-media-viewer";
-    const inject = ["slots", "conversationEvents", "connection", "settingsScope", "locale"];
+    const inject = ["slots", "connection", "settingsScope", "locale"];
 
     function apply(ctx) {
       const connection = ctx.get("connection");
@@ -536,7 +504,6 @@ window.__ModuleLoader__.load({
       const t = ctx.locale.bind(SETTINGS_NS);
       const scope = ctx.settingsScope.bind({ namespace: SETTINGS_NAMESPACE });
       settingsScope = scope;
-      ctx.conversationEvents.register(mediaDefinition);
       ctx.slots.inject("conversation.chat.turnTail", () => ctx.slots.register({
         name: "conversation.chat.turnTail",
         select: selectMedia,
@@ -555,7 +522,7 @@ window.__ModuleLoader__.load({
     exports.apply = apply;
     exports.inject = inject;
     exports.name = name;
-    exports.testing = Object.freeze({ mediaTransport });
+    exports.testing = Object.freeze({ extractCandidates, mediaTransport, selectMedia });
     return module.exports;
   },
 });

package/index.js

@@ -22,12 +22,12 @@ import { isAbsolute, resolve } from "node:path";
 import z from "@deepseek-ai/schemastery";
 import { installSettingsSection, settingsNamespace } from "@deepseek-ai/dsh-settings";
 
-import { COMFY_DEFAULT_ORIGIN, MAX_BYTES, comfyUrl, isInside, mimeOf, normalizeComfyOrigin, testing } from "./lib.js";
+import { COMFY_DEFAULT_ORIGIN, MAX_BYTES, comfyUrl, isInside, mimeOf, normalizeComfyOrigin, resolveSessionCwd, testing } from "./lib.js";
 
 export { testing } from "./lib.js";
 
 export const name = "dsh-inline-media-viewer";
-export const inject = ["connection", "sessions", "settings"];
+export const inject = ["connection", "sessions", "sessionQuery", "settings"];
 
 const CHANNEL = "/inline-media";
 const ENDPOINT = "read";
@@ -119,8 +119,7 @@ async function readRemote(source, signal, settingsValue) {
 }
 
 async function readLocal(ctx, source, sessionId) {
-  const session = ctx.sessions.get(sessionId);
-  const cwd = session?.header?.cwd;
+  const cwd = await resolveSessionCwd(ctx.sessions, ctx.sessionQuery, sessionId);
   if (!cwd) throw new Error("session working directory is unavailable");
   const mime = mimeOf(source);
   if (!mime) throw new Error("unsupported media extension");

package/lib.js

@@ -1,5 +1,5 @@
 /**
- * dsh-inline-media-viewer — pure helpers.
+ * dsh-inline-media-viewer — dependency-free helpers.
  *
  * This module has NO runtime dependencies: unit tests and reviewers can import
  * it anywhere. Integration concerns (RPC channel, settings registration) live
@@ -79,6 +79,11 @@ export function isInside(root, target) {
   return rel === "" || (!isAbsolute(rel) && rel !== ".." && !rel.startsWith(`..${sep}`));
 }
 
+export async function resolveSessionCwd(sessions, sessionQuery, sessionId) {
+  const live = sessions.get(sessionId);
+  return live ? live.header.cwd : (await sessionQuery.readSession(sessionId)).session.cwd;
+}
+
 /**
  * Parse a user-configured ComfyUI address into a canonical origin URL.
  *
@@ -175,4 +180,5 @@ export const testing = Object.freeze({
   isInside,
   mimeOf,
   normalizeComfyOrigin,
+  resolveSessionCwd,
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wisdoverse/dsh-inline-media-viewer",
-  "version": "1.0.3",
+  "version": "1.0.6",
   "description": "Persistent inline image, video, and audio previews for DeepSeek Harness Web conversations, with workspace-confined local reads and an optional ComfyUI proxy.",
   "repository": {
     "type": "git",