@wisdoverse/dsh-inline-media-viewer 1.0.1 → 1.0.3

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 1.0.3
+
+- Clarify and enforce the transport split: workspace files use the DSH host,
+  regular HTTP(S) media loads directly, and only recognized ComfyUI URLs use
+  the optional proxy.
+- Mark ComfyUI as optional throughout the bilingual settings UI and README.
+
+## 1.0.2
+
+- Make the settings navigation and all setting copy react live to DSH's
+  English/Chinese UI language through the standard locale slot contract.
+- Add a dependency-free client registration test for both locale dictionaries
+  and the settings locale namespace.
+
 ## 1.0.1
 
 - Publish the plugin as `@wisdoverse/dsh-inline-media-viewer` for one-command
@@ -8,22 +22,22 @@
   documentation with the scoped package name.
 
 ## 1.0.0
-
-- **Initial public release.** Inline image/video/audio previews in the
-  conversation tail (`conversation.chat.turnTail` projection): any media
-  path or media URL mentioned in a chat turn renders inline under that
-  turn.
-- **Workspace-confined local reads** — a path renders only when it
-  resolves inside the calling session's workspace root (`realpath` +
-  containment; no symlink escapes).
-- **Configurable ComfyUI proxy** — media URLs on the local aliases
-  (`127.0.0.1`/`localhost` on port 8188) or on the configured server
-  address are fetched server-side from the configured origin, with
-  redirects refused, a 20 s timeout, and a 48 MiB cap.
-- **Settings page** (媒体预览 / Media preview): auto-render toggle,
-  per-turn cap (1–30), max media height (160–1200 px), ComfyUI server
-  address — persisted through the DSH settings document (loopback
-  writes).
-- **Pure helpers** in a dependency-free `lib.js` with a zero-dependency
-  unit test runner (`node test.mjs`), plus README, SECURITY, and MIT
+
+- **Initial public release.** Inline image/video/audio previews in the
+  conversation tail (`conversation.chat.turnTail` projection): any media
+  path or media URL mentioned in a chat turn renders inline under that
+  turn.
+- **Workspace-confined local reads** — a path renders only when it
+  resolves inside the calling session's workspace root (`realpath` +
+  containment; no symlink escapes).
+- **Configurable ComfyUI proxy** — media URLs on the local aliases
+  (`127.0.0.1`/`localhost` on port 8188) or on the configured server
+  address are fetched server-side from the configured origin, with
+  redirects refused, a 20 s timeout, and a 48 MiB cap.
+- **Settings page** (媒体预览 / Media preview): auto-render toggle,
+  per-turn cap (1–30), max media height (160–1200 px), ComfyUI server
+  address — persisted through the DSH settings document (loopback
+  writes).
+- **Pure helpers** in a dependency-free `lib.js` with a zero-dependency
+  unit test runner (`node test.mjs`), plus README, SECURITY, and MIT
   LICENSE.

package/LICENSE

@@ -1,21 +1,21 @@
-MIT License
-
-Copyright (c) 2025 Wisdoverse
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2025 Wisdoverse
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -8,7 +8,7 @@
   <a href="CHANGELOG.md"><img alt="Latest tag" src="https://img.shields.io/github/v/tag/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square&amp;label=version"></a>
   <a href="LICENSE"><img alt="License" src="https://img.shields.io/github/license/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square"></a>
   <a href="package.json"><img alt="Top language" src="https://img.shields.io/github/languages/top/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square"></a>
-  <a href="#configuration"><img alt="ComfyUI support" src="https://img.shields.io/badge/ComfyUI-supported-ff6f00?style=flat-square"></a>
+  <a href="#configuration"><img alt="Optional ComfyUI" src="https://img.shields.io/badge/ComfyUI-optional-ff6f00?style=flat-square"></a>
 </p>
 
 <p align="center">
@@ -40,9 +40,14 @@ audio/sound.mp3                    →  <audio controls>
 | --- | --- |
 | Inline rendering | Displays images, videos, and audio directly below the chat turn that mentions them. |
 | Workspace-safe reads | Resolves local paths with `realpath` and rejects traversal, out-of-workspace paths, and symlink escapes. |
-| ComfyUI proxy | Fetches recognized ComfyUI media URLs server-side from the configured origin, including for remote users and HTTPS pages. |
+| Optional ComfyUI proxy | Fetches recognized ComfyUI media URLs server-side from the configured origin, including for remote users and HTTPS pages. |
 | Bounded transfers | Limits each file or response to 48 MiB and remote requests to 20 seconds. |
-| User controls | Provides auto-render, per-turn item limit, media height, and ComfyUI origin settings. |
+| User controls | Provides auto-render, per-turn item limit, media height, and optional ComfyUI origin settings. |
+
+> [!NOTE]
+> ComfyUI is not required. Workspace files and regular HTTP(S) media URLs work
+> when ComfyUI is not installed or running; its proxy is activated only for
+> recognized ComfyUI URLs.
 
 ## Supported media
 
@@ -97,12 +102,15 @@ through [`cordis.patch.yml`](cordis.patch.yml).
 
 Open **Settings → 媒体预览 / Media preview**.
 
+The navigation label and all setting copy follow DSH's active UI language and
+switch live between English and Chinese.
+
 | Setting | Default | Allowed values |
 | --- | --- | --- |
 | Auto-render detected media | On | On / off |
 | Maximum items per turn | `12` | `1`–`30` |
 | Maximum media height | `380 px` | `160`–`1200 px` |
-| ComfyUI origin | Empty | `http(s)://host[:port]` |
+| ComfyUI origin (optional) | Empty | `http(s)://host[:port]` |
 
 Settings are stored in the DSH settings document. Writes are available only on
 loopback connections; remote browsers can read settings but cannot persist
@@ -110,6 +118,7 @@ changes.
 
 ### ComfyUI origin
 
+- Skip this setting entirely if you do not use ComfyUI.
 - Leave the field empty to use `http://127.0.0.1:8188`.
 - Accepted forms are `http://host[:port]`, `https://host[:port]`, and bare
   `host[:port]` (`http` is assumed).

package/README.zh-CN.md

@@ -8,7 +8,7 @@
   <a href="CHANGELOG.md"><img alt="最新标签" src="https://img.shields.io/github/v/tag/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square&amp;label=version"></a>
   <a href="LICENSE"><img alt="许可证" src="https://img.shields.io/github/license/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square"></a>
   <a href="package.json"><img alt="主要语言" src="https://img.shields.io/github/languages/top/Wisdoverse/dsh-inline-media-viewer-plugin?style=flat-square"></a>
-  <a href="#配置"><img alt="支持 ComfyUI" src="https://img.shields.io/badge/ComfyUI-supported-ff6f00?style=flat-square"></a>
+  <a href="#配置"><img alt="可选 ComfyUI" src="https://img.shields.io/badge/ComfyUI-optional-ff6f00?style=flat-square"></a>
 </p>
 
 <p align="center">
@@ -39,9 +39,13 @@ audio/sound.mp3                    →  <audio controls>
 | --- | --- |
 | 内联渲染 | 在提及媒体的聊天消息下方直接显示图像、视频和音频。 |
 | 工作区安全读取 | 使用 `realpath` 解析本地路径，并拒绝目录穿越、工作区外路径和符号链接逃逸。 |
-| ComfyUI 代理 | 由服务端从配置的源站获取识别到的 ComfyUI 媒体 URL，使远程用户和 HTTPS 页面也能正常查看。 |
+| 可选 ComfyUI 代理 | 由服务端从配置的源站获取识别到的 ComfyUI 媒体 URL，使远程用户和 HTTPS 页面也能正常查看。 |
 | 资源限制 | 每个文件或响应最大 48 MiB，远程请求最长 20 秒。 |
-| 用户控制 | 提供自动渲染、每条消息的媒体数量、媒体高度和 ComfyUI 源站设置。 |
+| 用户控制 | 提供自动渲染、每条消息的媒体数量、媒体高度和可选的 ComfyUI 源站设置。 |
+
+> [!NOTE]
+> ComfyUI 不是必需依赖。即使没有安装或运行 ComfyUI，工作区文件和普通 HTTP(S)
+> 媒体 URL 仍可正常使用；只有识别为 ComfyUI 的 URL 才会启用代理。
 
 ## 支持的媒体格式
 
@@ -95,17 +99,20 @@ dsh plugin --profile web add @wisdoverse/dsh-inline-media-viewer
 
 打开 **设置 → 媒体预览 / Media preview**。
 
+导航名称和全部设置文案会跟随 DSH 当前界面语言，在中文与英文之间实时切换。
+
 | 设置项 | 默认值 | 可选范围 |
 | --- | --- | --- |
 | 自动渲染检测到的媒体 | 开启 | 开启 / 关闭 |
 | 每条消息的最大媒体数量 | `12` | `1`–`30` |
 | 媒体最大高度 | `380 px` | `160`–`1200 px` |
-| ComfyUI 源站 | 留空 | `http(s)://host[:port]` |
+| ComfyUI 源站（可选） | 留空 | `http(s)://host[:port]` |
 
 设置值保存在 DSH 设置文档中。只有回环连接可以写入；远程浏览器可以读取设置，但不能持久化修改。
 
 ### ComfyUI 源站
 
+- 不使用 ComfyUI 时无需配置此项。
 - 留空时使用 `http://127.0.0.1:8188`。
 - 支持 `http://host[:port]`、`https://host[:port]` 和不带协议的
   `host[:port]`（默认使用 `http`）。

package/SECURITY.md

@@ -1,67 +1,67 @@
-# Security
-
-This plugin renders media in a user's chat. It is a **local trust helper**, not
-a security boundary: the conversation content it renders is produced by the
-same session that views it. What shipping standards demand here is that the
-plugin *cannot be turned into a wider primitive* — no arbitrary local file
-exfiltration, no arbitrary SSRF, no unbounded memory use.
-
-## Local file reads
-
-- Only the session's workspace root is readable: `realpath(cwd)` + containment
-  check (`isInside`) against the resolved target. Symlink escapes, `..`
-  traversal, and out-of-workspace paths are rejected.
-- Only known media extensions are accepted (MIME map in `lib.js`).
-- Size cap: 48 MiB per file.
-- The client must supply a valid session id; the workspace root is taken from
-  that session's header, never from client input.
-
-## Remote (ComfyUI) proxy
-
-- The fetch target is always the **configured ComfyUI origin** (default
-  `http://127.0.0.1:8188`, `comfyUrl` in the `inline-media` settings
-  namespace) — never the source host. Chat content can therefore only
-  select a path/query on a server the user configured, not an arbitrary
-  host.
-- A source URL is accepted only when its host:port is a local alias
-  (`127.0.0.1` / `localhost` on port 8188) **or** matches the configured
-  origin; everything else is rejected before any network I/O.
-- The configured address is validated to a bare `http(s)://host[:port]`
-  origin: credentials, paths, queries, hashes, and odd hostnames are
-  rejected. A non-empty invalid value fails remote reads with an explicit
-  error instead of silently retargeting; an empty value uses the built-in
-  default.
-- Settings writes are loopback-only (see below), so only the local user
-  can point the proxy at another host — a remote viewer cannot retarget it.
-- `redirect: "error"` — redirects are refused.
-- 20 s timeout, 48 MiB response cap, and the response MIME must be
-  image/video/audio.
-
-## Transport
-
-- The media channel `/inline-media/read` is registered with the DSH
-  connection service (`authority: "trusted-host"`), so it runs under the same
-  browser-trust fence and session gating as DSH's own RPC surface.
-- The client renderer never receives file system paths back — only `data:`
-  URLs — so a hostile session cannot use the channel as a file oracle for
-  paths the UI already knows.
-
-## Settings
-
-- Values are normalized client-side and validated server-side against the
-  schema (autoRender boolean; displayCap 1–30; imageMaxPx 160–1200;
-  comfyUrl string ≤ 512 chars, parsed to a bare origin at use time).
-- The settings service only writes back for **loopback** connections; remote
-  browsers are read-only, so a remote viewer cannot persist state.
-
-## Known limitations
-
-- Remote (non-loopback) browsers cannot persist settings by design (DSH
-  settings writes are loopback-only).
-- ComfyUI on a non-standard host/port: set the server address in the settings
-  page. The proxy fetches only from that configured origin, so it must be
-  reachable from the DSH host process — plain `http://` for a local install,
-  `https://` behind a TLS-terminating proxy. The loopback aliases
-  (`127.0.0.1`/`localhost` on port 8188) are always accepted as source
-  origins; editing `COMFY_HOSTS`/`COMFY_PORTS` is deliberate code surgery,
-  not a configuration surface.
+# Security
+
+This plugin renders media in a user's chat. It is a **local trust helper**, not
+a security boundary: the conversation content it renders is produced by the
+same session that views it. What shipping standards demand here is that the
+plugin *cannot be turned into a wider primitive* — no arbitrary local file
+exfiltration, no arbitrary SSRF, no unbounded memory use.
+
+## Local file reads
+
+- Only the session's workspace root is readable: `realpath(cwd)` + containment
+  check (`isInside`) against the resolved target. Symlink escapes, `..`
+  traversal, and out-of-workspace paths are rejected.
+- Only known media extensions are accepted (MIME map in `lib.js`).
+- Size cap: 48 MiB per file.
+- The client must supply a valid session id; the workspace root is taken from
+  that session's header, never from client input.
+
+## Remote (ComfyUI) proxy
+
+- The fetch target is always the **configured ComfyUI origin** (default
+  `http://127.0.0.1:8188`, `comfyUrl` in the `inline-media` settings
+  namespace) — never the source host. Chat content can therefore only
+  select a path/query on a server the user configured, not an arbitrary
+  host.
+- A source URL is accepted only when its host:port is a local alias
+  (`127.0.0.1` / `localhost` on port 8188) **or** matches the configured
+  origin; everything else is rejected before any network I/O.
+- The configured address is validated to a bare `http(s)://host[:port]`
+  origin: credentials, paths, queries, hashes, and odd hostnames are
+  rejected. A non-empty invalid value fails remote reads with an explicit
+  error instead of silently retargeting; an empty value uses the built-in
+  default.
+- Settings writes are loopback-only (see below), so only the local user
+  can point the proxy at another host — a remote viewer cannot retarget it.
+- `redirect: "error"` — redirects are refused.
+- 20 s timeout, 48 MiB response cap, and the response MIME must be
+  image/video/audio.
+
+## Transport
+
+- The media channel `/inline-media/read` is registered with the DSH
+  connection service (`authority: "trusted-host"`), so it runs under the same
+  browser-trust fence and session gating as DSH's own RPC surface.
+- The client renderer never receives file system paths back — only `data:`
+  URLs — so a hostile session cannot use the channel as a file oracle for
+  paths the UI already knows.
+
+## Settings
+
+- Values are normalized client-side and validated server-side against the
+  schema (autoRender boolean; displayCap 1–30; imageMaxPx 160–1200;
+  comfyUrl string ≤ 512 chars, parsed to a bare origin at use time).
+- The settings service only writes back for **loopback** connections; remote
+  browsers are read-only, so a remote viewer cannot persist state.
+
+## Known limitations
+
+- Remote (non-loopback) browsers cannot persist settings by design (DSH
+  settings writes are loopback-only).
+- ComfyUI on a non-standard host/port: set the server address in the settings
+  page. The proxy fetches only from that configured origin, so it must be
+  reachable from the DSH host process — plain `http://` for a local install,
+  `https://` behind a TLS-terminating proxy. The loopback aliases
+  (`127.0.0.1`/`localhost` on port 8188) are always accepted as source
+  origins; editing `COMFY_HOSTS`/`COMFY_PORTS` is deliberate code surgery,
+  not a configuration surface.