@wirecat/cli-core 0.362.0 → 0.364.0

package/dist/store/sqlite/evidence-findings.js

@@ -0,0 +1,172 @@
+import { CliError } from "@wirecat/cli-base";
+import { contextEvidenceFingerprint } from "../../context/evidence.js";
+import { findingFingerprint, findingHash } from "../../meetings/index.js";
+import { EVIDENCE_FINDINGS_KIND, validateEvidenceFindings, } from "../evidence-findings.js";
+import { contextRecordOf } from "./context-evidence.js";
+import { findingsAgent, findingsCoreOver } from "./findings-core.js";
+import { authorActor } from "./memories.js";
+import { proposalOperationsOver } from "./proposed-actions.js";
+import { write } from "./transaction.js";
+const stale = () => {
+    throw new CliError("validation_error", "evidence findings changed since they were read; stage a new batch", {
+        reason: "evidence-findings.stale",
+    });
+};
+const invalid = (message) => {
+    throw new CliError("validation_error", message);
+};
+const TEXT_BUDGET = 262144;
+export const evidenceFindingsStoreOver = (context) => {
+    const { database } = context;
+    const proposals = proposalOperationsOver(context);
+    const core = findingsCoreOver(context, EVIDENCE_FINDINGS_KIND);
+    const load = (id) => {
+        if (typeof id !== "string" || !/^[1-9]\d*$/.test(id) || !Number.isSafeInteger(Number(id)))
+            return invalid("a findings batch needs a stored ID");
+        const row = database
+            .prepare("SELECT length(CAST(payload AS BLOB)) AS bytes,length(CAST(result AS BLOB)) AS result_bytes FROM proposed_actions WHERE id=? AND account_id IS NULL AND kind=?")
+            .get(Number(id), EVIDENCE_FINDINGS_KIND);
+        if (!row)
+            throw new CliError("not_found", "the evidence findings batch is unavailable");
+        if (Number(row.bytes) > 100000 || Number(row.result_bytes) > 65536)
+            return invalid("stored findings exceed the read budget");
+        return proposals.get(id);
+    };
+    const view = (proposal) => {
+        const input = proposal.payload;
+        if (!input || !proposal.target || !["proposed", "approved"].includes(proposal.status))
+            return invalid("invalid stored findings batch");
+        return {
+            id: proposal.id,
+            project: proposal.target,
+            input: { schemaVersion: 1, key: input.key, extractor: input.extractor, findings: input.findings },
+            fingerprint: findingHash({ input, author: proposal.proposedBy.id }),
+            status: proposal.status === "proposed" ? "proposed" : "reviewed",
+            author: proposal.proposedBy,
+            decidedBy: proposal.decidedBy,
+            decidedAt: proposal.decidedAt,
+            previous: proposal.result
+                ? proposal.result.items
+                : input.findings.flatMap((finding) => {
+                    const held = core.previous(null, findingFingerprint(finding));
+                    return held ? [{ ...held, id: finding.id, reused: true }] : [];
+                }),
+            receipt: proposal.result,
+        };
+    };
+    const snapshot = (input) => {
+        let readBytes = 0;
+        return core.snapshot(input, (evidence, _finding, _project, seen) => {
+            if (seen.has(evidence.reference)) {
+                if (seen.get(evidence.reference) !== evidence.fingerprint)
+                    return stale();
+                return;
+            }
+            const record = contextRecordOf(database, evidence.reference);
+            if (!record)
+                return stale();
+            readBytes += Buffer.byteLength(record.text) + Buffer.byteLength(record.title ?? "");
+            if (readBytes > TEXT_BUDGET)
+                return invalid(`finding evidence exceeds the ${TEXT_BUDGET}-byte stored text budget`);
+            const fingerprint = contextEvidenceFingerprint(record);
+            if (fingerprint !== evidence.fingerprint)
+                return stale();
+            seen.set(evidence.reference, fingerprint);
+        });
+    };
+    const decider = (by) => {
+        if (by === undefined || by === "owner")
+            return { author: "owner", decision: { by: "owner" } };
+        const raw = by;
+        const agent = findingsAgent({
+            bot: raw.bot,
+            ...(raw.model === undefined ? {} : { model: raw.model }),
+        });
+        if (typeof raw.reason !== "string" || !raw.reason.trim() || raw.reason.length > 2000)
+            return invalid("an agent deciding for the owner gives a reason of 1–2000 characters");
+        return {
+            author: agent,
+            decision: { by: "agent", bot: agent.bot, model: agent.model ?? null, reason: raw.reason.trim() },
+        };
+    };
+    return {
+        stage: async (raw, rawAgent) => {
+            const input = validateEvidenceFindings(raw);
+            const projects = new Set(input.findings.map((finding) => finding.project));
+            if (projects.size !== 1)
+                return invalid("an evidence findings batch is about one project");
+            const by = findingsAgent(rawAgent);
+            return write(database, () => {
+                const { actor } = authorActor(context, by);
+                const inputHash = findingHash({ input, model: by.model ?? null });
+                const held = database
+                    .prepare("SELECT id FROM proposed_actions WHERE account_id IS NULL AND kind=? AND proposed_by_type=? AND proposed_by_id=? AND json_extract(payload,'$.key')=? ORDER BY id LIMIT 1")
+                    .get(EVIDENCE_FINDINGS_KIND, actor.type, actor.id, input.key);
+                if (held) {
+                    const proposal = load(String(held.id));
+                    if (proposal.payload.inputHash !== inputHash)
+                        return invalid("the findings batch key was already used for different input");
+                    return view(proposal);
+                }
+                const snapshotHash = snapshot(input);
+                const fingerprints = input.findings.map(findingFingerprint);
+                if (new Set(fingerprints).size !== fingerprints.length)
+                    return invalid("the batch contains duplicate findings");
+                return view(proposals.propose({
+                    kind: EVIDENCE_FINDINGS_KIND,
+                    by,
+                    target: [...projects][0],
+                    payload: { ...input, inputHash, snapshotHash, agentModel: by.model ?? null },
+                }));
+            });
+        },
+        get: async (id) => view(load(id)),
+        list: async ({ project, limit = 20, offset = 0, status } = {}) => {
+            if (status !== undefined && status !== "proposed" && status !== "reviewed")
+                return invalid("finding status is proposed or reviewed");
+            if (!Number.isSafeInteger(limit) || limit < 1 || limit > 50 || !Number.isSafeInteger(offset) || offset < 0)
+                return invalid("findings lists take 1–50 items and a nonnegative offset");
+            const projectId = project === undefined ? null : /^project:([1-9]\d*)$/.exec(project)?.[1];
+            if (projectId === undefined)
+                return invalid("a findings list filters by a project reference");
+            const ids = database
+                .prepare("SELECT id FROM proposed_actions WHERE account_id IS NULL AND kind=? AND (? IS NULL OR (target_type='project' AND target_id=?)) AND (? IS NULL OR status=?) ORDER BY id DESC LIMIT ? OFFSET ?")
+                .all(EVIDENCE_FINDINGS_KIND, projectId, projectId === null ? null : Number(projectId), status ?? null, status === "reviewed" ? "approved" : (status ?? null), limit + 1, offset);
+            return { items: ids.slice(0, limit).map((row) => view(load(String(row.id)))), hasMore: ids.length > limit };
+        },
+        review: async (id, decision) => write(database, () => {
+            const proposal = load(id);
+            const batch = view(proposal);
+            if (!decision || typeof decision.fingerprint !== "string" || decision.fingerprint !== batch.fingerprint)
+                return stale();
+            if (!Array.isArray(decision.accept) ||
+                decision.accept.length > 16 ||
+                new Set(decision.accept).size !== decision.accept.length ||
+                decision.accept.some((candidate) => !batch.input.findings.some((finding) => finding.id === candidate)))
+                return invalid("accept only unique IDs shown in this batch");
+            const accepted = [...decision.accept].sort();
+            const { author, decision: decidedBy } = decider(decision.by);
+            if (batch.receipt) {
+                if (JSON.stringify(batch.receipt.accepted) !== JSON.stringify(accepted))
+                    return invalid("this findings batch was already reviewed with a different decision");
+                return batch;
+            }
+            const input = proposal.payload;
+            if (snapshot(batch.input) !== input.snapshotHash)
+                return stale();
+            if (proposal.proposedBy.type !== "bot" || !proposal.proposedBy.name)
+                return invalid("a findings author must be an agent");
+            const agent = {
+                bot: proposal.proposedBy.name,
+                ...(input.agentModel === null ? {} : { model: input.agentModel }),
+            };
+            const items = core.outcomes(null, batch.input, accepted, agent);
+            return view(proposals.approve(id, {
+                previewFingerprint: batch.fingerprint,
+                accepted,
+                items,
+                decision: decidedBy,
+            }, author));
+        }),
+    };
+};

package/dist/store/sqlite/findings-core.d.ts

@@ -0,0 +1,17 @@
+import { type Finding, type FindingEvidence, type FindingOutcome, type FindingsInput } from "../../meetings/index.js";
+import type { StoreContext } from "./open.js";
+export interface FindingsAgent {
+    bot: string;
+    model?: string;
+}
+export declare const findingsAgent: (agent: FindingsAgent) => FindingsAgent;
+/**
+ * What meeting and evidence findings share: the project and assignee snapshot, earlier decisions on an unchanged
+ * candidate, creating the accepted facts and tasks, and the receipt items. Each kind checks its own evidence,
+ * including a reference it already saw for another finding.
+ */
+export declare const findingsCoreOver: (context: StoreContext, kind: string) => {
+    snapshot: (input: FindingsInput, cite: (evidence: FindingEvidence, finding: Finding, projectId: string, seen: Map<string, unknown>) => void) => string;
+    previous: (account: number | null, fingerprint: string) => FindingOutcome | undefined;
+    outcomes: (account: number | null, input: FindingsInput, accepted: string[], agent: FindingsAgent) => FindingOutcome[];
+};

package/dist/store/sqlite/findings-core.js

@@ -0,0 +1,108 @@
+import { CliError } from "@wirecat/cli-base";
+import { findingFingerprint, findingHash, } from "../../meetings/index.js";
+import { factOperationsOver } from "./facts.js";
+import { linkEvidence } from "./memories.js";
+import { requiredThing } from "./notes.js";
+import { taskRowOf } from "./things.js";
+import { workTaskOperationsOver } from "./work-tasks.js";
+const invalid = (message) => {
+    throw new CliError("validation_error", message);
+};
+export const findingsAgent = (agent) => {
+    if (!agent ||
+        typeof agent.bot !== "string" ||
+        !agent.bot.trim() ||
+        agent.bot.length > 200 ||
+        agent.bot === "owner" ||
+        (agent.model !== undefined && (typeof agent.model !== "string" || agent.model.length > 200)))
+        return invalid("findings must name an agent author independently of their payload");
+    return { bot: agent.bot, ...(agent.model === undefined ? {} : { model: agent.model }) };
+};
+/**
+ * What meeting and evidence findings share: the project and assignee snapshot, earlier decisions on an unchanged
+ * candidate, creating the accepted facts and tasks, and the receipt items. Each kind checks its own evidence,
+ * including a reference it already saw for another finding.
+ */
+export const findingsCoreOver = (context, kind) => {
+    const { database } = context;
+    const facts = factOperationsOver(context);
+    const tasks = workTaskOperationsOver(context);
+    const snapshot = (input, cite) => {
+        const seen = new Map();
+        for (const finding of input.findings) {
+            const project = requiredThing(database, finding.project, "the project");
+            if (project.type !== "project")
+                return invalid("a finding needs an owner project");
+            const projectRow = database
+                .prepare("SELECT id,key,name,description,type,scope,updated_at FROM projects WHERE id=? AND account_id IS NULL AND deleted_at IS NULL")
+                .get(project.id);
+            if (!projectRow)
+                throw new CliError("not_found", "the owner project is unavailable");
+            seen.set(finding.project, projectRow);
+            if (finding.kind === "task" && finding.assignee) {
+                const person = requiredThing(database, finding.assignee, "the assignee");
+                if (person.type !== "person")
+                    return invalid("the assignee must be a stored person");
+                const personRow = database.prepare("SELECT id,name,updated_at FROM persons WHERE id=?").get(person.id);
+                if (!personRow)
+                    throw new CliError("not_found", "the assignee is unavailable");
+                seen.set(finding.assignee, personRow);
+            }
+            for (const evidence of finding.evidence)
+                cite(evidence, finding, String(project.id), seen);
+        }
+        return findingHash([...seen].sort(([a], [b]) => a.localeCompare(b)));
+    };
+    const previous = (account, fingerprint) => {
+        const row = database
+            .prepare("SELECT substr(j.value,1,4096) AS item FROM proposed_actions p,json_each(p.result,'$.items') j WHERE p.account_id IS ? AND p.kind=? AND p.status='approved' AND json_extract(j.value,'$.fingerprint')=? ORDER BY p.id LIMIT 1")
+            .get(account, kind, fingerprint);
+        return row ? JSON.parse(String(row.item)) : undefined;
+    };
+    const create = (finding, agent) => {
+        const evidence = finding.evidence.map((item) => item.reference);
+        if (finding.kind === "fact") {
+            const fact = facts.add({
+                type: finding.type,
+                statement: finding.statement,
+                project: finding.project,
+                evidence,
+                by: agent,
+            });
+            return facts.accept(fact.ref).ref;
+        }
+        const task = tasks.create({
+            project: finding.project,
+            title: finding.title,
+            type: finding.type,
+            description: `${finding.commitment}: ${finding.reason}`,
+            ...(finding.dueAt ? { dueAt: new Date(finding.dueAt) } : {}),
+        }, agent);
+        const id = taskRowOf(database, task.id);
+        if (id === undefined)
+            throw new CliError("configuration_error", "created finding task is unavailable");
+        linkEvidence(context, { type: finding.type, id }, evidence, "agent");
+        if (finding.assignee)
+            tasks.assign(task.id, { to: finding.assignee, role: "assignee" }, agent);
+        return task.ref;
+    };
+    /** Reuses an earlier decision on an unchanged candidate; refuses to accept one that was rejected. */
+    const outcomes = (account, input, accepted, agent) => input.findings.map((finding) => {
+        const fingerprint = findingFingerprint(finding);
+        const prior = previous(account, fingerprint);
+        if (prior) {
+            if (accepted.includes(finding.id) && prior.status === "rejected")
+                return invalid("this unchanged finding was already rejected; changed evidence needs a new candidate");
+            return { ...prior, id: finding.id, reused: true };
+        }
+        const status = accepted.includes(finding.id) ? "accepted" : "rejected";
+        return {
+            id: finding.id,
+            fingerprint,
+            status,
+            reference: status === "accepted" ? create(finding, agent) : null,
+            reused: false,
+        };
+    });
+    return { snapshot, previous, outcomes };
+};

package/dist/store/sqlite/meeting-findings.js

@@ -1,12 +1,9 @@
 import { CliError } from "@wirecat/cli-base";
 import { findingHash, MEETING_FINDINGS_KIND, meetingCueFingerprint, meetingFindingFingerprint, parseMeetingReference, validateMeetingFindings, } from "../../meetings/index.js";
-import { factOperationsOver } from "./facts.js";
-import { authorActor, linkEvidence } from "./memories.js";
-import { requiredThing } from "./notes.js";
+import { findingsCoreOver } from "./findings-core.js";
+import { authorActor } from "./memories.js";
 import { proposalOperationsOver } from "./proposed-actions.js";
-import { taskRowOf } from "./things.js";
 import { write } from "./transaction.js";
-import { workTaskOperationsOver } from "./work-tasks.js";
 const stale = () => {
     throw new CliError("validation_error", "meeting findings changed since they were read; stage a new batch", {
         reason: "meeting-findings.stale",
@@ -18,8 +15,6 @@ const invalid = (message) => {
 export const meetingFindingsStoreOver = (context) => {
     const { database } = context;
     const proposals = proposalOperationsOver(context);
-    const facts = factOperationsOver(context);
-    const tasks = workTaskOperationsOver(context);
     const accountId = (key) => {
         if (!key ||
             typeof key.provider !== "string" ||
@@ -68,109 +63,56 @@ export const meetingFindingsStoreOver = (context) => {
             receipt: proposal.result,
         };
     };
+    const core = findingsCoreOver(context, MEETING_FINDINGS_KIND);
     const snapshot = (account, input) => {
         let readBytes = 0;
-        const seen = new Map();
-        for (const finding of input.findings) {
-            const project = requiredThing(database, finding.project, "the project");
-            if (project.type !== "project")
-                return invalid("a finding needs an owner project");
-            const projectRow = database
-                .prepare("SELECT id,key,name,description,type,scope,updated_at FROM projects WHERE id=? AND account_id IS NULL AND deleted_at IS NULL")
-                .get(project.id);
-            if (!projectRow)
-                throw new CliError("not_found", "the owner project is unavailable");
-            seen.set(finding.project, projectRow);
-            if (finding.kind === "task" && finding.assignee) {
-                const person = requiredThing(database, finding.assignee, "the assignee");
-                if (person.type !== "person")
-                    return invalid("the assignee must be a stored person");
-                const personRow = database.prepare("SELECT id,name,updated_at FROM persons WHERE id=?").get(person.id);
-                if (!personRow)
-                    throw new CliError("not_found", "the assignee is unavailable");
-                seen.set(finding.assignee, personRow);
-            }
-            for (const evidence of finding.evidence) {
-                const parsed = parseMeetingReference(evidence.reference);
-                if (parsed.accountId !== account)
-                    throw new CliError("not_found", "the cited cue belongs to another account");
-                const membership = database
-                    .prepare("SELECT id,updated_at,confirmed,source FROM links WHERE from_type='meeting' AND from_id=? AND to_type='project' AND to_id=? AND kind='member-of' AND anchor IS NULL AND confirmed=1")
-                    .get(parsed.meetingId, project.id);
-                if (!membership)
-                    return invalid("each cited meeting needs confirmed membership in the finding's project");
-                seen.set(`${finding.project}/${parsed.meetingId}`, membership);
-                if (seen.has(evidence.reference)) {
-                    if (seen.get(evidence.reference) !== evidence.fingerprint)
-                        return stale();
-                    continue;
-                }
-                const query = "FROM meeting_transcript_rows r JOIN meeting_transcripts t ON t.id=r.meeting_transcript_id JOIN meetings m ON m.id=t.meeting_id WHERE m.id=? AND m.account_id=? AND m.deleted_at IS NULL AND t.id=? AND t.deleted_at IS NULL AND t.superseded_at IS NULL AND r.position=?";
-                const params = [parsed.meetingId, account, parsed.transcriptId, parsed.cuePosition];
-                const budget = database
-                    .prepare(`SELECT length(CAST(r.text AS BLOB))+coalesce(length(CAST(r.speaker_name AS BLOB)),0)+coalesce(length(CAST(t.content_hash AS BLOB)),0) AS bytes ${query}`)
-                    .get(...params);
-                if (!budget)
-                    return stale();
-                readBytes += Number(budget.bytes);
-                if (!Number.isSafeInteger(readBytes) || readBytes > 65536)
-                    return invalid("finding evidence exceeds the 65536-byte stored text budget");
-                const row = database
-                    .prepare(`SELECT t.content_hash,r.start_ms,r.end_ms,r.speaker_participant_id,r.speaker_name,r.text ${query}`)
-                    .get(...params);
-                if (!row)
+        return core.snapshot(input, (evidence, finding, projectId, seen) => {
+            const parsed = parseMeetingReference(evidence.reference);
+            if (parsed.accountId !== account)
+                throw new CliError("not_found", "the cited cue belongs to another account");
+            const membership = database
+                .prepare("SELECT id,updated_at,confirmed,source FROM links WHERE from_type='meeting' AND from_id=? AND to_type='project' AND to_id=? AND kind='member-of' AND anchor IS NULL AND confirmed=1")
+                .get(parsed.meetingId, projectId);
+            if (!membership)
+                return invalid("each cited meeting needs confirmed membership in the finding's project");
+            seen.set(`${finding.project}/${parsed.meetingId}`, membership);
+            if (seen.has(evidence.reference)) {
+                if (seen.get(evidence.reference) !== evidence.fingerprint)
                     return stale();
-                const fingerprint = meetingCueFingerprint({
-                    reference: evidence.reference,
-                    transcriptId: parsed.transcriptId,
-                    contentHash: row.content_hash == null ? null : String(row.content_hash),
-                    position: parsed.cuePosition,
-                    startMs: Number(row.start_ms),
-                    endMs: Number(row.end_ms),
-                    speakerParticipantId: row.speaker_participant_id == null ? null : Number(row.speaker_participant_id),
-                    speakerName: row.speaker_name == null ? null : String(row.speaker_name),
-                    text: String(row.text),
-                });
-                if (fingerprint !== evidence.fingerprint)
-                    return stale();
-                seen.set(evidence.reference, fingerprint);
+                return;
             }
-        }
-        return findingHash([...seen].sort(([a], [b]) => a.localeCompare(b)));
-    };
-    const previous = (account, fingerprint) => {
-        const row = database
-            .prepare("SELECT substr(j.value,1,4096) AS item FROM proposed_actions p,json_each(p.result,'$.items') j WHERE p.account_id=? AND p.kind=? AND p.status='approved' AND json_extract(j.value,'$.fingerprint')=? ORDER BY p.id LIMIT 1")
-            .get(account, MEETING_FINDINGS_KIND, fingerprint);
-        return row ? JSON.parse(String(row.item)) : undefined;
-    };
-    const create = (finding, agent) => {
-        const evidence = finding.evidence.map((item) => item.reference);
-        if (finding.kind === "fact") {
-            const fact = facts.add({
-                type: finding.type,
-                statement: finding.statement,
-                project: finding.project,
-                evidence,
-                by: agent,
+            const query = "FROM meeting_transcript_rows r JOIN meeting_transcripts t ON t.id=r.meeting_transcript_id JOIN meetings m ON m.id=t.meeting_id WHERE m.id=? AND m.account_id=? AND m.deleted_at IS NULL AND t.id=? AND t.deleted_at IS NULL AND t.superseded_at IS NULL AND r.position=?";
+            const params = [parsed.meetingId, account, parsed.transcriptId, parsed.cuePosition];
+            const budget = database
+                .prepare(`SELECT length(CAST(r.text AS BLOB))+coalesce(length(CAST(r.speaker_name AS BLOB)),0)+coalesce(length(CAST(t.content_hash AS BLOB)),0) AS bytes ${query}`)
+                .get(...params);
+            if (!budget)
+                return stale();
+            readBytes += Number(budget.bytes);
+            if (!Number.isSafeInteger(readBytes) || readBytes > 65536)
+                return invalid("finding evidence exceeds the 65536-byte stored text budget");
+            const row = database
+                .prepare(`SELECT t.content_hash,r.start_ms,r.end_ms,r.speaker_participant_id,r.speaker_name,r.text ${query}`)
+                .get(...params);
+            if (!row)
+                return stale();
+            const fingerprint = meetingCueFingerprint({
+                reference: evidence.reference,
+                transcriptId: parsed.transcriptId,
+                contentHash: row.content_hash == null ? null : String(row.content_hash),
+                position: parsed.cuePosition,
+                startMs: Number(row.start_ms),
+                endMs: Number(row.end_ms),
+                speakerParticipantId: row.speaker_participant_id == null ? null : Number(row.speaker_participant_id),
+                speakerName: row.speaker_name == null ? null : String(row.speaker_name),
+                text: String(row.text),
             });
-            return facts.accept(fact.ref).ref;
-        }
-        const task = tasks.create({
-            project: finding.project,
-            title: finding.title,
-            type: finding.type,
-            description: `${finding.commitment}: ${finding.reason}`,
-            ...(finding.dueAt ? { dueAt: new Date(finding.dueAt) } : {}),
-        }, agent);
-        const id = taskRowOf(database, task.id);
-        if (id === undefined)
-            throw new CliError("configuration_error", "created finding task is unavailable");
-        linkEvidence(context, { type: finding.type, id }, evidence, "agent");
-        if (finding.assignee)
-            tasks.assign(task.id, { to: finding.assignee, role: "assignee" }, agent);
-        return task.ref;
+            if (fingerprint !== evidence.fingerprint)
+                return stale();
+            seen.set(evidence.reference, fingerprint);
+        });
     };
+    const previous = core.previous;
     return {
         stage: async (key, raw, agent) => {
             const input = validateMeetingFindings(raw);
@@ -248,23 +190,7 @@ export const meetingFindingsStoreOver = (context) => {
                 bot: proposal.proposedBy.name,
                 ...(input.agentModel === null ? {} : { model: input.agentModel }),
             };
-            const items = batch.input.findings.map((finding) => {
-                const fingerprint = meetingFindingFingerprint(finding);
-                const prior = previous(account, fingerprint);
-                if (prior) {
-                    if (accepted.includes(finding.id) && prior.status === "rejected")
-                        return invalid("this unchanged finding was already rejected; changed evidence needs a new candidate");
-                    return { ...prior, id: finding.id, reused: true };
-                }
-                const status = accepted.includes(finding.id) ? "accepted" : "rejected";
-                return {
-                    id: finding.id,
-                    fingerprint,
-                    status,
-                    reference: status === "accepted" ? create(finding, agent) : null,
-                    reused: false,
-                };
-            });
+            const items = core.outcomes(account, batch.input, accepted, agent);
             return view(proposals.approve(id, {
                 previewFingerprint: batch.fingerprint,
                 accepted,

package/dist/store/sqlite/proposed-actions.d.ts

@@ -63,8 +63,11 @@ export interface ProposedActionsStore {
     failed(id: string, error: string): Promise<ProposedAction>;
     judge(id: string, verdict: ProposedAction["verdict"]): Promise<ProposedAction>;
 }
-type ProposalOperations = {
+type ProposalOperations = Omit<{
     [K in keyof ProposedActionsStore]: ProposedActionsStore[K] extends (...args: infer A) => Promise<infer R> ? (...args: A) => R : never;
+}, "approve"> & {
+    /** `by` records an agent deciding for the owner; the public store always records the owner. */
+    approve(id: string, result?: unknown, by?: Author): ProposedAction;
 };
 export declare const proposalOperationsOver: (context: StoreContext) => ProposalOperations;
 export declare const proposedActionsStoreOver: (context: StoreContext) => ProposedActionsStore;

package/dist/store/sqlite/proposed-actions.js

@@ -1,5 +1,6 @@
 import { CliError } from "@wirecat/cli-base";
 import { MEETING_FINDINGS_KIND } from "../../meetings/index.js";
+import { EVIDENCE_FINDINGS_KIND } from "../evidence-findings.js";
 import { authorActor } from "./memories.js";
 import { requiredThing } from "./notes.js";
 import { referenceOfThing, storedThing } from "./things.js";
@@ -60,8 +61,8 @@ export const proposalOperationsOver = (context) => {
             .run(to, now(), ...values, Number(id));
         return actionOf(rowOf(id));
     });
-    const decide = (id, to, result) => {
-        const { actor } = authorActor(context, "owner");
+    const decide = (id, to, result, by = "owner") => {
+        const { actor } = authorActor(context, by);
         return move(id, ["proposed"], to, ", decided_by_type = ?, decided_by_id = ?, decided_at = ?, result = ?", [
             actor.type,
             actor.id,
@@ -109,7 +110,7 @@ export const proposalOperationsOver = (context) => {
                 .all(status ?? null, status ?? null, Math.min(Math.max(limit, 1), 500))
                 .map(actionOf);
         },
-        approve: (id, result) => decide(id, "approved", result),
+        approve: (id, result, by) => decide(id, "approved", result, by),
         reject: (id) => decide(id, "rejected"),
         executed: (id, result) => move(id, ["approved"], "executed", ", executed_at = ?, result = ?", [
             now(),
@@ -133,15 +134,22 @@ export const proposalOperationsOver = (context) => {
 export const proposedActionsStoreOver = (context) => {
     const operations = proposalOperationsOver(context);
     const generic = (id) => {
-        if (operations.get(id).kind === MEETING_FINDINGS_KIND)
+        const kind = operations.get(id).kind;
+        if (kind === MEETING_FINDINGS_KIND)
             throw new CliError("validation_error", "review meeting findings through the dedicated findings command", {
                 reason: "meeting-findings.dedicated-review",
             });
+        if (kind === EVIDENCE_FINDINGS_KIND)
+            throw new CliError("validation_error", "review evidence findings through the dedicated findings command", {
+                reason: "evidence-findings.dedicated-review",
+            });
     };
     return {
         propose: async (input) => {
             if (input.kind === MEETING_FINDINGS_KIND)
                 throw new CliError("validation_error", "stage meeting findings through the dedicated findings command");
+            if (input.kind === EVIDENCE_FINDINGS_KIND)
+                throw new CliError("validation_error", "stage evidence findings through the dedicated findings command");
             return operations.propose(input);
         },
         get: async (id) => operations.get(id),

package/dist/store/store.d.ts

@@ -1,10 +1,11 @@
-import type { ContextEvidenceReader, ContextIndex } from "../context/evidence.js";
+import type { ContextEvidenceReader, ContextIndex, ContextRecordReader } from "../context/evidence.js";
 import { type AccountStore } from "./account-store.js";
 import { type AccountsStore } from "./accounts.js";
 import { type AttachmentsStore } from "./attachments.js";
 import { type ChatsStore } from "./chats.js";
 import { type ConversationsStore } from "./conversations.js";
 import { type CountersStore } from "./counters.js";
+import type { EvidenceFindingsStore } from "./evidence-findings.js";
 import type { MeetingFindingsStore } from "./meeting-findings.js";
 import { type MentionsStore } from "./mentions.js";
 import { type MessagesStore } from "./messages.js";
@@ -35,6 +36,7 @@ import { type VectorsStore } from "./vectors.js";
 export interface MessageStore {
     readonly contextEvidence?: ContextEvidenceReader;
     readonly contextIndex?: ContextIndex;
+    readonly contextRecords?: ContextRecordReader;
     /** Accounts, account groups and which account each app profile is. */
     readonly accounts: AccountsStore;
     /** One account's chats: the list, what left, what is complete, their metadata. */
@@ -77,6 +79,8 @@ export interface MessageStore {
     readonly catalog: CatalogStore;
     /** Choices that hold until replaced, each with its evidence. */
     readonly meetingFindings: MeetingFindingsStore;
+    /** Cited facts and follow-ups about one project from stored messages, mail and documents, for review. */
+    readonly evidenceFindings: EvidenceFindingsStore;
     readonly facts: FactsStore;
     /** What agents concluded: summaries, digests, facts, preferences, each with evidence and a scope. */
     readonly memories: MemoriesStore;

package/dist/store/store.js

@@ -16,8 +16,9 @@ import { agentActionsStoreOver } from "./sqlite/agent-actions.js";
 import * as attachmentTexts from "./sqlite/attachment-texts.js";
 import { botUpdateStoreOver } from "./sqlite/bot-updates.js";
 import { catalogStoreOver } from "./sqlite/catalog.js";
-import { contextEvidenceOver, contextIndexOver } from "./sqlite/context-evidence.js";
+import { contextEvidenceOver, contextIndexOver, contextRecordsOver } from "./sqlite/context-evidence.js";
 import { mailStoreOver } from "./sqlite/emails.js";
+import { evidenceFindingsStoreOver } from "./sqlite/evidence-findings.js";
 import { factsStoreOver } from "./sqlite/facts.js";
 import { involvementStoreOver } from "./sqlite/involvements.js";
 import { knowledgeStoreOver } from "./sqlite/knowledge.js";
@@ -82,6 +83,7 @@ const storeOver = (context) => {
     };
     const contextEvidence = once(() => contextEvidenceOver(context));
     const contextIndex = once(() => contextIndexOver(context, stemmerFor));
+    const contextRecords = once(() => contextRecordsOver(context));
     const searches = once(() => searchesStoreOver(context));
     const queries = once(() => queriesStoreOver(context, stemmerFor));
     const searchIndex = once(() => searchIndexStoreOver(context));
@@ -93,6 +95,7 @@ const storeOver = (context) => {
     const notes = once(() => ({ ...notesStoreOver(context), ...noteSearchOver(context) }));
     const catalog = once(() => catalogStoreOver(context));
     const meetingFindings = once(() => meetingFindingsStoreOver(context));
+    const evidenceFindings = once(() => evidenceFindingsStoreOver(context));
     const facts = once(() => factsStoreOver(context));
     const memories = once(() => memoriesStoreOver(context));
     const proposedActions = once(() => proposedActionsStoreOver(context));
@@ -105,6 +108,9 @@ const storeOver = (context) => {
         get contextIndex() {
             return contextIndex();
         },
+        get contextRecords() {
+            return contextRecords();
+        },
         meetingVectors: meetingVectorsOver(context),
         get accounts() {
             return areas.accounts().whole;
@@ -175,6 +181,9 @@ const storeOver = (context) => {
         get meetingFindings() {
             return meetingFindings();
         },
+        get evidenceFindings() {
+            return evidenceFindings();
+        },
         get facts() {
             return facts();
         },