@wireapp/core 27.3.4 → 27.3.5

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [27.3.5](https://github.com/wireapp/wire-web-packages/tree/main/packages/core/compare/@wireapp/core@27.3.4...@wireapp/core@27.3.5) (2022-06-09)
+
+
+### Bug Fixes
+
+* Do not process outdated events ([#4289](https://github.com/wireapp/wire-web-packages/tree/main/packages/core/issues/4289)) ([e817f8f](https://github.com/wireapp/wire-web-packages/tree/main/packages/core/commit/e817f8f3351d8b9c016bf94a2668278d9dc14514))
+
+
+
+
+
 ## [27.3.4](https://github.com/wireapp/wire-web-packages/tree/main/packages/core/compare/@wireapp/core@27.3.3...@wireapp/core@27.3.4) (2022-06-08)
 
 **Note:** Version bump only for package @wireapp/core

package/package.json

@@ -69,6 +69,6 @@
     "test:project": "yarn dist && yarn test",
     "test:node": "nyc jasmine --config=jasmine.json"
   },
-  "version": "27.3.4",
-  "gitHead": "d4ad56bf0f2ca6759b2e19742de7e26388905c56"
+  "version": "27.3.5",
+  "gitHead": "2ef677ae91a6350051dc3c2c24bd1b20f60a9f2e"
 }

package/src/main/Account.js

@@ -306,7 +306,7 @@ class Account extends events_1.EventEmitter {
         const handleNotification = async (notification, source) => {
             var e_1, _a;
             try {
-                const messages = this.service.notification.handleNotification(notification, conversation_1.PayloadBundleSource.WEBSOCKET, dryRun);
+                const messages = this.service.notification.handleNotification(notification, source, dryRun);
                 try {
                     for (var messages_1 = __asyncValues(messages), messages_1_1; messages_1_1 = await messages_1.next(), !messages_1_1.done;) {
                         const message = messages_1_1.value;

package/src/main/notification/NotificationService.d.ts

@@ -44,6 +44,15 @@ export declare class NotificationService extends EventEmitter {
     setLastEventDate(eventDate: Date): Promise<Date>;
     setLastNotificationId(lastNotification: Notification): Promise<string>;
     handleNotificationStream(notificationHandler: NotificationHandler, onMissedNotifications: (notificationId: string) => void, abortHandler: AbortHandler): Promise<void>;
+    /**
+     * Checks if an event should be ignored.
+     * An event that has a date prior to that last event that we have parsed should be ignored
+     *
+     * @param event
+     * @param source
+     * @param lastEventDate?
+     */
+    private isOutdatedEvent;
     handleNotification(notification: Notification, source: PayloadBundleSource, dryRun?: boolean): AsyncGenerator<HandledEventPayload>;
     private cleanupPayloadBundle;
     private handleEvent;

package/src/main/notification/NotificationService.js

@@ -136,10 +136,37 @@ class NotificationService extends events_1.EventEmitter {
             }).catch(error => this.logger.error(error));
         }
     }
+    /**
+     * Checks if an event should be ignored.
+     * An event that has a date prior to that last event that we have parsed should be ignored
+     *
+     * @param event
+     * @param source
+     * @param lastEventDate?
+     */
+    isOutdatedEvent(event, source, lastEventDate) {
+        const isFromNotificationStream = source === conversation_1.PayloadBundleSource.NOTIFICATION_STREAM;
+        const shouldCheckEventDate = !!event.time && isFromNotificationStream && lastEventDate;
+        if (shouldCheckEventDate) {
+            /** This check prevents duplicated "You joined" system messages. */
+            const isOutdated = lastEventDate.getTime() >= new Date(event.time).getTime();
+            return isOutdated;
+        }
+        return false;
+    }
     handleNotification(notification, source, dryRun = false) {
         return __asyncGenerator(this, arguments, function* handleNotification_1() {
             for (const event of notification.payload) {
                 this.logger.log(`Handling event of type "${event.type}" for notification with ID "${notification.id}"`, event);
+                let lastEventDate = undefined;
+                try {
+                    lastEventDate = yield __await(this.database.getLastEventDate());
+                }
+                catch (_a) { }
+                if ('time' in event && this.isOutdatedEvent(event, source, lastEventDate)) {
+                    this.logger.info(`Ignored outdated event type: '${event.type}'`);
+                    continue;
+                }
                 try {
                     const data = yield __await(this.handleEvent(event, source, dryRun));
                     yield yield __await(Object.assign(Object.assign({}, data), { mappedEvent: data.mappedEvent ? this.cleanupPayloadBundle(data.mappedEvent) : undefined }));