@wipcomputer/wip-release 1.9.27 → 1.9.30

package/cli.js

@@ -119,12 +119,12 @@ Flags:
   --skip-stale-check       Skip stale remote branch check
   --skip-worktree-check    Skip worktree guard (allow release from worktree)
 
-Release notes (highest priority wins, files ALWAYS beat --notes flag):
-  1. --notes-file=path          Explicit file path (always wins)
-  2. RELEASE-NOTES-v{ver}.md    In repo root (wins over --notes)
-  3. ai/dev-updates/YYYY-MM-DD* Today's dev update (wins over --notes if longer)
-  4. --notes="text"             Fallback only (use for repos without release notes files)
-  Written notes on disk always take priority over a CLI one-liner.
+Release notes (REQUIRED, must be a file on disk):
+  1. --notes-file=path          Explicit file path
+  2. RELEASE-NOTES-v{ver}.md    In repo root (auto-detected)
+  3. ai/dev-updates/YYYY-MM-DD* Today's dev update (auto-detected)
+  The --notes flag is NOT accepted. Write a file. Commit it on your branch.
+  The file shows up in the PR diff so it can be reviewed before merge.
 
 Skill publish to website:
   Add .publish-skill.json to repo root: { "name": "my-tool" }

package/core.mjs

@@ -227,31 +227,96 @@ function checkReleaseNotes(notes, notesSource, level) {
   const issues = [];
 
   if (!notes) {
-    issues.push('No release notes provided. Write a RELEASE-NOTES-v{version}.md or ai/dev-updates/ file.');
+    issues.push('No release notes found. A file is REQUIRED.');
+    issues.push('Write RELEASE-NOTES-v{version}.md or ai/dev-updates/YYYY-MM-DD--description.md');
+    issues.push('Commit it on your branch so it is reviewable in the PR.');
     return { ok: false, issues, block: true };
   }
 
-  // Notes too short. All levels blocked.
-  if (notes.length < 50) {
-    issues.push('Release notes are too short (under 50 chars). Explain what changed and why.');
-    issues.push('Write a RELEASE-NOTES-v{version}.md or ai/dev-updates/ file.');
+  // HARD RULE: release notes must come from a file on disk.
+  // --notes flag is NOT accepted. Write a file. Commit it. Review it.
+  if (notesSource === 'flag') {
+    issues.push('Release notes must come from a file, not the --notes flag.');
+    issues.push('Write RELEASE-NOTES-v{version}.md or ai/dev-updates/YYYY-MM-DD--description.md');
+    issues.push('Commit it on your branch so it is reviewable in the PR before merge.');
+    return { ok: false, issues, block: true };
   }
 
-  // Bare --notes flag for minor/major is never acceptable.
-  if (notesSource === 'flag' && (level === 'minor' || level === 'major')) {
-    issues.push('Minor/major releases require a file, not --notes flag.');
-    issues.push('Write RELEASE-NOTES-v{version}.md (dashes not dots) and commit it.');
+  // Notes too short.
+  if (notes.length < 50) {
+    issues.push('Release notes are too short (under 50 chars). Explain what changed and why.');
   }
 
-  // Check for changelog-style one-liners regardless of source
+  // Check for changelog-style one-liners
   const looksLikeChangelog = /^(fix|add|update|remove|bump|chore|refactor|docs?)[\s:]/i.test(notes);
   if (looksLikeChangelog && notes.length < 100) {
     issues.push('Notes look like a changelog entry, not a narrative. Explain the impact.');
   }
 
+  // Release notes should reference at least one issue
+  const hasIssueRef = /#\d+/.test(notes);
+  if (!hasIssueRef) {
+    issues.push('No issue reference found (#XX). Every release should close or reference an issue.');
+  }
+
   return { ok: issues.length === 0, issues, block: issues.length > 0 };
 }
 
+/**
+ * Scaffold a RELEASE-NOTES-v{version}.md template if one doesn't exist.
+ * Called when the release notes gate blocks. Gives the agent a file to fill in.
+ */
+export function scaffoldReleaseNotes(repoPath, version) {
+  const dashed = version.replace(/\./g, '-');
+  const notesPath = join(repoPath, `RELEASE-NOTES-v${dashed}.md`);
+  if (existsSync(notesPath)) return notesPath;
+
+  const pkg = JSON.parse(readFileSync(join(repoPath, 'package.json'), 'utf8'));
+  const name = pkg.name?.replace(/^@[^/]+\//, '') || basename(repoPath);
+
+  // Auto-detect issue references from commits since last tag
+  let issueRefs = '';
+  try {
+    const lastTag = execFileSync('git', ['describe', '--tags', '--abbrev=0'],
+      { cwd: repoPath, encoding: 'utf8' }).trim();
+    const log = execFileSync('git', ['log', `${lastTag}..HEAD`, '--oneline'],
+      { cwd: repoPath, encoding: 'utf8' });
+    const issues = [...new Set(log.match(/#\d+/g) || [])];
+    if (issues.length > 0) {
+      issueRefs = issues.map(i => `- ${i}`).join('\n');
+    }
+  } catch {}
+
+  const template = `# Release Notes: ${name} v${version}
+
+**One-line summary of what this release does**
+
+## What changed
+
+Describe the changes. Not a commit list. Explain:
+- What was built or fixed
+- Why it matters
+- What the user should know
+
+## Why
+
+What problem does this solve? What was broken or missing?
+
+## Issues closed
+
+${issueRefs || '- #XX (replace with actual issue numbers)'}
+
+## How to verify
+
+\`\`\`bash
+# Commands to test the changes
+\`\`\`
+`;
+
+  writeFileSync(notesPath, template);
+  return notesPath;
+}
+
 /**
  * Check if a file was modified in commits since the last git tag.
  */
@@ -457,6 +522,23 @@ export function createGitHubRelease(repoPath, newVersion, notes, currentVersion)
         console.warn(`  ! GitHub release body is only ${bodyLen} chars. Notes may be truncated.`);
       }
     } catch {}
+
+    // Auto-close referenced issues
+    const issueNums = [...new Set((body.match(/#(\d+)/g) || []).map(m => m.slice(1)))];
+    for (const num of issueNums) {
+      try {
+        // Only close if issue exists and is open on the public repo
+        const publicSlug = repoSlug.replace(/-private$/, '');
+        execFileSync('gh', [
+          'issue', 'close', num,
+          '--repo', publicSlug,
+          '--comment', `Closed by v${newVersion}. See release notes.`
+        ], { cwd: repoPath, stdio: 'pipe' });
+        console.log(`  ✓ Closed #${num} on ${publicSlug}`);
+      } catch {
+        // Issue doesn't exist on public repo or already closed. Fine.
+      }
+    }
   } finally {
     try { execFileSync('rm', ['-f', tmpFile]); } catch {}
   }
@@ -783,11 +865,10 @@ export async function release({ repoPath, level, notes, notesSource, dryRun, noP
       console.log(`  ✗ Release notes blocked:`);
       for (const issue of notesCheck.issues) console.log(`    - ${issue}`);
       console.log('');
-      console.log('  Release notes must explain what changed and why.');
-      console.log('  Options:');
-      console.log('    1. Write RELEASE-NOTES-v{version}.md (dashes not dots) and commit it');
-      console.log('    2. Write ai/dev-updates/YYYY-MM-DD--description.md and commit it');
-      console.log('    3. Use --notes="at least 50 chars explaining the change and its impact"');
+      // Scaffold a template so the agent has something to fill in
+      const templatePath = scaffoldReleaseNotes(repoPath, newVersion);
+      console.log(`  Scaffolded template: ${basename(templatePath)}`);
+      console.log('  Fill it in, commit, then run wip-release again.');
       console.log('');
       return { currentVersion, newVersion, dryRun: false, failed: true };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@wipcomputer/wip-release",
-  "version": "1.9.27",
+  "version": "1.9.30",
   "type": "module",
   "description": "One-command release pipeline. Bumps version, updates changelog + SKILL.md, publishes to npm + GitHub.",
   "main": "core.mjs",