@winspan/claude-forge 8.41.0 → 8.51.0

package/tests/unit/web/routes-stats.test.ts

@@ -0,0 +1,92 @@
+/**
+ * Unit tests for /api/stats route (system-wide stats for the dashboard).
+ */
+
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import express, { type Application } from 'express';
+import request from 'supertest';
+import { SQLiteStorage } from '../../../src/core/storage/sqlite.js';
+import { registerStatsRoutes } from '../../../src/web/routes/stats.js';
+
+const SESSION = 'sess-stats';
+const PROJECT = '/tmp/proj';
+
+function ts(offsetMs = 0): string {
+  // Use very-recent timestamps so daily activity windows include them.
+  return new Date(Date.now() - offsetMs).toISOString();
+}
+
+describe('Stats Routes', () => {
+  let app: Application;
+  let storage: SQLiteStorage;
+
+  beforeEach(() => {
+    storage = new SQLiteStorage(':memory:');
+    app = express();
+    app.use(express.json());
+    registerStatsRoutes(app, { storage });
+  });
+
+  afterEach(() => {
+    storage.close();
+  });
+
+  it('returns zero values when database is empty', async () => {
+    const res = await request(app).get('/api/stats');
+    expect(res.status).toBe(200);
+    expect(res.body.totalSessions).toBe(0);
+    expect(res.body.totalEvents).toBe(0);
+    expect(res.body.toolUsage).toEqual({});
+    expect(res.body.dailyActivity).toEqual([]);
+    expect(res.body.skillInvocations).toBe(0);
+  });
+
+  it('returns aggregate counts after events written', async () => {
+    storage.writeEvent({
+      session_id: SESSION, project_path: PROJECT, timestamp: ts(0),
+      hook_type: 'UserPromptSubmit', user_prompt: 'q1',
+    });
+    storage.writeEvent({
+      session_id: SESSION, project_path: PROJECT, timestamp: ts(0),
+      hook_type: 'PreToolUse', tool_name: 'Bash', tool_input: { command: 'ls' },
+    });
+    storage.writeEvent({
+      session_id: SESSION, project_path: PROJECT, timestamp: ts(0),
+      hook_type: 'PreToolUse', tool_name: 'Bash', tool_input: { command: 'pwd' },
+    });
+    storage.writeEvent({
+      session_id: SESSION, project_path: PROJECT, timestamp: ts(0),
+      hook_type: 'PreToolUse', tool_name: 'Edit', tool_input: { file_path: '/x' },
+    });
+
+    const res = await request(app).get('/api/stats');
+    expect(res.status).toBe(200);
+    expect(res.body.totalEvents).toBe(4);
+    expect(res.body.totalSessions).toBe(1);
+    expect(res.body.toolUsage.Bash).toBe(2);
+    expect(res.body.toolUsage.Edit).toBe(1);
+    expect(Array.isArray(res.body.dailyActivity)).toBe(true);
+    expect(res.body.dailyActivity.length).toBeGreaterThanOrEqual(1);
+  });
+
+  it('counts skill invocations', async () => {
+    storage.writeSkillInvocation({
+      id: 'si-1', route_request_id: null, session_id: SESSION,
+      agent_id: null, skill_id: 'official-tdd',
+      invocation_type: 'dynamic', reason: null,
+      workflow: null, phase: null, feature_slug: null, artifact_path: null,
+      depth: 0, success: 1, error: null, timestamp: Date.now(),
+    });
+    storage.writeSkillInvocation({
+      id: 'si-2', route_request_id: null, session_id: SESSION,
+      agent_id: null, skill_id: 'official-debug',
+      invocation_type: 'dynamic', reason: null,
+      workflow: null, phase: null, feature_slug: null, artifact_path: null,
+      depth: 0, success: 1, error: null, timestamp: Date.now(),
+    });
+
+    const res = await request(app).get('/api/stats');
+    expect(res.status).toBe(200);
+    expect(res.body.skillInvocations).toBe(2);
+  });
+});

package/tests/unit/web/routes-tasks.test.ts

@@ -0,0 +1,385 @@
+/**
+ * Unit tests for /api/tasks routes (list + detail + filter + pagination).
+ *
+ * Tests updated after implement phase to assert the new
+ * `{ items, total, has_more }` response shape (was: bare Task[]).
+ * Former [CHAR] tests are now regular tests asserting the new contract.
+ */
+
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import express, { type Application } from 'express';
+import request from 'supertest';
+import { SQLiteStorage } from '../../../src/core/storage/sqlite.js';
+import { registerTasksRoutes } from '../../../src/web/routes/tasks.js';
+
+const SESSION   = 'sess-task-1';
+const PROJECT_A = '/home/user/project-alpha';
+const PROJECT_B = '/home/user/project-beta';
+
+// Stable UUIDs used as event IDs (must pass Zod uuid validation)
+const EV_PROMPT = '776a8705-cdf6-42e3-a746-8e2cb8a2a90c';
+const EV_TOOL   = '2ace53f4-3a5d-4028-9354-438044cd33bd';
+const EV_AGENT  = 'dc56940c-3161-4071-bf44-7dd8e5f5fb9b';
+const INJ_ID    = 'd4ef23b3-fd39-494d-a0c4-88ddc1f4a809';
+const SI_ID     = 'bc082fc2-11c2-4396-b22c-c0ff49901c04';
+
+function ts(offsetMs = 0): string {
+  return new Date(Date.UTC(2026, 0, 1) + offsetMs).toISOString();
+}
+
+/** Write a session so the JOIN in queryTasksFiltered can find project_path */
+function seedSession(storage: SQLiteStorage, sessionId: string, projectPath: string, t = ts()) {
+  storage.getDatabase().prepare(
+    `INSERT OR IGNORE INTO sessions (session_id, project_path, start_time) VALUES (?, ?, ?)`
+  ).run(sessionId, projectPath, t);
+}
+
+describe('Tasks Routes', () => {
+  let app: Application;
+  let storage: SQLiteStorage;
+
+  beforeEach(() => {
+    storage = new SQLiteStorage(':memory:');
+    app = express();
+    app.use(express.json());
+    registerTasksRoutes(app, { storage });
+  });
+
+  afterEach(() => {
+    storage.close();
+  });
+
+  // ─────────────────────────────────────────────────────────────────────────
+  // GET /api/tasks — new { items, total, has_more } shape
+  // ─────────────────────────────────────────────────────────────────────────
+
+  describe('GET /api/tasks — paginated response', () => {
+    it('returns empty page when no tasks (A1)', async () => {
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      expect(res.body).toMatchObject({ items: [], total: 0, has_more: false });
+    });
+
+    it('returns items newest-first with total and has_more (A1)', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 't1', session_id: SESSION, title: 'first',  start_time: ts() });
+      storage.writeTask({ id: 't2', session_id: SESSION, title: 'second', start_time: ts(1000) });
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      expect(res.body.total).toBe(2);
+      expect(res.body.has_more).toBe(false);
+      expect(res.body.items).toHaveLength(2);
+      expect(res.body.items[0].id).toBe('t2');
+      expect(res.body.items[1].id).toBe('t1');
+    });
+
+    it('items include project_path from joined sessions', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 'tp', session_id: SESSION, title: 'with-proj', start_time: ts() });
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      expect(res.body.items[0].project_path).toBe(PROJECT_A);
+    });
+
+    it('honours session filter and returns wrapped response', async () => {
+      seedSession(storage, 'sess-a', PROJECT_A);
+      seedSession(storage, 'sess-b', PROJECT_B);
+      storage.writeTask({ id: 'a', session_id: 'sess-a', title: 'a', start_time: ts() });
+      storage.writeTask({ id: 'b', session_id: 'sess-b', title: 'b', start_time: ts(1000) });
+      const res = await request(app).get('/api/tasks').query({ session: 'sess-a' });
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(1);
+      expect(res.body.items[0].id).toBe('a');
+      expect(res.body.total).toBe(1);
+    });
+
+    it('respects limit param and sets has_more', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      for (let i = 0; i < 5; i++) {
+        storage.writeTask({ id: `t${i}`, session_id: SESSION, title: `task${i}`, start_time: ts(i * 1000) });
+      }
+      const res = await request(app).get('/api/tasks').query({ limit: 3 });
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(3);
+      expect(res.body.total).toBe(5);
+      expect(res.body.has_more).toBe(true);
+    });
+
+    it('clamps limit to 200 (A6)', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 'tx', session_id: SESSION, title: 'x', start_time: ts() });
+      const res = await request(app).get('/api/tasks').query({ limit: 201 });
+      expect(res.status).toBe(200);
+      // No error — clamped silently by Zod max(200) → returns valid page
+      expect(res.body).toHaveProperty('items');
+      expect(res.body).toHaveProperty('total');
+    });
+
+    it('task items contain expected fields', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 'field-check', session_id: SESSION, title: 'Test task', start_time: ts() });
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      const task = res.body.items[0];
+      expect(task).toHaveProperty('id', 'field-check');
+      expect(task).toHaveProperty('session_id', SESSION);
+      expect(task).toHaveProperty('title', 'Test task');
+      expect(task).toHaveProperty('start_time');
+      expect(task).toHaveProperty('status');
+      expect(task).toHaveProperty('event_count');
+    });
+
+    // ── safety-net:task-title-summary-real ─────────────────────────────────
+    // These tests assert the first_prompt field must be present in API items.
+    // They will be RED until the backend SQL subquery is added (Phase 2 fix).
+
+    it('safety-net: every item has first_prompt key (may be null)', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 'fp-check', session_id: SESSION, title: '<task-notification>', start_time: ts() });
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(1);
+      // first_prompt key must exist in the response (value may be null when no event)
+      expect(res.body.items[0]).toHaveProperty('first_prompt');
+    });
+
+    it('safety-net: first_prompt contains user_prompt text when event exists', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      const taskStart = ts();
+      storage.writeTask({ id: 'fp-event', session_id: SESSION, title: '<task-notification>', start_time: taskStart });
+      // Write a UserPromptSubmit event for this session after task start
+      storage.writeEvent({
+        event_id: EV_PROMPT,
+        session_id: SESSION, project_path: PROJECT_A,
+        timestamp: ts(100),
+        hook_type: 'UserPromptSubmit',
+        user_prompt: '<task-notification>\n<summary>Fix the login bug</summary>\n</task-notification>',
+      });
+      const res = await request(app).get('/api/tasks');
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(1);
+      const fp = res.body.items[0].first_prompt as string | null;
+      expect(fp).not.toBeNull();
+      expect(fp).toContain('Fix the login bug');
+    });
+  });
+
+  // ─────────────────────────────────────────────────────────────────────────
+  // GET /api/tasks — filter params
+  // ─────────────────────────────────────────────────────────────────────────
+
+  describe('GET /api/tasks — filter params', () => {
+    it('filters by single project (A2)', async () => {
+      seedSession(storage, 'sess-a', PROJECT_A);
+      seedSession(storage, 'sess-b', PROJECT_B);
+      storage.writeTask({ id: 'ta', session_id: 'sess-a', title: 'alpha task', start_time: ts() });
+      storage.writeTask({ id: 'tb', session_id: 'sess-b', title: 'beta task',  start_time: ts(1000) });
+
+      const res = await request(app).get('/api/tasks').query({ project: PROJECT_A });
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(1);
+      expect(res.body.items[0].id).toBe('ta');
+      expect(res.body.total).toBe(1);
+    });
+
+    it('filters by multiple projects OR (A3)', async () => {
+      seedSession(storage, 'sess-a', PROJECT_A);
+      seedSession(storage, 'sess-b', PROJECT_B);
+      seedSession(storage, 'sess-c', '/other');
+      storage.writeTask({ id: 'ta', session_id: 'sess-a', title: 'a', start_time: ts() });
+      storage.writeTask({ id: 'tb', session_id: 'sess-b', title: 'b', start_time: ts(1000) });
+      storage.writeTask({ id: 'tc', session_id: 'sess-c', title: 'c', start_time: ts(2000) });
+
+      const res = await request(app).get('/api/tasks')
+        .query(`project=${encodeURIComponent(PROJECT_A)}&project=${encodeURIComponent(PROJECT_B)}`);
+      expect(res.status).toBe(200);
+      expect(res.body.items).toHaveLength(2);
+      expect(res.body.total).toBe(2);
+      const ids = res.body.items.map((t: { id: string }) => t.id).sort();
+      expect(ids).toEqual(['ta', 'tb']);
+    });
+
+    it('filters by from/to time range (A4)', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 'early', session_id: SESSION, title: 'early', start_time: '2026-01-01T00:00:00.000Z' });
+      storage.writeTask({ id: 'mid',   session_id: SESSION, title: 'mid',   start_time: '2026-01-15T12:00:00.000Z' });
+      storage.writeTask({ id: 'late',  session_id: SESSION, title: 'late',  start_time: '2026-02-01T00:00:00.000Z' });
+
+      const res = await request(app).get('/api/tasks').query({
+        from: '2026-01-01T00:00:00.000Z',
+        to:   '2026-01-31T23:59:59.000Z',
+      });
+      expect(res.status).toBe(200);
+      expect(res.body.total).toBe(2);
+      const ids = res.body.items.map((t: { id: string }) => t.id).sort();
+      expect(ids).toEqual(['early', 'mid']);
+    });
+
+    it('filters by search (title LIKE) (A5)', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      storage.writeTask({ id: 't1', session_id: SESSION, title: '重构数据库',  start_time: ts() });
+      storage.writeTask({ id: 't2', session_id: SESSION, title: 'build CI',    start_time: ts(1000) });
+      storage.writeTask({ id: 't3', session_id: SESSION, title: '重构 API',    start_time: ts(2000) });
+
+      const res = await request(app).get('/api/tasks').query({ search: '重构' });
+      expect(res.status).toBe(200);
+      expect(res.body.total).toBe(2);
+      const ids = res.body.items.map((t: { id: string }) => t.id).sort();
+      expect(ids).toEqual(['t1', 't3']);
+    });
+
+    it('returns 400 for invalid query params', async () => {
+      const res = await request(app).get('/api/tasks').query({ limit: 'abc' });
+      expect(res.status).toBe(400);
+      expect(res.body).toHaveProperty('error');
+    });
+  });
+
+  // ─────────────────────────────────────────────────────────────────────────
+  // GET /api/tasks — pagination (A8)
+  // ─────────────────────────────────────────────────────────────────────────
+
+  describe('GET /api/tasks — pagination (A8)', () => {
+    it('offset increments page, total stays constant', async () => {
+      seedSession(storage, SESSION, PROJECT_A);
+      for (let i = 0; i < 6; i++) {
+        storage.writeTask({ id: `pg${i}`, session_id: SESSION, title: `t${i}`, start_time: ts(i * 1000) });
+      }
+
+      const page1 = await request(app).get('/api/tasks').query({ limit: 4, offset: 0 });
+      const page2 = await request(app).get('/api/tasks').query({ limit: 4, offset: 4 });
+
+      expect(page1.body.total).toBe(6);
+      expect(page1.body.items).toHaveLength(4);
+      expect(page1.body.has_more).toBe(true);
+
+      expect(page2.body.total).toBe(6);
+      expect(page2.body.items).toHaveLength(2);
+      expect(page2.body.has_more).toBe(false);
+
+      // No overlap
+      const p1ids = page1.body.items.map((t: { id: string }) => t.id);
+      const p2ids = page2.body.items.map((t: { id: string }) => t.id);
+      expect(p1ids.some((id: string) => p2ids.includes(id))).toBe(false);
+    });
+  });
+
+  // ─────────────────────────────────────────────────────────────────────────
+  // GET /api/tasks/projects
+  // ─────────────────────────────────────────────────────────────────────────
+
+  describe('GET /api/tasks/projects', () => {
+    it('returns empty array when no tasks', async () => {
+      const res = await request(app).get('/api/tasks/projects');
+      expect(res.status).toBe(200);
+      expect(res.body).toEqual([]);
+    });
+
+    it('returns distinct project paths that have tasks', async () => {
+      seedSession(storage, 'sess-a', PROJECT_A);
+      seedSession(storage, 'sess-b', PROJECT_B);
+      seedSession(storage, 'sess-c', '/other/path');
+      storage.writeTask({ id: 'ta', session_id: 'sess-a', title: 'a', start_time: ts() });
+      storage.writeTask({ id: 'tb', session_id: 'sess-b', title: 'b', start_time: ts(1000) });
+      // sess-c has no tasks — should not appear
+
+      const res = await request(app).get('/api/tasks/projects');
+      expect(res.status).toBe(200);
+      expect(res.body).toHaveLength(2);
+      expect(res.body).toContain(PROJECT_A);
+      expect(res.body).toContain(PROJECT_B);
+      expect(res.body).not.toContain('/other/path');
+    });
+
+    it('de-duplicates when multiple sessions share a project', async () => {
+      seedSession(storage, 'sess-1', PROJECT_A);
+      seedSession(storage, 'sess-2', PROJECT_A);
+      storage.writeTask({ id: 't1', session_id: 'sess-1', title: 'a', start_time: ts() });
+      storage.writeTask({ id: 't2', session_id: 'sess-2', title: 'b', start_time: ts(1000) });
+
+      const res = await request(app).get('/api/tasks/projects');
+      expect(res.status).toBe(200);
+      expect(res.body).toHaveLength(1);
+      expect(res.body[0]).toBe(PROJECT_A);
+    });
+  });
+
+  // ─────────────────────────────────────────────────────────────────────────
+  // GET /api/tasks/:taskId — detail route (unchanged by this feature)
+  // ─────────────────────────────────────────────────────────────────────────
+
+  describe('GET /api/tasks/:taskId', () => {
+    it('returns 404 for non-existent task', async () => {
+      const res = await request(app).get('/api/tasks/missing');
+      expect(res.status).toBe(404);
+      expect(res.body.error).toBe('Task not found');
+    });
+
+    it('returns task detail with timeline + injections + skill invocations', async () => {
+      storage.writeTask({ id: 'task-1', session_id: SESSION, title: 'Build', start_time: ts() });
+
+      // Write events bound to this task
+      storage.writeEvent({
+        event_id: EV_PROMPT,
+        session_id: SESSION, project_path: PROJECT_A, timestamp: ts(100),
+        hook_type: 'UserPromptSubmit', user_prompt: 'go build',
+      });
+      storage.writeEvent({
+        event_id: EV_TOOL,
+        session_id: SESSION, project_path: PROJECT_A, timestamp: ts(200),
+        hook_type: 'PreToolUse', tool_name: 'Edit',
+        tool_input: { file_path: '/main.ts' },
+      });
+      storage.linkEventToTask('task-1', EV_PROMPT);
+      storage.linkEventToTask('task-1', EV_TOOL);
+
+      // Injection
+      storage.writeInjection({
+        id: INJ_ID, event_id: EV_TOOL, session_id: SESSION,
+        timestamp: ts(150), source_handler: 'pre-tool',
+        injection_type: 'systemMessage', content: 'reminder',
+      });
+
+      // Skill invocation within task time window
+      storage.writeSkillInvocation({
+        id: SI_ID, route_request_id: null, session_id: SESSION,
+        agent_id: null, skill_id: 'official-tdd',
+        invocation_type: 'dynamic', reason: 'tdd',
+        workflow: null, phase: null, feature_slug: null, artifact_path: null,
+        depth: 0, success: 1, error: null,
+        timestamp: new Date(ts(150)).getTime(),
+      });
+
+      const res = await request(app).get('/api/tasks/task-1');
+      expect(res.status).toBe(200);
+      expect(res.body.task.id).toBe('task-1');
+      expect(res.body.userPrompts).toHaveLength(1);
+      expect(res.body.userPrompts[0].content).toBe('go build');
+      expect(res.body.timeline).toHaveLength(1);
+      expect(res.body.timeline[0].tool_name).toBe('Edit');
+      expect(res.body.injections).toHaveLength(1);
+      expect(res.body.injections[0].source_handler).toBe('pre-tool');
+      expect(res.body.skillInvocations).toHaveLength(1);
+      expect(res.body.skillInvocations[0].skill_id).toBe('official-tdd');
+      expect(res.body.artifacts).toContain('/main.ts');
+    });
+
+    it('marks Agent calls in timeline with agent_detail', async () => {
+      storage.writeTask({ id: 'agent-task', session_id: SESSION, title: 'agent', start_time: ts() });
+      storage.writeEvent({
+        event_id: EV_AGENT,
+        session_id: SESSION, project_path: PROJECT_A, timestamp: ts(100),
+        hook_type: 'PreToolUse', tool_name: 'Task',
+        tool_input: { subagent_type: 'researcher', name: 'r1', prompt: 'go' },
+      });
+      storage.linkEventToTask('agent-task', EV_AGENT);
+
+      const res = await request(app).get('/api/tasks/agent-task');
+      expect(res.status).toBe(200);
+      expect(res.body.timeline).toHaveLength(1);
+      expect(res.body.timeline[0].is_agent_call).toBe(true);
+      expect(res.body.timeline[0].agent_detail.subagent_type).toBe('researcher');
+      expect(res.body.timeline[0].agent_detail.name).toBe('r1');
+    });
+  });
+});