@windyroad/voice-tone 0.6.2 → 0.6.3-preview.885

package/.claude-plugin/plugin.json

@@ -123,5 +123,5 @@
     }
   },
   "name": "wr-voice-tone",
-  "version": "0.6.2"
+  "version": "0.6.3"
 }

package/hooks/external-comms-gate.sh

@@ -125,6 +125,19 @@ except Exception:
 # Permit silently when session_id is absent; the gate cannot key a marker.
 [ -n "$SESSION_ID" ] || exit 0
 
+# P405: `gh api` defaults to a read (GET). It only carries an outbound prose
+# body — the thing this gate reviews — when a request-body flag is supplied
+# (-f/--field, -F/--raw-field, --input; any of these flips gh api's default to
+# POST). Read-only polls carry none — e.g. `/wr-itil:review-problems` Step 4.5c's
+# security-advisories discovery poll `gh api repos/O/R/security-advisories --jq ...`
+# — and must NOT trip the gate. Used to narrow the two `gh api` surfaces
+# (security-advisories + comments) to writes only; every other surface
+# (gh issue/pr create|comment|edit, npm publish, changeset, git commit) is
+# inherently a write and stays gated unconditionally.
+_gh_api_has_body() {
+    printf '%s' "$1" | grep -qE '(^|[[:space:]])(--field|--raw-field|--input|-f|-F)([[:space:]]|=)'
+}
+
 # ---------- Surface detection ----------
 SURFACE=""
 DRAFT=""
@@ -153,9 +166,19 @@ except Exception:
         elif echo "$COMMAND" | grep -qE '(^|;|&&|\|\|)\s*gh pr edit(\s|$)'; then
             SURFACE="gh-pr-edit"
         elif echo "$COMMAND" | grep -qE 'gh api .*security-advisories'; then
-            SURFACE="gh-api-security-advisories"
+            # P405: gate only advisory-DRAFT writes; read-only polls (no body flag) skip.
+            if _gh_api_has_body "$COMMAND"; then
+                SURFACE="gh-api-security-advisories"
+            else
+                exit 0
+            fi
         elif echo "$COMMAND" | grep -qE 'gh api .*/comments'; then
-            SURFACE="gh-api-comments"
+            # P405: gate only comment-body writes; read-only polls (no body flag) skip.
+            if _gh_api_has_body "$COMMAND"; then
+                SURFACE="gh-api-comments"
+            else
+                exit 0
+            fi
         elif echo "$COMMAND" | grep -qE '(^|;|&&|\|\|)\s*npm publish(\s|$)'; then
             SURFACE="npm-publish"
         elif echo "$COMMAND" | grep -qE '(^|;|&&|\|\|)\s*git commit(\s|$)'; then

package/hooks/test/external-comms-gate.bats

@@ -196,6 +196,44 @@ run_hook() {
   [[ "$output" == *"wr-voice-tone:external-comms"* ]]
 }
 
+# ---------------------------------------------------------------------------
+# P405 — read-only `gh api` polls must NOT trip the gate. `gh api` defaults to
+# GET; it only carries an outbound prose body (the thing this gate reviews)
+# when a request-body flag (-f/--field, -F/--raw-field, --input) is present.
+# The `/wr-itil:review-problems` Step 4.5c security-advisories discovery poll
+# is read-only (`--jq` filter, no body flag) and was being denied as if it
+# were an advisory draft, silently blacking out one discovery channel.
+# ---------------------------------------------------------------------------
+
+@test "P405: read-only gh api security-advisories poll (--jq, no body flag) is not gated" {
+  INPUT=$(build_bash_input "gh api repos/foo/bar/security-advisories --jq '.[].ghsa_id'")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P405: bare gh api security-advisories read (no flags) is not gated" {
+  INPUT=$(build_bash_input "gh api repos/foo/bar/security-advisories")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P405: read-only gh api comments poll (--jq, no body flag) is not gated" {
+  INPUT=$(build_bash_input "gh api repos/foo/bar/issues/1/comments --jq '.[].body'")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P405: gh api security-advisories write with -f body flag still triggers the gate" {
+  INPUT=$(build_bash_input "gh api repos/foo/bar/security-advisories -f summary='new advisory'")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"deny"* ]]
+  [[ "$output" == *"wr-voice-tone:external-comms"* ]]
+}
+
 @test "npm publish triggers the gate" {
   INPUT=$(build_bash_input "npm publish")
   run_hook "$INPUT"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/voice-tone",
-  "version": "0.6.2",
+  "version": "0.6.3-preview.885",
   "description": "Voice and tone enforcement for user-facing copy",
   "bin": {
     "windyroad-voice-tone": "./bin/install.mjs"