@windyroad/style-guide 0.5.1-preview.1014 → 0.5.2-preview.1058

package/.claude-plugin/plugin.json

@@ -79,5 +79,5 @@
     }
   },
   "name": "wr-style-guide",
-  "version": "0.5.1"
+  "version": "0.5.2"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/style-guide",
-  "version": "0.5.1-preview.1014",
+  "version": "0.5.2-preview.1058",
   "description": "Style guide enforcement for CSS and UI components",
   "bin": {
     "windyroad-style-guide": "./bin/install.mjs"
@@ -24,6 +24,7 @@
     "hooks/",
     "skills/",
     ".claude-plugin/",
-    "lib/"
+    "lib/",
+    "!hooks/test/"
   ]
 }

package/hooks/test/slide-marker-on-subprocess-return.bats

@@ -1,118 +0,0 @@
-#!/usr/bin/env bats
-
-# Tests for slide_marker_on_subprocess_return helper (P111).
-#
-# Behavioural contract:
-# - Slides an existing marker forward (touch) on PostToolUse:Agent|Bash
-#   completion, treating subprocess wall-clock as continuous parent-session
-#   work for TTL purposes.
-# - Never CREATES a marker (creating requires a real gate review).
-# - Skips slide on subprocess error (tool_response.is_error=true) so a failed
-#   subprocess does NOT extend the parent's trust window (ADR-009 amendment).
-# - No-op when no marker exists or session_id is empty (fail-safe).
-
-setup() {
-  HOOKS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  source "$HOOKS_DIR/lib/gate-helpers.sh"
-
-  TEST_SESSION="bats-slide-$$-${BATS_TEST_NUMBER}"
-  MARKER="/tmp/architect-reviewed-${TEST_SESSION}"
-  rm -f "$MARKER"
-}
-
-teardown() {
-  rm -f "$MARKER"
-}
-
-# Helper: backdate file mtime by N seconds (portable between macOS and Linux)
-_backdate() {
-  local file="$1" seconds="$2"
-  local stamp
-  stamp=$(date -v-${seconds}S +%Y%m%d%H%M.%S 2>/dev/null \
-       || date -d "${seconds} seconds ago" +%Y%m%d%H%M.%S 2>/dev/null)
-  touch -t "$stamp" "$file"
-}
-
-@test "slide: existing marker is touched on success response" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}
-
-@test "slide: long-running subprocess does NOT cause parent marker expiry on return (P111 reproduction)" {
-  # Simulate the P111 failure mode: parent's marker is set, then a long
-  # subprocess runs (we backdate the marker to simulate elapsed wall-clock),
-  # then PostToolUse fires with a successful tool_response. The marker mtime
-  # must be refreshed so the parent's NEXT PreToolUse gate check (which
-  # compares NOW - mtime against TTL) sees a fresh marker.
-  touch "$MARKER"
-  # Marker is 50 minutes old — under default 60-min TTL but close to expiry.
-  # Without the slide on subprocess return, a subsequent 15-min subprocess
-  # would push the mtime past TTL and the next PreToolUse would deny.
-  _backdate "$MARKER" 3000
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"content":[{"type":"text","text":"OK"}]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  NOW=$(date +%s)
-  [ "$AFTER" -gt "$BEFORE" ]
-  # And the new mtime is approximately NOW (within 5 seconds of slide call)
-  AGE=$((NOW - AFTER))
-  [ "$AGE" -lt 5 ]
-}
-
-@test "slide: does NOT touch marker when tool_response.is_error=true" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_response":{"is_error":true,"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$BEFORE" = "$AFTER" ]
-}
-
-@test "slide: no-op when marker does not exist (never creates)" {
-  [ ! -f "$MARKER" ]
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  [ ! -f "$MARKER" ]
-}
-
-@test "slide: no-op when marker path argument is empty" {
-  _HOOK_INPUT='{"tool_response":{"content":[]}}'
-  run slide_marker_on_subprocess_return ""
-  [ "$status" -eq 0 ]
-}
-
-@test "slide: malformed hook input is fail-safe (no slide)" {
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='not valid json'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  # Fail-safe: when the hook input cannot be parsed, treat as error and skip
-  [ "$BEFORE" = "$AFTER" ]
-}
-
-@test "slide: triggers correctly on Skill tool_response shape (P213, ADR-009 2026-06-08 amendment)" {
-  # hooks.json matcher expansion Agent|Bash → Agent|Bash|Skill (P213 Option D)
-  # widens slide-marker coverage to PostToolUse:Skill completions (e.g. the
-  # /wr-risk-scorer:assess-* sibling assessor SKILLs run as long subprocesses
-  # by the AFK orchestrator). The Skill tool_response shape is identical to
-  # Agent|Bash (Claude Code's uniform PostToolUse contract), so the matcher-
-  # agnostic helper composes without code changes. This test documents that
-  # contract explicitly so a future hook_input shape divergence regression
-  # surfaces here rather than at the gate-denial site.
-  touch "$MARKER"
-  _backdate "$MARKER" 60
-  BEFORE=$(_mtime "$MARKER")
-  _HOOK_INPUT='{"tool_name":"Skill","tool_response":{"content":[{"type":"text","text":"OK"}]}}'
-  slide_marker_on_subprocess_return "$MARKER"
-  AFTER=$(_mtime "$MARKER")
-  [ "$AFTER" -gt "$BEFORE" ]
-}

package/hooks/test/style-guide-enforce-scope.bats

@@ -1,75 +0,0 @@
-#!/usr/bin/env bats
-
-# Tests for style-guide-enforce-edit.sh — verifies the path-based exemption
-# for governance-managed surfaces (docs/story-maps/, docs/stories/) per
-# ADR-060 § Phase 2 amendment 2026-05-12 lines 481-496 (P170 Phase 2 Slice 2.5).
-#
-# The style-guide hook is opt-in (gates only *.css|*.html|*.jsx|*.tsx|*.vue|
-# *.svelte|*.ejs|*.hbs). Story-map HTML files would otherwise be blocked at
-# `*.html` matching when docs/STYLE-GUIDE.md is absent OR review-gate is open.
-# The exemption short-circuits before the extension check.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/style-guide-enforce-edit.sh"
-  ORIG_DIR="$PWD"
-  TEST_DIR=$(mktemp -d)
-  cd "$TEST_DIR"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$TEST_DIR"
-}
-
-run_hook_with_file() {
-  local file_path="$1"
-  local json="{\"tool_input\":{\"file_path\":\"${file_path}\"},\"session_id\":\"test-session-$$\"}"
-  echo "$json" | bash "$HOOK"
-}
-
-assert_path_allowed() {
-  local file_path="$1"
-  run run_hook_with_file "$file_path"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-assert_path_blocked() {
-  local file_path="$1"
-  run run_hook_with_file "$file_path"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-# --- Story maps + stories exemptions (P170 Phase 2 Slice 2.5 / ADR-060) ---
-
-@test "style-guide: exempts docs/story-maps/ HTML in per-state subdir" {
-  assert_path_allowed "$PWD/docs/story-maps/draft/STORY-MAP-001-foo.html"
-}
-
-@test "style-guide: exempts docs/story-maps/ HTML in completed subdir" {
-  assert_path_allowed "$PWD/docs/story-maps/completed/STORY-MAP-002-bar.html"
-}
-
-@test "style-guide: exempts docs/stories/ files even though .md isn't normally gated" {
-  # Markdown isn't in the opt-in extension list anyway, so this passes by
-  # virtue of the extension filter — but the explicit exemption documents
-  # intent and survives a hypothetical future scope-widening.
-  assert_path_allowed "$PWD/docs/stories/draft/STORY-001-foo.md"
-}
-
-# --- Regression: non-exempt UI files still gate ---
-
-@test "style-guide: exempts VCS-internal .git/ files even with a gated extension (P458)" {
-  assert_path_allowed "$PWD/.git/hooks/pre-commit.css"
-}
-
-@test "style-guide: still blocks an unrelated .html file when no policy exists" {
-  # No docs/STYLE-GUIDE.md created — hook should still block this HTML.
-  assert_path_blocked "$PWD/public/index.html"
-}
-
-@test "style-guide: still blocks a .tsx component file when no policy exists" {
-  assert_path_blocked "$PWD/src/Component.tsx"
-}

package/hooks/test/style-guide-eval-once-per-session.bats

@@ -1,77 +0,0 @@
-#!/usr/bin/env bats
-
-# P095 / ADR-038: style-guide-eval.sh UserPromptSubmit hook must emit
-# the full MANDATORY block only on the first prompt of a session;
-# subsequent prompts emit a terse reminder.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/style-guide/hooks/style-guide-eval.sh"
-
-  WORKDIR="$(mktemp -d)"
-  mkdir -p "$WORKDIR/docs"
-  : > "$WORKDIR/docs/STYLE-GUIDE.md"
-
-  SID="sg-eval-test-$$-$RANDOM"
-}
-
-teardown() {
-  rm -f "/tmp/style-guide-announced-${SID}"
-  rm -f "/tmp/style-guide-announced-${SID}-alt"
-  rm -rf "$WORKDIR"
-}
-
-run_hook() {
-  local sid="$1"
-  (cd "$WORKDIR" && echo "{\"session_id\":\"$sid\"}" | bash "$HOOK")
-}
-
-@test "style-guide-eval: first invocation emits the full MANDATORY block" {
-  run run_hook "$SID"
-  [ "$status" -eq 0 ]
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY STYLE GUIDE CHECK"* ]]
-  [[ "$output" == *"wr-style-guide:agent"* ]]
-}
-
-@test "style-guide-eval: first invocation writes the announcement marker" {
-  run run_hook "$SID"
-  [ -f "/tmp/style-guide-announced-${SID}" ]
-}
-
-@test "style-guide-eval: second invocation emits only a terse reminder" {
-  run_hook "$SID" >/dev/null
-  run run_hook "$SID"
-  [ "${#output}" -lt 250 ]
-  [[ "$output" == *"style-guide"* ]] || [[ "$output" == *"STYLE"* ]]
-  [[ "$output" == *"wr-style-guide:agent"* ]]
-  [[ "$output" != *"REQUIRED ACTIONS:"* ]]
-}
-
-@test "style-guide-eval: terse reminder preserves the MANDATORY signal word" {
-  run_hook "$SID" >/dev/null
-  run run_hook "$SID"
-  [[ "$output" == *"MANDATORY"* ]] || [[ "$output" == *"REQUIRED"* ]] || [[ "$output" == *"NON-OPTIONAL"* ]]
-}
-
-@test "style-guide-eval: terse reminder names the trigger artifact" {
-  run_hook "$SID" >/dev/null
-  run run_hook "$SID"
-  [[ "$output" == *"STYLE-GUIDE.md"* ]]
-}
-
-@test "style-guide-eval: different session_id re-emits the full block" {
-  run_hook "$SID" >/dev/null
-  local SID2="${SID}-alt"
-  run run_hook "$SID2"
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY STYLE GUIDE CHECK"* ]]
-  rm -f "/tmp/style-guide-announced-${SID2}"
-}
-
-@test "style-guide-eval: empty session_id emits the full block and writes no marker" {
-  run run_hook ""
-  [ "${#output}" -gt 400 ]
-  [[ "$output" == *"MANDATORY STYLE GUIDE CHECK"* ]]
-  [ ! -f "/tmp/style-guide-announced-" ]
-}

package/hooks/test/style-guide-no-stop-hook.bats

@@ -1,15 +0,0 @@
-#!/usr/bin/env bats
-
-# P001 / ADR-009: Stop-hook marker reset removed.
-
-setup() {
-  PLUGIN_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/../.." && pwd)"
-}
-
-@test "style-guide: hooks.json has no Stop hook entry (ADR-009)" {
-  ! grep -q '"Stop"' "$PLUGIN_DIR/hooks/hooks.json"
-}
-
-@test "style-guide: style-guide-reset-marker.sh has been removed" {
-  [ ! -f "$PLUGIN_DIR/hooks/style-guide-reset-marker.sh" ]
-}

package/hooks/test/style-guide-project-root.bats

@@ -1,20 +0,0 @@
-#!/usr/bin/env bats
-
-# P004: style-guide-enforce-edit.sh project-root check.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/style-guide-enforce-edit.sh"
-}
-
-run_hook_with_file() {
-  local file_path="$1"
-  local json="{\"tool_input\":{\"file_path\":\"${file_path}\"},\"session_id\":\"test-$$\"}"
-  echo "$json" | bash "$HOOK"
-}
-
-@test "style-guide project-root: absolute .css outside project exits 0" {
-  run run_hook_with_file "/Users/other/project/src/style.css"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}

package/hooks/test/substance-aware-drift.bats

@@ -1,86 +0,0 @@
-#!/usr/bin/env bats
-
-# Behavioural tests for ADR-009 amendment 2026-06-06: substance-aware drift +
-# atomic verdict-write — style-guide gate. Sibling-coverage to architect /
-# jtbd / voice-tone bats files of the same name.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  source "$SCRIPT_DIR/lib/review-gate.sh"
-
-  TEST_SESSION="bats-sg-substance-$$-${BATS_TEST_NUMBER}"
-  SYSTEM="style-guide"
-  TEST_DIR=$(mktemp -d -t substance-aware-drift-sg.XXXXXX)
-  POLICY_FILE="$TEST_DIR/STYLE-GUIDE.md"
-
-  MARKER="/tmp/${SYSTEM}-reviewed-${TEST_SESSION}"
-  HASH_FILE="${MARKER}.hash"
-  rm -f "$MARKER" "$HASH_FILE"
-}
-
-teardown() {
-  rm -f "$MARKER" "$HASH_FILE"
-  rm -rf "$TEST_DIR"
-}
-
-_install_and_mark() {
-  local body="$1"
-  printf '%s' "$body" > "$POLICY_FILE"
-  touch "$MARKER"
-  store_review_hash "$TEST_SESSION" "$SYSTEM" "$POLICY_FILE"
-}
-
-@test "style-guide substance-aware: trailing-whitespace edit does NOT re-trigger" {
-  _install_and_mark "# Style Guide
-
-Use 2-space indentation.
-"
-  printf '%s' "# Style Guide
-
-Use 2-space indentation.
-" > "$POLICY_FILE"
-
-  run check_review_gate "$TEST_SESSION" "$SYSTEM" "$POLICY_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "style-guide substance-aware: new-rule edit DOES re-trigger" {
-  _install_and_mark "# Style Guide
-
-Use 2-space indentation.
-"
-  printf '%s' "# Style Guide
-
-Use 2-space indentation.
-Always trailing-comma.
-" > "$POLICY_FILE"
-
-  run check_review_gate "$TEST_SESSION" "$SYSTEM" "$POLICY_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "style-guide atomic-write: store_review_hash lands marker + hash together" {
-  printf '%s' "# Style Guide
-
-Body.
-" > "$POLICY_FILE"
-  touch "$MARKER"
-  run store_review_hash "$TEST_SESSION" "$SYSTEM" "$POLICY_FILE"
-  [ "$status" -eq 0 ]
-  [ -f "$MARKER" ]
-  [ -f "$HASH_FILE" ]
-}
-
-@test "style-guide conservative: single-numeral change DOES re-trigger" {
-  _install_and_mark "# Style Guide
-
-Use 2-space indentation.
-"
-  printf '%s' "# Style Guide
-
-Use 4-space indentation.
-" > "$POLICY_FILE"
-
-  run check_review_gate "$TEST_SESSION" "$SYSTEM" "$POLICY_FILE"
-  [ "$status" -ne 0 ]
-}