@windyroad/risk-scorer 0.13.2 → 0.13.4

package/.claude-plugin/plugin.json

@@ -310,5 +310,5 @@
     }
   },
   "name": "wr-risk-scorer",
-  "version": "0.13.2"
+  "version": "0.13.4"
 }

package/hooks/external-comms-evaluator.conf

@@ -21,3 +21,10 @@ EXTERNAL_COMMS_POLICY_FILE=RISK-POLICY.md
 # Whether to run the leak-pattern pre-filter (lib/leak-detect.sh). Risk evaluator
 # checks confidential-information leaks; voice-tone evaluator does not.
 EXTERNAL_COMMS_LEAK_PREFILTER=yes
+
+# Surfaces this evaluator's policy disclaims (P360). EMPTY for the risk evaluator:
+# leak detection on commit-message bodies is meaningful (a credential committed to
+# git history is still a leak), so risk-scorer gates every detected surface. The
+# voice-tone evaluator sets this to `git-commit-message` because its policy doc
+# excludes commit messages; the divergence lives in each package's .conf.
+EXTERNAL_COMMS_SKIP_SURFACES=

package/hooks/external-comms-gate.sh

@@ -78,6 +78,10 @@ source "$SCRIPT_DIR/lib/external-comms-key.sh"
 #   EXTERNAL_COMMS_ASSESS_SKILL    — on-demand skill path for manual delegation
 #   EXTERNAL_COMMS_POLICY_FILE     — policy doc whose absence triggers advisory-only
 #   EXTERNAL_COMMS_LEAK_PREFILTER  — yes|no — whether to run leak-detect pre-filter
+#   EXTERNAL_COMMS_SKIP_SURFACES   — space-separated surface list this evaluator's
+#                                    policy disclaims; the marker-review delegation
+#                                    silent-passes on those surfaces (P360). Default
+#                                    empty (gate every detected surface).
 # Fail-closed if absent: this hook cannot operate without a configured evaluator.
 CONF_FILE="$SCRIPT_DIR/external-comms-evaluator.conf"
 if [ ! -f "$CONF_FILE" ]; then
@@ -91,6 +95,7 @@ source "$CONF_FILE"
 : "${EXTERNAL_COMMS_ASSESS_SKILL:?assess-skill missing from $CONF_FILE}"
 EXTERNAL_COMMS_POLICY_FILE="${EXTERNAL_COMMS_POLICY_FILE:-RISK-POLICY.md}"
 EXTERNAL_COMMS_LEAK_PREFILTER="${EXTERNAL_COMMS_LEAK_PREFILTER:-yes}"
+EXTERNAL_COMMS_SKIP_SURFACES="${EXTERNAL_COMMS_SKIP_SURFACES:-}"
 
 # ---------- Bypass ----------
 if [ "${BYPASS_RISK_GATE:-0}" = "1" ]; then
@@ -318,6 +323,48 @@ if [ "$EXTERNAL_COMMS_LEAK_PREFILTER" = "yes" ]; then
     fi
 fi
 
+# ---------- Per-evaluator surface skip (P360) ----------
+# Some surfaces are explicitly disclaimed by THIS evaluator's policy doc, so the
+# marker-review delegation below would be a guaranteed-PASS no-op (the subagent
+# reads the policy, declares the surface out of scope, emits PASS — ~19K tokens
+# per round-trip). EXTERNAL_COMMS_SKIP_SURFACES (per-package .conf) lists those
+# surfaces; the gate silent-passes the prose-review delegation when the detected
+# surface is on the list. Voice-tone sets this to `git-commit-message` because
+# docs/VOICE-AND-TONE.md § Scope excludes commit messages ("covered by ADR-014 +
+# ADR-018"); risk-scorer leaves it empty (its leak check on commit messages is
+# meaningful). Placed AFTER the leak pre-filter so a skipped surface still gets
+# credential/prod-URL scanning — this silences ONLY the prose-review deny, the
+# same conservative shape as the P365 repo-visibility precondition below.
+if [ -n "$EXTERNAL_COMMS_SKIP_SURFACES" ]; then
+    case " $EXTERNAL_COMMS_SKIP_SURFACES " in
+        *" $SURFACE "*)
+            exit 0
+            ;;
+    esac
+fi
+
+# ---------- Repo-visibility precondition: git-commit-message surface (P365) ----------
+# A commit message only becomes external-facing prose when it lands in a PUBLIC
+# GitHub repo (git log / PR commits tab / release-page auto-notes / CHANGELOG).
+# In private or internal repos the marker-review delegation deny below is a pure
+# false-positive (P365 — user direction 2026-06-11: "this MUST NOT fire for
+# private repos"). Confirm visibility authoritatively via gh and silent-pass the
+# marker gate on any non-PUBLIC result. Any INDETERMINATE result (gh absent,
+# unauthenticated, no remote, API error → empty $REPO_VISIBILITY) is treated as
+# non-public: a commit message is only demonstrably external when the repo is
+# confirmably PUBLIC, so the conservative direction for THIS surface is to not
+# fire. This is a fail-open on the voice/tone-and-prose review ONLY — the
+# leak-pattern pre-filter above (credentials / prod-URLs) has already run for
+# every surface in every repo, so the high-stakes secrecy net is unaffected.
+# Scoped to git-commit-message only; the gh-issue/pr/api, npm-publish, and
+# changeset-author surfaces are inherently external and stay gated regardless.
+if [ "$SURFACE" = "git-commit-message" ]; then
+    REPO_VISIBILITY=$(gh repo view --json visibility -q .visibility 2>/dev/null || echo "")
+    if [ "$REPO_VISIBILITY" != "PUBLIC" ]; then
+        exit 0
+    fi
+fi
+
 # ---------- Marker-based gate (per-evaluator marker per ADR-028 amended 2026-05-14) ----------
 SESSION_DIR="${TMPDIR:-/tmp}/claude-risk-${SESSION_ID}"
 mkdir -p "$SESSION_DIR"

package/hooks/test/external-comms-gate.bats

@@ -65,10 +65,28 @@ print(json.dumps({
 " "$file_path" "$content"
 }
 
+# Mock `gh repo view --json visibility` for the git-commit-message surface
+# repo-visibility precondition (P365). vis ∈ {PUBLIC,PRIVATE,INTERNAL}; pass the
+# literal "FAIL" to simulate gh absent / unauthenticated (non-zero exit). The
+# mock ignores args and prints the chosen visibility so the hook's
+# `gh repo view --json visibility -q .visibility` resolves deterministically.
+mock_gh_visibility() {
+  local vis="$1"
+  mkdir -p "$TEST_PROJECT_DIR/mockbin"
+  if [ "$vis" = "FAIL" ]; then
+    printf '#!/usr/bin/env bash\nexit 1\n' > "$TEST_PROJECT_DIR/mockbin/gh"
+  else
+    printf '#!/usr/bin/env bash\necho %s\n' "$vis" > "$TEST_PROJECT_DIR/mockbin/gh"
+  fi
+  chmod +x "$TEST_PROJECT_DIR/mockbin/gh"
+}
+
 # Run the hook in a project dir with RISK-POLICY.md present, piping JSON via stdin.
+# mockbin (if populated by mock_gh_visibility) is prepended to PATH so the
+# git-commit-message visibility precondition resolves against the mock.
 run_hook() {
   local input="$1"
-  run bash -c "cd '$TEST_PROJECT_DIR' && printf '%s' \"\$1\" | '$HOOK'" _ "$input"
+  run bash -c "cd '$TEST_PROJECT_DIR' && export PATH='$TEST_PROJECT_DIR/mockbin':\$PATH && printf '%s' \"\$1\" | '$HOOK'" _ "$input"
 }
 
 # ---------- Tests ----------
@@ -244,6 +262,7 @@ run_hook() {
 }
 
 @test "P082: git commit -m with leak-free body denies and delegates to risk evaluator" {
+  mock_gh_visibility PUBLIC
   INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
   run_hook "$INPUT"
   [ "$status" -eq 0 ]
@@ -253,6 +272,7 @@ run_hook() {
 }
 
 @test "P082: git commit --amend -m is intercepted (P082 SC2)" {
+  mock_gh_visibility PUBLIC
   INPUT=$(build_bash_input "git commit --amend -m \"rewritten subject\"")
   run_hook "$INPUT"
   [ "$status" -eq 0 ]
@@ -264,6 +284,7 @@ run_hook() {
   # Build a HEREDOC-shaped command. The hook regex pulls the body BETWEEN
   # the <<'EOF' opener and the closing EOF marker — the extracted DRAFT is
   # the inner text, NOT the literal `$(cat <<'EOF' ... EOF)` wrapper.
+  mock_gh_visibility PUBLIC
   BODY=$'feat(foo): add bar\n\nWe observed a build failure on Node 20.'
   CMD=$'git commit -m "$(cat <<\'EOF\'\n'"$BODY"$'\nEOF\n)"'
   INPUT=$(build_bash_input "$CMD")
@@ -306,6 +327,7 @@ run_hook() {
 }
 
 @test "P082: per-evaluator marker keyed on (body, git-commit-message) permits the call" {
+  mock_gh_visibility PUBLIC
   BODY="docs(retro): close iter 3 ask-hygiene trail"
   SURFACE="git-commit-message"
   KEY=$(printf '%s\n%s' "$BODY" "$SURFACE" | shasum -a 256 | cut -d' ' -f1)
@@ -317,6 +339,85 @@ run_hook() {
   [ -z "$output" ]
 }
 
+# ---------------------------------------------------------------------------
+# P365 — repo-visibility precondition on the git-commit-message surface.
+# A commit message is external-facing prose ONLY when it lands in a PUBLIC
+# GitHub repo (git log / PR commits tab / release notes / CHANGELOG). In
+# private/internal repos — or any repo whose visibility cannot be confirmed
+# PUBLIC — the marker-review delegation deny is a pure false-positive
+# (user direction 2026-06-11: "this MUST NOT fire for private repos"). The
+# precondition silent-passes the marker gate for the git-commit-message
+# surface on any non-PUBLIC / indeterminate gh result. It is scoped to that
+# surface only and runs AFTER the leak pre-filter, so the credential/prod-URL
+# security net survives the short-circuit.
+# ---------------------------------------------------------------------------
+
+@test "P365: git commit -m in a PRIVATE repo silent-passes (no external-comms deny)" {
+  mock_gh_visibility PRIVATE
+  INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P365: git commit -m in an INTERNAL repo silent-passes" {
+  mock_gh_visibility INTERNAL
+  INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P365: git commit -m when gh is unavailable/indeterminate silent-passes (fail-non-public)" {
+  mock_gh_visibility FAIL
+  INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "P365: git commit -m in a PUBLIC repo still denies+delegates (gate intact, precondition surface-scoped)" {
+  mock_gh_visibility PUBLIC
+  INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"deny"* ]]
+  [[ "$output" == *"git-commit-message"* ]]
+}
+
+@test "P360: empty EXTERNAL_COMMS_SKIP_SURFACES leaves the risk evaluator gating commit messages (divergence guard)" {
+  # The voice-tone evaluator skips git-commit-message (its policy disclaims it);
+  # the risk evaluator's .conf leaves EXTERNAL_COMMS_SKIP_SURFACES empty, so its
+  # leak check on commit bodies stays meaningful. Guards against a regression
+  # that accidentally skips this surface for risk-scorer (e.g. defaulting the
+  # knob non-empty, or syncing voice-tone's value into the shared gate body).
+  grep -qE '^EXTERNAL_COMMS_SKIP_SURFACES=$' "$HOOKS_DIR/external-comms-evaluator.conf"
+  mock_gh_visibility PUBLIC
+  INPUT=$(build_bash_input "git commit -m \"fix(foo): handle null input\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"deny"* ]]
+  [[ "$output" == *"git-commit-message"* ]]
+}
+
+@test "P365: leak-shaped credential in a PRIVATE-repo commit body still hard-fails (security net survives)" {
+  mock_gh_visibility PRIVATE
+  INPUT=$(build_bash_input "git commit -m \"docs: token=${GH_TOKEN_LIKE}\"")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"deny"* ]]
+  [[ "$output" == *"git-commit-message"* ]]
+}
+
+@test "P365: PRIVATE visibility does NOT short-circuit the gh-issue surface (still denies+delegates)" {
+  mock_gh_visibility PRIVATE
+  INPUT=$(build_bash_input "gh issue create --title x --body 'a clean issue body'")
+  run_hook "$INPUT"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"deny"* ]]
+  [[ "$output" == *"gh-issue-create"* ]]
+}
+
 # ---------------------------------------------------------------------------
 # P364 — backtick-bearing double-quoted --body marker-key mismatch.
 # When an outbound body contains markdown backticks (a code span), the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/risk-scorer",
-  "version": "0.13.2",
+  "version": "0.13.4",
   "description": "Pipeline risk scoring, commit/push gates, and secret leak detection",
   "bin": {
     "windyroad-risk-scorer": "./bin/install.mjs"