@windyroad/risk-scorer 0.13.0 → 0.13.1-preview.709

package/.claude-plugin/plugin.json

@@ -310,5 +310,5 @@
     }
   },
   "name": "wr-risk-scorer",
-  "version": "0.13.0"
+  "version": "0.13.1"
 }

package/hooks/lib/external-comms-key.sh

@@ -54,8 +54,21 @@ surface = os.environ.get('EXTCOMMS_SURFACE', '')
 # changeset-author: strip the leading YAML frontmatter block + blank line.
 if surface == 'changeset-author':
     draft = re.sub(r'^---\n.*?\n---\n\n?', '', draft, count=1, flags=re.DOTALL)
-# Single canonical newline normalization: strip all trailing whitespace.
-draft = draft.rstrip()
+# Substance-aware whitespace normalization (P276 / ADR-009 + ADR-028 amended
+# 2026-06-06). Tolerate trivial PASS-class reformatting so a marker survives
+# interior CRLF/CR line endings and per-line trailing whitespace — the same
+# normalization _substance_normalize_then_hash (gate-helpers.sh) applies to
+# the policy-file-drift gates. Conservative boundary preserved: single-numeral
+# edits and frontmatter-key changes stay substantive (key changes → review
+# re-fires), so the leak-detection guarantee is never weakened.
+#   1. CRLF / CR -> LF
+#   2. strip trailing whitespace per line
+#   3. strip trailing whitespace of the whole draft (subsumes the prior
+#      single-canonical rstrip; NO trailing '\n' is appended here so the key
+#      shape sha256(normalize(draft) + '\n' + surface) is byte-stable for
+#      already-clean drafts — existing markers and keys do not shift).
+draft = draft.replace('\r\n', '\n').replace('\r', '\n')
+draft = '\n'.join(line.rstrip() for line in draft.split('\n')).rstrip()
 print(hashlib.sha256((draft + '\n' + surface).encode('utf-8')).hexdigest())
 " 2>/dev/null
 }

package/hooks/test/external-comms-key-substance.bats

@@ -0,0 +1,74 @@
+#!/usr/bin/env bats
+# Behavioural tests for compute_external_comms_key substance-aware draft
+# normalization (P276 — external-comms gate marker over-fires on PASS-class
+# content edits).
+#
+# Contract (ADR-009 + ADR-028 amended 2026-06-06, ratified): the marker key
+# must survive TRIVIAL whitespace-class edits to the draft body — interior
+# CRLF/CR line endings and per-line trailing whitespace — so a PASS review
+# does not have to re-fire on a no-op reformat. The conservative boundary is
+# preserved: single-numeral edits and frontmatter-key changes remain
+# SUBSTANTIVE (the key changes → review re-fires) so the leak-detection
+# guarantee is never weakened.
+#
+# These exercise compute_external_comms_key directly (its stdout = the 64-char
+# sha256 key) — behavioural assertions on the function's output, not a
+# structural grep of the source.
+
+setup() {
+  HOOKS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  # shellcheck source=../lib/external-comms-key.sh
+  source "$HOOKS_DIR/lib/external-comms-key.sh"
+}
+
+# ---------- Trivial edits must NOT change the key (P276) ----------
+
+@test "P276: interior CRLF line endings produce the same key as LF" {
+  lf=$(compute_external_comms_key $'Line one\nLine two\nLine three' 'gh-issue-comment')
+  crlf=$(compute_external_comms_key $'Line one\r\nLine two\r\nLine three' 'gh-issue-comment')
+  [ -n "$lf" ]
+  [ "$lf" = "$crlf" ]
+}
+
+@test "P276: per-line trailing whitespace produces the same key as clean lines" {
+  clean=$(compute_external_comms_key $'Line one\nLine two' 'gh-issue-comment')
+  trailing=$(compute_external_comms_key $'Line one   \nLine two\t' 'gh-issue-comment')
+  [ -n "$clean" ]
+  [ "$clean" = "$trailing" ]
+}
+
+@test "P276: trailing whitespace at end of draft produces the same key (regression guard for prior rstrip)" {
+  clean=$(compute_external_comms_key 'A short draft body' 'gh-issue-comment')
+  trailed=$(compute_external_comms_key $'A short draft body\n\n  ' 'gh-issue-comment')
+  [ "$clean" = "$trailed" ]
+}
+
+# ---------- Conservative boundary: substantive edits MUST change the key ----------
+
+@test "P276 boundary: a single-numeral edit changes the key (review re-fires)" {
+  before=$(compute_external_comms_key 'We support 12 plugins today' 'gh-issue-comment')
+  after=$(compute_external_comms_key 'We support 11 plugins today' 'gh-issue-comment')
+  [ "$before" != "$after" ]
+}
+
+@test "P276 boundary: a word/content edit changes the key (review re-fires)" {
+  before=$(compute_external_comms_key 'The release is ready' 'gh-issue-comment')
+  after=$(compute_external_comms_key 'The release is delayed' 'gh-issue-comment')
+  [ "$before" != "$after" ]
+}
+
+# ---------- Surface binding + changeset frontmatter strip preserved ----------
+
+@test "P276: the surface remains part of the key (same body, different surface → different key)" {
+  a=$(compute_external_comms_key 'Same body text' 'gh-issue-comment')
+  b=$(compute_external_comms_key 'Same body text' 'gh-pr-comment')
+  [ "$a" != "$b" ]
+}
+
+@test "P276: changeset frontmatter strip still holds — full content keys equal the body-only key" {
+  body=$'Add the substance-aware normalization to the external-comms key.'
+  full=$'---\n"@windyroad/risk-scorer": patch\n---\n\n'"$body"
+  body_key=$(compute_external_comms_key "$body" 'changeset-author')
+  full_key=$(compute_external_comms_key "$full" 'changeset-author')
+  [ "$body_key" = "$full_key" ]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/risk-scorer",
-  "version": "0.13.0",
+  "version": "0.13.1-preview.709",
   "description": "Pipeline risk scoring, commit/push gates, and secret leak detection",
   "bin": {
     "windyroad-risk-scorer": "./bin/install.mjs"