@windyroad/jtbd 0.13.1 → 0.13.2

package/hooks/test/jtbd-mark-reviewed.bats

@@ -1,160 +0,0 @@
-#!/usr/bin/env bats
-
-# Tests for jtbd-mark-reviewed.sh — verifies the PostToolUse:Agent hook
-# creates session markers and stores the right policy-path hash when
-# wr-jtbd:agent (or legacy jtbd-lead) returns a PASS verdict.
-#
-# Per ADR-005 (P011): assertions are functional — execute the hook with
-# mock JSON, assert on side-effects (marker files, hash file contents).
-# Source-grep assertions for "the script mentions docs/jtbd" were
-# removed because they passed even when the surrounding code path was
-# unreachable.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/jtbd-mark-reviewed.sh"
-  ORIG_DIR="$PWD"
-  TEST_DIR=$(mktemp -d)
-  cd "$TEST_DIR"
-  SESSION_ID="test-session-$$"
-  MARKER="/tmp/jtbd-reviewed-${SESSION_ID}"
-  PLAN_MARKER="/tmp/jtbd-plan-reviewed-${SESSION_ID}"
-  HASH_FILE="/tmp/jtbd-reviewed-${SESSION_ID}.hash"
-  VERDICT_FILE="/tmp/jtbd-verdict"
-  rm -f "$MARKER" "$PLAN_MARKER" "$HASH_FILE" "$VERDICT_FILE"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$TEST_DIR"
-  rm -f "$MARKER" "$PLAN_MARKER" "$HASH_FILE" "$VERDICT_FILE"
-}
-
-# Helper: pipe a PostToolUse:Agent JSON to the hook for the given subagent.
-run_hook() {
-  local subagent="$1"
-  local json="{\"tool_input\":{\"subagent_type\":\"${subagent}\"},\"session_id\":\"${SESSION_ID}\"}"
-  echo "$json" | bash "$HOOK"
-}
-
-# --- Path support: docs/jtbd directory (preferred) ---
-
-@test "uses docs/jtbd directory when present (creates marker + hash)" {
-  mkdir -p docs/jtbd/solo-developer
-  echo "# Persona" > docs/jtbd/solo-developer/persona.md
-  echo "# Index" > docs/jtbd/README.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "wr-jtbd:agent"
-
-  [ -f "$MARKER" ]
-  [ -f "$HASH_FILE" ]
-  [ "$(cat "$HASH_FILE")" != "missing" ]
-  [ -n "$(cat "$HASH_FILE")" ]
-}
-
-@test "directory hash excludes README.md (only persona/job files contribute)" {
-  mkdir -p docs/jtbd
-  echo "# Index" > docs/jtbd/README.md
-  echo "PASS" > "$VERDICT_FILE"
-  run_hook "wr-jtbd:agent"
-  HASH_README_ONLY="$(cat "$HASH_FILE")"
-
-  rm -f "$HASH_FILE" "$MARKER"
-  echo "different content" >> docs/jtbd/README.md
-  echo "PASS" > "$VERDICT_FILE"
-  run_hook "wr-jtbd:agent"
-  HASH_README_CHANGED="$(cat "$HASH_FILE")"
-
-  # Changing README.md alone must not change the hash — README is excluded.
-  [ "$HASH_README_ONLY" = "$HASH_README_CHANGED" ]
-}
-
-# --- Path support: docs/jtbd/ is the sole canonical layout (ADR-008 Option 3, P019) ---
-
-@test "does NOT store a review hash when only legacy docs/JOBS_TO_BE_DONE.md exists (P019)" {
-  # Legacy single-file layout — the mark-reviewed hook must exit early
-  # without storing a hash, because the enforce hook cannot gate the
-  # project until it runs /wr-jtbd:update-guide to migrate to docs/jtbd/.
-  mkdir -p docs
-  echo "# Jobs" > docs/JOBS_TO_BE_DONE.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "wr-jtbd:agent"
-
-  # No marker, no hash file — the gate is inactive on legacy-layout projects.
-  [ ! -f "$MARKER" ]
-  [ ! -f "$HASH_FILE" ]
-}
-
-@test "hashes docs/jtbd/ when both layouts coexist (legacy single-file is ignored, P019)" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-  echo "# legacy jobs" > docs/JOBS_TO_BE_DONE.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "wr-jtbd:agent"
-
-  # The directory-derived hash must NOT equal the standalone-file hash —
-  # proves the hook did not consult the legacy file.
-  DIR_HASH="$(cat "$HASH_FILE")"
-  FILE_HASH=$(cat docs/JOBS_TO_BE_DONE.md \
-              | (md5sum 2>/dev/null || md5 -r 2>/dev/null || shasum 2>/dev/null) \
-              | cut -d' ' -f1)
-  [ "$DIR_HASH" != "$FILE_HASH" ]
-}
-
-# --- Verdict handling ---
-
-@test "FAIL verdict does NOT create review marker (but plan marker still set)" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-  echo "FAIL" > "$VERDICT_FILE"
-
-  run_hook "wr-jtbd:agent"
-
-  [ ! -f "$MARKER" ]
-  [ -f "$PLAN_MARKER" ]
-}
-
-@test "missing verdict file allows marker (backward compat)" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-
-  run_hook "wr-jtbd:agent"
-
-  [ -f "$MARKER" ]
-}
-
-@test "verdict file is consumed (removed) after hook runs" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "wr-jtbd:agent"
-
-  [ ! -f "$VERDICT_FILE" ]
-}
-
-# --- Subagent routing ---
-
-@test "ignores unrelated subagent (no marker created)" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "wr-architect:agent"
-
-  [ ! -f "$MARKER" ]
-  [ ! -f "$PLAN_MARKER" ]
-}
-
-@test "matches legacy jtbd-lead subagent name" {
-  mkdir -p docs/jtbd
-  echo "# job" > docs/jtbd/job.md
-  echo "PASS" > "$VERDICT_FILE"
-
-  run_hook "jtbd-lead"
-
-  [ -f "$MARKER" ]
-}

package/hooks/test/jtbd-marker-only-exempt.bats

@@ -1,140 +0,0 @@
-#!/usr/bin/env bats
-
-# P301: jtbd-enforce-edit.sh exempts marker-only frontmatter diffs to
-# docs/decisions/*.md ADRs from the JTBD review gate. The JTBD gate currently
-# fires on docs/decisions/ writes (decisions are not in its exclusion list);
-# the ticket's symptom "Batch 8 (ADR-020): blocked on architect review
-# (`jtbd policy file changed since last review`)" is that JTBD round-trip.
-#
-# Behavioural — exercises the full hook with constructed PreToolUse stdin
-# JSON payloads under a sandbox project dir; asserts on stdout+exit.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/jtbd-enforce-edit.sh"
-  ORIG_DIR="$PWD"
-  TEST_DIR=$(mktemp -d)
-  cd "$TEST_DIR"
-  # JTBD docs must exist for the gate to engage (otherwise it denies
-  # with "no JTBD documentation" — out of scope of this exemption test).
-  mkdir -p docs/jtbd/persona docs/decisions
-  echo "# stub job" > docs/jtbd/persona/JTBD-001-stub.proposed.md
-  echo "# stub adr" > docs/decisions/001-stub.proposed.md
-  SID="jtbd-marker-only-$$-$BATS_TEST_NUMBER"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$TEST_DIR"
-  rm -f "/tmp/jtbd-reviewed-${SID}" "/tmp/jtbd-reviewed-${SID}.hash"
-}
-
-run_hook_json() {
-  local json_file="$1"
-  bash "$HOOK" < "$json_file"
-}
-
-# ── Marker-only ADD: should exempt ───────────────────────────────────────
-
-@test "P301: Edit adding only human-oversight + oversight-date to ADR is exempt (no JTBD marker required)" {
-  adr="$PWD/docs/decisions/100-some-adr.proposed.md"
-  cat > "$adr" <<'EOF'
----
-status: "proposed"
----
-
-# 100 some adr
-EOF
-  old=$'---\nstatus: "proposed"\n---'
-  new=$'---\nstatus: "proposed"\nhuman-oversight: unconfirmed\noversight-date: 2026-06-08\n---'
-  json_file=$(mktemp)
-  jq -nc --arg p "$adr" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}' > "$json_file"
-  run run_hook_json "$json_file"
-  rm -f "$json_file"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "P301: Edit updating human-oversight value (unconfirmed → confirmed) on ADR is exempt" {
-  adr="$PWD/docs/decisions/101-promote.proposed.md"
-  cat > "$adr" <<'EOF'
----
-status: "proposed"
-human-oversight: unconfirmed
----
-
-# 101
-EOF
-  old=$'human-oversight: unconfirmed'
-  new=$'human-oversight: confirmed\noversight-date: 2026-06-08'
-  json_file=$(mktemp)
-  jq -nc --arg p "$adr" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}' > "$json_file"
-  run run_hook_json "$json_file"
-  rm -f "$json_file"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# ── Mixed marker + body: must NOT exempt ─────────────────────────────────
-
-@test "P301: Edit changing body content along with markers still gates" {
-  adr="$PWD/docs/decisions/110-mixed.proposed.md"
-  cat > "$adr" <<'EOF'
----
-status: "proposed"
----
-
-# 110
-
-Original body.
-EOF
-  old=$'---\nstatus: "proposed"\n---\n\n# 110\n\nOriginal body.'
-  new=$'---\nstatus: "proposed"\nhuman-oversight: confirmed\noversight-date: 2026-06-08\n---\n\n# 110\n\nNew policy claim added.'
-  json_file=$(mktemp)
-  jq -nc --arg p "$adr" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}' > "$json_file"
-  run run_hook_json "$json_file"
-  rm -f "$json_file"
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-# ── Pure body change: must still gate ────────────────────────────────────
-
-@test "P301: Edit changing only body content with no marker lines still gates" {
-  adr="$PWD/docs/decisions/120-body.proposed.md"
-  cat > "$adr" <<'EOF'
----
-status: "proposed"
----
-
-# 120
-
-Some text.
-EOF
-  old='Some text.'
-  new='Some text. And more.'
-  json_file=$(mktemp)
-  jq -nc --arg p "$adr" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}' > "$json_file"
-  run run_hook_json "$json_file"
-  rm -f "$json_file"
-  [[ "$output" == *"BLOCKED"* ]]
-}
-
-# ── Scope: exemption is narrow to docs/decisions/*.md ────────────────────
-
-@test "P301: marker-only diff to a NON docs/decisions/ path still gates (no path exemption)" {
-  mkdir -p "$PWD/src"
-  echo "// stub" > "$PWD/src/x.ts"
-  src="$PWD/src/x.ts"
-  old='// stub'
-  new=$'// stub\nhuman-oversight: confirmed'
-  json_file=$(mktemp)
-  jq -nc --arg p "$src" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}' > "$json_file"
-  run run_hook_json "$json_file"
-  rm -f "$json_file"
-  [[ "$output" == *"BLOCKED"* ]]
-}

package/hooks/test/jtbd-no-stop-hook.bats

@@ -1,15 +0,0 @@
-#!/usr/bin/env bats
-
-# P001 / ADR-009: Stop-hook marker reset removed.
-
-setup() {
-  PLUGIN_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/../.." && pwd)"
-}
-
-@test "jtbd: hooks.json has no Stop hook entry (ADR-009)" {
-  ! grep -q '"Stop"' "$PLUGIN_DIR/hooks/hooks.json"
-}
-
-@test "jtbd: jtbd-reset-marker.sh has been removed" {
-  [ ! -f "$PLUGIN_DIR/hooks/jtbd-reset-marker.sh" ]
-}

package/hooks/test/jtbd-oversight-marker-discipline.bats

@@ -1,216 +0,0 @@
-#!/usr/bin/env bats
-
-# P348 / ADR-068 amendment 2026-06-02: jtbd-oversight-marker-discipline.sh
-# is the JTBD-side sibling of architect-oversight-marker-discipline.sh.
-# Denies Edit/Write that introduces `human-oversight: confirmed` into a
-# docs/jtbd/ artefact's frontmatter unless a session-scoped evidence marker
-# proves the user has substance-confirmed THAT artefact.
-#
-# Behavioural — exercises the hook with constructed PreToolUse stdin JSON
-# payloads under SESSION_MARKER_DIR sandboxing.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/jtbd/hooks/jtbd-oversight-marker-discipline.sh"
-  MARK_SCRIPT="$REPO_ROOT/packages/jtbd/scripts/mark-oversight-confirmed.sh"
-
-  DIR="$(mktemp -d)"
-  mkdir -p "$DIR/docs/jtbd/developer"
-  MARK_DIR="$(mktemp -d)"
-  export SESSION_MARKER_DIR="$MARK_DIR"
-
-  ORIG_DIR="$PWD"
-  cd "$DIR"
-
-  SID="jtbd-discipline-test-$$"
-}
-
-teardown() {
-  cd "$ORIG_DIR"
-  rm -rf "$DIR" "$MARK_DIR"
-  unset SESSION_MARKER_DIR
-}
-
-expected_marker() {
-  local f="$1"
-  local abs_dir abs path_hash
-  abs_dir="$(cd "$(dirname "$f")" && pwd)"
-  abs="$abs_dir/$(basename "$f")"
-  if command -v sha256sum >/dev/null 2>&1; then
-    path_hash=$(printf '%s' "$abs" | sha256sum | cut -d' ' -f1 | cut -c1-16)
-  else
-    path_hash=$(printf '%s' "$abs" | shasum -a 256 | cut -d' ' -f1 | cut -c1-16)
-  fi
-  printf '%s/oversight-confirmed-%s-%s\n' "$MARK_DIR" "$path_hash" "$SID"
-}
-
-mk_existing_artefact() {
-  local subpath="$1"; shift
-  local dir
-  dir="$(dirname "$DIR/docs/jtbd/$subpath")"
-  mkdir -p "$dir"
-  {
-    echo "---"
-    echo "status: \"proposed\""
-    echo "date: 2026-06-02"
-    for line in "$@"; do echo "$line"; done
-    echo "---"
-    echo "# $(basename "$subpath" .md)"
-  } > "$DIR/docs/jtbd/$subpath"
-}
-
-# ── Positive paths ───────────────────────────────────────────────────────
-
-@test "Write introducing 'human-oversight: confirmed' to a JTBD with marker present is allowed" {
-  mk_existing_artefact "developer/JTBD-300-test.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-300-test.proposed.md"
-  : > "$(expected_marker "$art")"
-  new_content=$'---\nstatus: "proposed"\ndate: 2026-06-02\nhuman-oversight: confirmed\noversight-date: 2026-06-02\n---\n\n# JTBD-300\n'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg c "$new_content" \
-    '{tool_name:"Write",session_id:$s,tool_input:{file_path:$p,content:$c}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "Edit to a persona introducing the marker with evidence is allowed" {
-  mk_existing_artefact "developer/persona.md"
-  art="$DIR/docs/jtbd/developer/persona.md"
-  : > "$(expected_marker "$art")"
-  old='date: 2026-06-02'
-  new=$'date: 2026-06-02\nhuman-oversight: confirmed\noversight-date: 2026-06-02'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# ── Negative paths ───────────────────────────────────────────────────────
-
-@test "Write introducing 'human-oversight: confirmed' to a JTBD WITHOUT marker is denied" {
-  mk_existing_artefact "developer/JTBD-310-orphan.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-310-orphan.proposed.md"
-  new_content=$'---\nstatus: "proposed"\ndate: 2026-06-02\nhuman-oversight: confirmed\noversight-date: 2026-06-02\n---\n\n# JTBD-310\n'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg c "$new_content" \
-    '{tool_name:"Write",session_id:$s,tool_input:{file_path:$p,content:$c}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *'"permissionDecision": "deny"'* ]]
-  [[ "$output" == *"BLOCKED"* ]]
-  [[ "$output" == *"wr-jtbd-mark-oversight-confirmed"* ]]
-  [[ "$output" == *"/wr-jtbd:confirm-jobs-and-personas"* ]]
-}
-
-@test "Edit introducing the marker to persona WITHOUT marker is denied" {
-  mk_existing_artefact "tech-lead/persona.md"
-  art="$DIR/docs/jtbd/tech-lead/persona.md"
-  old='date: 2026-06-02'
-  new=$'date: 2026-06-02\nhuman-oversight: confirmed'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg o "$old" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:$o,new_string:$n}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [[ "$output" == *'"permissionDecision": "deny"'* ]]
-}
-
-# ── AFK-unconfirmed-write ────────────────────────────────────────────────
-
-@test "Write introducing 'human-oversight: unconfirmed' is allowed without marker (AFK path)" {
-  mk_existing_artefact "developer/JTBD-320-afk.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-320-afk.proposed.md"
-  new_content=$'---\nstatus: "proposed"\ndate: 2026-06-02\nhuman-oversight: unconfirmed\n---\n\n# JTBD-320-afk\n'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg c "$new_content" \
-    '{tool_name:"Write",session_id:$s,tool_input:{file_path:$p,content:$c}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# ── Scope / non-fire paths ───────────────────────────────────────────────
-
-@test "Edit to a non-JTBD path exits 0 silently even with the marker line" {
-  mkdir -p "$DIR/src"
-  echo "// stub" > "$DIR/src/foo.ts"
-  json=$(jq -nc --arg p "$DIR/src/foo.ts" --arg s "$SID" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:"// stub",new_string:"// human-oversight: confirmed"}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "Edit to docs/jtbd/README.md exits 0 silently" {
-  echo "# index" > "$DIR/docs/jtbd/README.md"
-  art="$DIR/docs/jtbd/README.md"
-  new=$'# index\nhuman-oversight: confirmed'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg n "$new" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:"# index",new_string:$n}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "Edit whose new content lacks the marker exits 0 silently" {
-  mk_existing_artefact "developer/JTBD-330-rename.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-330-rename.proposed.md"
-  json=$(jq -nc --arg p "$art" --arg s "$SID" \
-    '{tool_name:"Edit",session_id:$s,tool_input:{file_path:$p,old_string:"# JTBD-330-rename",new_string:"# JTBD-330 renamed"}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── End-to-end ───────────────────────────────────────────────────────────
-
-@test "mark-oversight-confirmed.sh writes a marker that satisfies the JTBD hook" {
-  mk_existing_artefact "developer/JTBD-340-e2e.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-340-e2e.proposed.md"
-  : > "$MARK_DIR/jtbd-announced-$SID"
-  bash "$MARK_SCRIPT" "$art"
-  [ -f "$(expected_marker "$art")" ]
-  new_content=$'---\nstatus: "proposed"\ndate: 2026-06-02\nhuman-oversight: confirmed\noversight-date: 2026-06-02\n---\n\n# JTBD-340-e2e\n'
-  json=$(jq -nc --arg p "$art" --arg s "$SID" --arg c "$new_content" \
-    '{tool_name:"Write",session_id:$s,tool_input:{file_path:$p,content:$c}}')
-  run bash -c "echo '$(echo "$json" | sed "s/'/'\\\\''/g")' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# P380: on macOS SESSION_MARKER_DIR defaults to /tmp, a symlink to /private/tmp.
-# `find <symlink> -maxdepth 1` in default (-P) mode refuses to descend the
-# start-point symlink, so candidate enumeration returns empty and the script
-# writes ZERO markers (silent cold-path exit 0). The `-L` flag follows it. This
-# test points SESSION_MARKER_DIR at a SYMLINK to the marker dir (reproducing the
-# macOS /tmp shape on any platform); RED without `-L`, GREEN with it.
-@test "mark-oversight-confirmed.sh enumerates candidates when SESSION_MARKER_DIR is a symlink (P380)" {
-  mk_existing_artefact "developer/JTBD-341-symlink.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-341-symlink.proposed.md"
-  : > "$MARK_DIR/jtbd-announced-$SID"
-  link_dir="${MARK_DIR}.link"
-  ln -s "$MARK_DIR" "$link_dir"
-  SESSION_MARKER_DIR="$link_dir" bash "$MARK_SCRIPT" "$art"
-  rm -f "$link_dir"
-  [ -f "$(expected_marker "$art")" ]
-}
-
-# P368: genuine cold path — no CLAUDE_SESSION_ID and no announce markers at all.
-# The shim correctly writes zero markers but must NOT do so SILENTLY: a loud
-# stderr diagnostic explains why the subsequent discipline-hook deny happens,
-# breaking the confusing "you didn't run the shim" loop. Exit stays 0 (contract:
-# do not crash SKILL flows before any hook has fired this session).
-@test "mark-oversight-confirmed.sh emits a loud stderr diagnostic on the no-candidate cold path (P368)" {
-  mk_existing_artefact "developer/JTBD-342-coldpath.proposed.md"
-  art="$DIR/docs/jtbd/developer/JTBD-342-coldpath.proposed.md"
-  run env -u CLAUDE_SESSION_ID bash "$MARK_SCRIPT" "$art"
-  [ "$status" -eq 0 ]                              # contract: cold path still exits 0
-  [ ! -f "$(expected_marker "$art")" ]             # no marker written
-  [[ "$output" == *"no candidate session id"* ]]   # loud, not silent
-  [[ "$output" == *"P368"* ]]
-}
-
-@test "tool_name=Bash exits 0 silently regardless of file path" {
-  json=$(jq -nc --arg s "$SID" \
-    '{tool_name:"Bash",session_id:$s,tool_input:{command:"echo human-oversight: confirmed"}}')
-  run bash -c "echo '$json' | bash '$HOOK'"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}

package/hooks/test/jtbd-oversight-nudge.bats

@@ -1,74 +0,0 @@
-#!/usr/bin/env bats
-
-# ADR-068: jtbd-oversight-nudge.sh (SessionStart) emits a one-line nudge when
-# jobs/personas lack the human-oversight marker, is silent when none do, and
-# self-suppresses under the shared AFK guard (WR_SUPPRESS_OVERSIGHT_NUDGE=1).
-# Behavioural — exercises the hook against fixture docs/jtbd/ trees.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
-  HOOK="$REPO_ROOT/packages/jtbd/hooks/jtbd-oversight-nudge.sh"
-  PLUGIN_ROOT="$REPO_ROOT/packages/jtbd"
-  DIR="$(mktemp -d)"
-  mkdir -p "$DIR/docs/jtbd/solo-developer"
-  # Hermeticity (P391): the AFK work-problems orchestrator exports
-  # WR_SUPPRESS_OVERSIGHT_NUDGE=1, which the hook self-suppresses on. Unset it so
-  # count-emitting tests assert real behaviour; guard-specific tests set it
-  # per-invocation via `run env WR_SUPPRESS_OVERSIGHT_NUDGE=...`.
-  unset WR_SUPPRESS_OVERSIGHT_NUDGE
-}
-
-teardown() { rm -rf "$DIR"; }
-
-mk_unmarked() {
-  mkdir -p "$(dirname "$DIR/docs/jtbd/$1")"
-  { echo "---"; echo "status: proposed"; echo "date-created: 2026-05-25"; echo "---"; echo "# $1"; } \
-    > "$DIR/docs/jtbd/$1"
-}
-mk_marked() {
-  mkdir -p "$(dirname "$DIR/docs/jtbd/$1")"
-  { echo "---"; echo "status: proposed"; echo "human-oversight: confirmed"; echo "---"; echo "# $1"; } \
-    > "$DIR/docs/jtbd/$1"
-}
-
-@test "emits a count line when there are unoversighted jobs/personas" {
-  mk_unmarked "solo-developer/persona.md"
-  mk_unmarked "solo-developer/JTBD-001-foo.proposed.md"
-  run env CLAUDE_PROJECT_DIR="$DIR" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"2 jobs/personas lack human oversight"* ]]
-  [[ "$output" == *"/wr-jtbd:confirm-jobs-and-personas"* ]]
-}
-
-@test "uses singular wording for exactly one unoversighted artifact" {
-  mk_unmarked "solo-developer/persona.md"
-  run env CLAUDE_PROJECT_DIR="$DIR" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [[ "$output" == *"1 job/persona lacks human oversight"* ]]
-}
-
-@test "silent when every job/persona is confirmed" {
-  mk_marked "solo-developer/persona.md"
-  run env CLAUDE_PROJECT_DIR="$DIR" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "shared AFK guard suppresses the nudge entirely" {
-  mk_unmarked "solo-developer/persona.md"
-  run env WR_SUPPRESS_OVERSIGHT_NUDGE=1 CLAUDE_PROJECT_DIR="$DIR" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "guard value other than 1 does not suppress" {
-  mk_unmarked "solo-developer/persona.md"
-  mk_unmarked "solo-developer/JTBD-001-foo.proposed.md"
-  run env WR_SUPPRESS_OVERSIGHT_NUDGE=0 CLAUDE_PROJECT_DIR="$DIR" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [[ "$output" == *"lack human oversight"* ]]
-}
-
-@test "silent when project has no docs/jtbd dir" {
-  run env CLAUDE_PROJECT_DIR="$DIR/empty" CLAUDE_PLUGIN_ROOT="$PLUGIN_ROOT" bash "$HOOK"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}

package/hooks/test/jtbd-project-root.bats

@@ -1,60 +0,0 @@
-#!/usr/bin/env bats
-
-# P004: jtbd-enforce-edit.sh project-root check.
-
-setup() {
-  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  HOOK="$SCRIPT_DIR/jtbd-enforce-edit.sh"
-}
-
-run_hook_with_file() {
-  local file_path="$1"
-  local json="{\"tool_input\":{\"file_path\":\"${file_path}\"},\"session_id\":\"test-$$\"}"
-  echo "$json" | bash "$HOOK"
-}
-
-@test "jtbd project-root: absolute path outside project exits 0" {
-  run run_hook_with_file "/Users/other/somewhere/file.json"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-@test "jtbd project-root: home-dir config path exits 0" {
-  run run_hook_with_file "/Users/somebody/.claude/channels/discord/access.json"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"BLOCKED"* ]]
-}
-
-# P191: the gate must resolve docs/jtbd from the project root
-# (CLAUDE_PROJECT_DIR), NOT the hook's actual runtime CWD. Claude Code can
-# launch the hook with a working directory that differs from the session/
-# project dir; a relative `[ -d "docs/jtbd" ]` then false-negatives and the
-# fail-closed "no JTBD documentation" branch blocks legitimate edits even
-# though docs/jtbd is present.
-@test "jtbd project-root: detects docs/jtbd via CLAUDE_PROJECT_DIR when hook CWD differs (P191)" {
-  local proj other json
-  proj="$(mktemp -d)"
-  other="$(mktemp -d)"        # a CWD that does NOT contain docs/jtbd
-  mkdir -p "$proj/docs/jtbd"
-  echo "# job" > "$proj/docs/jtbd/JTBD-001-x.md"
-  json="{\"tool_input\":{\"file_path\":\"${proj}/packages/x/foo.sh\"},\"session_id\":\"test-$$\"}"
-  # Fire the hook from `other` (wrong CWD) but with CLAUDE_PROJECT_DIR set to
-  # the real project. Pre-fix this emitted "no JTBD documentation exists";
-  # post-fix the gate is ACTIVE and denies for the missing review marker.
-  run env CLAUDE_PROJECT_DIR="$proj" bash -c "cd '$other' && printf '%s' '$json' | bash '$HOOK'"
-  rm -rf "$proj" "$other"
-  [[ "$output" != *"no JTBD documentation exists"* ]]
-  [[ "$output" == *"without JTBD review"* ]]
-}
-
-# P191 regression guard: when docs/jtbd genuinely does not exist under the
-# project root, the fail-closed "no JTBD documentation" deny is preserved
-# (the fix narrows the false-negative; it must not silence true-absence).
-@test "jtbd project-root: genuinely-absent docs/jtbd still denies (fail-closed preserved, P191)" {
-  local proj json
-  proj="$(mktemp -d)"         # no docs/jtbd created
-  json="{\"tool_input\":{\"file_path\":\"${proj}/foo.sh\"},\"session_id\":\"test-$$\"}"
-  run env CLAUDE_PROJECT_DIR="$proj" bash -c "printf '%s' '$json' | bash '$HOOK'"
-  rm -rf "$proj"
-  [[ "$output" == *"no JTBD documentation exists"* ]]
-}