@windyroad/jtbd 0.12.0 → 0.12.1-preview.563

package/.claude-plugin/plugin.json

@@ -90,5 +90,5 @@
     }
   },
   "name": "wr-jtbd",
-  "version": "0.12.0"
+  "version": "0.12.1"
 }

package/hooks/jtbd-enforce-edit.sh

@@ -10,6 +10,16 @@
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 source "$SCRIPT_DIR/lib/review-gate.sh"
 
+# P191: resolve the project root from the session signal, not the hook's
+# runtime CWD. Claude Code may launch the hook with an actual working
+# directory that differs from the session/project dir while still exporting
+# CLAUDE_PROJECT_DIR (and a $PWD env var) pointing at the project. A relative
+# `[ -d "docs/jtbd" ]` then false-negatives even though docs/jtbd is present,
+# tripping the fail-closed "no JTBD documentation" deny on legitimate edits.
+# Anchor every project-relative check on PROJECT_DIR. Pattern mirrors
+# jtbd-oversight-nudge.sh.
+PROJECT_DIR="${CLAUDE_PROJECT_DIR:-$PWD}"
+
 INPUT=$(cat)
 
 FILE_PATH=$(echo "$INPUT" | python3 -c "
@@ -44,7 +54,7 @@ fi
 case "$FILE_PATH" in
   /*)
     case "$FILE_PATH" in
-      "$PWD"/*) ;;
+      "$PROJECT_DIR"/*) ;;
       *) exit 0 ;;
     esac
     ;;
@@ -107,8 +117,8 @@ esac
 # Legacy docs/JOBS_TO_BE_DONE.md is NOT consulted at runtime; the gate is
 # inactive on projects that have not run /wr-jtbd:update-guide.
 JTBD_PATH=""
-if [ -d "docs/jtbd" ]; then
-  JTBD_PATH="docs/jtbd"
+if [ -d "$PROJECT_DIR/docs/jtbd" ]; then
+  JTBD_PATH="$PROJECT_DIR/docs/jtbd"
 fi
 
 # If no JTBD docs exist, block and direct to create skill

package/hooks/jtbd-mark-reviewed.sh

@@ -7,6 +7,12 @@
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 source "$SCRIPT_DIR/lib/review-gate.sh"
 
+# P191: anchor the docs/jtbd detection on the project root, not the hook's
+# runtime CWD (see jtbd-enforce-edit.sh for the full rationale). If this
+# marker-write side false-negatives on docs/jtbd it never stores the marker,
+# and the enforce gate then denies the next edit for lack of a marker.
+PROJECT_DIR="${CLAUDE_PROJECT_DIR:-$PWD}"
+
 INPUT=$(cat)
 
 SUBAGENT=$(echo "$INPUT" | jq -r '.tool_input.subagent_type // empty') || true
@@ -19,10 +25,10 @@ fi
 # Canonical JTBD path — directory only (ADR-008 Option 3). If the
 # directory doesn't exist the marker is not stored; the gate will
 # surface a "run update-guide" recommendation on the next edit.
-if [ ! -d "docs/jtbd" ]; then
+if [ ! -d "$PROJECT_DIR/docs/jtbd" ]; then
   exit 0
 fi
-JTBD_PATH="docs/jtbd"
+JTBD_PATH="$PROJECT_DIR/docs/jtbd"
 
 case "$SUBAGENT" in
   *jtbd-lead*|*wr-jtbd*)

package/hooks/test/jtbd-project-root.bats

@@ -24,3 +24,37 @@ run_hook_with_file() {
   [ "$status" -eq 0 ]
   [[ "$output" != *"BLOCKED"* ]]
 }
+
+# P191: the gate must resolve docs/jtbd from the project root
+# (CLAUDE_PROJECT_DIR), NOT the hook's actual runtime CWD. Claude Code can
+# launch the hook with a working directory that differs from the session/
+# project dir; a relative `[ -d "docs/jtbd" ]` then false-negatives and the
+# fail-closed "no JTBD documentation" branch blocks legitimate edits even
+# though docs/jtbd is present.
+@test "jtbd project-root: detects docs/jtbd via CLAUDE_PROJECT_DIR when hook CWD differs (P191)" {
+  local proj other json
+  proj="$(mktemp -d)"
+  other="$(mktemp -d)"        # a CWD that does NOT contain docs/jtbd
+  mkdir -p "$proj/docs/jtbd"
+  echo "# job" > "$proj/docs/jtbd/JTBD-001-x.md"
+  json="{\"tool_input\":{\"file_path\":\"${proj}/packages/x/foo.sh\"},\"session_id\":\"test-$$\"}"
+  # Fire the hook from `other` (wrong CWD) but with CLAUDE_PROJECT_DIR set to
+  # the real project. Pre-fix this emitted "no JTBD documentation exists";
+  # post-fix the gate is ACTIVE and denies for the missing review marker.
+  run env CLAUDE_PROJECT_DIR="$proj" bash -c "cd '$other' && printf '%s' '$json' | bash '$HOOK'"
+  rm -rf "$proj" "$other"
+  [[ "$output" != *"no JTBD documentation exists"* ]]
+  [[ "$output" == *"without JTBD review"* ]]
+}
+
+# P191 regression guard: when docs/jtbd genuinely does not exist under the
+# project root, the fail-closed "no JTBD documentation" deny is preserved
+# (the fix narrows the false-negative; it must not silence true-absence).
+@test "jtbd project-root: genuinely-absent docs/jtbd still denies (fail-closed preserved, P191)" {
+  local proj json
+  proj="$(mktemp -d)"         # no docs/jtbd created
+  json="{\"tool_input\":{\"file_path\":\"${proj}/foo.sh\"},\"session_id\":\"test-$$\"}"
+  run env CLAUDE_PROJECT_DIR="$proj" bash -c "printf '%s' '$json' | bash '$HOOK'"
+  rm -rf "$proj"
+  [[ "$output" == *"no JTBD documentation exists"* ]]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/jtbd",
-  "version": "0.12.0",
+  "version": "0.12.1-preview.563",
   "description": "Jobs-to-be-done enforcement for UI changes",
   "bin": {
     "windyroad-jtbd": "./bin/install.mjs"