@windyroad/jtbd 0.1.3 → 0.2.0-preview.32

package/hooks/jtbd-enforce-edit.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 # JTBD - PreToolUse enforcement hook
-# BLOCKS Edit/Write to UI files until jtbd-lead is consulted.
+# BLOCKS Edit/Write to project files until jtbd-lead is consulted.
 # Uses shared review-gate.sh for TTL, drift detection, and fail-closed.
 
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
@@ -35,14 +35,36 @@ if [ -z "$FILE_PATH" ]; then
   exit 0
 fi
 
-# Gate UI component and route files
+BASENAME=$(basename "$FILE_PATH")
+
+# Exclude non-JTBD files (matches architect gate exclusions)
 case "$FILE_PATH" in
-  *.html|*.jsx|*.tsx|*.vue|*.svelte|*.ejs|*.hbs) ;;
-  *) exit 0 ;;
+  *.css|*.scss|*.sass|*.less)
+    exit 0 ;;
+  *.png|*.jpg|*.jpeg|*.gif|*.svg|*.ico|*.webp)
+    exit 0 ;;
+  *.woff|*.woff2|*.ttf|*.eot)
+    exit 0 ;;
+  *package-lock.json|*yarn.lock|*pnpm-lock.yaml)
+    exit 0 ;;
+  *.map)
+    exit 0 ;;
+  *.changeset/*.md|*/.changeset/*.md)
+    exit 0 ;;
+  */MEMORY.md|*/.claude/projects/*/memory/*)
+    exit 0 ;;
+  */.claude/plans/*.md|*.claude/plans/*.md)
+    exit 0 ;;
+  */RISK-POLICY.md)
+    exit 0 ;;
+  */.risk-reports/*)
+    exit 0 ;;
+  */docs/BRIEFING.md|docs/BRIEFING.md)
+    exit 0 ;;
+  */docs/problems/*.md|docs/problems/*.md)
+    exit 0 ;;
 esac
 
-BASENAME=$(basename "$FILE_PATH")
-
 # If no JTBD doc exists, block and direct to create skill
 if [ ! -f "docs/JOBS_TO_BE_DONE.md" ]; then
   review_gate_deny "BLOCKED: Cannot edit '${BASENAME}' because docs/JOBS_TO_BE_DONE.md does not exist. Run /wr-jtbd:update-guide to generate a JTBD document for this project, then delegate to wr-jtbd:agent for review."

package/hooks/jtbd-eval.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 # JTBD - UserPromptSubmit hook
 # Detects JOBS_TO_BE_DONE.md in the project and injects delegation instruction.
-# If the file doesn't exist, instructs Claude to create it via the agent.
+# If the file doesn't exist, instructs Claude to create it via the update-guide skill.
 
 if [ -f "docs/JOBS_TO_BE_DONE.md" ]; then
   cat <<'HOOK_OUTPUT'
@@ -9,27 +9,24 @@ INSTRUCTION: MANDATORY JTBD CHECK. YOU MUST FOLLOW THIS.
 DETECTED: docs/JOBS_TO_BE_DONE.md exists in this project.
 
 This is a NON-OPTIONAL instruction. You MUST use the jtbd-lead agent
-before editing any user-facing UI file (.html, .jsx, .tsx, .vue, .svelte, .ejs, .hbs).
-This is proactive. Do not wait for the user to ask.
+before editing any project file. This is proactive. Do not wait for the
+user to ask.
 
 REQUIRED ACTIONS:
 1. Use the Agent tool to delegate to wr-jtbd:agent
    (subagent_type: "wr-jtbd:agent")
 2. The jtbd-lead will review proposed changes against docs/JOBS_TO_BE_DONE.md
    and PRODUCT_DISCOVERY.md persona definitions
-3. Do NOT write or edit UI code without jtbd-lead review FIRST
+3. Do NOT write or edit project files without jtbd-lead review FIRST
 4. Do NOT skip this step even if you think you can handle it yourself
 
-SCOPE: User-facing files (.html, .jsx, .tsx, .vue, .svelte, .ejs, .hbs).
-Does NOT apply to: .css files, .ts/.js backend files, config files.
+SCOPE: All project files.
+Does NOT apply to: CSS, images, fonts, lockfiles, changesets, memory files, plan files.
 HOOK_OUTPUT
 else
-  # Check if this is a web project (has UI files)
-  if ls src/**/*.tsx src/**/*.jsx src/**/*.html 2>/dev/null | head -1 | grep -q .; then
-    cat <<'HOOK_OUTPUT'
-NOTE: This project has UI files but no docs/JOBS_TO_BE_DONE.md.
-If the user's task involves editing UI files, the edit will be blocked
-until a JTBD document exists. Run /wr-jtbd:update-guide to generate one.
+  cat <<'HOOK_OUTPUT'
+NOTE: This project has no docs/JOBS_TO_BE_DONE.md.
+Edits to project files will be blocked until a JTBD document exists.
+Run /wr-jtbd:update-guide to generate one.
 HOOK_OUTPUT
-  fi
 fi

package/hooks/test/jtbd-enforce-scope.bats

@@ -0,0 +1,57 @@
+#!/usr/bin/env bats
+
+# Tests for jtbd-enforce-edit.sh — verifies broadened scope with exclusions
+
+setup() {
+  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  HOOK="$SCRIPT_DIR/jtbd-enforce-edit.sh"
+}
+
+# Helper: check if a file extension is in the exclusion list by grepping the hook
+file_is_excluded() {
+  local pattern="$1"
+  # The hook should have a case statement that exits 0 for excluded files
+  grep -q "$pattern" "$HOOK"
+}
+
+@test "enforce: excludes CSS files" {
+  file_is_excluded '\.css'
+}
+
+@test "enforce: excludes image files" {
+  file_is_excluded '\.png'
+}
+
+@test "enforce: excludes font files" {
+  file_is_excluded '\.woff'
+}
+
+@test "enforce: excludes lockfiles" {
+  file_is_excluded 'package-lock.json'
+}
+
+@test "enforce: excludes changeset files" {
+  file_is_excluded '\.changeset'
+}
+
+@test "enforce: excludes memory files" {
+  file_is_excluded 'MEMORY.md'
+}
+
+@test "enforce: excludes plan files" {
+  file_is_excluded '\.claude/plans'
+}
+
+@test "enforce: excludes risk reports" {
+  file_is_excluded '\.risk-reports'
+}
+
+@test "enforce: excludes RISK-POLICY.md" {
+  file_is_excluded 'RISK-POLICY.md'
+}
+
+@test "enforce: does NOT have UI-only case guard" {
+  # The old guard matched only UI extensions then exited for everything else.
+  # The new hook should NOT exit 0 for all non-UI files.
+  ! grep -q '\*) exit 0 ;;' "$HOOK"
+}

package/hooks/test/jtbd-eval.bats

@@ -0,0 +1,46 @@
+#!/usr/bin/env bats
+
+# Tests for jtbd-eval.sh — verifies JTBD suggestion fires for any project
+
+setup() {
+  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  HOOK="$SCRIPT_DIR/jtbd-eval.sh"
+  ORIG_DIR="$PWD"
+  TEST_DIR=$(mktemp -d)
+  cd "$TEST_DIR"
+}
+
+teardown() {
+  cd "$ORIG_DIR"
+  rm -rf "$TEST_DIR"
+}
+
+@test "eval: suggests update-guide when JOBS_TO_BE_DONE.md missing (no UI files)" {
+  # No UI files, no docs — should still suggest
+  run bash "$HOOK"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"wr-jtbd:update-guide"* ]]
+}
+
+@test "eval: suggests update-guide when JOBS_TO_BE_DONE.md missing (with UI files)" {
+  mkdir -p src
+  touch src/App.tsx
+  run bash "$HOOK"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"wr-jtbd:update-guide"* ]]
+}
+
+@test "eval: injects enforcement instruction when JOBS_TO_BE_DONE.md exists" {
+  mkdir -p docs
+  echo "# Jobs" > docs/JOBS_TO_BE_DONE.md
+  run bash "$HOOK"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"MANDATORY JTBD CHECK"* ]]
+}
+
+@test "eval: does not reference UI-only scoping in output" {
+  run bash "$HOOK"
+  [ "$status" -eq 0 ]
+  # Should not contain the old UI-only messaging
+  [[ "$output" != *"UI files"* ]]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/jtbd",
-  "version": "0.1.3",
+  "version": "0.2.0-preview.32",
   "description": "Jobs-to-be-done enforcement for UI changes",
   "bin": {
     "windyroad-jtbd": "./bin/install.mjs"