@windyroad/itil 0.56.3 → 0.57.0-preview.923

package/.claude-plugin/plugin.json

@@ -497,5 +497,5 @@
     }
   },
   "name": "wr-itil",
-  "version": "0.56.3"
+  "version": "0.57.0"
 }

package/hooks/hooks.json

@@ -59,6 +59,10 @@
         "matcher": "Bash",
         "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-commit-trailer-transition-advisory.sh" }]
       },
+      {
+        "matcher": "Bash",
+        "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-fix-title-lifecycle-advisory.sh" }]
+      },
       {
         "matcher": "Write|Edit|MultiEdit",
         "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-fictional-defer-detect.sh" }]

package/hooks/itil-fix-title-lifecycle-advisory.sh

@@ -0,0 +1,72 @@
+#!/bin/bash
+# wr-itil — PostToolUse:Bash hook (P345/RFC-044/STORY-038). Detects the
+# fix-without-paired-lifecycle-transition drift: a just-landed commit whose
+# subject is fix-typed (`fix: ...` / `fix(<pkg>): ...`) and names P<NNN>
+# ticket(s) that are still in `docs/problems/open/` — i.e. the commit claims
+# to fix a ticket but carried no Open -> Known Error (or -> Verifying)
+# transition in the same grain. The ticket then ages across release + CI
+# verification until a catch-up cadence notices (P345; P334 witness chain).
+#
+# ADVISORY-ONLY per ADR-092: Open -> Known Error asserts a knowledge claim
+# (root cause known + workaround documented) that a fix-titled commit does
+# NOT establish, so this hook must never auto-fire the transition and never
+# block the commit. The hook DETECTS and ADVISES; a skill
+# (/wr-itil:transition-problem) — or the human — PERFORMS the transition
+# (ADR-014 hook-detects-skill-commits grain). Sibling (copy-and-retarget) of
+# itil-commit-trailer-transition-advisory.sh (P378): different signal —
+# commit-title P<NNN> tokens vs Refs: trailers.
+#
+# Advisory-only (ADR-013 Rule 6 fail-open; ADR-045 ≤300-byte TOTAL emission
+# even with multiple named tickets; exit 0 on every path).
+# Bypass: BYPASS_FIX_TITLE_LIFECYCLE_ADVISORY=1.
+#
+# @adr ADR-092 (advisory-only posture + binding rule) ADR-014 (hook detects,
+#      skill commits) ADR-045 (budget) ADR-013 (Rule 6 fail-open) ADR-052 (bats)
+# @problem P345  @rfc RFC-044  @story STORY-038
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+# shellcheck source=lib/command-detect.sh
+source "$SCRIPT_DIR/lib/command-detect.sh"
+
+INPUT=$(cat)
+TOOL_NAME=$(printf '%s' "$INPUT" | python3 -c "import sys,json
+try: print(json.load(sys.stdin).get('tool_name',''))
+except: print('')" 2>/dev/null || echo "")
+[ "$TOOL_NAME" = "Bash" ] || exit 0
+
+COMMAND=$(printf '%s' "$INPUT" | python3 -c "import sys,json
+try: print(json.load(sys.stdin).get('tool_input',{}).get('command',''))
+except: print('')" 2>/dev/null || echo "")
+command_invokes_git_commit "$COMMAND" || exit 0
+[ "${BYPASS_FIX_TITLE_LIFECYCLE_ADVISORY:-}" = "1" ] && exit 0
+git rev-parse --is-inside-work-tree >/dev/null 2>&1 || exit 0
+[ -d "./docs/problems/open" ] || exit 0
+
+SUBJECT=$(git log -1 --format='%s' HEAD 2>/dev/null) || exit 0
+case "$SUBJECT" in
+  "fix: "*|"fix("*) ;;
+  *) exit 0 ;;
+esac
+
+PIDS=$(printf '%s' "$SUBJECT" | grep -oE 'P[0-9]{3}' | sort -u || true)
+[ -n "$PIDS" ] || exit 0
+
+OPEN_IDS=""
+OPEN_COUNT=0
+while IFS= read -r pid; do
+  [ -n "$pid" ] || continue
+  num="${pid#P}"
+  shopt -s nullglob; files=(./docs/problems/open/${num}-*.md); shopt -u nullglob
+  if [ ${#files[@]} -gt 0 ]; then
+    OPEN_COUNT=$((OPEN_COUNT + 1))
+    # Cap the named IDs at 3 so TOTAL emission stays ≤300 bytes (ADR-045).
+    if [ "$OPEN_COUNT" -le 3 ]; then
+      OPEN_IDS="${OPEN_IDS:+$OPEN_IDS,}$pid"
+    fi
+  fi
+done <<< "$PIDS"
+[ "$OPEN_COUNT" -gt 0 ] || exit 0
+[ "$OPEN_COUNT" -gt 3 ] && OPEN_IDS="${OPEN_IDS}+$((OPEN_COUNT - 3))"
+
+echo "P345 ADVISORY: fix-titled commit names ${OPEN_IDS} still Open — no paired lifecycle transition landed. Transition it (/wr-itil:transition-problem <NNN> known-error) or document why not. Bypass: BYPASS_FIX_TITLE_LIFECYCLE_ADVISORY=1." >&2
+exit 0

package/hooks/test/itil-fix-title-lifecycle-advisory.bats

@@ -0,0 +1,129 @@
+#!/usr/bin/env bats
+
+# P345/RFC-044/STORY-038: itil-fix-title-lifecycle-advisory.sh — post-commit
+# ADVISORY for fix-titled commits whose named P<NNN> ticket is still Open on
+# disk (no paired lifecycle transition in the commit). Advisory-only per
+# ADR-092: never blocks, exit 0 on every path. Behavioural (ADR-052).
+
+setup() {
+  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
+  HOOK="$REPO_ROOT/packages/itil/hooks/itil-fix-title-lifecycle-advisory.sh"
+  DIR="$(mktemp -d)"; cd "$DIR"
+  git init -q; git config user.email t@e.x; git config user.name t
+  mkdir -p docs/problems/open docs/problems/known-error
+  echo x > seed; git add -A; git commit -qm "chore: seed"
+}
+teardown() { cd /; rm -rf "$DIR"; }
+
+# Feed the hook a PostToolUse Bash payload for a `git commit` command.
+run_hook() {
+  printf '{"tool_name":"Bash","tool_input":{"command":"git commit -m x"}}' | bash "$HOOK"
+}
+
+commit() { git commit -q --allow-empty -m "$1"; }
+
+@test "advises when a fix-titled commit names a still-Open ticket" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "fix(itil): P501 stop the widget breaking"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"P501"* ]]
+  [[ "$output" == *"Open"* ]]
+  [[ "$output" == *"transition"* ]]
+}
+
+@test "silent when the named ticket is known-error (transition already happened)" {
+  echo t > docs/problems/known-error/501-widget-breaks.md
+  commit "fix(itil): P501 stop the widget breaking"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "silent when the named ticket does not exist on disk" {
+  commit "fix(itil): P999 phantom ticket"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "silent on a non-fix-typed subject naming a P token" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "docs(problems): P501 add investigation notes"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "silent on a fix-typed subject with no P token" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "fix(itil): tidy the widget"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "advises on the bare fix: form too" {
+  echo t > docs/problems/open/502-gadget-stuck.md
+  commit "fix: P502 unstick the gadget"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"P502"* ]]
+}
+
+@test "total emission stays at or under 300 bytes with many still-Open tickets" {
+  for n in 511 512 513 514 515 516; do
+    echo t > "docs/problems/open/${n}-thing-${n}.md"
+  done
+  commit "fix(itil): P511 P512 P513 P514 P515 P516 mega sweep"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -n "$output" ]
+  [ "${#output}" -le 300 ]
+}
+
+@test "bypass env var suppresses the advisory" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "fix(itil): P501 stop the widget breaking"
+  run env BYPASS_FIX_TITLE_LIFECYCLE_ADVISORY=1 bash -c 'printf "{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":\"git commit -m x\"}}" | bash "$0"' "$HOOK"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "silent on non-Bash tool payloads" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "fix(itil): P501 stop the widget breaking"
+  run bash -c 'printf "{\"tool_name\":\"Write\",\"tool_input\":{}}" | bash "$0"' "$HOOK"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "silent on non-commit Bash commands" {
+  echo t > docs/problems/open/501-widget-breaks.md
+  commit "fix(itil): P501 stop the widget breaking"
+  run bash -c 'printf "{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":\"git log --oneline\"}}" | bash "$0"' "$HOOK"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "fail-open silent when docs/problems is absent" {
+  rm -rf docs/problems
+  commit "fix(itil): P501 stop the widget breaking"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}
+
+@test "fail-open silent outside a git work tree" {
+  NOGIT="$(mktemp -d)"; cd "$NOGIT"
+  run run_hook
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+  cd /; rm -rf "$NOGIT"
+}
+
+@test "fail-open silent on malformed JSON input" {
+  run bash -c 'printf "not json at all" | bash "$0"' "$HOOK"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.56.3",
+  "version": "0.57.0-preview.923",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"