@windyroad/itil 0.55.5 → 0.56.0-preview.876

package/.claude-plugin/plugin.json

@@ -497,5 +497,5 @@
     }
   },
   "name": "wr-itil",
-  "version": "0.55.5"
+  "version": "0.56.0"
 }

package/bin/wr-itil-check-rfc-has-stories

@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+# Generated by scripts/sync-shim-wrappers.sh from
+# packages/shared/lib/shim-wrapper-template.sh. DO NOT EDIT individual
+# shim files in packages/*/bin/wr-* directly; edit the template + run
+# `npm run sync:shim-wrappers` to regenerate.
+#
+# Resolution (ADR-080):
+#   1. If the wrapper's parent dir is semver-shaped, treat as installed-
+#      cache execution and resolve to the highest-version sibling's
+#      scripts/ entry below.
+#   2. Otherwise (parent dir is e.g. `architect`), treat as source-
+#      monorepo execution and dispatch to own scripts/. The source-repo-
+#      guard `exec` is the anchor parsed by
+#      packages/retrospective/scripts/check-tarball-shipped-shims.sh.
+#   3. If the cache parent contains zero semver-shaped siblings, exit
+#      127 with a stderr message naming the cache parent (per SQ-080-2).
+#
+# @adr ADR-080 (highest-version-wins shim wrapper plugin scaffold)
+# @adr ADR-049 (plugin-bundled scripts resolve via bin/ on $PATH — amended)
+# @problem P343 (mid-session staleness window)
+
+set -euo pipefail
+
+SHIM_DIR="$(cd "$(dirname "$0")" && pwd)"
+OWN_VERSION_DIR="$(dirname "$SHIM_DIR")"
+OWN_VERSION_NAME="$(basename "$OWN_VERSION_DIR")"
+CACHE_PARENT="$(dirname "$OWN_VERSION_DIR")"
+
+SEMVER_RE='^[0-9]+\.[0-9]+\.[0-9]+([-+][0-9A-Za-z.-]+)?$'
+
+# Source-repo guard: own parent dir is NOT semver → dispatch to own scripts/.
+if ! [[ "$OWN_VERSION_NAME" =~ $SEMVER_RE ]]; then
+  exec "$SHIM_DIR/../scripts/check-rfc-has-stories.sh" "$@"
+fi
+
+# Cache execution: pick the highest-semver sibling under CACHE_PARENT.
+HIGHEST=""
+while IFS= read -r dir; do
+  name="$(basename "$dir")"
+  [[ "$name" =~ $SEMVER_RE ]] || continue
+  if [[ -z "$HIGHEST" ]] || [[ "$(printf '%s\n%s\n' "$HIGHEST" "$name" | sort -V | tail -1)" == "$name" ]]; then
+    HIGHEST="$name"
+  fi
+done < <(find "$CACHE_PARENT" -mindepth 1 -maxdepth 1 -type d 2>/dev/null)
+
+if [[ -z "$HIGHEST" ]]; then
+  printf 'wr-shim: no cached versions in %s\n' "$CACHE_PARENT" >&2
+  exit 127
+fi
+
+exec "$CACHE_PARENT/$HIGHEST/scripts/check-rfc-has-stories.sh" "$@"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.55.5",
+  "version": "0.56.0-preview.876",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"

package/scripts/check-rfc-has-stories.sh

@@ -0,0 +1,59 @@
+#!/usr/bin/env bash
+# check-rfc-has-stories.sh — ADR-089 (every RFC has at least one story).
+#
+# The load-bearing detection half of the manage-rfc `proposed -> accepted` gate:
+# an RFC must list >=1 story before it can be accepted. Exits non-zero (with a
+# stderr directive) when the RFC's `stories:` frontmatter is empty (`stories: []`)
+# or missing; exits 0 when >=1 `STORY-NNN` is listed (inline or block-list).
+#
+# This removes the pre-ADR-089 empty-stories fallback (the "atomic RFC ships with
+# stories: [] / JTBD-101 friction guard" shape). An atomic fix is now an RFC with
+# exactly one full story, never an empty list.
+#
+# Usage: check-rfc-has-stories.sh <rfc-file>
+# Exit:  0 = >=1 story; 1 = empty/missing stories; 2 = usage / file error.
+#
+# Authority: ADR-089. Driver: P404. Behavioural test: check-rfc-has-stories.bats.
+set -euo pipefail
+
+rfc="${1:-}"
+if [ -z "$rfc" ]; then
+  echo "check-rfc-has-stories: usage: check-rfc-has-stories.sh <rfc-file>" >&2
+  exit 2
+fi
+if [ ! -f "$rfc" ]; then
+  echo "check-rfc-has-stories: file not found: $rfc" >&2
+  exit 2
+fi
+
+# The frontmatter `stories:` line (first match; frontmatter is at the top).
+stories_line="$(awk '/^stories:/{print; exit}' "$rfc")"
+
+if [ -z "$stories_line" ]; then
+  echo "check-rfc-has-stories: $rfc has no 'stories:' field — an RFC must list >=1 story (ADR-089). Decompose the fix into >=1 story before accepting." >&2
+  exit 1
+fi
+
+# Reject an explicit empty inline list: `stories: []`.
+if printf '%s' "$stories_line" | grep -qE '^stories:[[:space:]]*\[[[:space:]]*\][[:space:]]*$'; then
+  echo "check-rfc-has-stories: $rfc has empty 'stories: []' — an RFC must list >=1 story (ADR-089; the empty-stories fallback is removed). An atomic fix is an RFC with exactly one full story." >&2
+  exit 1
+fi
+
+# Accept if a STORY-id appears inline on the stories: line.
+if printf '%s' "$stories_line" | grep -qE 'STORY-[0-9]'; then
+  exit 0
+fi
+
+# Accept if a YAML block-list under stories: carries >=1 STORY-id.
+if awk '
+  /^stories:/ { inblock=1; next }
+  inblock && /^[[:space:]]*-[[:space:]]*STORY-[0-9]/ { found=1 }
+  inblock && /^[^[:space:]-]/ { exit }
+  END { exit !found }
+' "$rfc"; then
+  exit 0
+fi
+
+echo "check-rfc-has-stories: $rfc 'stories:' lists no STORY- ids — an RFC must list >=1 story (ADR-089)." >&2
+exit 1

package/scripts/test/check-rfc-has-stories.bats

@@ -0,0 +1,69 @@
+#!/usr/bin/env bats
+# Behavioural test for check-rfc-has-stories.sh (ADR-089 — every RFC has >=1 story).
+# The predicate exits non-zero when an RFC's `stories:` frontmatter is empty or
+# missing (the empty-stories fallback ADR-089 removes); exit 0 when >=1 story is
+# listed. This is the load-bearing detection half of the proposed->accepted gate.
+#
+# @adr ADR-089 (every RFC has at least one story)
+# @problem P404 (implement ADR-089 + ADR-090)
+
+setup() {
+  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
+  SCRIPT="${REPO_ROOT}/packages/itil/scripts/check-rfc-has-stories.sh"
+  TMPD="$(mktemp -d)"
+}
+teardown() { rm -rf "$TMPD"; }
+
+@test "check-rfc-has-stories: empty stories: [] is REJECTED (exit non-zero + directive)" {
+  cat > "$TMPD/RFC-901-empty.proposed.md" <<'EOF'
+---
+status: proposed
+problems: [P170]
+stories: []
+---
+# RFC-901: empty
+EOF
+  run bash "$SCRIPT" "$TMPD/RFC-901-empty.proposed.md"
+  [ "$status" -ne 0 ]
+  [[ "$output" == *"stories"* ]]
+}
+
+@test "check-rfc-has-stories: missing stories: field is REJECTED" {
+  cat > "$TMPD/RFC-902-none.proposed.md" <<'EOF'
+---
+status: proposed
+problems: [P170]
+---
+# RFC-902: no stories field
+EOF
+  run bash "$SCRIPT" "$TMPD/RFC-902-none.proposed.md"
+  [ "$status" -ne 0 ]
+  [[ "$output" == *"stories"* ]]
+}
+
+@test "check-rfc-has-stories: inline >=1 story is ACCEPTED (exit 0)" {
+  cat > "$TMPD/RFC-903-ok.proposed.md" <<'EOF'
+---
+status: proposed
+problems: [P170]
+stories: [STORY-020, STORY-021]
+---
+# RFC-903: has stories
+EOF
+  run bash "$SCRIPT" "$TMPD/RFC-903-ok.proposed.md"
+  [ "$status" -eq 0 ]
+}
+
+@test "check-rfc-has-stories: block-list >=1 story is ACCEPTED (exit 0)" {
+  cat > "$TMPD/RFC-904-block.proposed.md" <<'EOF'
+---
+status: proposed
+problems: [P170]
+stories:
+  - STORY-020
+---
+# RFC-904: block-list stories
+EOF
+  run bash "$SCRIPT" "$TMPD/RFC-904-block.proposed.md"
+  [ "$status" -eq 0 ]
+}

package/skills/manage-rfc/SKILL.md

@@ -118,7 +118,7 @@ Each transition is a `git mv` + Edit + `git add` (P057 staging trap) + README re
 
 | Transition | Checks |
 |------------|--------|
-| `proposed → accepted` | All `problems:` entries resolve. Architect re-review PASS. JTBD re-review PASS. `## Scope` populated (not "deferred"). `## Tasks` decomposed (≥ 1 task; not just deferred placeholder). |
+| `proposed → accepted` | All `problems:` entries resolve. Architect re-review PASS. JTBD re-review PASS. `## Scope` populated (not "deferred"). `## Tasks` decomposed (≥ 1 task; not just deferred placeholder). **`stories:` non-empty — run `wr-itil-check-rfc-has-stories <rfc-file>`; hard-block on non-zero exit (empty `stories: []` or missing).** Per **ADR-089** the empty-stories fallback is removed: an atomic fix is an RFC with exactly one full story; an empty `stories:` is permitted only on a `proposed`/draft RFC before the fix is scoped, never at `accepted`. |
 | `accepted → in-progress` | First commit referencing `Refs: RFC-<NNN>` exists OR is being authored in this same commit. I1 hard-block on missing/orphan trace. |
 | `in-progress → verifying` | All `## Tasks` checked. `## Verification` section drafted (release marker, user-side check, trace closure path). I1 hard-block on missing/orphan trace. |
 | `verifying → closed` | User explicitly confirms (or AFK Rule 6 fallback for evidence-based close per ADR-022 / ADR-044 framework-resolved silent dispatch). I1 advisory-with-escalation if driving problems Closed/Parked. |