@windyroad/itil 0.54.4-preview.806 → 0.54.5-preview.809

package/.claude-plugin/plugin.json

@@ -497,5 +497,5 @@
     }
   },
   "name": "wr-itil",
-  "version": "0.54.4"
+  "version": "0.54.5"
 }

package/hooks/lib/session-id.sh

@@ -221,10 +221,13 @@ get_candidate_session_ids() {
     # Concurrent-session SIDs: every recent announce marker across all
     # systems, within the mtime window. `*-announced-*` is system-agnostic
     # (picks up any present or future announcing plugin). `-maxdepth 1` and
-    # `-mmin -N` are portable across BSD (macOS) and GNU find. The sed strips
-    # the leading path then the `<system>-announced-` prefix, leaving the
-    # trailing UUID (UUIDs never contain the literal "-announced-").
-    find "$marker_dir" -maxdepth 1 -name '*-announced-*' -mmin "-${window_mins}" 2>/dev/null \
+    # `-mmin -N` are portable across BSD (macOS) and GNU find. `-L` follows the
+    # start-point symlink — on macOS marker_dir defaults to /tmp, a symlink to
+    # /private/tmp, which `find` would otherwise refuse to descend, silently
+    # enumerating zero candidates (no-op on Linux where /tmp is a real dir). P380.
+    # The sed strips the leading path then the `<system>-announced-` prefix,
+    # leaving the trailing UUID (UUIDs never contain the literal "-announced-").
+    find -L "$marker_dir" -maxdepth 1 -name '*-announced-*' -mmin "-${window_mins}" 2>/dev/null \
       | sed 's|.*/||; s/.*-announced-//'
   } | awk 'NF && !seen[$0]++'
 }

package/hooks/test/session-id.bats

@@ -349,3 +349,22 @@ candidates() {
   # The concurrent announce marker is still enumerated alongside the env SID.
   [[ "$output" == *"$other_uuid"* ]]
 }
+
+# P380: on macOS /tmp is a symlink to /private/tmp. The `find <symlink>
+# -maxdepth 1` enumeration in get_candidate_session_ids in default (-P) mode
+# refuses to descend the start-point symlink, so it silently adds zero
+# concurrent SIDs; the `-L` flag follows it. (get_current_session_id uses a
+# shell glob (`ls`), which traverses the symlink regardless — so this test
+# needs a SECOND concurrent marker whose SID is reachable ONLY via the find
+# enumeration to isolate the bug.) RED without `-L`, GREEN with it.
+@test "candidates: enumerates concurrent markers when SESSION_MARKER_DIR is a symlink (P380 macOS /tmp)" {
+  primary_uuid="aabbccdd-0000-1111-2222-symlinkprim0"   # picked by get_current_session_id glob
+  concurrent_uuid="eeff0011-0000-1111-2222-symlinkconc0" # reachable only via the find enum
+  mark_announced "architect" "$primary_uuid"
+  mark_announced "jtbd" "$concurrent_uuid"
+  link_tmp="${SANDBOX_TMP}.link"
+  ln -s "$SANDBOX_TMP" "$link_tmp"
+  output=$(SESSION_MARKER_DIR="$link_tmp" bash -c "source '$HELPER'; get_candidate_session_ids")
+  rm -f "$link_tmp"
+  [[ "$output" == *"$concurrent_uuid"* ]]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.54.4-preview.806",
+  "version": "0.54.5-preview.809",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"

package/skills/review-problems/SKILL.md

@@ -141,7 +141,7 @@ Read `docs/problems/.upstream-channels.json`. Branch on state:
 
 - **Interactive mode** (AskUserQuestion available):
   1. Fire **one** `AskUserQuestion` per skill invocation (NOT per pass — adopters who decline at run 1 are not re-prompted within the same session) with options: `Bootstrap now (recommended)` / `Decline (skip inbound-discovery this session)` / `Decline permanently (write empty channels stub)`.
-  2. On `Bootstrap now`: fire a second `AskUserQuestion` for channel-type (single-select: `github-issues` / `github-discussions` / `github-security-advisories`); then a third for the per-channel coordinates (repo `<owner>/<name>` for all three; `label` for github-issues; `category` for github-discussions). For the per-coordinate prompt fire ONE multi-part `AskUserQuestion` (multiple Question objects in a single call per ADR-013 Rule 1 batched ≤4) — do NOT serialise to N round-trips.
+  2. On `Bootstrap now`: fire a second `AskUserQuestion` for channel-type (single-select: `github-issues` / `github-discussions` / `github-security-advisories`); then a third for the per-channel coordinates (repo `<owner>/<name>` for all three; `category` for github-discussions). github-issues needs only `repo` — do NOT prompt for `label` or `title_prefix` (both are removed/soft per P373; the bootstrapped channel polls all open issues by default, and an adopter who later wants strict pre-filtering hand-edits `strict_title_prefix: true` into the config). For the per-coordinate prompt fire ONE multi-part `AskUserQuestion` (multiple Question objects in a single call per ADR-013 Rule 1 batched ≤4) — do NOT serialise to N round-trips.
   3. **Preview before write** (JTBD persona-fit constraint from review): emit the planned JSON contents to the agent's user-visible output so the adopter can read it before the write fires. Default `ttl_seconds: 86400` (24h — matches ADR-062's documented TTL). Channel schema mirrors the polled-channels list at 4.5c (`type` + `repo` + per-type identifier).
   4. Write `docs/problems/.upstream-channels.json` with the bootstrapped channel + the defaulted TTL.
   5. **Resume the original pass** at 4.5b with the freshly-written config.
@@ -194,7 +194,7 @@ The TTL-expiry auto-recheck is what makes the system self-healing across maintai
 
 For each channel in `channels[]`, run the appropriate `gh` invocation. Fail-soft per channel: missing `GH_TOKEN`, rate-limit, or HTTP error logs an advisory and skips that channel only:
 
-- `github-issues`: `gh issue list --repo <repo> --label <label> --state open --json number,title,author,createdAt,body,labels --limit 100`
+- `github-issues`: `gh issue list --repo <repo> --state open --json number,title,author,createdAt,body,labels --limit 100` — poll **all** open issues; do NOT pre-filter by `title_prefix` or label. Per JTBD-301 (the plugin-user persona has low context on repo internals and must not pre-classify), ANY open issue is a potential problem report — a one-shot reporter who files plain prose without the `[problem]` template prefix must still be discovered (witness: P373, issue #273 silently dropped). The `title_prefix` field (if configured) is a **soft signal** — use it only to rank/annotate, never to discard. The de-facto filter is the Step 4.5d semantic-comparator + Step 4.5e JTBD-alignment + dual-axis-risk classifiers at the assessment-pipeline boundary, which emit a verdict for every report (per ADR-062 — every submitted report receives a verdict, even if it is "won't-fix" or "duplicate"). **Adopter opt-in (JTBD-003)**: a channel may set `"strict_title_prefix": true` to restore a hard pre-filter (`gh issue list --repo <repo> --state open --search "<title_prefix> in:title" --json ...`), discarding non-prefixed issues at the channel boundary; the default (field absent or `false`) polls all open issues.
 - `github-discussions`: `gh api repos/<repo>/discussions --jq '[.[] | select(.category.name == "<category>") | {number, title, author, createdAt, body}]'` (fall back to GraphQL `gh api graphql ...` if REST is insufficient for the discussions surface).
 - `github-security-advisories`: `gh api repos/<repo>/security-advisories --jq '[.[] | {ghsa_id, summary, description, author, published_at}]'`.