@windyroad/itil 0.4.2 → 0.4.3-preview.99

package/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "wr-itil",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "ITIL-aligned IT service management for Claude Code"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.4.2",
+  "version": "0.4.3-preview.99",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"

package/skills/manage-problem/SKILL.md

@@ -130,12 +130,24 @@ Before creating, search existing problems for similar issues. The user may not k
 
 ### 3. For new problems: Assign the next ID
 
-Scan `docs/problems/` for existing files. Extract the highest numeric ID and increment by 1. Zero-pad to 3 digits.
+Compute the next ID as the **max of the local and origin highest IDs**, plus one, zero-padded to 3 digits. Comparing against `origin/<base>` is required by ADR-019 (confirmation criterion 2): without it, parallel sessions can mint the same ID for different problems and force a destructive surgical rebase on push (P040 incident).
 
 ```bash
-ls docs/problems/*.md 2>/dev/null | sed 's/.*\///' | grep -oE '^[0-9]+' | sort -n | tail -1
+# Local-max ID
+local_max=$(ls docs/problems/*.md 2>/dev/null | sed 's/.*\///' | grep -oE '^[0-9]+' | sort -n | tail -1)
+
+# Origin-max ID — `git ls-tree origin/<base>` reads remote-tracking ref
+# without requiring a fetch in this step (Step 0 preflight is the place
+# where the fetch happens). Default base is `main`; if the user is on
+# another branch, swap accordingly.
+origin_max=$(git ls-tree origin/main docs/problems/ 2>/dev/null | grep -oE '[0-9]{3}' | sort -n | tail -1)
+
+# Take the max of the two and increment.
+next=$(printf '%03d' $(( $(echo -e "${local_max:-0}\n${origin_max:-0}" | sort -n | tail -1) + 1 )))
 ```
 
+If the local choice would have collided with an origin ticket created since the last fetch, the `git ls-tree origin/<base>` lookup catches it here and the renumber is automatic. Log the renumber decision in the operation report (e.g. "Bumped next ID from 042 → 043 to avoid collision with origin").
+
 ### 4. For new problems: Gather information
 
 If the arguments contain a description, extract what you can. For anything missing, use `AskUserQuestion` to gather:

package/skills/manage-problem/test/manage-problem-id-collision-guard.bats

@@ -0,0 +1,39 @@
+#!/usr/bin/env bats
+# Doc-lint guard: manage-problem SKILL.md step 3 (Assign the next ID) must
+# include the next-ID collision guard against origin per ADR-019
+# confirmation criterion 2.
+#
+# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
+# These tests assert that the skill specification document instructs the
+# orchestrator to compare next-ID against origin/<base> before assigning,
+# so parallel sessions don't produce colliding ticket numbers.
+#
+# Cross-reference:
+#   P043 (next-ID collision guard in ticket-creator skills)
+#   P040 (work-problems does not fetch origin before starting — sibling)
+#   ADR-019 (AFK orchestrator preflight, including next-ID guard)
+#   @jtbd JTBD-006 (Progress the Backlog While I'm Away)
+
+setup() {
+  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  SKILL_FILE="${SKILL_DIR}/SKILL.md"
+}
+
+@test "SKILL.md cites ADR-019 (next-ID collision guard)" {
+  run grep -n "ADR-019" "$SKILL_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "SKILL.md step 3 references git ls-tree origin for next-ID lookup" {
+  # ADR-019 mechanism: the orchestrator MUST re-check next-ID assignment
+  # against `git ls-tree origin/<base>` before creating any new ticket.
+  run grep -n "git ls-tree origin" "$SKILL_FILE"
+  [ "$status" -eq 0 ]
+}
+
+@test "SKILL.md mentions taking the max of local and origin IDs" {
+  # The guard logic is: take the max of local-max-ID and origin-max-ID,
+  # then increment. Skill must mention this combination.
+  run grep -niE "max of (the )?(two|local and origin)|max\(.*origin" "$SKILL_FILE"
+  [ "$status" -eq 0 ]
+}