@windyroad/itil 0.3.0 → 0.3.1-preview.72

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.3.0",
+  "version": "0.3.1-preview.72",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"

package/skills/manage-incident/SKILL.md

@@ -260,6 +260,14 @@ After any operation, report:
 - For restore: the linked problem ID (or "No Problem" note)
 - Any quality-check warnings
 
-Do not commit. The user will commit when ready.
+Commit the completed work per ADR-014 (governance skills commit their own work):
+1. `git add` all created/modified files for this operation
+2. Delegate to `wr-risk-scorer:pipeline` (subagent_type: `wr-risk-scorer:pipeline`) to assess the staged changes and create a bypass marker
+3. `git commit -m "<message>"` using the convention for the operation type:
+   - New incident: `docs(incidents): open I<NNN> <title>`
+   - Incident mitigated: `docs(incidents): I<NNN> mitigated — <mitigation summary>`
+   - Incident restored: `docs(incidents): I<NNN> restored — <action>`
+   - Incident closed: `docs(incidents): close I<NNN>`
+4. If risk is above appetite: use `AskUserQuestion` to ask whether to commit anyway, remediate first, or park the work. If `AskUserQuestion` is unavailable, skip the commit and report the uncommitted state clearly.
 
 $ARGUMENTS

package/skills/manage-problem/SKILL.md

@@ -277,7 +277,11 @@ For each known-error that has a `## Fix Released` section, use `AskUserQuestion`
 
 **Step 9e: Update files**
 
-Edit each problem file where the priority changed. Do not commit — the user will commit when ready.
+Edit each problem file where the priority changed. Then commit the updated files per ADR-014:
+1. `git add` the changed problem files
+2. Delegate to `wr-risk-scorer:pipeline` to assess and create a bypass marker
+3. `git commit -m "docs(problems): review — re-rank priorities"`
+If `AskUserQuestion` is unavailable and risk is above appetite, skip the commit and report the uncommitted state.
 
 ### 10. Quality checks
 
@@ -300,6 +304,15 @@ After any operation, report:
 - The current status
 - Any quality check warnings
 
-Do not commit. The user will commit when ready.
+Commit the completed work per ADR-014 (governance skills commit their own work):
+1. `git add` all created/modified files for this operation
+2. Delegate to `wr-risk-scorer:pipeline` (subagent_type: `wr-risk-scorer:pipeline`) to assess the staged changes and create a bypass marker
+3. `git commit -m "<message>"` using the convention for the operation type:
+   - New problem: `docs(problems): open P<NNN> <title>`
+   - Known Error transition: `docs(problems): P<NNN> known error — <root cause summary>`
+   - Problem closed: `docs(problems): close P<NNN> <title>`
+   - Review/re-rank: `docs(problems): review — re-rank priorities`
+   - Fix implemented: `fix(<scope>): <description> (closes P<NNN>)` — include problem file changes in the same commit
+4. If risk is above appetite: use `AskUserQuestion` to ask whether to commit anyway, remediate first, or park the work. If `AskUserQuestion` is unavailable, skip the commit and report the uncommitted state clearly.
 
 $ARGUMENTS

package/skills/manage-problem/test/manage-problem-no-prose-options.bats

@@ -0,0 +1,46 @@
+#!/usr/bin/env bats
+# Doc-lint guard: manage-problem SKILL.md must not contain prose option prompts.
+#
+# Structural assertion — Permitted Exception to the source-grep ban (ADR-005 / P011).
+# These tests do not assert hook behaviour; they assert that the skill specification
+# document conforms to the structured-interaction contract.
+#
+# Cross-reference:
+#   ADR-013 Confirmation criterion (docs/decisions/013-structured-user-interaction-for-governance-decisions.proposed.md)
+#   P021 investigation task: "add a BATS or doc-lint test that fails if the skill contains prose option patterns"
+#   @jtbd JTBD-001 (enforce governance without slowing down)
+#   @jtbd JTBD-101 (extend the suite with clear patterns)
+
+setup() {
+  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  SKILL_FILE="${SKILL_DIR}/SKILL.md"
+}
+
+@test "SKILL.md exists and has frontmatter" {
+  [ -f "$SKILL_FILE" ]
+  run head -1 "$SKILL_FILE"
+  [ "$status" -eq 0 ]
+  [ "$output" = "---" ]
+}
+
+@test "SKILL.md does not contain 'Your call:' prose option prompt" {
+  # ADR-013 Rule 1: all decision branch points must use AskUserQuestion, not prose.
+  # 'Your call:' is the canonical unstructured prompt observed in P021 (risk-scorer image #3).
+  run grep -n "Your call:" "$SKILL_FILE"
+  [ "$status" -ne 0 ]   # grep exits 1 when no match — that IS the pass condition
+}
+
+@test "SKILL.md does not contain freestanding 'Options: (a)' prose list" {
+  # ADR-013 Rule 1: prose option lists must not appear as skill instructions.
+  # Pattern: 'Options: (a)' as an instruction to Claude to present unstructured choices.
+  # Note: 'Would you like to: (a)' in AskUserQuestion examples is a different pattern
+  # and is NOT matched by this assertion.
+  run grep -n "Options: (a)" "$SKILL_FILE"
+  [ "$status" -ne 0 ]
+}
+
+@test "SKILL.md does not contain 'which way?' prose branch prompt" {
+  # ADR-013 Confirmation criterion lists 'which way?' as a prohibited prose prompt.
+  run grep -n "which way?" "$SKILL_FILE"
+  [ "$status" -ne 0 ]
+}