@windyroad/itil 0.19.5 → 0.19.6

package/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "wr-itil",
-  "version": "0.19.5",
+  "version": "0.19.6",
   "description": "ITIL-aligned IT service management for Claude Code"
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.19.5",
+  "version": "0.19.6",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"

package/skills/work-problems/SKILL.md

@@ -104,10 +104,10 @@ The skipped tickets that triggered stop-condition #2 frequently carry **user-ans
 
 **2. Branch on interactivity per ADR-013 Rule 1 / Rule 6.**
 
-- **Interactive invocation** (AskUserQuestion is available AND the loop was not started in AFK mode): batch the questions into one `AskUserQuestion` call (or more, if >4 questions, issued sequentially). Header: `"Outstanding design questions"`. For each question, set the prompt from the extracted text and the options from the ticket's candidate fixes or option list. Write each answer back to the corresponding ticket file so the next AFK loop does not re-ask.
-- **Non-interactive / AFK invocation** (default for this skill per JTBD-006 — the persona is AFK): do NOT call `AskUserQuestion`. Instead emit an `### Outstanding Design Questions` section in the post-stop summary listing each question with its Ticket ID, the question text, and one-line context. The user answers on return.
+- **Default branch — call `AskUserQuestion` when available** (the orchestrator's main turn is interactive by construction; the user is presumed at the keyboard). Batch the questions into one `AskUserQuestion` call (or more, if >4 questions, issued sequentially). Header: `"Outstanding design questions"`. For each question, set the prompt from the extracted text and the options from the ticket's candidate fixes or option list. Write each answer back to the corresponding ticket file so the next AFK loop does not re-ask. This is ADR-013 Rule 1 applied to the orchestrator's main-turn surface.
+- **Fallback branch — emit `### Outstanding Design Questions` table** when `AskUserQuestion` is unavailable (restricted permission mode, hook-disabled tool surface, or any other context where the structured-question primitive cannot fire). The table lists each question with its Ticket ID, the question text, and one-line context. The user answers on return. This is ADR-013 Rule 6 fail-safe — fall back to a structured summary when the structured-interaction primitive is unavailable.
 
-This branch is the Rule 6 fail-safe applied to stop-condition #2: Rule 1 says route governance decisions through `AskUserQuestion`; Rule 6 says fall back to a structured summary when the tool is unavailable or the user is away. JTBD-006's persona constraint ("autonomously work without needing interactive input") makes the non-interactive path the default for this skill — AskUserQuestion is the exception, not the rule.
+**Cross-skill principle (architect FLAG, P122)**: orchestrator main turns default to `AskUserQuestion` when available; the AFK persona (JTBD-006) is served by the **subprocess-boundary contract under ADR-032** (iteration subprocess workers are AFK by construction via `claude -p` — they exit at `ITERATION_SUMMARY` and never reach stop-condition #2), NOT by suppressing `AskUserQuestion` at the orchestrator layer. Step 5's iteration-prompt template carries the per-subprocess AFK contract (constraint: "Do not call `AskUserQuestion`"); stop-condition #2 fires only in the orchestrator's main turn where the user is presumed present. This principle generalises to any future AFK orchestrator that hits the same surface — defer the AFK persona to the subprocess boundary, not to the orchestrator's question-surfacing branch.
 
 **3. Emit the final summary + `ALL_DONE`.** The summary includes the Outstanding Design Questions table when any user-answerable questions were surfaced (see Output Format).
 
@@ -425,7 +425,7 @@ When `AskUserQuestion` is unavailable or the user is AFK, the skill (and the del
 | Origin diverged before start | Pull `--ff-only` if trivial; stop with report (`git log HEAD..origin/<base>` and reverse) if non-fast-forward — per ADR-019 (Step 0) |
 | Prior-session partial work detected at start (session-continuity dirty: untracked `docs/decisions/*.proposed.md` / `docs/problems/*.md`, `.afk-run-state/iter-*.json` with `is_error: true` or `api_error_status >= 400`, stale `.claude/worktrees/*`, uncommitted SKILL.md/source/ADR edits) | Halt the loop with a structured Prior-Session State report in the AFK summary. Do NOT attempt non-interactive resume. Interactive invocations prompt via `AskUserQuestion` with 4 options (resume / discard / leave-and-lower-priority / halt). Per P109 + ADR-013 Rule 6 (Step 0 session-continuity detection pass). |
 | Fix verification needed | Skip problem, add to "needs verification" list |
-| Stop-condition #2 with user-answerable skip-reasons | Emit Outstanding Design Questions table in summary (do NOT call AskUserQuestion). The persona is AFK by definition — per JTBD-006 and ADR-013 Rule 6 — so the table is the default. Interactive invocations may batch up to 4 questions through AskUserQuestion instead — per ADR-013 Rule 1 (Step 2.5). |
+| Stop-condition #2 with user-answerable skip-reasons | Default: call AskUserQuestion (batched, ≤4 per call, sequential when >4) — the orchestrator's main turn is interactive by construction per ADR-032 subprocess-boundary; user is presumed at the keyboard. Fallback: emit Outstanding Design Questions table when AskUserQuestion is unavailable (Rule 6 fail-safe). Per ADR-013 Rule 1 + P122 (Step 2.5). |
 | Unexpected dirty state between iterations | Halt the loop. Report the `git status --porcelain` output, the last iteration's reported outcome, and the divergence — per P036 (Step 6.75). Do NOT attempt non-interactive recovery. |
 | External root cause detected at Open → Known Error, or at park with `upstream-blocked` reason | Append the stable `- **Upstream report pending** — external dependency identified; invoke /wr-itil:report-upstream when ready` marker to the ticket's `## Related` section; do NOT auto-invoke `/wr-itil:report-upstream` (Step 6 security-path branch is interactive — per ADR-024 Consequences). Use the already-noted grep check to avoid duplicate lines. Per P063 + ADR-013 Rule 6. |
 

package/skills/work-problems/test/work-problems-step-2-5-routing.bats

@@ -0,0 +1,80 @@
+#!/usr/bin/env bats
+
+# P122: work-problems Step 2.5 stop-condition #2 routing must default to
+# AskUserQuestion (interactive) and use the table emit only as the
+# AskUserQuestion-unavailable fallback. The "non-interactive default for
+# this skill" prose was wrong-by-design — JTBD-006 (AFK persona) is served
+# by the iteration subprocess workers, not by suppressing AskUserQuestion
+# at the orchestrator's main turn (which is interactive by construction).
+#
+# Doc-lint contract assertions per ADR-037 Permitted Exception (structural
+# checks on prose contract, not behavioural coverage).
+
+setup() {
+  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
+  SKILL_MD="$REPO_ROOT/packages/itil/skills/work-problems/SKILL.md"
+}
+
+@test "work-problems P122: SKILL.md exists" {
+  [ -f "$SKILL_MD" ]
+}
+
+@test "work-problems P122: Step 2.5 removes the legacy AFK-as-default prose" {
+  # The flipped default — the legacy "non-interactive path the default
+  # for this skill" prose at Step 2.5 must be gone. (Note: Step 0's
+  # session-continuity AFK branch intentionally retains its own AFK
+  # default for a different reason; this test is scoped to Step 2.5's
+  # specific phrasing only.)
+  run grep -F 'non-interactive path the default for this skill' "$SKILL_MD"
+  [ "$status" -ne 0 ]
+}
+
+@test "work-problems P122: Step 2.5 explicitly cites AskUserQuestion as the default branch" {
+  # The new default-selection prose names a "Default branch" that calls
+  # AskUserQuestion. Match the structural phrase rather than the
+  # backtick-wrapped tool name to keep the grep portable.
+  run grep -F 'Default branch' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}
+
+@test "work-problems P122: Step 2.5 cites the orchestrator-vs-subprocess principle" {
+  # The flip's load-bearing reasoning: the orchestrator's main turn is
+  # interactive by construction; AFK persona is served by the
+  # subprocess-boundary contract under ADR-032, not by suppressing
+  # AskUserQuestion at the orchestrator layer. (Architect FLAG —
+  # cross-skill principle sentence.)
+  run grep -F 'subprocess-boundary contract' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+  run grep -F 'interactive by construction' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}
+
+@test "work-problems P122: Step 2.5 preserves the user-answerable skip-reason scoping" {
+  # P103 anti-pattern boundary: the AskUserQuestion default must NOT
+  # broaden to architect-design or upstream-blocked skip-reasons. The
+  # user-answerable scoping from Step 4's classifier remains in force.
+  run grep -F 'user-answerable' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}
+
+@test "work-problems P122: Step 2.5 preserves the 4-question-per-call cap" {
+  # AskUserQuestion's documented per-call limit; sequential calls when
+  # the question set exceeds the cap.
+  run grep -F '4 questions per' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}
+
+@test "work-problems P122: Step 2.5 preserves the table-fallback-when-unavailable branch" {
+  # Rule 6 fail-safe: when AskUserQuestion is unavailable (restricted
+  # permission mode, etc.), emit the Outstanding Design Questions table.
+  run grep -F 'Outstanding Design Questions' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}
+
+@test "work-problems P122: Decisions Table row for stop-condition #2 names AskUserQuestion as default" {
+  # The Step 6.5 Decisions Table row at the bottom of the SKILL.md
+  # must agree with the Step 2.5 prose — the prior "table is the
+  # default" wording must be flipped here too.
+  run grep -E '^\| Stop-condition #2 .*AskUserQuestion' "$SKILL_MD"
+  [ "$status" -eq 0 ]
+}