@windyroad/itil 0.19.2-preview.196 → 0.19.3-preview.198

package/.claude-plugin/plugin.json

@@ -1,5 +1,5 @@
 {
   "name": "wr-itil",
-  "version": "0.19.2",
+  "version": "0.19.3",
   "description": "ITIL-aligned IT service management for Claude Code"
 }

package/hooks/hooks.json

@@ -4,7 +4,8 @@
       { "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/bin/check-deps.sh wr-itil wr-risk-scorer" }] }
     ],
     "UserPromptSubmit": [
-      { "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-assistant-output-gate.sh" }] }
+      { "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-assistant-output-gate.sh" }] },
+      { "hooks": [{ "type": "command", "command": "${CLAUDE_PLUGIN_ROOT}/hooks/itil-correction-detect.sh" }] }
     ],
     "PreToolUse": [
       {

package/hooks/itil-correction-detect.sh

@@ -0,0 +1,83 @@
+#!/bin/bash
+# P078 / ADR-013 / ADR-038: itil correction-signal UserPromptSubmit gate.
+#
+# When the incoming user prompt carries a strong-affect correction
+# signal (FFS / all-caps imperatives like DO NOT / direct contradiction
+# / exasperation markers / meta-correction "you always|never|keep"),
+# inject a MANDATORY reminder so the assistant OFFERS to capture a
+# problem ticket BEFORE addressing the operational request — the
+# correction is almost always a class-of-behaviour, not a one-off slip,
+# and a ticket preserves the signal as durable WSJF-ranked backlog.
+#
+# Once-per-session full block; terse reminder on subsequent corrections
+# (per ADR-038 progressive disclosure). The full block names the
+# matched pattern so the assistant has the why-this-fired context.
+#
+# Forward-compat: advertises /wr-itil:capture-problem (ADR-032 — not
+# yet shipped) with /wr-itil:manage-problem as the today-target
+# fallback. When capture-problem ships the wording stays valid.
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+# shellcheck source=lib/session-marker.sh
+source "$SCRIPT_DIR/lib/session-marker.sh"
+# shellcheck source=lib/detectors.sh
+source "$SCRIPT_DIR/lib/detectors.sh"
+
+INPUT=$(cat)
+SESSION_ID=$(echo "$INPUT" | jq -r '.session_id // empty' 2>/dev/null || echo "")
+PROMPT=$(echo "$INPUT" | jq -r '.prompt // empty' 2>/dev/null || echo "")
+
+# Guard: if the prompt carries no correction signal, do nothing.
+# Burning the announcement marker on non-correction prompts would waste
+# the once-per-session budget on no-op context.
+if [ -z "$PROMPT" ]; then
+  exit 0
+fi
+
+MATCHED=$(echo "$PROMPT" | detect_correction_signal)
+if [ -z "$MATCHED" ]; then
+  exit 0
+fi
+
+if has_announced "itil-correction-detect" "$SESSION_ID"; then
+  cat <<HOOK_OUTPUT
+MANDATORY: correction signal ($MATCHED). OFFER /wr-itil:capture-problem (fallback /wr-itil:manage-problem) BEFORE addressing the request. See P078.
+HOOK_OUTPUT
+else
+  cat <<HOOK_OUTPUT
+INSTRUCTION: MANDATORY — correction signal detected. OFFER ticket capture FIRST.
+DETECTED: incoming user prompt contains a strong-affect correction
+signal (matched pattern: $MATCHED).
+
+NON-OPTIONAL RULES:
+
+1. BEFORE addressing the operational request in the prompt, OFFER
+   to capture a problem ticket for the underlying behavioural pattern.
+   Use /wr-itil:capture-problem when shipped (ADR-032 background
+   capture pattern). Until then, fall back to /wr-itil:manage-problem
+   for synchronous capture.
+
+2. The correction is almost always a class-of-behaviour, not a one-off
+   slip. Acknowledging verbally and moving on lets the signal decay
+   with session context; the same pattern recurs next session and the
+   user has to flag it again. A ticket preserves the correction as
+   durable, WSJF-ranked backlog.
+
+3. The offer is non-blocking — the user can decline — but the offer
+   MUST appear before the operational response. Do NOT wait for the
+   user to request the ticket themselves; that's exactly the manual-
+   policing-AI-output friction P078 closes.
+
+4. Suggested phrasing: "Before I address that — want me to capture a
+   problem ticket for this pattern?" Then proceed with the operational
+   request regardless of the answer.
+
+See:
+- ~/.claude/projects/.../memory/feedback_capture_on_correction.md
+- docs/problems/078-assistant-does-not-offer-problem-ticket-on-user-correction.*.md
+- packages/itil/hooks/lib/detectors.sh (CORRECTION_SIGNAL_PATTERNS)
+HOOK_OUTPUT
+  mark_announced "itil-correction-detect" "$SESSION_ID"
+fi
+
+exit 0

package/hooks/lib/detectors.sh

@@ -51,6 +51,30 @@ DIRECTION_PIN_PATTERNS=(
   '\bship it\b'
 )
 
+# Correction-signal patterns — strong-affect correction signals in
+# the user's incoming prompt that should trigger an offer to capture
+# a problem ticket for the underlying behavioural pattern (P078).
+# Extracted from feedback_capture_on_correction.md and the P078 ticket
+# Root Cause Analysis "missing trigger" vocabulary.
+#
+# Case-insensitive (grep -Eqi). False-positive budget is accepted per
+# P078 Investigation Tasks (a user message quoting the vocabulary in
+# non-correction context will fire — minor over-report traded for
+# signal reliability).
+CORRECTION_SIGNAL_PATTERNS=(
+  '\bFFS\b'
+  "for f.{1,3}'?s sake"
+  '\bDO NOT\b'
+  "\bDON'T\b"
+  '\bSTOP\b'
+  "that'?s wrong"
+  "that'?s not right"
+  "you'?re not listening"
+  '\byou (always|never|keep)\b'
+  '!{2,}'
+  '\bno\b.*\bwrong\b'
+)
+
 # detect_prose_ask: scans text on stdin for canonical prose-ask
 # phrasings. Exits 0 if any pattern matches, 1 otherwise. Writes the
 # first matched phrase to stdout (for observability in the Stop hook
@@ -88,3 +112,23 @@ detect_direction_pin() {
   done
   return 1
 }
+
+# detect_correction_signal: scans text on stdin for strong-affect
+# correction signals (P078). Exits 0 if any pattern matches, 1
+# otherwise. Writes the first matched phrase to stdout for
+# observability in the hook's systemMessage.
+#
+# Usage:
+#   if echo "$prompt" | detect_correction_signal > /dev/null; then ... fi
+detect_correction_signal() {
+  local text
+  text=$(cat)
+  local pattern
+  for pattern in "${CORRECTION_SIGNAL_PATTERNS[@]}"; do
+    if echo "$text" | grep -Eqi -- "$pattern"; then
+      echo "$pattern"
+      return 0
+    fi
+  done
+  return 1
+}

package/hooks/test/itil-correction-detect.bats

@@ -0,0 +1,136 @@
+#!/usr/bin/env bats
+
+# P078: itil-correction-detect.sh UserPromptSubmit hook must detect
+# strong-signal correction patterns in the incoming user prompt
+# (FFS / DO NOT / direct contradiction / exasperation markers /
+# meta-correction "you always|you never|you keep") and inject a
+# MANDATORY systemMessage instructing the assistant to OFFER
+# /wr-itil:capture-problem (with /wr-itil:manage-problem fallback)
+# BEFORE addressing the operational request.
+#
+# Per ADR-038: full block emits once per session; subsequent prompts
+# emit a terse reminder (<250 bytes) preserving the MANDATORY signal,
+# the gate name, and the capture-problem affordance.
+#
+# Per feedback_behavioural_tests.md (P081): these are behavioural
+# assertions — they simulate the hook payload on stdin and assert on
+# what the hook emits, not on the source text of the hook file.
+
+setup() {
+  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../.." && pwd)"
+  HOOK="$REPO_ROOT/packages/itil/hooks/itil-correction-detect.sh"
+  SID="itil-correction-test-$$-$RANDOM"
+}
+
+teardown() {
+  rm -f "/tmp/itil-correction-detect-announced-${SID}"
+  rm -f "/tmp/itil-correction-detect-announced-${SID}-alt"
+}
+
+run_hook() {
+  local sid="$1"
+  local prompt="$2"
+  echo "{\"session_id\":\"$sid\",\"prompt\":$(printf '%s' "$prompt" | jq -Rs .)}" | bash "$HOOK"
+}
+
+@test "correction-detect: 'FFS' triggers full MANDATORY block on first emission" {
+  run run_hook "$SID" "FFS, you didn't run the test"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+  [[ "$output" == *"capture-problem"* ]] || [[ "$output" == *"manage-problem"* ]]
+}
+
+@test "correction-detect: writes the announcement marker on first emission" {
+  run run_hook "$SID" "FFS stop framing it that way"
+  [ "$status" -eq 0 ]
+  [ -f "/tmp/itil-correction-detect-announced-${SID}" ]
+}
+
+@test "correction-detect: all-caps imperative 'DO NOT' triggers the block" {
+  run run_hook "$SID" "DO NOT TELL ME the cache is stale when you haven't installed it"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+}
+
+@test "correction-detect: meta-correction 'you always' triggers the block" {
+  run run_hook "$SID" "you always do this — frame your own failures as external"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+}
+
+@test "correction-detect: direct contradiction 'that's wrong' triggers the block" {
+  run run_hook "$SID" "no, that's wrong — the cache wasn't refreshed because you didn't install"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+}
+
+@test "correction-detect: exasperation '!!!' triggers the block" {
+  run run_hook "$SID" "stop framing your own failure as external!!!"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+}
+
+@test "correction-detect: 'you're not listening' triggers the block" {
+  run run_hook "$SID" "you're not listening — install first then check the cache"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [[ "$output" == *"MANDATORY"* ]]
+}
+
+@test "correction-detect: second correction prompt in same session emits terse reminder only" {
+  run_hook "$SID" "FFS that's not right" >/dev/null
+  run run_hook "$SID" "DO NOT do that again"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -lt 250 ]
+  [[ "$output" == *"capture-problem"* ]] || [[ "$output" == *"manage-problem"* ]]
+  [[ "$output" != *"NON-OPTIONAL RULES"* ]]
+}
+
+@test "correction-detect: terse reminder preserves MANDATORY / REQUIRED signal word" {
+  run_hook "$SID" "FFS" >/dev/null
+  run run_hook "$SID" "you keep doing this"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"MANDATORY"* ]] || [[ "$output" == *"REQUIRED"* ]] || [[ "$output" == *"NON-OPTIONAL"* ]]
+}
+
+@test "correction-detect: emitted block names capture-problem and manage-problem fallback" {
+  run run_hook "$SID" "FFS!"
+  [ "$status" -eq 0 ]
+  [[ "$output" == *"capture-problem"* ]]
+  [[ "$output" == *"manage-problem"* ]]
+}
+
+@test "correction-detect: different session_id re-emits the full block" {
+  run_hook "$SID" "FFS" >/dev/null
+  local SID2="${SID}-alt"
+  run run_hook "$SID2" "FFS"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  rm -f "/tmp/itil-correction-detect-announced-${SID2}"
+}
+
+@test "correction-detect: empty session_id emits the full block and writes no marker" {
+  run run_hook "" "FFS, that's wrong"
+  [ "$status" -eq 0 ]
+  [ "${#output}" -gt 300 ]
+  [ ! -f "/tmp/itil-correction-detect-announced-" ]
+}
+
+@test "correction-detect: plain conversational prompt does not emit a block" {
+  run run_hook "$SID" "what does ADR-013 say about ambiguous decisions?"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+  [ ! -f "/tmp/itil-correction-detect-announced-${SID}" ]
+}
+
+@test "correction-detect: direction-pin 'yes' alone does not trigger" {
+  run run_hook "$SID" "yes, go ahead and update the ticket"
+  [ "$status" -eq 0 ]
+  [ -z "$output" ]
+  [ ! -f "/tmp/itil-correction-detect-announced-${SID}" ]
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/itil",
-  "version": "0.19.2-preview.196",
+  "version": "0.19.3-preview.198",
   "description": "ITIL-aligned IT service management for Claude Code (problem, and future incident/change skills)",
   "bin": {
     "windyroad-itil": "./bin/install.mjs"