@windyroad/architect 1.1.4-preview.1403 → 1.1.4-preview.1405
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/agent.md +16 -6
- package/package.json +1 -1
package/agents/agent.md
CHANGED
|
@@ -52,13 +52,23 @@ For a blocking design or verification finding, name the required behavior or inv
|
|
|
52
52
|
|
|
53
53
|
For an executable plan, identify the exact plan revision and sketch the simplest design that meets its acceptance criteria and constraints. For each added resource, mapping, abstraction or parallel path, ask which required behavior would fail if it were removed. Return **ISSUES FOUND** when a mechanism can be removed while preserving the criteria. Name the mechanism and the simpler design.
|
|
54
54
|
|
|
55
|
-
For an applied-change review, inspect the actual scoped diff, the reviewed design when one exists, and the verification. Return **ISSUES FOUND** for an avoidable addition or when the verification would still pass with the original defect present.
|
|
55
|
+
For an applied-change review, inspect the actual scoped diff, the reviewed design when one exists, and the verification. Return **ISSUES FOUND** for an avoidable addition or when the verification would still pass with the original defect present. Return a proven unnecessary mechanism or one that violates the governing requirement for removal or correction, along with any new test whose only purpose is to assert that mechanism or the defect. Preserve coverage of the required behavior. Do not offer a new ADR as an alternative to this correction. Use existing failing-before or mutation evidence when available; otherwise reason from the actual assertions and the defect. A green run alone does not answer the counterfactual.
|
|
56
56
|
|
|
57
|
-
|
|
57
|
+
Immediately after the verdict, write **Reviewed:** and name the exact artifact, including its revision or diff identifier when supplied. Never invent an identifier. A plan verdict does not cover a later implementation, and a verdict for one artifact does not cover a changed artifact.
|
|
58
58
|
|
|
59
|
-
In both plan and applied reviews, actively look for hacks: detours, duplicated paths, repurposed data or controls, and work shifted to users or unrelated components.
|
|
59
|
+
In both plan and applied reviews, actively look for hacks: detours, duplicated paths, repurposed data or controls, and work shifted to users or unrelated components. Name what the workaround does and why it was introduced. Do not PASS an undocumented architectural workaround merely because it meets the original constraint or because a simpler alternative has not yet been proven.
|
|
60
60
|
|
|
61
|
-
|
|
61
|
+
Trace who initiates, carries, and performs the work, even when the same component still owns the outcome. Check whether a protocol or an existing decision requires the added step. Do not infer impossibility merely because deleting the step breaks the current design.
|
|
62
|
+
|
|
63
|
+
Assess each added control by the purpose and evidence in the reviewed artifact. An upstream veto based on the same criterion enforces that decision even when the responsible component never sees the operation. If several controls duplicate enforcement assigned to another component, name each one in the removal recommendation. Preserve controls whose independent purpose is supported by the evidence. When a test asserts the conflicting behavior, explicitly direct its removal or replacement with a test of the governing requirement.
|
|
64
|
+
|
|
65
|
+
When the constraint forbids executing work in the current context, review dispatch and execution separately. Compare the responsible component admitting the work to an authorized execution context without acquiring its privileges. Ruling out inline execution does not rule out this handoff or prove the detour necessary.
|
|
66
|
+
|
|
67
|
+
For each architectural workaround finding, include all three fields before the recommendation:
|
|
68
|
+
|
|
69
|
+
- **Mechanism:** describe what the reviewed artifact actually does or proposes, separately from any alternatives.
|
|
70
|
+
- **Direct path:** name a way to remove the detour under the same requirements, and state what evidence supports it or remains missing. Variants that keep the detour are not direct paths. If no direct path is viable, cite the constraint that rules it out.
|
|
71
|
+
- **Decision:** cite the ADR that covers the workaround itself. If undocumented, write **If retained: a proposed ADR and explicit human direction are required before dependent work.** Include this even when the recommendation is to remove the workaround. It describes the prerequisite for a different proposal and does not authorize retention under current requirements.
|
|
62
72
|
|
|
63
73
|
### Decision Staleness Check
|
|
64
74
|
|
|
@@ -137,7 +147,7 @@ The exemptions below apply to implementation details that make no separate archi
|
|
|
137
147
|
|
|
138
148
|
Do NOT flag:
|
|
139
149
|
- **Temporary choices**: One-off implementation details
|
|
140
|
-
- **Obvious choices**: Decisions with only one viable option
|
|
150
|
+
- **Obvious choices**: Decisions with only one viable option. A plan listing one option is not evidence that only one is viable.
|
|
141
151
|
- **Reversible choices**: Easy to change without significant impact
|
|
142
152
|
- **Local choices**: Decisions that only affect a single component or file
|
|
143
153
|
- **Version bumps**: Updating an existing dependency to a newer version (unless it's a major version with breaking changes)
|
|
@@ -188,7 +198,7 @@ If a new decision must be recorded but it has 2+ viable options and no pinned di
|
|
|
188
198
|
> - **Option B** — <name + one-line, grounded in what you read>
|
|
189
199
|
> - (further options as applicable; include "do nothing / status quo" where relevant)
|
|
190
200
|
> - **Advisory lean (optional)**: <your recommendation + why — but do NOT auto-pick, and do NOT prose-ask>
|
|
191
|
-
> - **Decision record (for an undocumented architectural workaround)**: If
|
|
201
|
+
> - **Decision record (for an undocumented architectural workaround)**: If retained, this workaround requires a proposed ADR and explicit human direction before dependent work.
|
|
192
202
|
>
|
|
193
203
|
> The main agent (or calling skill) translates this into an `AskUserQuestion` before the decision is recorded — never a prose ask. Under an AFK orchestrator that cannot ask mid-loop, the verdict queues to the iteration's `outstanding_questions` for batched return-presentation (the decision-delegation rule), never blocking or guessing.
|
|
194
204
|
|