@windyroad/architect 0.18.3 → 0.18.4-preview.884

package/.claude-plugin/plugin.json

@@ -123,5 +123,5 @@
     }
   },
   "name": "wr-architect",
-  "version": "0.18.3"
+  "version": "0.18.4"
 }

package/.codex-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "wr-architect",
-  "version": "0.18.3",
+  "version": "0.18.4",
   "description": "Architecture decision enforcement for AI coding agents",
   "author": {
     "name": "Windy Road Technology",

package/hooks/test/architect-oversight-marker-discipline.bats

@@ -217,6 +217,23 @@ mk_existing_adr() {
   [ -f "$(expected_marker "$adr")" ]
 }
 
+# P368: genuine cold path — no CLAUDE_SESSION_ID and no announce markers at all.
+# The shim correctly writes zero markers (nothing to key on) but must NOT do so
+# SILENTLY: a loud stderr diagnostic explains why the subsequent discipline-hook
+# deny happens, breaking the confusing "you didn't run the shim" loop the shim's
+# prior silent exit 0 produced. Exit stays 0 (documented contract: do not crash
+# SKILL flows before any hook has fired this session).
+@test "mark-oversight-confirmed.sh emits a loud stderr diagnostic on the no-candidate cold path (P368)" {
+  mk_existing_adr "252-coldpath.proposed.md"
+  adr="$DIR/docs/decisions/252-coldpath.proposed.md"
+  # MARK_DIR is empty (no *-announced-* markers); unset the env SID fast-path too.
+  run env -u CLAUDE_SESSION_ID bash "$MARK_SCRIPT" "$adr"
+  [ "$status" -eq 0 ]                              # contract: cold path still exits 0
+  [ ! -f "$(expected_marker "$adr")" ]             # no marker written
+  [[ "$output" == *"no candidate session id"* ]]   # loud, not silent
+  [[ "$output" == *"P368"* ]]
+}
+
 # ── Non-Edit/Write tool calls always exit 0 silently ────────────────────
 
 @test "tool_name=Bash exits 0 silently regardless of file path" {

package/hooks/test/architect-oversight-nudge.bats

@@ -12,6 +12,11 @@ setup() {
   PLUGIN_ROOT="$REPO_ROOT/packages/architect"
   DIR="$(mktemp -d)"
   mkdir -p "$DIR/docs/decisions"
+  # Hermeticity (P391): the AFK work-problems orchestrator exports
+  # WR_SUPPRESS_OVERSIGHT_NUDGE=1, which the hook self-suppresses on. Unset it so
+  # count-emitting tests assert real behaviour; guard-specific tests set it
+  # per-invocation via `run env WR_SUPPRESS_OVERSIGHT_NUDGE=...`.
+  unset WR_SUPPRESS_OVERSIGHT_NUDGE
 }
 
 teardown() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/architect",
-  "version": "0.18.3",
+  "version": "0.18.4-preview.884",
   "description": "Architecture decision enforcement for AI coding agents",
   "bin": {
     "windyroad-architect": "./bin/install.mjs"

package/scripts/mark-oversight-confirmed.sh

@@ -34,9 +34,10 @@
 #
 # Exit codes:
 #   0 — marker(s) written for at least one candidate SID, OR no candidate
-#       SID was discoverable (cold-path: no announce markers yet). The
-#       latter is a no-op so SKILL flows do not crash before any hook has
-#       fired in the session.
+#       SID was discoverable (cold path: no announce markers yet). The latter
+#       writes no marker and prints a loud stderr diagnostic (P368) explaining
+#       the downstream hook deny, then exits 0 so SKILL flows do not crash
+#       before any hook has fired in the session.
 #   2 — bad argument (missing or empty artefact-path).
 #
 # @adr ADR-066 (human-oversight marker)
@@ -97,10 +98,23 @@ candidates=$(
   } | awk 'NF && !seen[$0]++'
 )
 
-# No candidate SID — cold path. Exit 0 so SKILL flows do not crash before any
-# hook has fired this session. The subsequent Write deny will naturally
-# surface the missing-marker case to the agent.
-[ -n "$candidates" ] || exit 0
+# No candidate SID — cold path. Emit a loud stderr diagnostic (P368) and still
+# exit 0. Exit 0 preserves the documented contract (do not crash SKILL flows
+# before any announce marker has fired this session); the diagnostic replaces the
+# prior SILENT no-op, which masqueraded as success and left the caller to hit the
+# oversight-marker-discipline hook's deny with no idea why — the confusing loop
+# P368 documents (the deny points back at this shim, which the caller already ran).
+if [ -z "$candidates" ]; then
+  {
+    echo "wr-architect-mark-oversight-confirmed: no candidate session id discoverable"
+    echo "  (CLAUDE_SESSION_ID empty and no *-announced-* markers in ${MARKER_DIR} within ${WINDOW_MINS}min)."
+    echo "  NO oversight marker was written for: ${ABS_PATH}"
+    echo "  The oversight-marker-discipline hook will DENY the 'human-oversight: confirmed' Edit"
+    echo "  until a session announce marker exists. Start a fresh session, or point SESSION_MARKER_DIR"
+    echo "  at a dir containing a *-announced-<sid> file, then re-run this shim (P368)."
+  } >&2
+  exit 0
+fi
 
 while IFS= read -r sid; do
   [ -n "$sid" ] || continue