@windyroad/architect 0.1.2 → 0.1.3-preview.27

package/README.md

@@ -0,0 +1,66 @@
+# @windyroad/architect
+
+**Architecture decision enforcement for Claude Code.** Ensures every code change is reviewed against your project's architecture decisions before it lands.
+
+Part of [Windy Road Agent Plugins](../../README.md).
+
+## What It Does
+
+The architect plugin prevents architectural drift by gating edits behind an architecture review. When you have a `docs/decisions/` directory, the plugin:
+
+1. **Detects** your architecture decisions on every prompt
+2. **Blocks** edits to project files until the architect agent has reviewed the proposed changes
+3. **Reviews** changes against your existing ADRs (Architecture Decision Records) and flags conflicts
+4. **Flags** when a new decision should be documented
+
+No decisions directory yet? The plugin stays silent until you create one.
+
+## Install
+
+```bash
+npx @windyroad/architect
+```
+
+Restart Claude Code after installing.
+
+## Usage
+
+Once installed, the plugin works automatically. You don't need to invoke it -- it intercepts edits and runs the review before allowing changes through.
+
+**Create a new Architecture Decision Record:**
+
+```
+/wr-architect:create-adr
+```
+
+This walks you through creating an ADR in [MADR 4.0](https://adr.github.io/madr/) format. It examines your existing decisions, asks about the problem and options, and writes a properly formatted record to `docs/decisions/`.
+
+## How It Works
+
+| Hook | Trigger | What it does |
+|------|---------|-------------|
+| `architect-detect.sh` | Every prompt | Checks for `docs/decisions/` and injects the review instruction |
+| `architect-enforce-edit.sh` | Edit or Write | Blocks the edit if the architect hasn't reviewed yet |
+| `architect-plan-enforce.sh` | ExitPlanMode | Ensures plans are reviewed before execution |
+| `architect-mark-reviewed.sh` | Agent completes | Marks the review as done (TTL: 1800s) |
+| `architect-refresh-hash.sh` | After edit | Refreshes the content hash so the next edit triggers a fresh review |
+| `architect-reset-marker.sh` | Session end | Cleans up review markers |
+
+## Agent
+
+The `wr-architect:agent` reviews proposed changes against existing decisions in `docs/decisions/` and reports:
+
+- Whether changes comply with or violate existing decisions
+- Whether a new ADR should be created
+- Whether existing decisions are stale and need reassessment
+
+## Updating and Uninstalling
+
+```bash
+npx @windyroad/architect --update
+npx @windyroad/architect --uninstall
+```
+
+## Licence
+
+[MIT](../../LICENSE)

package/agents/agent.md

@@ -10,7 +10,6 @@ tools:
   - Read
   - Glob
   - Grep
-  - Bash
 model: inherit
 ---
 
@@ -107,20 +106,9 @@ Issue types:
 - **[Missing Supersession]**: A new decision should supersede an old one but doesn't
 - **[Confirmation Violation]**: New code violates a confirmation criterion of an existing decision
 
-## Verdict File
-
-After completing your review, you MUST write a verdict file so the hook system knows the outcome:
-
-- After **PASS**: `echo "PASS" > /tmp/architect-verdict`
-- After **ISSUES FOUND**: `echo "FAIL" > /tmp/architect-verdict`
-
-Advisory items (staleness flags) do NOT count as FAIL. Only write FAIL when there are actionable issues (Decision Conflict, Undocumented Decision, Decision Format, Missing Supersession, Confirmation Violation).
-
-You MUST NOT use Bash for anything other than writing the verdict file.
-
 ## Constraints
 
-- You are read-only. You do not edit files (the only exception is writing the verdict file via Bash).
+- You are read-only. You do not edit files.
 - You review all project files: source code, configuration, CI workflows, hook scripts, build scripts, and decision files. The only exclusions are stylesheets, images, lockfiles, and font files.
 - If the change is purely cosmetic (comments, formatting, whitespace), report PASS.
 - Do not block changes that are clearly within the scope of an existing accepted decision.

package/hooks/architect-mark-reviewed.sh

@@ -1,17 +1,19 @@
 #!/bin/bash
 # Architecture - PostToolUse hook for Agent tool
 # Creates a session marker when architect has been consulted.
+# Parses verdict from agent output text (session-safe, no temp files).
 # This marker unlocks the architect-enforce-edit.sh PreToolUse block.
-# Mirrors: voice-tone-mark-reviewed.sh
 
-# Source shared portable helpers (_mtime, _hashcmd)
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 source "$SCRIPT_DIR/lib/gate-helpers.sh"
 
-INPUT=$(cat)
+_parse_input
 
-SUBAGENT=$(echo "$INPUT" | jq -r '.tool_input.subagent_type // empty') || true
-SESSION_ID=$(echo "$INPUT" | jq -r '.session_id // empty') || true
+TOOL_NAME=$(_get_tool_name)
+[ "$TOOL_NAME" = "Agent" ] || exit 0
+
+SUBAGENT=$(_get_subagent_type)
+SESSION_ID=$(_get_session_id)
 
 if [ -z "$SESSION_ID" ]; then
   exit 0
@@ -19,25 +21,24 @@ fi
 
 case "$SUBAGENT" in
   *architect*)
-    # Check verdict file from architect agent
-    VERDICT_FILE="/tmp/architect-verdict"
+    # Parse verdict from agent output text (no temp file needed)
+    AGENT_OUTPUT=$(_get_tool_output)
     VERDICT=""
-    if [ -f "$VERDICT_FILE" ]; then
-      VERDICT=$(cat "$VERDICT_FILE")
-      rm -f "$VERDICT_FILE"
+    if echo "$AGENT_OUTPUT" | grep -q "Architecture Review: PASS"; then
+      VERDICT="PASS"
+    elif echo "$AGENT_OUTPUT" | grep -q "ISSUES FOUND"; then
+      VERDICT="FAIL"
     fi
 
     case "$VERDICT" in
       PASS)
-        # Architect explicitly passed, create marker
         touch "/tmp/architect-reviewed-${SESSION_ID}"
         ;;
       FAIL)
-        # Architect found issues, do NOT create marker
+        # Do NOT create marker — review found issues
         ;;
       *)
-        # No verdict file (agent error or old agent version)
-        # Allow with warning to avoid permanent lockout
+        # Could not parse verdict — allow with marker to avoid lockout
         touch "/tmp/architect-reviewed-${SESSION_ID}"
         ;;
     esac
@@ -52,6 +53,8 @@ case "$SUBAGENT" in
       echo "$HASH" > "/tmp/architect-reviewed-${SESSION_ID}.hash"
     fi
 
+    # Plan review marker
+    touch "/tmp/architect-plan-reviewed-${SESSION_ID}"
     ;;
 esac
 

package/hooks/lib/architect-gate.sh

@@ -12,7 +12,7 @@ source "$_ARCHITECT_GATE_DIR/gate-helpers.sh"
 check_architect_gate() {
   local SESSION_ID="$1"
   local MARKER="/tmp/architect-reviewed-${SESSION_ID}"
-  local TTL_SECONDS="${ARCHITECT_TTL:-600}"
+  local TTL_SECONDS="${ARCHITECT_TTL:-1800}"
 
   if [ -n "$SESSION_ID" ] && [ -f "$MARKER" ]; then
     local NOW=$(date +%s)

package/hooks/test/architect-gate.bats

@@ -0,0 +1,32 @@
+#!/usr/bin/env bats
+
+# Tests for architect-gate.sh (TTL, drift, marker)
+
+setup() {
+  SCRIPT_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
+  source "$SCRIPT_DIR/lib/architect-gate.sh"
+  TEST_SESSION="test-$$-$BATS_TEST_NUMBER"
+}
+
+teardown() {
+  rm -f "/tmp/architect-reviewed-${TEST_SESSION}"
+  rm -f "/tmp/architect-reviewed-${TEST_SESSION}.hash"
+}
+
+@test "gate denies when no marker exists" {
+  run check_architect_gate "$TEST_SESSION"
+  [ "$status" -ne 0 ]
+}
+
+@test "gate allows when marker exists and is fresh" {
+  touch "/tmp/architect-reviewed-${TEST_SESSION}"
+  run check_architect_gate "$TEST_SESSION"
+  [ "$status" -eq 0 ]
+}
+
+@test "gate denies when marker is expired" {
+  touch "/tmp/architect-reviewed-${TEST_SESSION}"
+  # Set TTL to 0 to force expiry
+  ARCHITECT_TTL=0 run check_architect_gate "$TEST_SESSION"
+  [ "$status" -ne 0 ]
+}

package/hooks/test/architect-mark-reviewed.bats

@@ -0,0 +1,26 @@
+#!/usr/bin/env bats
+
+# Tests for architect verdict parsing from output text
+
+@test "grep matches 'Architecture Review: PASS'" {
+  output="Some preamble text\n\n**Architecture Review: PASS**\n\nNo conflicts."
+  echo -e "$output" | grep -q "Architecture Review: PASS"
+}
+
+@test "grep matches 'ISSUES FOUND'" {
+  output="**Architecture Review: ISSUES FOUND**\n\n1. [Decision Conflict]"
+  echo -e "$output" | grep -q "ISSUES FOUND"
+}
+
+@test "grep does NOT match unrelated text" {
+  output="The review is complete. Everything looks good."
+  ! echo -e "$output" | grep -q "Architecture Review: PASS"
+}
+
+@test "subagent pattern matches wr-architect:agent" {
+  SUBAGENT="wr-architect:agent"
+  case "$SUBAGENT" in
+    *architect*) true ;;
+    *) false ;;
+  esac
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@windyroad/architect",
-  "version": "0.1.2",
+  "version": "0.1.3-preview.27",
   "description": "Architecture decision enforcement for AI coding agents",
   "bin": {
     "windyroad-architect": "./bin/install.mjs"

package/skills/{wr:adr → create-adr}/SKILL.md

@@ -1,5 +1,5 @@
 ---
-name: wr:adr
+name: wr-architect:create-adr
 description: Create a new Architecture Decision Record (MADR 4.0) in docs/decisions/. Examines existing decisions, asks about the problem and options, and writes a properly formatted ADR.
 allowed-tools: Read, Write, Edit, Bash, Glob, Grep, AskUserQuestion
 ---