@windstream/react-shared-components 0.1.92 → 0.1.94

package/src/contentful/blocks/navigation/desktop-link-groups.tsx/index.test.tsx

@@ -0,0 +1,208 @@
+import React from "react";
+import { DesktopLinkGroups } from "./index";
+
+import { act, fireEvent, render, screen } from "@testing-library/react";
+
+jest.mock("@shared/components/material-icon", () => ({
+  MaterialIcon: ({ name, className }: any) => (
+    <span data-testid={`icon-${name}`} className={className}>
+      {name}
+    </span>
+  ),
+}));
+
+jest.mock("@shared/components/text", () => ({
+  Text: ({ as: Tag = "span", children, className }: any) => (
+    <Tag className={className}>{children}</Tag>
+  ),
+}));
+
+jest.mock("@shared/contentful/blocks/button", () => ({
+  Button: ({
+    children,
+    buttonClassName,
+    onClick,
+    linkClassName,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    showButtonAs,
+    ...rest
+  }: any) => (
+    <button
+      data-testid="button"
+      className={buttonClassName || linkClassName}
+      onClick={onClick}
+      aria-expanded={rest["aria-expanded"]}
+    >
+      {children || rest.buttonLabel}
+    </button>
+  ),
+}));
+
+let outsideClickCallback: (() => void) | null = null;
+jest.mock("@shared/hooks/use-outside-click", () => ({
+  useOutsideClick: (_ref: any, cb: () => void) => {
+    outsideClickCallback = cb;
+  },
+}));
+
+jest.mock("@shared/utils", () => ({
+  cx: (...args: any[]) => args.filter(Boolean).join(" "),
+}));
+
+describe("DesktopLinkGroups", () => {
+  it("renders nothing when link is undefined", () => {
+    const { container } = render(
+      <DesktopLinkGroups anchorName="test" link={undefined} />
+    );
+    expect(container.innerHTML).toBe("");
+  });
+
+  it("renders single Button when link is a button (has href)", () => {
+    const link = {
+      href: "/products",
+      buttonLabel: "Products",
+      anchorId: "prod",
+    };
+    render(<DesktopLinkGroups anchorName="nav-0" link={link as any} />);
+    expect(screen.getByTestId("button")).toHaveTextContent("Products");
+  });
+
+  describe("Group rendering", () => {
+    const groupLink = {
+      anchorId: "group-1",
+      title: "My Account",
+      items: {
+        items: [
+          { buttonLabel: "Profile", href: "/profile", anchorId: "p1" },
+          { buttonLabel: "Settings", href: "/settings", anchorId: "p2" },
+        ],
+      },
+    };
+
+    it("renders group title button", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      expect(screen.getByText("My Account")).toBeInTheDocument();
+    });
+
+    it("renders dropdown arrow icon (down when closed)", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      expect(
+        screen.getByTestId("icon-keyboard_arrow_down")
+      ).toBeInTheDocument();
+    });
+
+    it("toggles open state and shows up arrow when open", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      expect(screen.getByTestId("icon-keyboard_arrow_up")).toBeInTheDocument();
+    });
+
+    it("renders submenu items when open", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      expect(screen.getByText("Profile")).toBeInTheDocument();
+      expect(screen.getByText("Settings")).toBeInTheDocument();
+    });
+
+    it("closes when toggled again", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      fireEvent.click(toggleBtn);
+      expect(
+        screen.getByTestId("icon-keyboard_arrow_down")
+      ).toBeInTheDocument();
+    });
+
+    it("renders null title when title is missing", () => {
+      const noTitleLink = { ...groupLink, title: null };
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={noTitleLink as any} />
+      );
+      // Should still render without error
+      expect(screen.getAllByTestId("button")[0]).toBeInTheDocument();
+    });
+
+    it("handles empty items array", () => {
+      const emptyItems = { ...groupLink, items: { items: [] } };
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={emptyItems as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      // No submenu links rendered
+      expect(screen.getAllByTestId("button")).toHaveLength(1);
+    });
+
+    it("handles null items", () => {
+      const nullItems = { ...groupLink, items: null };
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={nullItems as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      expect(screen.getAllByTestId("button")).toHaveLength(1);
+    });
+
+    it("closes when a submenu anchor link is clicked", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      // Simulate clicking an anchor within the submenu ul
+      const submenuList = screen.getByRole("list");
+      const anchor = document.createElement("a");
+      anchor.href = "/profile";
+      submenuList.appendChild(anchor);
+      fireEvent.click(anchor);
+      // After click, arrow should be down (closed)
+      expect(
+        screen.getByTestId("icon-keyboard_arrow_down")
+      ).toBeInTheDocument();
+    });
+
+    it("does not close when non-anchor element is clicked in submenu", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      const submenuList = screen.getByRole("list");
+      // Click on a non-anchor element
+      fireEvent.click(submenuList);
+      // Should still be open
+      expect(screen.getByTestId("icon-keyboard_arrow_up")).toBeInTheDocument();
+    });
+
+    it("closes when outside click is triggered", () => {
+      render(
+        <DesktopLinkGroups anchorName="account-0" link={groupLink as any} />
+      );
+      const toggleBtn = screen.getAllByTestId("button")[0];
+      fireEvent.click(toggleBtn);
+      // Should be open
+      expect(screen.getByTestId("icon-keyboard_arrow_up")).toBeInTheDocument();
+      // Trigger outside click callback
+      act(() => {
+        outsideClickCallback!();
+      });
+      // Should close
+      expect(
+        screen.getByTestId("icon-keyboard_arrow_down")
+      ).toBeInTheDocument();
+    });
+  });
+});

package/src/contentful/blocks/navigation/desktop-link-groups.tsx/index.tsx

@@ -1,139 +1,141 @@
-import React, { CSSProperties } from "react";
-
-import { MaterialIcon } from "@shared/components/material-icon";
-import { Text } from "@shared/components/text";
-import { Button } from "@shared/contentful/blocks/button";
-import { ButtonProps as ContentfulButtonProps } from "@shared/contentful/blocks/button/types";
-import { useOutsideClick } from "@shared/hooks/use-outside-click";
-import { cx } from "@shared/utils";
-
-type ComponentButtonGroup = {
-  anchorId?: string | null;
-  title?: string | null;
-  items?: { items?: ContentfulButtonProps[] | null } | null;
-};
-
-type Link = ContentfulButtonProps | ComponentButtonGroup;
-
-type LinkGroupsProps = {
-  link?: Link;
-  anchorName: string;
-  /**
-   * Tailwind text-color class to apply to the top-level link/group
-   * label. Lets the parent navbar invert text color (e.g. `text-white`)
-   * when rendered on a dark background. Submenu items keep their
-   * default `text-text-link` so they remain readable on the white
-   * popover background.
-   */
-  linkColorClassName?: string;
-};
-
-const isButton = (link: Link): link is ContentfulButtonProps => {
-  // If your group never has `href`, this is a simple and effective guard
-  return typeof (link as ContentfulButtonProps).href === "string";
-};
-
-export const DesktopLinkGroups: React.FC<LinkGroupsProps> = ({
-  link,
-  anchorName,
-  linkColorClassName,
-}) => {
-  const [isOpen, setIsOpen] = React.useState(false);
-
-  const ref = React.useRef<HTMLDivElement>(null);
-  useOutsideClick(ref, () => setIsOpen(false));
-
-  if (!link) return null;
-
-  // Single button
-  if (isButton(link)) {
-    return (
-      <Button
-        key={`submenu-link-btn-${link.anchorId}`}
-        {...link}
-        linkClassName={cx(
-          "body3 flex items-center h-full",
-          linkColorClassName || "text-text"
-        )}
-        linkVariant="unstyled"
-      />
-    );
-  }
-
-  // Group
-  const { anchorId, title, items } = link;
-  const subMenu = Array.isArray(items?.items) ? items!.items! : [];
-  const fullAnchorName = `--link-anchor-${anchorName}`;
-
-  return (
-    <div
-      className="relative h-full"
-      style={{ anchorName: fullAnchorName } as CSSProperties}
-      ref={ref}
-    >
-      <Button
-        onClick={() => setIsOpen(prev => !prev)}
-        aria-expanded={isOpen}
-        buttonClassName={cx(
-          "group body3 flex h-full items-center",
-          linkColorClassName || "text-text"
-        )}
-        key={anchorId}
-        showButtonAs="unstyled"
-      >
-        <Text as="span" className="group-hover:underline">
-          {title ?? null}
-        </Text>
-        <MaterialIcon
-          weight="200"
-          size={24}
-          className="text-icon-secondary group-hover:opacity-50"
-          name={isOpen ? "keyboard_arrow_up" : "keyboard_arrow_down"}
-        />
-      </Button>
-
-      <div
-        className={cx(
-          "shadow-navDrop fixed z-[1001] min-w-44 rounded-input-poppers border border-border bg-bg",
-          "transition-[opacity,transform] ease-out",
-          isOpen && subMenu.length > 0
-            ? "pointer-events-auto translate-y-0 opacity-100 duration-75"
-            : "pointer-events-none -translate-y-2 opacity-0 duration-0"
-        )}
-        style={
-          {
-            positionAnchor: fullAnchorName,
-            top: "anchor(bottom)",
-            left: "calc((anchor(left) + anchor(right)) / 2)",
-            translate: "-50% 0",
-          } as CSSProperties
-        }
-      >
-        <ul
-          className="flex flex-col gap-2 py-2"
-          onClick={event => {
-            // Close the popup when a submenu link is clicked.
-            // Required for Pages Router where this component persists across
-            // client-side navigations and `isOpen` would otherwise stay true.
-            const target = event.target as HTMLElement | null;
-            if (target?.closest("a")) {
-              setIsOpen(false);
-            }
-          }}
-        >
-          {subMenu.map((site, index) => {
-            return (
-              <li key={`submenu-link-${index}`} className="submenu-link">
-                <Button
-                  {...site}
-                  linkVariant="unstyled"
-                  linkClassName="body3 px-4 hover:bg-bg-surface-hover flex items-center w-full h-11 text-text-link"
-                />
-              </li>
-            );
-          })}
-        </ul>
-      </div>
-    </div>
-  );
-};
+import React, { CSSProperties } from "react";
+
+import { MaterialIcon } from "@shared/components/material-icon";
+import { Text } from "@shared/components/text";
+import { Button } from "@shared/contentful/blocks/button";
+import { ButtonProps as ContentfulButtonProps } from "@shared/contentful/blocks/button/types";
+import { useOutsideClick } from "@shared/hooks/use-outside-click";
+import { cx } from "@shared/utils";
+
+type ComponentButtonGroup = {
+  anchorId?: string | null;
+  title?: string | null;
+  items?: { items?: ContentfulButtonProps[] | null } | null;
+};
+
+type Link = ContentfulButtonProps | ComponentButtonGroup;
+
+type LinkGroupsProps = {
+  link?: Link;
+  anchorName: string;
+  /**
+   * Tailwind text-color class to apply to the top-level link/group
+   * label. Lets the parent navbar invert text color (e.g. `text-white`)
+   * when rendered on a dark background. Submenu items keep their
+   * default `text-text-link` so they remain readable on the white
+   * popover background.
+   */
+  linkColorClassName?: string;
+};
+
+const isButton = (link: Link): link is ContentfulButtonProps => {
+  // If your group never has `href`, this is a simple and effective guard
+  return typeof (link as ContentfulButtonProps).href === "string";
+};
+
+export const DesktopLinkGroups: React.FC<LinkGroupsProps> = ({
+  link,
+  anchorName,
+  linkColorClassName,
+}) => {
+  const [isOpen, setIsOpen] = React.useState(false);
+
+  const ref = React.useRef<HTMLDivElement>(null);
+  useOutsideClick(ref, () => setIsOpen(false));
+
+  if (!link) return null;
+
+  // Single button
+  if (isButton(link)) {
+    return (
+      <Button
+        key={`submenu-link-btn-${link.anchorId}`}
+        {...link}
+        showButtonAs="text"  
+        linkClassName={cx(
+          "body3 inline-flex items-center no-underline hover:underline",  
+          linkColorClassName || "text-text"
+        )}
+      />
+    );
+  }
+
+
+  // Group
+  const { anchorId, title, items } = link;
+  const subMenu = Array.isArray(items?.items) ? items!.items! : [];
+  const fullAnchorName = `--link-anchor-${anchorName}`;
+
+  return (
+    <div
+      className="relative h-full"
+      style={{ anchorName: fullAnchorName } as CSSProperties}
+      ref={ref}
+    >
+      <Button
+        onClick={() => setIsOpen(prev => !prev)}
+        aria-expanded={isOpen}
+        buttonClassName={cx(
+          "group body3 flex items-center h-full",
+          linkColorClassName || "text-text"
+        )}
+        key={anchorId}
+        showButtonAs="unstyled"   
+      >
+
+        <Text as="span" className="group-hover:underline leading-none">
+          {title ?? null}
+        </Text>
+        <MaterialIcon
+          weight="200"
+          size={24}
+          className="text-icon-secondary group-hover:opacity-50 mt-[1px]"
+          name={isOpen ? "keyboard_arrow_up" : "keyboard_arrow_down"}
+        />
+      </Button>
+
+      <div
+        className={cx(
+          "shadow-navDrop fixed z-[1001] min-w-44 rounded-input-poppers border border-border bg-bg",
+          "transition-[opacity,transform] ease-out",
+          isOpen && subMenu.length > 0
+            ? "pointer-events-auto translate-y-0 opacity-100 duration-75"
+            : "pointer-events-none -translate-y-2 opacity-0 duration-0"
+        )}
+        style={
+          {
+            positionAnchor: fullAnchorName,
+            top: "anchor(bottom)",
+            left: "calc((anchor(left) + anchor(right)) / 2)",
+            translate: "-50% 0",
+          } as CSSProperties
+        }
+      >
+        <ul
+          className="flex flex-col gap-2 py-2"
+          onClick={event => {
+            // Close the popup when a submenu link is clicked.
+            // Required for Pages Router where this component persists across
+            // client-side navigations and `isOpen` would otherwise stay true.
+            const target = event.target as HTMLElement | null;
+            if (target?.closest("a")) {
+              setIsOpen(false);
+            }
+          }}
+        >
+          {subMenu.map((site, index) => {
+            return (
+              <li key={`submenu-link-${index}`} className="submenu-link">
+                <Button
+                  {...site}
+                  showButtonAs="text"
+                  linkClassName="body3 px-3 flex items-center text-text-link no-underline hover:underline hover:bg-bg-surface-hover"
+                />
+              </li>
+            );
+          })}
+        </ul>
+      </div>
+    </div>
+  );
+};