@window-splitter/state 1.1.2 → 1.1.4

package/package.json

@@ -2,7 +2,7 @@
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@window-splitter/state",
   "sideEffects": false,
-  "version": "1.1.2",
+  "version": "1.1.4",
   "description": "A state machine for a WAI-ARIA compliant window splitter",
   "homepage": "https://react-window-splitter-six.vercel.app",
   "repository": {
@@ -29,7 +29,7 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@internal/eslint-config": "1.1.2",
+    "@internal/eslint-config": "1.1.4",
     "@testing-library/react": "^16.0.0",
     "@types/big.js": "^6.2.2",
     "@vitest/browser": "catalog:",
@@ -77,5 +77,5 @@
     "window"
   ],
   "types": "./dist/commonjs/index.d.ts",
-  "gitHead": "d9d2440aa94cb486fa4334f69a7e4717926f3192"
+  "gitHead": "df18ce3b7488d52f8d91ae7000f5dcaec65f6bdd"
 }

package/src/index.ts

@@ -1185,7 +1185,11 @@ function updateLayout(
 ): Partial<GroupMachineContextValue> {
   const handleIndex = getPanelHandleIndex(context, dragEvent.handleId);
   const handle = context.items[handleIndex] as PanelHandleData;
-  const newItems = [...context.items];
+  // Check if items need to be prepared (have non-pixel values)
+  const needsPrepare = context.items.some(
+    (item) => isPanelData(item) && item.currentValue.type !== "pixel"
+  );
+  const newItems = needsPrepare ? prepareItems(context) : [...context.items];
 
   let moveAmount =
     context.orientation === "horizontal"
@@ -1634,7 +1638,7 @@ function handleOverflow(context: GroupMachineContextValue) {
   const totalSize = pixelItems.reduce((acc, i) => acc.add(i), new Big(0));
   const overflow = totalSize.abs().sub(groupSize);
 
-  if (overflow.eq(0) || groupSize.eq(0)) {
+  if (overflow.abs().lt(1) || groupSize.eq(0)) {
     return context;
   }
 
@@ -2212,7 +2216,7 @@ export function groupMachine(
           context.items = withLastKnownSize;
         } else if (
           totalSize > getGroupSize(context) &&
-          state.current !== "dragging"
+          state.current === "idle"
         ) {
           context.items = handleOverflow({
             ...context,
@@ -2257,7 +2261,7 @@ export function groupMachine(
             panel,
             getUnitPixelValue(context, parseUnit(event.size))
           );
-          const isBigger = newSize > current;
+          const isBigger = newSize.gt(current);
           const delta = isBigger
             ? newSize.minus(current)
             : current.minus(newSize);

package/src/machine.test.ts

@@ -13,9 +13,11 @@ import {
   GroupMachineEvent,
   initializePanel,
   initializePanelHandleData,
+  isPanelData,
   isPanelHandle,
   prepareSnapshot,
 } from "./index.js";
+import Big from "big.js";
 import { spring } from "framer-motion";
 import * as Cookies from "tiny-cookie";
 import { Actor, createActor } from "./test-utils.js";
@@ -464,6 +466,151 @@ describe("constraints", () => {
     });
   });
 
+  // Test for https://github.com/hipstersmoothie/window-splitter/issues/79
+  // The bug: applyDelta in togglingCollapse state calls updateLayout without 
+  // ensuring items are in pixel format first. If items somehow end up in 
+  // percentage format during the animation, it fails.
+  test("applyDelta should handle percentage format items during animation", async () => {
+    const actor = createActor({ groupId: "group" });
+
+    sendAll(actor, [
+      { type: "registerPanel", data: initializePanel({ id: "panel-1" }) },
+      {
+        type: "registerPanelHandle",
+        data: initializePanelHandleData({ id: "resizer-1", size: "10px" }),
+      },
+      {
+        type: "registerPanel",
+        data: initializePanel({
+          id: "panel-2",
+          collapsible: true,
+          min: "100px",
+          default: "200px",
+          collapseAnimation: {
+            easing: "ease-in-out",
+            duration: 5000, // Long animation so we can intercept
+          },
+        }),
+      },
+    ]);
+
+    initializeSizes(actor, { width: 500, height: 200 });
+
+    // Start the collapse animation - this transitions to togglingCollapse
+    actor.send({
+      type: "collapsePanel",
+      panelId: "panel-2",
+    });
+
+    // Wait a tick for the animation to start
+    await new Promise((resolve) => setTimeout(resolve, 50));
+
+    // Verify we're in togglingCollapse state
+    expect(actor.state.current).toBe("togglingCollapse");
+
+    // Now simulate a scenario where items got back into percentage format
+    // (e.g., from autosave restoration or some edge case)
+    const groupSize = 500;
+    const staticWidth = 10;
+    const availableSpace = groupSize - staticWidth;
+    
+    for (const item of actor.value.items) {
+      if (isPanelData(item) && !item.collapsed) {
+        const pixelValue = item.currentValue.value.toNumber();
+        item.currentValue = {
+          type: "percent",
+          value: new Big(pixelValue).div(availableSpace),
+        };
+      }
+    }
+
+    // Send an applyDelta event - this is what the animation actor sends
+    // Before the fix, this should throw because updateLayout is called
+    // with percentage items
+    actor.send({
+      type: "applyDelta",
+      handleId: "resizer-1",
+      panelId: "panel-2",
+      delta: 10,
+    });
+
+    await waitForIdle(actor);
+  });
+
+
+  test("overflow measurements should not collapse panels during animation", async () => {
+    const actor = createActor({ groupId: "group" });
+
+    sendAll(actor, [
+      {
+        type: "registerPanel",
+        data: initializePanel({
+          id: "panel-1",
+          collapsible: true,
+          collapsedSize: "60px",
+          default: "140px",
+        }),
+      },
+      {
+        type: "registerPanelHandle",
+        data: initializePanelHandleData({ id: "resizer-1", size: "10px" }),
+      },
+      {
+        type: "registerPanel",
+        data: initializePanel({
+          id: "panel-2",
+          collapsible: true,
+          default: "140px",
+          collapseAnimation: {
+            easing: "ease-in-out",
+            duration: 500,
+          },
+        }),
+      },
+    ]);
+
+    actor.send({
+      type: "setSize",
+      size: { width: 300, height: 200 },
+    });
+    actor.send({
+      type: "setActualItemsSize",
+      childrenSizes: {
+        "panel-1": { width: 140, height: 200 },
+        "panel-2": { width: 140, height: 200 },
+      },
+    });
+
+    const panelBefore = actor.value.items.find(
+      (item) => isPanelData(item) && item.id === "panel-1"
+    );
+    expect(panelBefore?.collapsed).toBe(false);
+
+    actor.send({
+      type: "collapsePanel",
+      panelId: "panel-2",
+    });
+
+    await new Promise((resolve) => setTimeout(resolve, 50));
+
+    expect(actor.state.current).toBe("togglingCollapse");
+
+    actor.send({
+      type: "setActualItemsSize",
+      childrenSizes: {
+        "panel-1": { width: 200, height: 200 },
+        "panel-2": { width: 200, height: 200 },
+      },
+    });
+
+    const panelAfter = actor.value.items.find(
+      (item) => isPanelData(item) && item.id === "panel-1"
+    );
+    expect(panelAfter?.collapsed).toBe(false);
+
+    await waitForIdle(actor);
+  });
+
   test("supports 1 panel being collapsed with another panel expanding to fill", () => {
     const actor = createActor({
       groupId: "group",

package/.turbo/turbo-lint.log

@@ -1,18 +0,0 @@
-
-
-> @window-splitter/state@1.1.0 lint /Users/alisowski/Documents/react-window-splitter/packages/state
-> eslint .
-
-=============
-
-WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
-
-You may find that it works just fine, or you may not.
-
-SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
-
-YOUR TYPESCRIPT VERSION: 5.8.3
-
-Please only submit bug reports when using the officially supported version.
-
-=============

package/LICENSE

@@ -1,7 +0,0 @@
-Copyright 2025 Andrew Lisowski
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.