@window-splitter/react 1.1.3 → 1.1.5--canary.f61d2d9.0

package/src/ReactWindowSplitter.test.tsx

@@ -406,3 +406,121 @@ describe("imperative panel API", async () => {
     expect(leftHandle.current.isExpanded()).toBe(true);
   });
 });
+
+describe("direct-DOM animation path", () => {
+  test("grid template updates on the DOM during collapse animation", async () => {
+    const handle = { current: null } as unknown as {
+      current: PanelGroupHandle;
+    };
+    const panelHandle = { current: null } as unknown as {
+      current: PanelHandle;
+    };
+
+    render(
+      <div style={{ width: 500 }}>
+        <PanelGroup
+          handle={handle}
+          orientation="horizontal"
+          style={{ height: 200 }}
+        >
+          <Panel id="panel1">1</Panel>
+          <PanelResizer id="resizer1" size="10px" />
+          <Panel
+            id="panel2"
+            handle={panelHandle}
+            min="100px"
+            collapsible
+            collapsedSize="60px"
+            defaultCollapsed
+            collapseAnimation={{ easing: "linear", duration: 300 }}
+          >
+            2
+          </Panel>
+        </PanelGroup>
+      </div>
+    );
+
+    await waitForMeasurement(handle.current);
+    const templateBefore = handle.current.getTemplate();
+    expect(templateBefore).toContain("60px");
+
+    panelHandle.current.expand();
+
+    // Wait for animation to be in progress
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    expect(handle.current.getState()).toBe("dragging");
+
+    const groupEl = document.querySelector(
+      "[data-group-id]"
+    ) as HTMLElement;
+    expect(groupEl).toBeTruthy();
+    const domTemplateDuringAnimation = groupEl.style.gridTemplateColumns;
+    expect(domTemplateDuringAnimation).toBeTruthy();
+    expect(domTemplateDuringAnimation).not.toContain("60px");
+
+    await new Promise((resolve) => setTimeout(resolve, 500));
+    expect(handle.current.getState()).toBe("idle");
+
+    // After animation ends, onUpdate fires once and React re-renders with the
+    // committed template. The DOM should no longer contain the collapsed size.
+    const finalDomTemplate = groupEl.style.gridTemplateColumns;
+    expect(finalDomTemplate).not.toContain("60px");
+  });
+
+  test("panel children do not re-render during animation", async () => {
+    const handle = { current: null } as unknown as {
+      current: PanelGroupHandle;
+    };
+    const panelHandle = { current: null } as unknown as {
+      current: PanelHandle;
+    };
+
+    let renderCount = 0;
+    const RenderCounter = () => {
+      renderCount++;
+      return <div data-testid="counter">renders: {renderCount}</div>;
+    };
+
+    render(
+      <div style={{ width: 500 }}>
+        <PanelGroup
+          handle={handle}
+          orientation="horizontal"
+          style={{ height: 200 }}
+        >
+          <Panel id="panel1">
+            <RenderCounter />
+          </Panel>
+          <PanelResizer id="resizer1" size="10px" />
+          <Panel
+            id="panel2"
+            handle={panelHandle}
+            min="100px"
+            collapsible
+            collapsedSize="60px"
+            defaultCollapsed
+            collapseAnimation={{ easing: "linear", duration: 300 }}
+          >
+            2
+          </Panel>
+        </PanelGroup>
+      </div>
+    );
+
+    await waitForMeasurement(handle.current);
+    const rendersBeforeAnimation = renderCount;
+
+    panelHandle.current.expand();
+
+    await new Promise((resolve) => setTimeout(resolve, 100));
+    expect(handle.current.getState()).toBe("dragging");
+
+    const rendersDuringAnimation = renderCount;
+    expect(rendersDuringAnimation).toBe(rendersBeforeAnimation);
+
+    await new Promise((resolve) => setTimeout(resolve, 500));
+    expect(handle.current.getState()).toBe("idle");
+
+    expect(renderCount).toBe(rendersBeforeAnimation);
+  });
+});

package/src/ReactWindowSplitter.tsx

@@ -75,6 +75,9 @@ const GroupMachineStateContextRef = createContext<
 const GroupMachineActor = createContext<(e: GroupMachineEvent) => void>(
   () => {}
 );
+const GroupMachineAnimationDomRef = createContext<
+  React.MutableRefObject<HTMLElement | null>
+>({ current: null });
 const GroupMachine = {
   useSelector<R>(
     selector: (data: { context: GroupMachineContextValue }) => R
@@ -107,12 +110,17 @@ const GroupMachine = {
     input: GroupMachineInput;
     children: React.ReactNode;
   }) => {
+    const animationDomRef = useRef<HTMLElement | null>(null);
     const [initialValue, send, state] = useMemo(
       () =>
-        groupMachine(input, (value) => {
-          currentContextRef.current = value;
-          setCurrentValue({ ...value });
-        }),
+        groupMachine(
+          input,
+          (value) => {
+            currentContextRef.current = value;
+            setCurrentValue({ ...value });
+          },
+          () => animationDomRef.current
+        ),
       // We only want this to run once, we dont care about changes to the input
       // eslint-disable-next-line react-hooks/exhaustive-deps
       []
@@ -136,7 +144,9 @@ const GroupMachine = {
         <GroupMachineStateContextRef.Provider value={currentContextRef}>
           <GroupMachineContext.Provider value={currentValue}>
             <GroupMachineActor.Provider value={send}>
-              {children}
+              <GroupMachineAnimationDomRef.Provider value={animationDomRef}>
+                {children}
+              </GroupMachineAnimationDomRef.Provider>
             </GroupMachineActor.Provider>
           </GroupMachineContext.Provider>
         </GroupMachineStateContextRef.Provider>
@@ -414,6 +424,7 @@ const PanelGroupImplementation = React.forwardRef<
 ) {
   const { send } = GroupMachine.useActorRef();
   const machineRef = GroupMachine.useContextRef();
+  const animationDomRef = useContext(GroupMachineAnimationDomRef);
   const innerRef = React.useRef<HTMLDivElement>(null);
   const ref = mergeRefs(outerRef, innerRef);
   const orientation = GroupMachine.useSelector(
@@ -429,6 +440,16 @@ const PanelGroupImplementation = React.forwardRef<
     send({ type: "setOrientation", orientation: orientationProp });
   }
 
+  // Register the group's DOM element so the machine can write
+  // grid-template directly during collapse/expand animations,
+  // bypassing React re-renders for each animation frame.
+  useLayoutEffect(() => {
+    animationDomRef.current = innerRef.current;
+    return () => {
+      animationDomRef.current = null;
+    };
+  }, [animationDomRef]);
+
   // Track the size of the group
   useLayoutEffect(() => {
     const { current: el } = innerRef;

package/.turbo/turbo-lint.log

@@ -1,18 +0,0 @@
-
-
-> @window-splitter/react@1.1.0 lint /Users/alisowski/Documents/react-window-splitter/packages/react
-> eslint .
-
-=============
-
-WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
-
-You may find that it works just fine, or you may not.
-
-SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0
-
-YOUR TYPESCRIPT VERSION: 5.8.3
-
-Please only submit bug reports when using the officially supported version.
-
-=============

package/LICENSE

@@ -1,7 +0,0 @@
-Copyright 2025 Andrew Lisowski
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.