@windagency/valora-plugin-engineering 1.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +20 -0
- package/agents/lead.md +489 -0
- package/commands/commit.md +788 -0
- package/commands/create-pr.md +401 -0
- package/commands/gather-knowledge.md +856 -0
- package/commands/plan-architecture.md +270 -0
- package/commands/plan-implementation.md +314 -0
- package/commands/plan.md +582 -0
- package/commands/review-code.md +681 -0
- package/commands/review-functional.md +236 -0
- package/commands/review-plan.md +551 -0
- package/commands/validate-parallel.md +281 -0
- package/commands/validate-plan.md +367 -0
- package/package.json +48 -0
- package/valora-plugin.json +7 -0
|
@@ -0,0 +1,281 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: validate-parallel
|
|
3
|
+
description: Run assert and review-code commands in parallel to reduce validation time by ~50%
|
|
4
|
+
experimental: true
|
|
5
|
+
argument-hint: '[--quick] [--severity=<level>] [--focus=<area>]'
|
|
6
|
+
allowed-tools:
|
|
7
|
+
- codebase_search
|
|
8
|
+
- read_file
|
|
9
|
+
- grep
|
|
10
|
+
- list_dir
|
|
11
|
+
- glob_file_search
|
|
12
|
+
- run_terminal_cmd
|
|
13
|
+
model: claude-haiku-4.5
|
|
14
|
+
agent: lead
|
|
15
|
+
prompts:
|
|
16
|
+
pipeline:
|
|
17
|
+
- stage: parallel-validation
|
|
18
|
+
prompt: validation.run-parallel-checks
|
|
19
|
+
required: true
|
|
20
|
+
parallel: true
|
|
21
|
+
inputs:
|
|
22
|
+
quick_mode: $ARG_quick
|
|
23
|
+
severity: $ARG_severity
|
|
24
|
+
focus: $ARG_focus
|
|
25
|
+
outputs:
|
|
26
|
+
- assert_results
|
|
27
|
+
- review_results
|
|
28
|
+
- combined_verdict
|
|
29
|
+
- blocking_issues
|
|
30
|
+
timeout_ms: 300000
|
|
31
|
+
merge_strategy: parallel
|
|
32
|
+
cache_strategy: none
|
|
33
|
+
retry_policy:
|
|
34
|
+
max_attempts: 1
|
|
35
|
+
backoff_ms: 0
|
|
36
|
+
retry_on: []
|
|
37
|
+
---
|
|
38
|
+
|
|
39
|
+
# Parallel Validation Command
|
|
40
|
+
|
|
41
|
+
## Role
|
|
42
|
+
|
|
43
|
+
Use the **@lead** agent profile to orchestrate parallel validation.
|
|
44
|
+
|
|
45
|
+
## Goal
|
|
46
|
+
|
|
47
|
+
**Execute `assert` and `review-code` commands in parallel** to reduce total validation time by ~50%. This command combines both validation phases into a single concurrent execution.
|
|
48
|
+
|
|
49
|
+
**Time savings**: ~9 minutes per workflow (from ~18 min sequential to ~9 min parallel)
|
|
50
|
+
|
|
51
|
+
## Context
|
|
52
|
+
|
|
53
|
+
### Input Arguments
|
|
54
|
+
|
|
55
|
+
```plaintext
|
|
56
|
+
$ARGUMENTS
|
|
57
|
+
```
|
|
58
|
+
|
|
59
|
+
### Configuration Parameters
|
|
60
|
+
|
|
61
|
+
**--quick** (default: false)
|
|
62
|
+
|
|
63
|
+
- Use quick validation modes for both commands
|
|
64
|
+
- `assert --quick=all` + `review-code --checklist`
|
|
65
|
+
- Further reduces time: ~5 min total vs ~9 min
|
|
66
|
+
|
|
67
|
+
**--severity** (default: all)
|
|
68
|
+
|
|
69
|
+
- Filter issues by severity level
|
|
70
|
+
- Passed to both assert and review-code
|
|
71
|
+
|
|
72
|
+
**--focus** (default: all)
|
|
73
|
+
|
|
74
|
+
- Focus area for review-code
|
|
75
|
+
- Options: security, performance, maintainability, all
|
|
76
|
+
|
|
77
|
+
## Parallel Execution
|
|
78
|
+
|
|
79
|
+
### Standard Mode
|
|
80
|
+
|
|
81
|
+
Runs in parallel:
|
|
82
|
+
|
|
83
|
+
1. `valora assert --severity=<level>` (~9 min)
|
|
84
|
+
2. `valora review-code --severity=<level> --focus=<area>` (~10 min)
|
|
85
|
+
|
|
86
|
+
**Total time**: ~10 min (limited by slower command)
|
|
87
|
+
|
|
88
|
+
### Quick Mode (`--quick`)
|
|
89
|
+
|
|
90
|
+
Runs in parallel:
|
|
91
|
+
|
|
92
|
+
1. `valora assert --quick=all` (~5 min)
|
|
93
|
+
2. `valora review-code --checklist` (~3 min)
|
|
94
|
+
|
|
95
|
+
**Total time**: ~5 min (limited by slower command)
|
|
96
|
+
|
|
97
|
+
## Process
|
|
98
|
+
|
|
99
|
+
### Step 1: Launch Parallel Processes
|
|
100
|
+
|
|
101
|
+
```bash
|
|
102
|
+
# Standard mode
|
|
103
|
+
valora assert &
|
|
104
|
+
valora review-code &
|
|
105
|
+
wait
|
|
106
|
+
|
|
107
|
+
# Quick mode
|
|
108
|
+
valora assert --quick=all &
|
|
109
|
+
valora review-code --checklist &
|
|
110
|
+
wait
|
|
111
|
+
```
|
|
112
|
+
|
|
113
|
+
### Step 2: Collect Results
|
|
114
|
+
|
|
115
|
+
Both commands complete and results are merged:
|
|
116
|
+
|
|
117
|
+
- **Assert Results**: Completeness, correctness, compliance
|
|
118
|
+
- **Review Results**: Code quality, security, maintainability
|
|
119
|
+
- **Combined Verdict**: PASS / WARN / FAIL
|
|
120
|
+
|
|
121
|
+
### Step 3: Report Combined Results
|
|
122
|
+
|
|
123
|
+
Unified report showing both validation outcomes.
|
|
124
|
+
|
|
125
|
+
## Output Requirements
|
|
126
|
+
|
|
127
|
+
### Combined Validation Report
|
|
128
|
+
|
|
129
|
+
```markdown
|
|
130
|
+
## Parallel Validation Complete
|
|
131
|
+
|
|
132
|
+
**Mode**: [Standard / Quick]
|
|
133
|
+
**Duration**: [X] min (saved ~[Y] min vs sequential)
|
|
134
|
+
|
|
135
|
+
---
|
|
136
|
+
|
|
137
|
+
### Assert Results
|
|
138
|
+
|
|
139
|
+
**Status**: [PASS / WARN / FAIL]
|
|
140
|
+
**Score**: [XX]%
|
|
141
|
+
|
|
142
|
+
| Category | Status | Issues |
|
|
143
|
+
| ------------ | ----------- | ------ |
|
|
144
|
+
| Completeness | [PASS/FAIL] | [N] |
|
|
145
|
+
| Correctness | [PASS/FAIL] | [N] |
|
|
146
|
+
| Compliance | [PASS/FAIL] | [N] |
|
|
147
|
+
|
|
148
|
+
### Review Results
|
|
149
|
+
|
|
150
|
+
**Status**: [APPROVE / REQUEST_CHANGES / BLOCK]
|
|
151
|
+
**Score**: [XX]/100
|
|
152
|
+
|
|
153
|
+
| Category | Status | Issues |
|
|
154
|
+
| ------------ | ----------- | ------ |
|
|
155
|
+
| Security | [PASS/FAIL] | [N] |
|
|
156
|
+
| Architecture | [PASS/FAIL] | [N] |
|
|
157
|
+
| Code Quality | [PASS/FAIL] | [N] |
|
|
158
|
+
| Performance | [PASS/FAIL] | [N] |
|
|
159
|
+
|
|
160
|
+
---
|
|
161
|
+
|
|
162
|
+
### Combined Verdict
|
|
163
|
+
|
|
164
|
+
**Overall**: [PASS / WARN / FAIL]
|
|
165
|
+
|
|
166
|
+
### Blocking Issues
|
|
167
|
+
|
|
168
|
+
[List of any blocking issues from either validation]
|
|
169
|
+
|
|
170
|
+
### Next Step
|
|
171
|
+
|
|
172
|
+
- If PASS: `/commit` to create commit
|
|
173
|
+
- If WARN: Address issues, then `/commit`
|
|
174
|
+
- If FAIL: `/implement` to fix issues
|
|
175
|
+
```
|
|
176
|
+
|
|
177
|
+
## Verdict Logic
|
|
178
|
+
|
|
179
|
+
| Assert | Review | Combined |
|
|
180
|
+
| ------ | --------------- | -------- |
|
|
181
|
+
| PASS | APPROVE | **PASS** |
|
|
182
|
+
| PASS | REQUEST_CHANGES | **WARN** |
|
|
183
|
+
| WARN | APPROVE | **WARN** |
|
|
184
|
+
| WARN | REQUEST_CHANGES | **WARN** |
|
|
185
|
+
| FAIL | Any | **FAIL** |
|
|
186
|
+
| Any | BLOCK | **FAIL** |
|
|
187
|
+
|
|
188
|
+
## Usage Examples
|
|
189
|
+
|
|
190
|
+
### Standard Parallel Validation
|
|
191
|
+
|
|
192
|
+
```bash
|
|
193
|
+
valora validate-parallel
|
|
194
|
+
```
|
|
195
|
+
|
|
196
|
+
Runs both validations in parallel (~10 min).
|
|
197
|
+
|
|
198
|
+
### Quick Parallel Validation
|
|
199
|
+
|
|
200
|
+
```bash
|
|
201
|
+
valora validate-parallel --quick
|
|
202
|
+
```
|
|
203
|
+
|
|
204
|
+
Uses quick modes for faster validation (~5 min).
|
|
205
|
+
|
|
206
|
+
### With Filters
|
|
207
|
+
|
|
208
|
+
```bash
|
|
209
|
+
valora validate-parallel --severity=critical --focus=security
|
|
210
|
+
```
|
|
211
|
+
|
|
212
|
+
Focus on critical security issues only.
|
|
213
|
+
|
|
214
|
+
## Integration with Workflow
|
|
215
|
+
|
|
216
|
+
### Before
|
|
217
|
+
|
|
218
|
+
```bash
|
|
219
|
+
# Sequential (~18 min)
|
|
220
|
+
valora implement
|
|
221
|
+
valora assert # ~9 min
|
|
222
|
+
valora review-code # ~10 min (after assert)
|
|
223
|
+
valora commit
|
|
224
|
+
```
|
|
225
|
+
|
|
226
|
+
### After
|
|
227
|
+
|
|
228
|
+
```bash
|
|
229
|
+
# Parallel (~10 min)
|
|
230
|
+
valora implement
|
|
231
|
+
valora validate-parallel # ~10 min (both in parallel)
|
|
232
|
+
valora commit
|
|
233
|
+
```
|
|
234
|
+
|
|
235
|
+
### With Quick Mode
|
|
236
|
+
|
|
237
|
+
```bash
|
|
238
|
+
# Quick parallel (~5 min)
|
|
239
|
+
valora implement
|
|
240
|
+
valora validate-parallel --quick # ~5 min
|
|
241
|
+
valora commit
|
|
242
|
+
```
|
|
243
|
+
|
|
244
|
+
## Command Output Summary
|
|
245
|
+
|
|
246
|
+
Print the following summary at command completion:
|
|
247
|
+
|
|
248
|
+
```markdown
|
|
249
|
+
## ✅ Parallel Validation: PASS
|
|
250
|
+
|
|
251
|
+
**Duration**: 9.2 min (saved 8.8 min vs sequential)
|
|
252
|
+
|
|
253
|
+
### Results Summary
|
|
254
|
+
|
|
255
|
+
| Validation | Status | Score | Issues |
|
|
256
|
+
| ---------- | ------- | ------ | ------- |
|
|
257
|
+
| Assert | PASS | 92% | 2 minor |
|
|
258
|
+
| Review | APPROVE | 85/100 | 3 low |
|
|
259
|
+
|
|
260
|
+
### Time Breakdown
|
|
261
|
+
|
|
262
|
+
| Command | Duration | Mode |
|
|
263
|
+
| ------------------- | ----------- | -------- |
|
|
264
|
+
| assert | 8.5 min | standard |
|
|
265
|
+
| review-code | 9.2 min | standard |
|
|
266
|
+
| **Total** | **9.2 min** | parallel |
|
|
267
|
+
| Sequential would be | 17.7 min | - |
|
|
268
|
+
| **Saved** | **8.5 min** | - |
|
|
269
|
+
|
|
270
|
+
### Next Step
|
|
271
|
+
|
|
272
|
+
→ `/commit` to create commit
|
|
273
|
+
```
|
|
274
|
+
|
|
275
|
+
## Notes
|
|
276
|
+
|
|
277
|
+
- Commands run truly in parallel using background processes
|
|
278
|
+
- Results are collected and merged after both complete
|
|
279
|
+
- Either command failing causes combined failure
|
|
280
|
+
- Quick mode further reduces time with template-based validation
|
|
281
|
+
- No additional dependencies required
|
|
@@ -0,0 +1,367 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: validate-plan
|
|
3
|
+
description: Automated pre-review validation to catch missing plan parameters early (reduces review-plan time by 60-70%)
|
|
4
|
+
experimental: true
|
|
5
|
+
argument-hint: '[<plan-path>] [--fix] [--strict]'
|
|
6
|
+
allowed-tools:
|
|
7
|
+
- read_file
|
|
8
|
+
- grep
|
|
9
|
+
- list_dir
|
|
10
|
+
- glob_file_search
|
|
11
|
+
- run_terminal_cmd # Required for modern CLI tools (jq, yq, rg, fd)
|
|
12
|
+
model: claude-sonnet-4.5
|
|
13
|
+
agent: lead
|
|
14
|
+
prompts:
|
|
15
|
+
pipeline:
|
|
16
|
+
- stage: validate
|
|
17
|
+
prompt: validation.check-plan-completeness
|
|
18
|
+
required: true
|
|
19
|
+
inputs:
|
|
20
|
+
plan_path: $ARG_1
|
|
21
|
+
fix_mode: $ARG_fix
|
|
22
|
+
strict_mode: $ARG_strict
|
|
23
|
+
outputs:
|
|
24
|
+
- validation_results
|
|
25
|
+
- missing_parameters
|
|
26
|
+
- completeness_score
|
|
27
|
+
- auto_fixable_issues
|
|
28
|
+
timeout_ms: 60000
|
|
29
|
+
merge_strategy: sequential
|
|
30
|
+
cache_strategy: none
|
|
31
|
+
retry_policy:
|
|
32
|
+
max_attempts: 1
|
|
33
|
+
backoff_ms: 0
|
|
34
|
+
retry_on: []
|
|
35
|
+
---
|
|
36
|
+
|
|
37
|
+
# Plan Validation Command
|
|
38
|
+
|
|
39
|
+
## Role
|
|
40
|
+
|
|
41
|
+
Use the **@lead** agent profile for plan validation.
|
|
42
|
+
|
|
43
|
+
## Goal
|
|
44
|
+
|
|
45
|
+
**Automated pre-review validation** to catch missing plan parameters and structural issues early, reducing formal `review-plan` time by 60-70% (from ~14 min to ~5 min).
|
|
46
|
+
|
|
47
|
+
This command runs quick automated checks before the full `review-plan` pipeline, ensuring plans are complete before human/AI review.
|
|
48
|
+
|
|
49
|
+
## Context
|
|
50
|
+
|
|
51
|
+
### Input Arguments
|
|
52
|
+
|
|
53
|
+
```plaintext
|
|
54
|
+
$ARGUMENTS
|
|
55
|
+
```
|
|
56
|
+
|
|
57
|
+
### Configuration Parameters
|
|
58
|
+
|
|
59
|
+
**Plan Path** (positional, optional)
|
|
60
|
+
|
|
61
|
+
- Path to plan document to validate
|
|
62
|
+
- Default: Most recent plan in session or `knowledge-base/PLAN-*.md`
|
|
63
|
+
|
|
64
|
+
**--fix** (default: false)
|
|
65
|
+
|
|
66
|
+
- Attempt to auto-fix missing parameters where possible
|
|
67
|
+
- Adds placeholder sections with TODO markers
|
|
68
|
+
|
|
69
|
+
**--strict** (default: false)
|
|
70
|
+
|
|
71
|
+
- Require 100% completeness for pass
|
|
72
|
+
- Default threshold: 80%
|
|
73
|
+
|
|
74
|
+
## Validation Checks
|
|
75
|
+
|
|
76
|
+
### 1. Required Sections (CRITICAL)
|
|
77
|
+
|
|
78
|
+
| Section | Required | Check |
|
|
79
|
+
| -------------------- | -------- | --------------------------------------- |
|
|
80
|
+
| Overview | Yes | Has task description and context |
|
|
81
|
+
| Implementation Steps | Yes | Has numbered steps with file paths |
|
|
82
|
+
| Dependencies | Yes | Has dependency list (internal/external) |
|
|
83
|
+
| Risk Assessment | Yes | Has risks with mitigations |
|
|
84
|
+
| Testing Strategy | Yes | Has unit/integration/E2E approach |
|
|
85
|
+
| Rollback Procedures | Yes | Has rollback commands |
|
|
86
|
+
| Effort Estimate | Yes | Has points/hours with confidence |
|
|
87
|
+
|
|
88
|
+
### 2. Step Completeness
|
|
89
|
+
|
|
90
|
+
Each implementation step must have:
|
|
91
|
+
|
|
92
|
+
| Field | Required | Validation |
|
|
93
|
+
| -------------- | -------- | -------------------------------------- |
|
|
94
|
+
| Objective | Yes | Non-empty description |
|
|
95
|
+
| Files | Yes | Specific file paths (not placeholders) |
|
|
96
|
+
| Implementation | Yes | Code snippets or pseudocode |
|
|
97
|
+
| Validation | Yes | Success criteria checklist |
|
|
98
|
+
| Rollback | Yes | Revert procedure |
|
|
99
|
+
|
|
100
|
+
### 3. Dependency Validation
|
|
101
|
+
|
|
102
|
+
| Check | Validation |
|
|
103
|
+
| ---------------------- | --------------------------------- |
|
|
104
|
+
| All deps listed | No orphan references |
|
|
105
|
+
| Versions specified | Package versions included |
|
|
106
|
+
| Availability confirmed | Status marked (available/pending) |
|
|
107
|
+
| Critical path marked | Dependencies ordered correctly |
|
|
108
|
+
|
|
109
|
+
### 4. Risk Coverage
|
|
110
|
+
|
|
111
|
+
| Check | Validation |
|
|
112
|
+
| -------------------- | ----------------------------------- |
|
|
113
|
+
| All steps have risks | Or explicitly "No risks identified" |
|
|
114
|
+
| Likelihood assessed | High/Medium/Low |
|
|
115
|
+
| Impact assessed | High/Medium/Low |
|
|
116
|
+
| Mitigation strategy | Specific action, not generic |
|
|
117
|
+
| Fallback defined | For high/critical risks |
|
|
118
|
+
|
|
119
|
+
### 5. Testing Coverage
|
|
120
|
+
|
|
121
|
+
| Check | Validation |
|
|
122
|
+
| ------------------ | -------------------------- |
|
|
123
|
+
| Unit tests planned | Coverage target specified |
|
|
124
|
+
| Integration tests | If applicable, defined |
|
|
125
|
+
| E2E tests | If applicable, defined |
|
|
126
|
+
| Test commands | Runnable commands included |
|
|
127
|
+
|
|
128
|
+
### 6. Effort Accuracy
|
|
129
|
+
|
|
130
|
+
| Check | Validation |
|
|
131
|
+
| ------------------ | -------------------------- |
|
|
132
|
+
| Per-step estimate | Each step has points/hours |
|
|
133
|
+
| Total calculated | Sum matches breakdown |
|
|
134
|
+
| Confidence stated | High/Medium/Low |
|
|
135
|
+
| Assumptions listed | Factors affecting estimate |
|
|
136
|
+
|
|
137
|
+
## Automated Checks
|
|
138
|
+
|
|
139
|
+
```bash
|
|
140
|
+
# Check for required sections
|
|
141
|
+
grep -c "## Overview\|## Implementation Steps\|## Dependencies\|## Risk\|## Testing\|## Rollback\|## Effort" PLAN.md
|
|
142
|
+
|
|
143
|
+
# Check for file paths in steps
|
|
144
|
+
grep -c "src/\|lib/\|test/\|\.ts\|\.tsx" PLAN.md
|
|
145
|
+
|
|
146
|
+
# Check for risk mitigations
|
|
147
|
+
grep -c "Mitigation:\|mitigation:" PLAN.md
|
|
148
|
+
|
|
149
|
+
# Check for test commands
|
|
150
|
+
grep -c "pnpm test\|npm test\|vitest\|jest" PLAN.md
|
|
151
|
+
|
|
152
|
+
# Check for rollback procedures
|
|
153
|
+
grep -c "git revert\|git reset\|rollback" PLAN.md
|
|
154
|
+
```
|
|
155
|
+
|
|
156
|
+
## Output Format
|
|
157
|
+
|
|
158
|
+
### Validation Report
|
|
159
|
+
|
|
160
|
+
```markdown
|
|
161
|
+
## Plan Validation Report
|
|
162
|
+
|
|
163
|
+
**Plan**: [PLAN-TASK-001.md]
|
|
164
|
+
**Completeness**: [XX]%
|
|
165
|
+
**Status**: [PASS / WARN / FAIL]
|
|
166
|
+
|
|
167
|
+
---
|
|
168
|
+
|
|
169
|
+
### Section Completeness
|
|
170
|
+
|
|
171
|
+
| Section | Status | Issues |
|
|
172
|
+
| -------------------- | ------ | ---------------------------------- |
|
|
173
|
+
| Overview | ✅ | - |
|
|
174
|
+
| Implementation Steps | ⚠️ | Step 3 missing file paths |
|
|
175
|
+
| Dependencies | ✅ | - |
|
|
176
|
+
| Risk Assessment | ❌ | No mitigations for 2 risks |
|
|
177
|
+
| Testing Strategy | ✅ | - |
|
|
178
|
+
| Rollback Procedures | ⚠️ | Generic procedure, needs specifics |
|
|
179
|
+
| Effort Estimate | ✅ | - |
|
|
180
|
+
|
|
181
|
+
---
|
|
182
|
+
|
|
183
|
+
### Missing Parameters
|
|
184
|
+
|
|
185
|
+
| # | Location | Missing | Severity | Auto-fixable |
|
|
186
|
+
| --- | -------- | ----------------- | -------- | ------------ |
|
|
187
|
+
| 1 | Step 3 | File paths | HIGH | No |
|
|
188
|
+
| 2 | Risk 2 | Mitigation | CRITICAL | No |
|
|
189
|
+
| 3 | Risk 4 | Mitigation | CRITICAL | No |
|
|
190
|
+
| 4 | Rollback | Specific commands | MEDIUM | Partial |
|
|
191
|
+
|
|
192
|
+
---
|
|
193
|
+
|
|
194
|
+
### Auto-Fixable Issues
|
|
195
|
+
|
|
196
|
+
[If --fix is used]
|
|
197
|
+
|
|
198
|
+
| # | Issue | Fix Applied |
|
|
199
|
+
| --- | ----------------------- | ------------------------ |
|
|
200
|
+
| 1 | Missing testing section | Added template with TODO |
|
|
201
|
+
| 2 | No effort breakdown | Added per-step template |
|
|
202
|
+
|
|
203
|
+
---
|
|
204
|
+
|
|
205
|
+
### Recommendations
|
|
206
|
+
|
|
207
|
+
1. **Add file paths to Step 3** - Specify exact files to modify
|
|
208
|
+
2. **Add mitigations for Risk 2, 4** - Define specific strategies
|
|
209
|
+
3. **Make rollback specific** - Include actual git/deploy commands
|
|
210
|
+
|
|
211
|
+
---
|
|
212
|
+
|
|
213
|
+
### Verdict
|
|
214
|
+
|
|
215
|
+
| Result | Criteria |
|
|
216
|
+
| ----------- | -------------------------------------------- |
|
|
217
|
+
| ✅ **PASS** | Completeness >= 80%, no CRITICAL issues |
|
|
218
|
+
| ⚠️ **WARN** | Completeness >= 60%, CRITICAL issues present |
|
|
219
|
+
| ❌ **FAIL** | Completeness < 60% |
|
|
220
|
+
|
|
221
|
+
**Current**: [WARN] - 2 CRITICAL issues must be resolved
|
|
222
|
+
|
|
223
|
+
---
|
|
224
|
+
|
|
225
|
+
### Next Step
|
|
226
|
+
|
|
227
|
+
- If PASS: `/review-plan` for full review (~5 min with pre-validation)
|
|
228
|
+
- If WARN: Fix issues, re-run `/validate-plan`
|
|
229
|
+
- If FAIL: Return to `/plan` to regenerate
|
|
230
|
+
```
|
|
231
|
+
|
|
232
|
+
## Integration with Workflow
|
|
233
|
+
|
|
234
|
+
### Before (without pre-validation)
|
|
235
|
+
|
|
236
|
+
```
|
|
237
|
+
/plan --> /review-plan (~14 min) --> /implement
|
|
238
|
+
↑
|
|
239
|
+
Multiple iterations
|
|
240
|
+
due to missing params
|
|
241
|
+
```
|
|
242
|
+
|
|
243
|
+
### After (with pre-validation)
|
|
244
|
+
|
|
245
|
+
```
|
|
246
|
+
/plan --> /validate-plan (~2 min) --> /review-plan (~5 min) --> /implement
|
|
247
|
+
↑
|
|
248
|
+
Quick fix cycle
|
|
249
|
+
catches issues early
|
|
250
|
+
```
|
|
251
|
+
|
|
252
|
+
### Time Savings
|
|
253
|
+
|
|
254
|
+
| Phase | Without | With | Saved |
|
|
255
|
+
| -------------- | ---------- | --------- | -------- |
|
|
256
|
+
| Pre-validation | 0 min | 2 min | - |
|
|
257
|
+
| Review | 14 min | 5 min | 9 min |
|
|
258
|
+
| **Total** | **14 min** | **7 min** | **~50%** |
|
|
259
|
+
|
|
260
|
+
## Usage Examples
|
|
261
|
+
|
|
262
|
+
### Basic Validation
|
|
263
|
+
|
|
264
|
+
```bash
|
|
265
|
+
valora validate-plan
|
|
266
|
+
```
|
|
267
|
+
|
|
268
|
+
Validates most recent plan against completeness checklist.
|
|
269
|
+
|
|
270
|
+
### Validate Specific Plan
|
|
271
|
+
|
|
272
|
+
```bash
|
|
273
|
+
valora validate-plan knowledge-base/PLAN-IMPL-TASK-001.md
|
|
274
|
+
```
|
|
275
|
+
|
|
276
|
+
### With Auto-Fix
|
|
277
|
+
|
|
278
|
+
```bash
|
|
279
|
+
valora validate-plan --fix
|
|
280
|
+
```
|
|
281
|
+
|
|
282
|
+
Attempts to add missing sections with TODO placeholders.
|
|
283
|
+
|
|
284
|
+
### Strict Mode
|
|
285
|
+
|
|
286
|
+
```bash
|
|
287
|
+
valora validate-plan --strict
|
|
288
|
+
```
|
|
289
|
+
|
|
290
|
+
Requires 100% completeness for PASS.
|
|
291
|
+
|
|
292
|
+
## Command Output Summary
|
|
293
|
+
|
|
294
|
+
Print the following summary at command completion:
|
|
295
|
+
|
|
296
|
+
**For PASS:**
|
|
297
|
+
|
|
298
|
+
```markdown
|
|
299
|
+
## ✅ Plan Validation: PASS
|
|
300
|
+
|
|
301
|
+
**Completeness**: 92%
|
|
302
|
+
**Critical Issues**: 0
|
|
303
|
+
**Duration**: 1.8 min
|
|
304
|
+
|
|
305
|
+
### Summary
|
|
306
|
+
|
|
307
|
+
- ✅ All required sections present
|
|
308
|
+
- ✅ All steps have file paths
|
|
309
|
+
- ✅ All risks have mitigations
|
|
310
|
+
- ⚠️ 2 minor recommendations
|
|
311
|
+
|
|
312
|
+
### Next Step
|
|
313
|
+
|
|
314
|
+
→ `/review-plan` for full review (expected: ~5 min)
|
|
315
|
+
```
|
|
316
|
+
|
|
317
|
+
**For WARN:**
|
|
318
|
+
|
|
319
|
+
```markdown
|
|
320
|
+
## ⚠️ Plan Validation: WARN
|
|
321
|
+
|
|
322
|
+
**Completeness**: 75%
|
|
323
|
+
**Critical Issues**: 2
|
|
324
|
+
**Duration**: 1.5 min
|
|
325
|
+
|
|
326
|
+
### Issues to Fix
|
|
327
|
+
|
|
328
|
+
1. ❌ Step 3: Missing file paths
|
|
329
|
+
2. ❌ Risk 2: No mitigation strategy
|
|
330
|
+
|
|
331
|
+
### Quick Fix
|
|
332
|
+
|
|
333
|
+
Address 2 issues above, then re-run:
|
|
334
|
+
→ `valora validate-plan`
|
|
335
|
+
|
|
336
|
+
Or proceed with issues:
|
|
337
|
+
→ `/review-plan` (will flag same issues)
|
|
338
|
+
```
|
|
339
|
+
|
|
340
|
+
**For FAIL:**
|
|
341
|
+
|
|
342
|
+
```markdown
|
|
343
|
+
## ❌ Plan Validation: FAIL
|
|
344
|
+
|
|
345
|
+
**Completeness**: 45%
|
|
346
|
+
**Critical Issues**: 5
|
|
347
|
+
**Duration**: 1.2 min
|
|
348
|
+
|
|
349
|
+
### Major Gaps
|
|
350
|
+
|
|
351
|
+
- Missing: Implementation Steps
|
|
352
|
+
- Missing: Risk Assessment
|
|
353
|
+
- Missing: Testing Strategy
|
|
354
|
+
|
|
355
|
+
### Recommendation
|
|
356
|
+
|
|
357
|
+
Plan is incomplete. Regenerate:
|
|
358
|
+
→ `/plan` to create new plan
|
|
359
|
+
```
|
|
360
|
+
|
|
361
|
+
## Notes
|
|
362
|
+
|
|
363
|
+
- Runs in ~2 minutes (vs 14 min for full review)
|
|
364
|
+
- Catches 60-70% of issues that cause review iterations
|
|
365
|
+
- Auto-fix mode adds TODO placeholders for manual completion
|
|
366
|
+
- Strict mode useful for production-critical plans
|
|
367
|
+
- Complements (doesn't replace) full `/review-plan`
|
package/package.json
ADDED
|
@@ -0,0 +1,48 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "@windagency/valora-plugin-engineering",
|
|
3
|
+
"version": "1.0.0",
|
|
4
|
+
"description": "Lead engineer agent and core engineering workflow commands for Valora (commit, create-pr, plan, plan-architecture, plan-implementation, review-code, review-functional, review-plan, validate-parallel, validate-plan, gather-knowledge).",
|
|
5
|
+
"keywords": [
|
|
6
|
+
"valora",
|
|
7
|
+
"valora-plugin",
|
|
8
|
+
"ai",
|
|
9
|
+
"agent",
|
|
10
|
+
"engineering",
|
|
11
|
+
"code-review",
|
|
12
|
+
"planning",
|
|
13
|
+
"git",
|
|
14
|
+
"workflow",
|
|
15
|
+
"automation",
|
|
16
|
+
"typescript"
|
|
17
|
+
],
|
|
18
|
+
"author": "Damien TIVELET <damien@wind-agency.com>",
|
|
19
|
+
"repository": {
|
|
20
|
+
"type": "git",
|
|
21
|
+
"url": "https://github.com/windagency/valora.ai"
|
|
22
|
+
},
|
|
23
|
+
"license": "MIT",
|
|
24
|
+
"type": "module",
|
|
25
|
+
"engines": {
|
|
26
|
+
"node": ">=22.0.0"
|
|
27
|
+
},
|
|
28
|
+
"volta": {
|
|
29
|
+
"node": "22.21.0",
|
|
30
|
+
"pnpm": "10.19.0"
|
|
31
|
+
},
|
|
32
|
+
"files": [
|
|
33
|
+
"valora-plugin.json",
|
|
34
|
+
"agents",
|
|
35
|
+
"commands"
|
|
36
|
+
],
|
|
37
|
+
"peerDependencies": {
|
|
38
|
+
"@windagency/valora": ">=0.1.0"
|
|
39
|
+
},
|
|
40
|
+
"scripts": {
|
|
41
|
+
"build": "true",
|
|
42
|
+
"clean": "true",
|
|
43
|
+
"beautify": "prettier --check \"**/*.+(js|jsx|ts|tsx|json|md|yml|yaml)\"",
|
|
44
|
+
"beautify:fix": "prettier --write \"**/*.+(js|jsx|ts|tsx|json|md|yml|yaml)\"",
|
|
45
|
+
"format": "pnpm beautify:fix",
|
|
46
|
+
"test": "true"
|
|
47
|
+
}
|
|
48
|
+
}
|
|
@@ -0,0 +1,7 @@
|
|
|
1
|
+
{
|
|
2
|
+
"name": "valora-plugin-engineering",
|
|
3
|
+
"version": "1.0.0",
|
|
4
|
+
"description": "Lead engineer agent and core engineering workflow commands (commit, create-pr, gather-knowledge, plan, plan-architecture, plan-implementation, review-code, review-functional, review-plan, validate-parallel, validate-plan).",
|
|
5
|
+
"engines": { "valora": ">=0.1.0" },
|
|
6
|
+
"contributes": ["agents", "commands"]
|
|
7
|
+
}
|