@williamthorsen/nmr 0.54.0 → 0.55.0

package/dist/esm/machine-lock.js

@@ -28,7 +28,7 @@ export const LOCK_DIR_ENV_VAR = 'NMR_LOCK_DIR';
 export const LOCK_FILE = 'heavy.lock';
 export const LOCK_TOKEN_ENV_VAR = 'NMR_MACHINE_LOCK_TOKEN';
 export const NO_LOCK_ENV_VAR = 'NMR_NO_LOCK';
-export const POLL_INTERVAL_MS = 1_000;
+export const POLL_INTERVAL_MS = 1000;
 export const STALE_AFTER_MS = 60_000;
 export async function acquireMachineLock(options) {
     const { command, dir, env, stderr } = options;

package/dist/esm/pass-manifest.js

@@ -49,7 +49,7 @@ export async function writePassManifestEntry(options) {
         writeDebugNote(`could not report ${command} to the delegating machine: ${describeError(error)}`, env, stderr);
     }
 }
-const MAX_MANIFEST_ENTRIES = 1_000;
+const MAX_MANIFEST_ENTRIES = 1000;
 function findRejection(entry, options) {
     if (!isPassManifestEntry(entry)) {
         return 'the entry is malformed';
@@ -84,6 +84,5 @@ function isRelativeScope(scope) {
     if (scope === '.') {
         return true;
     }
-    return (!path.posix.isAbsolute(scope) &&
-        scope.split('/').every((segment) => segment !== '' && segment !== '.' && segment !== '..'));
+    return !path.posix.isAbsolute(scope) && scope.split('/').every((segment) => !['', '.', '..'].includes(segment));
 }

package/dist/esm/remote-host-session.js

@@ -8,12 +8,12 @@ export function runHostSession(params) {
     const LOCK_PATH = params.lockPath;
     const RECLAIM_GUARD_PATH = `${params.lockPath}.reclaim`;
     const HEARTBEAT_INTERVAL_MS = 10_000;
-    const POLL_INTERVAL_MS = 1_000;
+    const POLL_INTERVAL_MS = 1000;
     const RECLAIM_GUARD_STALE_AFTER_MS = 10_000;
     const OUTPUT_LIMIT_BYTES = 65_536;
     const COMMAND_NOT_FOUND_EXIT_CODE = 127;
     const DELEGATION_FAILURE_EXIT_CODE = 255;
-    const STOP_GRACE_MS = 5_000;
+    const STOP_GRACE_MS = 5000;
     const NODE_MODULES_DIR = path.join(params.rootDir, 'node_modules');
     const BINS_RECORD_PATH = path.join(NODE_MODULES_DIR, '.nmr-delegate-bins');
     const token = crypto.randomUUID();

package/dist/esm/resolveBinStyles.js

@@ -1,7 +1,6 @@
 import process from 'node:process';
-import { describeInvalidOutputStyle } from '@williamthorsen/nmr-core';
+import { describeInvalidOutputStyle, UserError } from '@williamthorsen/nmr-core';
 import { resolveOutputStyles } from "./output-style.js";
-import { UserError } from "./UserError.js";
 export function resolveBinStyles() {
     const { invalid: invalidStyle, styles } = resolveOutputStyles({
         env: process.env,

package/dist/esm/user-config.js

@@ -9,9 +9,9 @@ var __rewriteRelativeImportExtension = (this && this.__rewriteRelativeImportExte
 import { existsSync } from 'node:fs';
 import path from 'node:path';
 import { pathToFileURL } from 'node:url';
+import { UserError } from '@williamthorsen/nmr-core';
 import { assertRecognizedKeys } from "./config-validation.js";
 import { isObject } from "./helpers/type-guards.js";
-import { UserError } from "./UserError.js";
 export const DELEGATE_WHEN_VALUES = ['agent', 'always'];
 export function formatDisplayPath(filePath, env) {
     const home = env['HOME'];

package/dist/esm/vitest-source-resolution.js

@@ -1,10 +1,10 @@
 import { existsSync, readFileSync, realpathSync, statSync } from 'node:fs';
 import { isBuiltin } from 'node:module';
 import path from 'node:path';
+import { UserError } from '@williamthorsen/nmr-core';
 import { findDirectoryChainMatch } from '@williamthorsen/toolbelt.filesystem';
 import { parsePackageJson } from "./helpers/package-json.js";
 import { isObject } from "./helpers/type-guards.js";
-import { UserError } from "./UserError.js";
 const SHARED_CONDITIONS = ['module', 'import', 'development', 'default'];
 const CLIENT_CONDITION = 'browser';
 const SERVER_CONDITION = 'node';

package/dist/esm/workspace.js

@@ -1,7 +1,7 @@
 import { findMonorepoRoot as findMonorepoRootOrNothing, resolveWorkspace } from '@williamthorsen/nmr-core/workspace';
-import { UserError } from "./UserError.js";
 const WORKSPACE_MANIFEST = 'pnpm-workspace.yaml';
 export { isMonorepoRoot, readWorkspaceOverrides, readWorkspacePackageNames, resolveWorkspace, } from '@williamthorsen/nmr-core/workspace';
+import { UserError } from '@williamthorsen/nmr-core';
 export function findMonorepoRoot(startDir) {
     const monorepoRoot = findMonorepoRootOrNothing(startDir);
     if (monorepoRoot === undefined) {

package/docs/check-cache.md

@@ -10,7 +10,7 @@ The cache is a working-tree cache, not a build cache: It answers "has this exact
 
 ## What is cached
 
-Cacheable by default: `check`, `check:strict`, `ci`, `fix:check`, `fmt:check`, `lint:check`, `lint:strict`, `lint:workflows`, `test`, `test:coverage`, `test:tool`, `test:unit`, `typecheck`, and the `root:` variants `root:check`, `root:lint:check`, `root:lint:strict`, `root:test`, `root:test:tool`, `root:test:unit`, and `root:typecheck`.
+Cacheable by default: `check`, `check:strict`, `ci`, `fix:check`, `fmt:check`, `lint:check`, `lint:shell`, `lint:strict`, `lint:workflows`, `test`, `test:coverage`, `test:tool`, `test:unit`, `typecheck`, and the `root:` variants `root:check`, `root:lint:check`, `root:lint:strict`, `root:test`, `root:test:tool`, `root:test:unit`, and `root:typecheck`.
 
 Everything else runs every time:
 

package/docs/delegate.md

@@ -46,13 +46,15 @@ The first rule that applies decides where a command runs:
 | 1   | `--no-delegate`                                                                         | Here                                                                                                               |
 | 2   | `--delegate` or `--delegate-to`                                                         | On a host; a command that cannot be delegated, or a tree that cannot be snapshotted, is refused                    |
 | 3   | The repo config declares `delegate: false`                                              | Here                                                                                                               |
-| 4   | `NMR_DELEGATE` names hosts                                                              | On a host; a command that cannot be delegated runs here, and a tree that cannot be snapshotted, here with one line |
-| 5   | `NMR_DELEGATE` is set but does not name a host                                          | Here                                                                                                               |
-| 6   | The user config's `when` matches, `CI` is unset, and the invocation is not `-F` or `-R` | On a host, as for rule 4; here with one line when no host answers                                                  |
-| 7   | Otherwise                                                                               | Here                                                                                                               |
+| 4   | `npm_lifecycle_event` names a package install hook, such as `postinstall`               | Here                                                                                                               |
+| 5   | `NMR_DELEGATE` names hosts                                                              | On a host; a command that cannot be delegated runs here, and a tree that cannot be snapshotted, here with one line |
+| 6   | `NMR_DELEGATE` is set but does not name a host                                          | Here                                                                                                               |
+| 7   | The user config's `when` matches, `CI` is unset, and the invocation is not `-F` or `-R` | On a host, as for rule 5; here with one line when no host answers                                                  |
+| 8   | Otherwise                                                                               | Here                                                                                                               |
 
-- **A step and a `-F` or `-R` child run where their parent runs.** nmr gives every process that it starts an empty `NMR_DELEGATE`, which rule 5 reads as "here"; the run on a host already passes `--no-delegate`, so a host does not apply its own user config. A git hook that an agent's command starts is an agent run.
+- **A step and a `-F` or `-R` child run where their parent runs.** nmr gives every process that it starts an empty `NMR_DELEGATE`, which rule 6 reads as "here"; the run on a host already passes `--no-delegate`, so a host does not apply its own user config. A git hook that an agent's command starts is an agent run.
 - **A repo whose checks must run on the machine that has the tree** declares `delegate: false` in `.config/nmr.config.ts`, the only value that the repo config accepts for the key. It outranks `NMR_DELEGATE` and the user config, but not a flag.
+- **A command in a package install hook runs here unless a flag asks otherwise.** During `pnpm add`, a hook such as `postinstall` sees a manifest that its lockfile does not match yet, and the host's frozen install of that tree fails. A command in any other `package.json` script, such as `test`, delegates as usual.
 - **`NMR_DEBUG=1` names what sent a command to a host**, such as `delegating ci per ~/.config/nmr/config.ts (when: agent)`, `per NMR_DELEGATE`, or `per --delegate-to`.
 
 ### Choosing among several hosts

package/docs/scripts.md

@@ -202,6 +202,10 @@ The result does not depend on what the machine has installed. nmr pins actionlin
 
 The supported platforms are macOS and Linux on x64 and arm64; on any other, the command fails and names the platform. actionlint reads its own configuration from `.github/actionlint.yaml`, through which a repo can ignore a finding.
 
+### Shell lint
+
+`lint:shell`, a root command, lints every `*.sh` file that git tracks under the monorepo root with [shellcheck](https://www.shellcheck.net/) and fails on any finding. A repo that does not track any `*.sh` file passes without downloading shellcheck, and a tracked file that is missing from the working tree is skipped. The command runs `nmr-shellcheck`, whose trailing arguments replace the file list, so `nmr lint:shell scripts/release.sh` lints that file alone. It uses the shellcheck that [Workflow lint](#workflow-lint) pins, downloads, and caches. Neither `check`, `check:strict`, nor `root:check` runs it.
+
 ### Root-only
 
 The `root:`-prefixed commands operate on root-level code only (not workspace packages).

package/docs/utilities.md

@@ -1,6 +1,6 @@
 # Standalone utilities
 
-The binaries behind nmr's default `clean`, `compile`, `fmt`, `lint:workflows`, and package `test` commands, and a check for the `prepublishOnly` hooks of publishable packages.
+The binaries behind nmr's default `clean`, `compile`, `fmt`, `lint:shell`, `lint:workflows`, and package `test` commands, and a check for the `prepublishOnly` hooks of publishable packages.
 
 ## `nmr-actionlint`
 
@@ -74,6 +74,14 @@ Pass `--no-cache`, or set `NMR_NO_CACHE=1`, to run uncached. `nmr --no-cache fmt
 nmr-fmt --check --no-cache
 ```
 
+## `nmr-shellcheck`
+
+Lint the monorepo's tracked `*.sh` files with the pinned shellcheck binary, passing when the repo does not track any. Any arguments replace the file list and reach shellcheck as given. This is the default root `lint:shell` script; [Shell lint](scripts.md#shell-lint) covers its behavior.
+
+```bash
+nmr-shellcheck
+```
+
 ## `nmr-vitest`
 
 Run Vitest from a package directory with the monorepo's shared config. Vitest 5 does not search parent directories for a config, so `nmr-vitest` names it: When the working directory does not contain a `vitest.config.*` or `vite.config.*` of its own, it passes `--config` naming the `vitest.config.*` at the monorepo root, the directory that contains `pnpm-workspace.yaml`. It does not search the directories in between. A package with a config of its own, a monorepo root without a `vitest.config.*`, and a directory outside any monorepo all run Vitest without the flag. An explicit `--config` or `-c` ahead of any `--` passes through unchanged, and so does every other argument. This is the command behind every package-scope `test*` script.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@williamthorsen/nmr",
-  "version": "0.54.0",
+  "version": "0.55.0",
   "private": false,
   "description": "Context-aware script runner for pnpm monorepos",
   "keywords": [
@@ -64,6 +64,7 @@
     "nmr-fmt": "bin/nmr-fmt.js",
     "nmr-report-catalog": "bin/nmr-report-catalog.js",
     "nmr-report-overrides": "bin/nmr-report-overrides.js",
+    "nmr-shellcheck": "bin/nmr-shellcheck.js",
     "nmr-taze": "bin/nmr-taze.js",
     "nmr-vitest": "bin/nmr-vitest.js"
   },
@@ -79,7 +80,7 @@
     "!docs/*.v*.md"
   ],
   "dependencies": {
-    "@williamthorsen/nmr-core": "0.14.0",
+    "@williamthorsen/nmr-core": "0.15.1",
     "@williamthorsen/toolbelt.errors": "0.9.0",
     "@williamthorsen/toolbelt.filesystem": "0.10.0",
     "glob": "14.0.3",
@@ -92,11 +93,11 @@
     "@williamthorsen/toolbelt.testing": "0.8.0",
     "@williamthorsen/toolbelt.vitest": "0.13.1",
     "esbuild": "0.28.2",
-    "readyup": "0.44.0",
+    "readyup": "0.45.0",
     "tinyglobby": "0.2.17",
     "typescript": "6.0.3",
-    "vite": "8.3.5",
-    "vitest": "5.0.5",
+    "vite": "8.3.6",
+    "vitest": "5.1.0",
     "yaml": "2.9.1"
   },
   "peerDependencies": {

package/dist/esm/UserError.d.ts

@@ -1,8 +0,0 @@
-/**
- * A failure in what the user declared -- a config file, a `package.json` -- rather than a fault in nmr.
- *
- * The CLI boundary prints one of these as its message alone.
- */
-export declare class UserError extends Error {
-    constructor(message: string);
-}

package/dist/esm/UserError.js

@@ -1,6 +0,0 @@
-export class UserError extends Error {
-    constructor(message) {
-        super(message);
-        this.name = 'UserError';
-    }
-}

package/dist/esm/reportCliFailure.d.ts

@@ -1,9 +0,0 @@
-import type { Writable } from 'node:stream';
-/**
- * Writes a failure to the CLI's error stream: as its message alone when the user's own declaration caused it,
- * and with its stack otherwise.
- *
- * A stack records where nmr noticed a problem, which says nothing about the file that a user has to edit; for
- * nmr's own fault it is where a report has to start.
- */
-export declare function reportCliFailure(error: unknown, stderr: Writable): void;

package/dist/esm/reportCliFailure.js

@@ -1,11 +0,0 @@
-import { reportError } from '@williamthorsen/nmr-core';
-import { describeError, isError } from '@williamthorsen/toolbelt.errors';
-import { UserError } from "./UserError.js";
-export function reportCliFailure(error, stderr) {
-    if (error instanceof UserError) {
-        reportError(error.message, stderr);
-        return;
-    }
-    const detail = isError(error) && error.stack !== undefined ? error.stack : describeError(error);
-    stderr.write(`${detail}\n`);
-}