@williamthorsen/nmr 0.38.0 → 0.40.0

package/.readyup/kits/default.js

@@ -64,7 +64,7 @@ var workspaceScripts = {
   "test:unit": "pnpm exec vitest --project unit",
   "test:watch": `pnpm exec vitest ${GATE_PROJECTS} --watch`,
   typecheck: "tsgo --noEmit",
-  // The command is a string because neither half names an nmr command: both are binaries.
+  // The command is a string because neither half names an nmr command: Both are binaries.
   upgrade: "nmr-report-catalog && nmr-taze",
   "view-coverage": "open coverage/index.html"
 };
@@ -75,8 +75,8 @@ var rootScripts = {
   build: ["-R build"],
   check: [TYPECHECK_STEP, "fmt:check", "lint:check", "test"],
   "check:strict": [TYPECHECK_STEP, "fmt:check", "lint:strict", "test"],
-  // Excludes the audit, which in CI has a workflow of its own. The build is what the narrowed check runs
-  // against, so it declines the arguments rather than being narrowed by them.
+  // Excludes the audit, which in CI has a workflow of its own. The narrowed check runs against the build, so
+  // the build declines the arguments rather than being narrowed by them.
   ci: [{ run: "build", shouldDeclineArguments: true }, "check:strict"],
   clean: "nmr-clean",
   fix: ["lint", "fmt"],
@@ -86,8 +86,8 @@ var rootScripts = {
   lint: "eslint --fix .",
   "lint:check": "eslint .",
   "lint:strict": "strict-lint",
-  // The audit costs seconds and `ci` costs minutes, so the cheap gate fails first. The audit reads the
-  // dependency tree, which no argument narrowing the code under test says anything about.
+  // The audit takes seconds and `ci` takes minutes, so the cheap gate fails first. The audit reads the
+  // dependency tree, and an argument narrowing the code under test does not say anything about that tree.
   prepush: [{ run: "audit", shouldDeclineArguments: true }, "ci"],
   "report-overrides": "nmr-report-overrides",
   "root:check": [ROOT_TYPECHECK_STEP, "fmt:check", "root:lint:check", "root:test"],
@@ -99,7 +99,7 @@ var rootScripts = {
   "root:test:tool": "vitest --config ./vitest.root.config.ts --project tool",
   "root:test:unit": "vitest --config ./vitest.root.config.ts --project unit",
   "root:typecheck": "tsgo --noEmit",
-  // Carries the override report for the same reason `upgrade` does: both end in the tool that rewrites a
+  // Includes the override report for the same reason `upgrade` does: Both end in the tool that rewrites a
   // `pnpm.overrides` block, so both need the reporter's rejection ahead of them.
   "root:upgrade": "nmr-report-overrides && nmr-taze",
   test: ["root:test", "-R test"],
@@ -109,9 +109,9 @@ var rootScripts = {
   "test:unit": ["root:test:unit", "-R test:unit"],
   "test:watch": `vitest ${GATE_PROJECTS} --watch`,
   // Neither step is narrowable, so `nmr typecheck <file>` is rejected rather than checking that file under
-  // default options at the root and hunting for it in every package.
+  // default options at the root and searching for it in every package.
   typecheck: [ROOT_TYPECHECK_STEP, { run: "-R typecheck", shouldDeclineArguments: true }],
-  // The command is a string because neither half names an nmr command: both are binaries, and a composite
+  // The command is a string because neither half names an nmr command: Both are binaries, and a composite
   // element can name only a command.
   upgrade: "nmr-report-overrides && nmr-taze --recursive"
 };
@@ -124,6 +124,20 @@ function getDefaultRootScripts() {
 // src/tiers.ts
 import { readdirSync } from "node:fs";
 import path from "node:path";
+
+// src/git-ignored-paths.ts
+import { spawnSync } from "node:child_process";
+function listGitIgnoredPaths(dir) {
+  const result = spawnSync(
+    "git",
+    ["ls-files", "-z", "--others", "--ignored", "--exclude-standard", "--directory", "--no-empty-directory"],
+    { cwd: dir, encoding: "utf8" }
+  );
+  if (result.error !== void 0 || result.status !== 0) return [];
+  return result.stdout.split("\0").filter((entry) => entry !== "").toSorted();
+}
+
+// src/tiers.ts
 var TEST_DIR = "__tests__";
 var TEST_EXTENSIONS = "{ts,tsx}";
 var TEST_GLOB_PREFIX = `**/${TEST_DIR}/**`;
@@ -144,26 +158,27 @@ function hasTierInfix(filePath) {
 }
 var TEST_COLLECTION_EXCLUDE = [".git", "coverage", "dist", "node_modules"];
 var TIER_NAMES = ["unit", "tool", "localhost", "remote"];
-function collectTestFiles(dir, relativeDir, inTestDir, context) {
+function collectTestFiles(dir, relativeDir, isInTestDir, context) {
   const entries = readdirSync(dir, { withFileTypes: true });
   for (const entry of entries) {
     const relativePath = relativeDir === "" ? entry.name : `${relativeDir}/${entry.name}`;
     if (entry.isDirectory()) {
-      if (context.pruned.has(entry.name)) continue;
-      collectTestFiles(path.join(dir, entry.name), relativePath, inTestDir || entry.name === TEST_DIR, context);
-    } else if (inTestDir !== context.misplaced && TEST_FILE_PATTERN.test(entry.name)) {
-      context.found.push(relativePath);
+      if (context.pruned.has(entry.name) || context.ignoredPaths.has(`${relativePath}/`)) continue;
+      collectTestFiles(path.join(dir, entry.name), relativePath, isInTestDir || entry.name === TEST_DIR, context);
+    } else if (isInTestDir !== context.misplaced && TEST_FILE_PATTERN.test(entry.name) && !context.ignoredPaths.has(relativePath)) {
+      context.foundPaths.push(relativePath);
     }
   }
 }
-function walkTestFiles(rootDir, { exclude = [] }, misplaced) {
+function walkTestFiles(rootDir, { excludedBasenames = [] }, misplaced) {
   const context = {
-    found: [],
+    foundPaths: [],
+    ignoredPaths: new Set(listGitIgnoredPaths(rootDir)),
     misplaced,
-    pruned: /* @__PURE__ */ new Set([...TEST_COLLECTION_EXCLUDE, ...exclude])
+    pruned: /* @__PURE__ */ new Set([...TEST_COLLECTION_EXCLUDE, ...excludedBasenames])
   };
   collectTestFiles(rootDir, "", false, context);
-  return context.found.toSorted();
+  return context.foundPaths.toSorted();
 }
 
 // .readyup/kits/default.ts
@@ -210,21 +225,21 @@ var default_default = defineRdyKit({
           severity: "warn",
           quiet: true,
           check: toolVersionsHasNoPnpm,
-          fix: "Remove pnpm from .tool-versions \u2014 manage via packageManager field and corepack"
+          fix: "Remove pnpm from .tool-versions, and manage it through the packageManager field"
         },
         {
           name: "no package.json declares a pnpm field",
           severity: "error",
           quiet: true,
           check: () => noPnpmFieldInPackageJson(),
-          fix: "Move these settings into pnpm-workspace.yaml, quoting each version under `overrides`, or run `pnpx codemod run pnpm-v10-to-v11`. pnpm 11 reads no key from the `pnpm` field, so an override left there pins nothing while an upgrade run with `--write` goes on rewriting it"
+          fix: "Move these settings into pnpm-workspace.yaml, quoting each version under `overrides`, or run `pnpx codemod run pnpm-v10-to-v11`. pnpm 11 does not read any key from the `pnpm` field, so an override left there pins nothing while an upgrade run with `--write` goes on rewriting it"
         },
         {
           name: ".config/nmr.config.ts uses defineConfig",
           severity: "recommend",
           skip: () => !fileExists(".config/nmr.config.ts") ? "no nmr config file" : false,
           check: () => fileContains(".config/nmr.config.ts", /defineConfig/),
-          fix: "Wrap your config export with defineConfig() from @williamthorsen/nmr/config for type safety"
+          fix: "Wrap the config export with defineConfig() from @williamthorsen/nmr/config for type safety"
         },
         // `error` because falling short produces wrong results rather than a failure. Names and fixes are
         // getters because their version constants are declared below the kit.
@@ -236,7 +251,7 @@ var default_default = defineRdyKit({
           skip: () => !hasDevDependency("eslint") ? "eslint not installed" : false,
           check: hasSupportedEslintVersion,
           get fix() {
-            return `pnpm add --save-dev eslint@^${MIN_ESLINT_VERSION} \u2014 earlier releases resolve config from the working directory, so nmr's root lint and lint:check would apply the root config to every package`;
+            return `pnpm add --save-dev eslint@^${MIN_ESLINT_VERSION}. Earlier releases resolve config from the working directory, so nmr's root lint and lint:check would apply the root config to every package`;
           }
         },
         {
@@ -247,7 +262,7 @@ var default_default = defineRdyKit({
           skip: () => !hasDevDependency("@williamthorsen/strict-lint") ? "strict-lint not installed" : false,
           check: hasSupportedStrictLintVersion,
           get fix() {
-            return `pnpm add --save-dev @williamthorsen/strict-lint@^${MIN_STRICT_LINT_VERSION} \u2014 earlier releases pin ESLint to one config and resolve ceilings from the working directory, so nmr's root lint:strict would report the wrong rules for every package`;
+            return `pnpm add --save-dev @williamthorsen/strict-lint@^${MIN_STRICT_LINT_VERSION}. Earlier releases pin ESLint to one config and resolve ceilings from the working directory, so nmr's root lint:strict would report the wrong rules for every package`;
           }
         },
         // -- Root script cleanup -------------------------------------------------
@@ -256,7 +271,7 @@ var default_default = defineRdyKit({
           severity: "warn",
           quiet: true,
           check: noRedundantRootScripts,
-          fix: "Remove scripts from root package.json that nmr provides as built-in root scripts \u2014 invoke via nmr directly"
+          fix: "Remove scripts from root package.json that nmr provides as built-in root scripts, and invoke them through nmr directly"
         },
         // -- Git hooks -----------------------------------------------------------
         {
@@ -278,13 +293,13 @@ var default_default = defineRdyKit({
           name: "every bin target is a committed wrapper",
           severity: "error",
           check: () => everyBinTargetIsACommittedWrapper(),
-          fix: `Point each listed entry at a committed wrapper under bin/ that loads the build output at runtime. pnpm links a workspace package's bins during the install's link phase, which runs before anything is built, so a target that is not committed does not exist when pnpm reaches for it \u2014 and pnpm never retries, leaving the link missing for the life of the node_modules tree`
+          fix: `Point each listed entry at a committed wrapper under bin/ that loads the build output at runtime. pnpm links a workspace package's bins during the install's link phase, which runs before anything is built, so a target that is not committed does not exist when pnpm tries to link it. pnpm never retries, which leaves the link missing for the life of the node_modules tree`
         },
         {
           name: "every bin wrapper's build-output target is covered by files",
           severity: "warn",
           check: () => everyBinWrapperTargetIsCoveredByFiles(),
-          fix: "Add the build output directory to `files` in each listed package. npm and pnpm publish the bin target itself whatever `files` says, so the wrapper ships pointing at build output missing from the tarball"
+          fix: "Add the build output directory to `files` in each listed package. npm and pnpm publish the bin target itself whatever `files` says, so the wrapper is published pointing at build output missing from the tarball"
         },
         // -- Vitest projects -----------------------------------------------------
         {
@@ -298,7 +313,7 @@ var default_default = defineRdyKit({
           name: "every vitest.config builds on @williamthorsen/nmr/vitest",
           severity: "error",
           check: () => vitestConfigBuildsOnSharedConfig(),
-          fix: "Replace each listed config with: import { defineVitestConfig } from '@williamthorsen/nmr/vitest'; export default defineVitestConfig(); -- a config that does not call the factory declares no projects, so every tier-selecting test command fails against it. Pass your own settings to the factory as layers to keep them"
+          fix: "Replace each listed config with: import { defineVitestConfig } from '@williamthorsen/nmr/vitest'; export default defineVitestConfig(); -- a config that does not call the factory does not declare any projects, so every tier-selecting test command fails against it. Pass the repo's own settings to the factory as layers to keep them"
         },
         {
           name: "vitest.root.config.ts builds on @williamthorsen/nmr/vitest",
@@ -310,27 +325,27 @@ var default_default = defineRdyKit({
           name: "every workspace with a Vite config has a Vitest config",
           severity: "error",
           check: () => everyViteConfigHasVitestConfig(),
-          fix: "Add a vitest.config.ts calling defineVitestConfig() from @williamthorsen/nmr/vitest beside each listed vite.config -- Vitest stops its config search at the first directory holding either name, so the Vite config otherwise wins and the projects model is never reached"
+          fix: "Add a vitest.config.ts calling defineVitestConfig() from @williamthorsen/nmr/vitest beside each listed vite.config -- Vitest stops its config search at the first directory containing either name, so the Vite config otherwise wins and the projects model is never reached"
         },
         {
           name: "the test suite gates the test-file conventions",
           severity: "warn",
           check: () => testSuiteGatesTestFileConventions(),
-          fix: "Add a test of the repo's own under a __tests__ directory that declares the check: import { checkTestFileConventions } from '@williamthorsen/nmr/tests'; checkTestFileConventions(); -- passing `exclude` the directory names that the repo passes to `testCollectionExclude`. Without it no test run reports an untiered or misplaced test file, and this kit reports them in its place against nmr's built-in exclusions alone"
+          fix: "Add a test of the repo's own under a __tests__ directory that declares the check: import { checkTestFileConventions } from '@williamthorsen/nmr/tests'; checkTestFileConventions(); -- passing `excludedBasenames` the directory names that the repo passes to `testCollectionExclude`. Without it, the repo's test run does not report an untiered or misplaced test file, and this kit reports them in its place against only nmr's built-in exclusions and the paths that git ignores"
         },
         {
           name: "every test file names its isolation tier",
           severity: "error",
           skip: () => describeConventionsGuardSkip(),
           check: () => everyTestFileNamesItsTier(),
-          fix: `Rename each to <subject>[.<aspect>].<tier>.test.ts, naming one of ${TIER_NAMES.join(", ")}. Use tool for a test that reaches a program the environment supplies, which is where a retired .int. or .integration. file belongs. Only the segment before .test. selects a project, so an untiered file runs under the residual unit project and reports success`
+          fix: `Rename each to <subject>[.<aspect>].<tier>.test.ts, naming one of ${TIER_NAMES.join(", ")}. Use tool for a test that reaches a program supplied by the environment, which is the tier for a retired .int. or .integration. file. Only the segment before .test. selects a project, so an untiered file runs under the residual unit project and reports success`
         },
         {
-          name: "every test file sits under a __tests__ directory",
+          name: "every test file is under a __tests__ directory",
           severity: "error",
           skip: () => describeConventionsGuardSkip(),
           check: () => everyTestFileSitsUnderTestsDir(),
-          fix: "Move each into a __tests__ directory, the only place from which the shared Vitest config collects. No project collects a file outside one, so it runs nowhere and reports nothing. For a file that is not a test, declare checkTestFileConventions with its directory in `exclude` instead, which this check then defers to"
+          fix: "Move each into a __tests__ directory, the only place from which the shared Vitest config collects. Vitest does not collect a file outside one, so it runs nowhere and reports nothing. For a file that is not a test, declare checkTestFileConventions with its directory in `excludedBasenames` instead, which this check then defers to"
         },
         {
           name: "no package re-exports the ancestor Vitest config",
@@ -351,14 +366,14 @@ var default_default = defineRdyKit({
           name: "taze.config.ts builds on @williamthorsen/nmr/taze",
           severity: "warn",
           check: () => tazeConfigBuildsOnSharedConfig(),
-          fix: "Replace the taze config with: import { defineConfig } from '@williamthorsen/nmr/taze'; export default defineConfig(); \u2014 nmr's upgrade policy reaches a repo only through this file, so without it `nmr upgrade` reports nothing where dependencies are pinned to exact versions"
+          fix: "Replace the taze config with: import { defineConfig } from '@williamthorsen/nmr/taze'; export default defineConfig(); -- nmr's upgrade policy applies to a repo only through this file, so without it `nmr upgrade` does not report a dependency pinned to an exact version"
         },
         {
           name: "taze config declares no option taze discards",
           severity: "warn",
           quiet: true,
           check: () => tazeConfigAvoidsClobberedOptions(),
-          fix: "Set these through the upgrade script instead, as rootScripts: { upgrade: 'nmr-report-overrides && nmr-taze --recursive --request-timeout 90000' } in .config/nmr.config.ts, keeping the rest of the default script \u2014 taze's CLI writes a default for each of them over whatever the config file declares, so the value there never reaches taze (antfu-collective/taze#317). nmr already forwards a 30-second request timeout"
+          fix: "Set these through the upgrade script instead, as rootScripts: { upgrade: 'nmr-report-overrides && nmr-taze --recursive --request-timeout 90000' } in .config/nmr.config.ts, keeping the rest of the default script. taze's CLI writes a default for each of them over whatever the config file declares, so taze never uses the file's value (antfu-collective/taze#317). nmr already forwards a 30-second request timeout"
         },
         // -- Audit dependency --------------------------------------------------------
         {
@@ -373,7 +388,7 @@ var default_default = defineRdyKit({
           severity: "error",
           quiet: true,
           check: () => !fileExists("scripts/run-workspace-script.ts"),
-          fix: "Delete scripts/run-workspace-script.ts \u2014 nmr replaces this custom script runner"
+          fix: "Delete scripts/run-workspace-script.ts, because nmr replaces this custom script runner"
         },
         {
           name: 'no workspace packages reference run-workspace-script or "pnpm run ws"',
@@ -424,7 +439,7 @@ function allWorkspacePackagesCanBuild() {
   const packagesDir = join(process.cwd(), "packages");
   if (!existsSync(packagesDir)) return true;
   const entries = readdirSync2(packagesDir, { withFileTypes: true });
-  const failing = [];
+  const failingPackages = [];
   for (const entry of entries) {
     if (!entry.isDirectory()) continue;
     const pkgPath = `packages/${entry.name}/package.json`;
@@ -433,30 +448,33 @@ function allWorkspacePackagesCanBuild() {
     const hasBuildOverride = /"build"\s*:/.test(content);
     const hasDefaultBuildInputs = fileExists(`packages/${entry.name}/tsconfig.json`) && existsSync(join(packagesDir, entry.name, "src"));
     if (!hasBuildOverride && !hasDefaultBuildInputs) {
-      failing.push(entry.name);
+      failingPackages.push(entry.name);
     }
   }
-  if (failing.length === 0) return true;
+  if (failingPackages.length === 0) return true;
   return {
     ok: false,
-    detail: `missing build override or tsconfig.json + src/: ${failing.join(", ")}`
+    detail: `missing build override or tsconfig.json + src/: ${failingPackages.join(", ")}`
   };
 }
 function checkNoMatchingFiles(patterns, cwd) {
-  const found = findFiles(patterns, cwd);
-  if (found.length === 0) return true;
-  return { ok: false, detail: formatPaths(found) };
+  const foundFiles = findFiles(patterns, cwd);
+  if (foundFiles.length === 0) return true;
+  return { ok: false, detail: formatPaths(foundFiles) };
 }
 function checkRootVitestConfig(baseName, exportName, cwd) {
   const matches = findFiles([`${baseName}.${CONFIG_EXTENSIONS}`], cwd);
   if (matches.length === 0) {
     return { ok: false, detail: `${baseName}.ts is missing` };
   }
-  const stale = matches.filter(
+  const staleConfigs = matches.filter(
     (relativePath) => !importsSharedExport(readFileIn(cwd, relativePath), exportName, SHARED_VITEST_MODULE)
   );
-  if (stale.length === 0) return true;
-  return { ok: false, detail: `does not import ${exportName} from ${SHARED_VITEST_MODULE}: ${stale.join(", ")}` };
+  if (staleConfigs.length === 0) return true;
+  return {
+    ok: false,
+    detail: `does not import ${exportName} from ${SHARED_VITEST_MODULE}: ${staleConfigs.join(", ")}`
+  };
 }
 function prettierConfigBuildsOnSharedConfig(cwd = process.cwd()) {
   const configs = findFiles(
@@ -467,20 +485,20 @@ function prettierConfigBuildsOnSharedConfig(cwd = process.cwd()) {
   if (configs.length === 0) {
     return { ok: false, detail: describeMissingPrettierConfig(cwd) };
   }
-  const stale = configs.filter(
+  const staleConfigs = configs.filter(
     (relativePath) => !importsSharedExport(readFileIn(cwd, relativePath), "definePrettierConfig", SHARED_PRETTIER_MODULE)
   );
-  if (stale.length === 0) return true;
+  if (staleConfigs.length === 0) return true;
   return {
     ok: false,
-    detail: `does not import definePrettierConfig from ${SHARED_PRETTIER_MODULE}: ${stale.join(", ")}`
+    detail: `does not import definePrettierConfig from ${SHARED_PRETTIER_MODULE}: ${staleConfigs.join(", ")}`
   };
 }
 function describeMissingPrettierConfig(cwd) {
-  const inert = findFiles(INERT_PRETTIER_CONFIGS, cwd);
-  if (inert.length > 0) return `holds no code to call the factory: ${inert.join(", ")}`;
+  const inertConfigs = findFiles(INERT_PRETTIER_CONFIGS, cwd);
+  if (inertConfigs.length > 0) return `does not contain code that calls the factory: ${inertConfigs.join(", ")}`;
   if (hasPrettierConfigKey(cwd)) {
-    return 'holds no code to call the factory: the "prettier" key in package.json';
+    return 'does not contain code that calls the factory: the "prettier" key in package.json';
   }
   return ".prettierrc.js is missing";
 }
@@ -488,8 +506,8 @@ function hasPrettierConfigKey(cwd) {
   const manifest = readFileIn(cwd, "package.json");
   if (manifest === void 0) return false;
   try {
-    const parsed = JSON.parse(manifest);
-    return isRecord(parsed) && parsed["prettier"] !== void 0;
+    const parsedManifest = JSON.parse(manifest);
+    return isRecord(parsedManifest) && parsedManifest["prettier"] !== void 0;
   } catch {
     return false;
   }
@@ -502,11 +520,11 @@ function discoverMemberWorkspaces() {
   }
 }
 async function everyBinTargetIsACommittedWrapper() {
-  const discovery = discoverMemberWorkspaces();
-  if (!discovery.ok) return discovery;
-  const tracked = await listTrackedFiles();
-  const trackedPaths = tracked === void 0 ? void 0 : new Set(tracked);
-  const offenders = discovery.workspaces.flatMap(
+  const workspaceDiscovery = discoverMemberWorkspaces();
+  if (!workspaceDiscovery.ok) return workspaceDiscovery;
+  const trackedFiles = await listTrackedFiles();
+  const trackedPaths = trackedFiles === void 0 ? void 0 : new Set(trackedFiles);
+  const offenders = workspaceDiscovery.workspaces.flatMap(
     (workspace) => readBinEntries(workspace).flatMap((entry) => {
       const defect = describeBinTargetDefect(workspace, entry, trackedPaths);
       return defect === void 0 ? [] : [`${describeBinEntry(workspace, entry)} (${defect})`];
@@ -516,16 +534,18 @@ async function everyBinTargetIsACommittedWrapper() {
   return { ok: false, detail: formatPaths(offenders) };
 }
 function everyBinWrapperTargetIsCoveredByFiles() {
-  const discovery = discoverMemberWorkspaces();
-  if (!discovery.ok) return discovery;
+  const workspaceDiscovery = discoverMemberWorkspaces();
+  if (!workspaceDiscovery.ok) return workspaceDiscovery;
   const cwd = process.cwd();
-  const offenders = discovery.workspaces.flatMap((workspace) => {
+  const offenders = workspaceDiscovery.workspaces.flatMap((workspace) => {
     const files = workspace.packageJson["files"];
     if (!Array.isArray(files)) return [];
-    const published = new Set(files.flatMap((entry) => typeof entry === "string" ? [readFirstSegment(entry)] : []));
+    const publishedSegments = new Set(
+      files.flatMap((entry) => typeof entry === "string" ? [readFirstSegment(entry)] : [])
+    );
     return readBinEntries(workspace).flatMap((entry) => {
       const target = readWrapperTarget(cwd, workspace, entry);
-      if (target === void 0 || published.has(readFirstSegment(target))) return [];
+      if (target === void 0 || publishedSegments.has(readFirstSegment(target))) return [];
       return [`${describeBinEntry(workspace, entry)} -> ${target}`];
     });
   });
@@ -566,25 +586,25 @@ function readWrapperTarget(cwd, workspace, entry) {
   return posix.normalize(posix.join(posix.dirname(entry.target), specifier));
 }
 function everyTestFileNamesItsTier(cwd = process.cwd()) {
-  const untiered = findUntieredTestFiles(cwd);
-  if (untiered.length === 0) return true;
-  return { ok: false, detail: formatPaths(untiered) };
+  const untieredFiles = findUntieredTestFiles(cwd);
+  if (untieredFiles.length === 0) return true;
+  return { ok: false, detail: formatPaths(untieredFiles) };
 }
 function everyTestFileSitsUnderTestsDir(cwd = process.cwd()) {
-  const misplaced = findMisplacedTestFiles(cwd);
-  if (misplaced.length === 0) return true;
-  return { ok: false, detail: formatPaths(misplaced) };
+  const misplacedFiles = findMisplacedTestFiles(cwd);
+  if (misplacedFiles.length === 0) return true;
+  return { ok: false, detail: formatPaths(misplacedFiles) };
 }
 function everyViteConfigHasVitestConfig() {
-  const discovery = discoverMemberWorkspaces();
-  if (!discovery.ok) return discovery;
-  const unpaired = discovery.workspaces.flatMap((workspace) => {
+  const workspaceDiscovery = discoverMemberWorkspaces();
+  if (!workspaceDiscovery.ok) return workspaceDiscovery;
+  const unpairedConfigs = workspaceDiscovery.workspaces.flatMap((workspace) => {
     const viteConfigs = findWorkspaceConfigs(workspace, VITE_CONFIG_PATTERN);
     if (viteConfigs.length === 0) return [];
     return findWorkspaceConfigs(workspace, VITEST_CONFIG_PATTERN).length > 0 ? [] : viteConfigs;
   });
-  if (unpaired.length === 0) return true;
-  return { ok: false, detail: formatPaths(unpaired) };
+  if (unpairedConfigs.length === 0) return true;
+  return { ok: false, detail: formatPaths(unpairedConfigs) };
 }
 function findFiles(patterns, cwd) {
   return globSync(patterns, { cwd, exclude: (path2) => SCAN_EXCLUDE_DIRS.has(basename(path2)) }).map((path2) => path2.split(sep).join("/")).toSorted();
@@ -597,11 +617,11 @@ function formatPaths(paths) {
 ${paths.map((path2) => `      ${path2}`).join("\n")}`;
 }
 function getMinVersion() {
-  const picked = { "version": "0.38.0" };
-  if (typeof picked["version"] !== "string") {
+  const pickedFields = { "version": "0.40.0" };
+  if (typeof pickedFields["version"] !== "string") {
     throw new TypeError("nmr/package.json: 'version' must be a string");
   }
-  return picked["version"];
+  return pickedFields["version"];
 }
 function hasSupportedEslintVersion() {
   return hasMinDevDependencyVersion("eslint", MIN_ESLINT_VERSION, {
@@ -630,13 +650,13 @@ function isReExportOnly(content) {
   return statements.length > 0 && statements.every((line) => RE_EXPORT_LINE_PATTERN.test(line));
 }
 function noPnpmFieldInPackageJson(cwd = process.cwd()) {
-  const declaring = findFiles(["**/package.json"], cwd).flatMap((relativePath) => {
+  const declaringFiles = findFiles(["**/package.json"], cwd).flatMap((relativePath) => {
     const keys = readPnpmFieldKeys(readFileIn(cwd, relativePath));
     if (keys === void 0) return [];
     return [keys.length > 0 ? `${relativePath} (${keys.join(", ")})` : relativePath];
   });
-  if (declaring.length === 0) return true;
-  return { ok: false, detail: formatPaths(declaring) };
+  if (declaringFiles.length === 0) return true;
+  return { ok: false, detail: formatPaths(declaringFiles) };
 }
 function noReExportOnlyVitestConfigs(cwd = process.cwd()) {
   const nonRootConfigs = findFiles([`**/${VITEST_CONFIG_PATTERN}`], cwd).filter((path2) => path2.includes("/"));
@@ -650,11 +670,11 @@ function noRedundantRootScripts() {
   const scripts = pkg["scripts"];
   if (!isRecord(scripts)) return true;
   const builtInNames = Object.keys(getDefaultRootScripts());
-  const redundant = Object.keys(scripts).filter((name) => builtInNames.includes(name));
-  if (redundant.length === 0) return true;
+  const redundantNames = Object.keys(scripts).filter((name) => builtInNames.includes(name));
+  if (redundantNames.length === 0) return true;
   return {
     ok: false,
-    detail: `redundant: ${redundant.join(", ")}`
+    detail: `redundant: ${redundantNames.join(", ")}`
   };
 }
 function noRetiredVitestConfigs(cwd = process.cwd()) {
@@ -665,14 +685,14 @@ function noRetiredVitestConfigs(cwd = process.cwd()) {
 }
 function noUnguardedLefthookInstall(cwd = process.cwd()) {
   const scripts = readRootScripts(cwd);
-  const unguarded = INSTALL_LIFECYCLE_SCRIPTS.flatMap((name) => {
+  const unguardedScripts = INSTALL_LIFECYCLE_SCRIPTS.flatMap((name) => {
     const command = scripts[name];
     if (typeof command !== "string") return [];
     const isUnguarded = LEFTHOOK_INSTALL_PATTERN.test(command) && !LEFTHOOK_CHECK_INSTALL_PATTERN.test(command);
     return isUnguarded ? [`${name}: ${command}`] : [];
   });
-  if (unguarded.length === 0) return true;
-  return { ok: false, detail: formatPaths(unguarded) };
+  if (unguardedScripts.length === 0) return true;
+  return { ok: false, detail: formatPaths(unguardedScripts) };
 }
 function noWorkspaceRunScriptReferences() {
   const packagesDir = join(process.cwd(), "packages");
@@ -698,27 +718,27 @@ function readFileIn(cwd, relativePath) {
 }
 function readPnpmFieldKeys(content) {
   if (content === void 0) return void 0;
-  let parsed;
+  let parsedManifest;
   try {
-    parsed = JSON.parse(content);
+    parsedManifest = JSON.parse(content);
   } catch {
     return void 0;
   }
-  if (!isRecord(parsed)) return void 0;
-  const pnpm = parsed["pnpm"];
+  if (!isRecord(parsedManifest)) return void 0;
+  const pnpm = parsedManifest["pnpm"];
   return isRecord(pnpm) ? Object.keys(pnpm).toSorted() : void 0;
 }
 function readRootScripts(cwd) {
   const content = readFileIn(cwd, "package.json");
   if (content === void 0) return {};
-  let parsed;
+  let parsedManifest;
   try {
-    parsed = JSON.parse(content);
+    parsedManifest = JSON.parse(content);
   } catch {
     return {};
   }
-  if (!isRecord(parsed)) return {};
-  const scripts = parsed["scripts"];
+  if (!isRecord(parsedManifest)) return {};
+  const scripts = parsedManifest["scripts"];
   return isRecord(scripts) ? scripts : {};
 }
 function resolvesVersionViaWorkspace(range) {
@@ -729,11 +749,11 @@ function tazeConfigBuildsOnSharedConfig(cwd = process.cwd()) {
   if (configs.length === 0) {
     return { ok: false, detail: describeMissingTazeConfig(cwd) };
   }
-  const stale = configs.filter(
+  const staleConfigs = configs.filter(
     (relativePath) => !importsSharedExport(readFileIn(cwd, relativePath), "defineConfig", SHARED_TAZE_MODULE)
   );
-  if (stale.length === 0) return true;
-  return { ok: false, detail: `does not import defineConfig from ${SHARED_TAZE_MODULE}: ${stale.join(", ")}` };
+  if (staleConfigs.length === 0) return true;
+  return { ok: false, detail: `does not import defineConfig from ${SHARED_TAZE_MODULE}: ${staleConfigs.join(", ")}` };
 }
 function tazeConfigAvoidsClobberedOptions(cwd = process.cwd()) {
   const configs = findFiles([`taze.config.${CONFIG_EXTENSIONS}`], cwd);
@@ -741,22 +761,22 @@ function tazeConfigAvoidsClobberedOptions(cwd = process.cwd()) {
   for (const relativePath of configs) {
     const content = readFileIn(cwd, relativePath);
     if (content === void 0) continue;
-    const discarded = CLOBBERED_TAZE_OPTIONS.filter(({ pattern }) => pattern.test(content)).map(({ key }) => key);
-    if (discarded.length > 0) findings.push(`${relativePath}: ${discarded.join(", ")}`);
+    const discardedKeys = CLOBBERED_TAZE_OPTIONS.filter(({ pattern }) => pattern.test(content)).map(({ key }) => key);
+    if (discardedKeys.length > 0) findings.push(`${relativePath}: ${discardedKeys.join(", ")}`);
   }
   if (findings.length === 0) return true;
   return { ok: false, detail: formatPaths(findings) };
 }
 function describeMissingTazeConfig(cwd) {
-  const inert = findFiles(INERT_TAZE_CONFIGS, cwd);
-  if (inert.length > 0) return `holds no code to call the factory: ${inert.join(", ")}`;
+  const inertConfigs = findFiles(INERT_TAZE_CONFIGS, cwd);
+  if (inertConfigs.length > 0) return `does not contain code that calls the factory: ${inertConfigs.join(", ")}`;
   return "taze.config.ts is missing";
 }
 function testSuiteGatesTestFileConventions(cwd = process.cwd()) {
   if (findConventionsGuard(cwd) !== void 0) return true;
   return {
     ok: false,
-    detail: `no test file under __tests__ imports checkTestFileConventions from ${SHARED_TESTS_MODULE}`
+    detail: `the test files under __tests__ do not import checkTestFileConventions from ${SHARED_TESTS_MODULE}`
   };
 }
 function describeConventionsGuardSkip() {
@@ -777,9 +797,9 @@ function vitestConfigBuildsOnSharedConfig() {
   const cwd = process.cwd();
   const rootConfigs = findFiles([VITEST_CONFIG_PATTERN], cwd);
   if (rootConfigs.length === 0) return { ok: false, detail: "vitest.config.ts is missing" };
-  const discovery = discoverMemberWorkspaces();
-  if (!discovery.ok) return discovery;
-  const workspaceConfigs = discovery.workspaces.flatMap((workspace) => findWorkspaceConfigs(workspace, VITEST_CONFIG_PATTERN)).filter((relativePath) => !isOwnedByReExportCheck(cwd, relativePath));
+  const workspaceDiscovery = discoverMemberWorkspaces();
+  if (!workspaceDiscovery.ok) return workspaceDiscovery;
+  const workspaceConfigs = workspaceDiscovery.workspaces.flatMap((workspace) => findWorkspaceConfigs(workspace, VITEST_CONFIG_PATTERN)).filter((relativePath) => !isOwnedByReExportCheck(cwd, relativePath));
   const stale = [...rootConfigs, ...workspaceConfigs].filter(
     (relativePath) => !importsSharedExport(readFileIn(cwd, relativePath), "defineVitestConfig", SHARED_VITEST_MODULE)
   );

package/.readyup/manifest.json

@@ -11,12 +11,12 @@
       "esbuildVersion": "0.28.2",
       "inputs": [
         {
-          "hash": "488459c0",
+          "hash": "5f7bd316",
           "kind": "module",
           "path": "kits/default.ts"
         },
         {
-          "hash": "521b947a",
+          "hash": "9c1005ba",
           "kind": "inline",
           "path": "../package.json",
           "paths": [
@@ -24,17 +24,22 @@
           ]
         },
         {
-          "hash": "06bffeed",
+          "hash": "9336f4c0",
           "kind": "module",
           "path": "../src/default-scripts.ts"
         },
         {
-          "hash": "c53d0c51",
+          "hash": "d4828172",
+          "kind": "module",
+          "path": "../src/git-ignored-paths.ts"
+        },
+        {
+          "hash": "23646439",
           "kind": "module",
           "path": "../src/resolve-scripts.ts"
         },
         {
-          "hash": "2dfde614",
+          "hash": "19dec003",
           "kind": "module",
           "path": "../src/tiers.ts"
         }
@@ -43,8 +48,8 @@
       "path": "kits/default.js",
       "readyupVersion": "0.38.0",
       "source": "kits/default.ts",
-      "sourceHash": "488459c0",
-      "targetHash": "cbef780a"
+      "sourceHash": "5f7bd316",
+      "targetHash": "da11ca1f"
     }
   ]
 }