@williamthorsen/nmr 0.34.0 → 0.36.0

package/.readyup/kits/default.js

@@ -1,19 +1,40 @@
-/** @noformat — @generated. Do not edit. Compiled by rdy. */
+/** @noformat -- @generated. Do not edit. Compiled by rdy. */
 /* eslint-disable */
-export const __readyupVersion = "0.32.0";
+export const __readyupVersion = "0.35.0";
 
 
 // .readyup/kits/default.ts
 import { existsSync, globSync, readdirSync as readdirSync2 } from "node:fs";
-import { basename, join, sep } from "node:path";
+import { basename, dirname, join, posix, sep } from "node:path";
+
+// ../../node_modules/.pnpm/@williamthorsen+toolbelt.errors@0.7.0/node_modules/@williamthorsen/toolbelt.errors/dist/esm/4-release/isError.js
+function isError(error) {
+  return error instanceof Error || Object.prototype.toString.call(error) === "[object Error]";
+}
+
+// ../../node_modules/.pnpm/@williamthorsen+toolbelt.errors@0.7.0/node_modules/@williamthorsen/toolbelt.errors/dist/esm/4-release/describeError.js
+function describeError(error) {
+  try {
+    if (isError(error) && typeof error.message === "string" && error.message !== "") {
+      return error.message;
+    }
+    return String(error);
+  } catch {
+    return "[unstringifiable value]";
+  }
+}
+
+// .readyup/kits/default.ts
 import { defineRdyKit } from "readyup";
 import {
+  discoverWorkspaces,
   fileContains,
   fileExists,
   hasDevDependency,
   hasMinDevDependencyVersion,
   hasPackageJsonField,
   isRecord,
+  listTrackedFiles,
   readFile,
   readPackageJson
 } from "readyup/check-utils";
@@ -108,10 +129,8 @@ var TEST_EXTENSIONS = "{ts,tsx}";
 var TEST_GLOB_PREFIX = `**/${TEST_DIR}/**`;
 var TEST_FILE_PATTERN = /\.test\.tsx?$/;
 var ALL_TEST_PATTERNS = [`${TEST_GLOB_PREFIX}/*.test.${TEST_EXTENSIONS}`];
-function findTestFiles(rootDir) {
-  const found = [];
-  collectTestFiles(rootDir, "", false, found);
-  return found.toSorted();
+function findTestFiles(rootDir, options = {}) {
+  return walkTestFiles(rootDir, options, false);
 }
 function hasTierInfix(filePath) {
   const tiers = TIER_NAMES;
@@ -119,18 +138,27 @@ function hasTierInfix(filePath) {
 }
 var TEST_COLLECTION_EXCLUDE = [".git", "coverage", "dist", "node_modules"];
 var TIER_NAMES = ["unit", "tool", "localhost", "remote"];
-function collectTestFiles(dir, relativeDir, inTestDir, found) {
+function collectTestFiles(dir, relativeDir, inTestDir, context) {
   const entries = readdirSync(dir, { withFileTypes: true });
   for (const entry of entries) {
     const relativePath = relativeDir === "" ? entry.name : `${relativeDir}/${entry.name}`;
     if (entry.isDirectory()) {
-      if (TEST_COLLECTION_EXCLUDE.includes(entry.name)) continue;
-      collectTestFiles(path.join(dir, entry.name), relativePath, inTestDir || entry.name === TEST_DIR, found);
-    } else if (inTestDir && TEST_FILE_PATTERN.test(entry.name)) {
-      found.push(relativePath);
+      if (context.pruned.has(entry.name)) continue;
+      collectTestFiles(path.join(dir, entry.name), relativePath, inTestDir || entry.name === TEST_DIR, context);
+    } else if (inTestDir !== context.misplaced && TEST_FILE_PATTERN.test(entry.name)) {
+      context.found.push(relativePath);
     }
   }
 }
+function walkTestFiles(rootDir, { exclude = [] }, misplaced) {
+  const context = {
+    found: [],
+    misplaced,
+    pruned: /* @__PURE__ */ new Set([...TEST_COLLECTION_EXCLUDE, ...exclude])
+  };
+  collectTestFiles(rootDir, "", false, context);
+  return context.found.toSorted();
+}
 
 // .readyup/kits/default.ts
 var default_default = defineRdyKit({
@@ -231,6 +259,19 @@ var default_default = defineRdyKit({
           check: allWorkspacePackagesCanBuild,
           fix: `Add "build": ":" to packages that don't need a build, or ensure packages that use the default nmr build have a tsconfig.json and a src/ directory`
         },
+        // -- Bin targets ---------------------------------------------------------
+        {
+          name: "every bin target is a committed wrapper",
+          severity: "error",
+          check: () => everyBinTargetIsACommittedWrapper(),
+          fix: `Point each listed entry at a committed wrapper under bin/ that loads the build output at runtime. pnpm links a workspace package's bins during the install's link phase, which runs before anything is built, so a target that is not committed does not exist when pnpm reaches for it \u2014 and pnpm never retries, leaving the link missing for the life of the node_modules tree`
+        },
+        {
+          name: "every bin wrapper's build-output target is covered by files",
+          severity: "warn",
+          check: () => everyBinWrapperTargetIsCoveredByFiles(),
+          fix: "Add the build output directory to `files` in each listed package. npm and pnpm publish the bin target itself whatever `files` says, so the wrapper ships pointing at build output missing from the tarball"
+        },
         // -- Vitest projects -----------------------------------------------------
         {
           name: "no retired Vitest config variants",
@@ -240,10 +281,10 @@ var default_default = defineRdyKit({
           fix: "Delete every vitest.standalone.config.* and vitest.integration.config.*. nmr's test scripts select Vitest projects instead of naming config files"
         },
         {
-          name: "vitest.config.ts builds on @williamthorsen/nmr/vitest",
+          name: "every vitest.config builds on @williamthorsen/nmr/vitest",
           severity: "error",
           check: () => vitestConfigBuildsOnSharedConfig(),
-          fix: "Replace vitest.config.ts with: import { defineVitestConfig } from '@williamthorsen/nmr/vitest'; export default defineVitestConfig();"
+          fix: "Replace each listed config with: import { defineVitestConfig } from '@williamthorsen/nmr/vitest'; export default defineVitestConfig(); -- a config that does not call the factory declares no projects, so every tier-selecting test command fails against it. Pass your own settings to the factory as layers to keep them"
         },
         {
           name: "vitest.root.config.ts builds on @williamthorsen/nmr/vitest",
@@ -251,6 +292,12 @@ var default_default = defineRdyKit({
           check: () => vitestRootConfigBuildsOnSharedConfig(),
           fix: "Replace vitest.root.config.ts with: import { defineRootVitestConfig } from '@williamthorsen/nmr/vitest'; export default defineRootVitestConfig({ monorepoRoot: import.meta.dirname });"
         },
+        {
+          name: "every workspace with a Vite config has a Vitest config",
+          severity: "error",
+          check: () => everyViteConfigHasVitestConfig(),
+          fix: "Add a vitest.config.ts calling defineVitestConfig() from @williamthorsen/nmr/vitest beside each listed vite.config -- Vitest stops its config search at the first directory holding either name, so the Vite config otherwise wins and the projects model is never reached"
+        },
         {
           name: "every test file names its isolation tier",
           severity: "error",
@@ -312,7 +359,11 @@ var default_default = defineRdyKit({
   ]
 });
 var SCAN_EXCLUDE_DIRS = /* @__PURE__ */ new Set([".git", "coverage", "dist", "node_modules"]);
+var BUILD_OUTPUT_DIR = "dist";
+var WRAPPER_TARGET_PATTERN = /['"](\.\.?\/[^'"]+)['"]/;
 var CONFIG_EXTENSIONS = "{ts,mts,cts,js,mjs,cjs}";
+var VITE_CONFIG_PATTERN = `vite.config.${CONFIG_EXTENSIONS}`;
+var VITEST_CONFIG_PATTERN = `vitest.config.${CONFIG_EXTENSIONS}`;
 var SHARED_VITEST_MODULE = "@williamthorsen/nmr/vitest";
 var SHARED_PRETTIER_MODULE = "@williamthorsen/nmr/prettier";
 var INERT_PRETTIER_CONFIGS = [".prettierrc", ".prettierrc.{json,json5,yaml,yml,toml}"];
@@ -403,20 +454,105 @@ function hasPrettierConfigKey(cwd) {
     return false;
   }
 }
+function discoverMemberWorkspaces() {
+  try {
+    return { ok: true, workspaces: discoverWorkspaces({ filter: (workspace) => !workspace.isRoot }) };
+  } catch (error) {
+    return { ok: false, detail: `cannot enumerate workspaces: ${describeError(error)}` };
+  }
+}
+async function everyBinTargetIsACommittedWrapper() {
+  const discovery = discoverMemberWorkspaces();
+  if (!discovery.ok) return discovery;
+  const tracked = await listTrackedFiles();
+  const trackedPaths = tracked === void 0 ? void 0 : new Set(tracked);
+  const offenders = discovery.workspaces.flatMap(
+    (workspace) => readBinEntries(workspace).flatMap((entry) => {
+      const defect = describeBinTargetDefect(workspace, entry, trackedPaths);
+      return defect === void 0 ? [] : [`${describeBinEntry(workspace, entry)} (${defect})`];
+    })
+  );
+  if (offenders.length === 0) return true;
+  return { ok: false, detail: formatPaths(offenders) };
+}
+function everyBinWrapperTargetIsCoveredByFiles() {
+  const discovery = discoverMemberWorkspaces();
+  if (!discovery.ok) return discovery;
+  const cwd = process.cwd();
+  const offenders = discovery.workspaces.flatMap((workspace) => {
+    const files = workspace.packageJson["files"];
+    if (!Array.isArray(files)) return [];
+    const published = new Set(files.flatMap((entry) => typeof entry === "string" ? [readFirstSegment(entry)] : []));
+    return readBinEntries(workspace).flatMap((entry) => {
+      const target = readWrapperTarget(cwd, workspace, entry);
+      if (target === void 0 || published.has(readFirstSegment(target))) return [];
+      return [`${describeBinEntry(workspace, entry)} -> ${target}`];
+    });
+  });
+  if (offenders.length === 0) return true;
+  return { ok: false, detail: formatPaths(offenders) };
+}
+function describeBinEntry(workspace, entry) {
+  return `${workspace.name ?? workspace.dir}:${entry.command} -> ${entry.target}`;
+}
+function describeBinTargetDefect(workspace, entry, trackedPaths) {
+  if (readFirstSegment(entry.target) === BUILD_OUTPUT_DIR) return `names a path under ${BUILD_OUTPUT_DIR}/`;
+  if (trackedPaths === void 0) return void 0;
+  return trackedPaths.has(`${workspace.dir}/${entry.target}`) ? void 0 : "untracked";
+}
+function normalizeBinTarget(target) {
+  return target.replace(/^\.\//, "");
+}
+function readBinEntries(workspace) {
+  const bin = workspace.packageJson["bin"];
+  if (typeof bin === "string") {
+    const command = workspace.name?.split("/").at(-1) ?? basename(workspace.dir);
+    return [{ command, target: normalizeBinTarget(bin) }];
+  }
+  if (!isRecord(bin)) return [];
+  return Object.entries(bin).flatMap(
+    ([command, target]) => typeof target === "string" ? [{ command, target: normalizeBinTarget(target) }] : []
+  );
+}
+function readFirstSegment(entry) {
+  return normalizeBinTarget(entry).split("/", 1).at(0) ?? "";
+}
+function readWrapperTarget(cwd, workspace, entry) {
+  if (readFirstSegment(entry.target) === BUILD_OUTPUT_DIR) return void 0;
+  const content = readFileIn(cwd, `${workspace.dir}/${entry.target}`);
+  if (content === void 0) return void 0;
+  const specifier = WRAPPER_TARGET_PATTERN.exec(content)?.[1];
+  if (specifier === void 0) return void 0;
+  return posix.normalize(posix.join(posix.dirname(entry.target), specifier));
+}
 function everyTestFileNamesItsTier(cwd = process.cwd()) {
   const untiered = findTestFiles(cwd).filter((path2) => !hasTierInfix(path2));
   if (untiered.length === 0) return true;
   return { ok: false, detail: formatPaths(untiered) };
 }
+function everyViteConfigHasVitestConfig() {
+  const discovery = discoverMemberWorkspaces();
+  if (!discovery.ok) return discovery;
+  const unpaired = discovery.workspaces.flatMap((workspace) => {
+    const viteConfigs = findWorkspaceConfigs(workspace, VITE_CONFIG_PATTERN);
+    if (viteConfigs.length === 0) return [];
+    return findWorkspaceConfigs(workspace, VITEST_CONFIG_PATTERN).length > 0 ? [] : viteConfigs;
+  });
+  if (unpaired.length === 0) return true;
+  return { ok: false, detail: formatPaths(unpaired) };
+}
 function findFiles(patterns, cwd) {
   return globSync(patterns, { cwd, exclude: (path2) => SCAN_EXCLUDE_DIRS.has(basename(path2)) }).map((path2) => path2.split(sep).join("/")).toSorted();
 }
+function findWorkspaceConfigs(workspace, pattern) {
+  return findFiles([pattern], workspace.absolutePath).map((name) => `${workspace.dir}/${name}`);
+}
 function formatPaths(paths) {
   return `${paths.length} found:
 ${paths.map((path2) => `      ${path2}`).join("\n")}`;
 }
 function getMinVersion() {
-  const picked = { "version": "0.34.0" };
+  const picked = { "version": "0.36.0" };
   if (typeof picked["version"] !== "string") {
     throw new TypeError("nmr/package.json: 'version' must be a string");
   }
@@ -432,11 +568,17 @@ function hasSupportedStrictLintVersion() {
     exempt: resolvesVersionViaWorkspace
   });
 }
+function hasViteConfigBeside(cwd, relativePath) {
+  return findFiles([VITE_CONFIG_PATTERN], join(cwd, dirname(relativePath))).length > 0;
+}
 function importsSharedExport(content, exportName, moduleSpecifier) {
   if (content === void 0) return false;
   const pattern = new RegExp(String.raw`import\s*\{[^}]*\b${exportName}\b[^}]*\}\s*from\s*['"]${moduleSpecifier}['"]`);
   return pattern.test(content);
 }
+function isOwnedByReExportCheck(cwd, relativePath) {
+  return isReExportOnly(readFileIn(cwd, relativePath)) && !hasViteConfigBeside(cwd, relativePath);
+}
 function isReExportOnly(content) {
   if (content === void 0) return false;
   const statements = content.replace(/\/\*[\s\S]*?\*\//g, "").replace(/^\s*\/\/.*$/gm, "").split("\n").map((line) => line.trim()).filter((line) => line.length > 0);
@@ -452,8 +594,8 @@ function noPnpmFieldInPackageJson(cwd = process.cwd()) {
   return { ok: false, detail: formatPaths(declaring) };
 }
 function noReExportOnlyVitestConfigs(cwd = process.cwd()) {
-  const nonRootConfigs = findFiles([`**/vitest.config.${CONFIG_EXTENSIONS}`], cwd).filter((path2) => path2.includes("/"));
-  const reExports = nonRootConfigs.filter((path2) => isReExportOnly(readFileIn(cwd, path2)));
+  const nonRootConfigs = findFiles([`**/${VITEST_CONFIG_PATTERN}`], cwd).filter((path2) => path2.includes("/"));
+  const reExports = nonRootConfigs.filter((path2) => isOwnedByReExportCheck(cwd, path2));
   if (reExports.length === 0) return true;
   return { ok: false, detail: formatPaths(reExports) };
 }
@@ -546,15 +688,28 @@ function toolVersionsHasNoPnpm() {
   if (content === void 0) return true;
   return !/^pnpm\s/m.test(content);
 }
-function vitestConfigBuildsOnSharedConfig(cwd = process.cwd()) {
-  return checkRootVitestConfig("vitest.config", "defineVitestConfig", cwd);
+function vitestConfigBuildsOnSharedConfig() {
+  const cwd = process.cwd();
+  const rootConfigs = findFiles([VITEST_CONFIG_PATTERN], cwd);
+  if (rootConfigs.length === 0) return { ok: false, detail: "vitest.config.ts is missing" };
+  const discovery = discoverMemberWorkspaces();
+  if (!discovery.ok) return discovery;
+  const workspaceConfigs = discovery.workspaces.flatMap((workspace) => findWorkspaceConfigs(workspace, VITEST_CONFIG_PATTERN)).filter((relativePath) => !isOwnedByReExportCheck(cwd, relativePath));
+  const stale = [...rootConfigs, ...workspaceConfigs].filter(
+    (relativePath) => !importsSharedExport(readFileIn(cwd, relativePath), "defineVitestConfig", SHARED_VITEST_MODULE)
+  );
+  if (stale.length === 0) return true;
+  return { ok: false, detail: formatPaths(stale) };
 }
 function vitestRootConfigBuildsOnSharedConfig(cwd = process.cwd()) {
   return checkRootVitestConfig("vitest.root.config", "defineRootVitestConfig", cwd);
 }
 export {
   default_default as default,
+  everyBinTargetIsACommittedWrapper,
+  everyBinWrapperTargetIsCoveredByFiles,
   everyTestFileNamesItsTier,
+  everyViteConfigHasVitestConfig,
   hasSupportedEslintVersion,
   hasSupportedStrictLintVersion,
   noPnpmFieldInPackageJson,

package/.readyup/manifest.json

@@ -2,18 +2,21 @@
   "version": 1,
   "kits": [
     {
+      "bundledDependencies": {
+        "@williamthorsen/toolbelt.errors": "0.7.0"
+      },
       "checklists": [
         "nmr"
       ],
-      "esbuildVersion": "0.28.1",
+      "esbuildVersion": "0.28.2",
       "inputs": [
         {
-          "hash": "f58e8934",
+          "hash": "5c3cbdb9",
           "kind": "module",
           "path": "kits/default.ts"
         },
         {
-          "hash": "cbbd2a2c",
+          "hash": "6f709fcd",
           "kind": "inline",
           "path": "../package.json",
           "paths": [
@@ -26,22 +29,22 @@
           "path": "../src/default-scripts.ts"
         },
         {
-          "hash": "b42c7523",
+          "hash": "c53d0c51",
           "kind": "module",
           "path": "../src/resolve-scripts.ts"
         },
         {
-          "hash": "c2d21075",
+          "hash": "2dfde614",
           "kind": "module",
           "path": "../src/tiers.ts"
         }
       ],
       "name": "default",
       "path": "kits/default.js",
-      "readyupVersion": "0.32.0",
+      "readyupVersion": "0.35.0",
       "source": "kits/default.ts",
-      "sourceHash": "f58e8934",
-      "targetHash": "debdcb6e"
+      "sourceHash": "5c3cbdb9",
+      "targetHash": "c24a46ec"
     }
   ]
 }