@williamthorsen/nmr 0.18.0 → 0.18.2

package/README.md

@@ -3,13 +3,13 @@
 Context-aware script runner for PNPM monorepos. Ships an `nmr` (node-monorepo run) binary that provides centralized, consistent script execution across workspace packages and the monorepo root.
 
 <!-- section:release-notes -->
-## Release notes — v0.18.0 (2026-07-13)
+## Release notes — v0.18.2 (2026-07-18)
 
 ### 🐛 Bug fixes
 
-- Remove the attw check and the nmr-attw binary (#469)
+- Fail the build on aliased imports that escape the package source (#475)
 
-  Fixes an issue where a repo using nmr's default scripts could not pass `check:strict` without installing `@arethetypeswrong/cli` and conforming to inflexible requirements of questionable value. The `attw` check is removed.
+  Fixes an issue where an aliased import that resolved to a target outside the package's own source (one Node could not reach at runtime) passed the build but produced published output that crashed with a module-not-found error. `nmr-compile` now fails the build and reports the unresolvable import and where it pointed, so the problem surfaces before publish instead of in production. Aliased imports that resolve outside the source but remain genuinely external and runnable continue to build and ship unchanged.
 <!-- /section:release-notes -->
 
 ## Installation
@@ -144,7 +144,7 @@ These scripts are available out of the box. Repo-wide config (tier 2) and per-pa
 | `build`         | `compile`                                                |
 | `check`         | `typecheck`, `fmt:check`, `lint:check`, `test`           |
 | `check:strict`  | `typecheck`, `fmt:check`, `lint:strict`, `test:coverage` |
-| `clean`         | `pnpm exec rimraf dist/*`                                |
+| `clean`         | `nmr-clean`                                              |
 | `compile`       | `nmr-compile`                                            |
 | `fix`           | `lint`, `fmt`                                            |
 | `fix:check`     | `fmt:check`, `lint:check`                                |
@@ -179,7 +179,7 @@ A package gets this variant automatically when it contains a `vitest.integration
 | ------- | --------------------------------- |
 | `build` | `pnpm --recursive exec nmr build` |
 | `ci`    | `build`, `check:strict`           |
-| `clean` | `pnpm --recursive exec nmr clean` |
+| `clean` | `nmr-clean`                       |
 
 #### Check and quality
 
@@ -341,9 +341,17 @@ nmr sync-pnpm-version
 
 ## Standalone utilities
 
+### `nmr-clean`
+
+Remove a package's build output (`dist`) and its `nmr-compile` cache entry, leaving no state behind for the next build to skip on. Run from a package directory it cleans that package; run from the monorepo root it sweeps every workspace package in a single pass, running each package's resolved `clean` — so a package that overrides `clean`, in `.config/nmr.config.ts` or in its own `package.json`, gets its own command rather than the sweep. Removal is idempotent — cleaning an unbuilt package is a silent no-op. This is the default `clean` script at both levels.
+
+```bash
+nmr-clean
+```
+
 ### `nmr-compile`
 
-Compile a single package's `src` tree to `dist/esm` with the TypeScript compiler API, emitting `.js` and `.d.ts` in one pass. Because the compiler parses each source file, every relative import form — static, re-export, dynamic `import()`, and bare side-effect — is rewritten from `.ts` to `.js` in both outputs, and `.ts` occurrences inside strings and comments are left intact. tsconfig `paths` aliases are resolved to runnable relative `.js` specifiers in both outputs, sourced from the package's tsconfig. The build is skipped when no input has changed (a content-and-path hash is cached under `node_modules/.cache/nmr-compile/`, outside the published output). This is the default `compile` script — run it from a package directory.
+Compile a single package's `src` tree to `dist/esm` with the TypeScript compiler API, emitting `.js` and `.d.ts` in one pass. Because the compiler parses each source file, every relative import form — static, re-export, dynamic `import()`, and bare side-effect — is rewritten from `.ts` to `.js` in both outputs, and `.ts` occurrences inside strings and comments are left intact. tsconfig `paths` aliases are resolved to runnable relative `.js` specifiers in both outputs, sourced from the package's tsconfig. An aliased import whose target resolves outside the package's `src/` and is not resolvable without the alias mapping fails the build with a diagnostic, rather than being emitted verbatim to produce output that fails at runtime. The build is skipped when no input has changed and the previous output is still on disk (a content-and-path hash is cached under `node_modules/.cache/nmr-compile/`, outside the published output). Deleting the output by any means — `nmr clean`, `rm -rf dist`, `git clean` — therefore forces a rebuild rather than a skip. This is the default `compile` script — run it from a package directory.
 
 `typescript` is a peer dependency (`>=5.7.0`, required for `rewriteRelativeImportExtensions`); the consuming repo provides it. Relative imports in source must carry explicit `.ts` extensions for them to be rewritten.
 

package/bin/nmr-clean.js

@@ -0,0 +1,11 @@
+#!/usr/bin/env node
+try {
+  await import('../dist/esm/cli-clean.js');
+} catch (error) {
+  if (error.code === 'ERR_MODULE_NOT_FOUND') {
+    process.stderr.write('nmr-clean: build output not found — run `pnpm run build` first\n');
+  } else {
+    process.stderr.write(`nmr-clean: failed to load: ${error.message}\n`);
+  }
+  process.exit(1);
+}

package/dist/esm/cli-clean.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/esm/cli-clean.js

@@ -0,0 +1,9 @@
+import { reportError } from '@williamthorsen/nmr-core';
+import { runClean } from "./commands/clean.js";
+try {
+    await runClean(process.cwd());
+}
+catch (error) {
+    reportError(error instanceof Error ? error.message : String(error));
+    process.exitCode = 1;
+}

package/dist/esm/commands/build.js

@@ -1,5 +1,5 @@
 import { createHash } from 'node:crypto';
-import { existsSync, readFileSync, writeFileSync } from 'node:fs';
+import { existsSync, readdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { mkdir, readFile, writeFile } from 'node:fs/promises';
 import path from 'node:path';
 import { glob } from 'glob';
@@ -24,7 +24,7 @@ export async function buildPackage(packageDir, options = {}) {
         ignore: options.ignore ?? DEFAULT_IGNORE,
     });
     const dependencies = ['package.json', ...resolveTsconfigChain(packageDir)];
-    const { changed, currentHash } = await detectBuildChanges(packageDir, [...entryPoints, ...dependencies], emitConfig, cachePath);
+    const { changed, currentHash } = await detectBuildChanges(packageDir, [...entryPoints, ...dependencies], emitConfig, cachePath, hasExpectedBuildOutput(packageDir, outdir, entryPoints));
     if (!changed) {
         return;
     }
@@ -149,7 +149,15 @@ function resolveSpecifierReplacement(specifier, sourceContainingFile, compilerOp
             `Verify the tsconfig 'paths' mapping and that the target file exists.`);
     }
     if (!isWithin(sourceRoot, resolved.resolvedFileName)) {
-        return undefined;
+        const { paths: _paths, baseUrl: _baseUrl, rootDirs: _rootDirs, ...nodeResolutionOptions } = compilerOptions;
+        const bareResolved = ts.resolveModuleName(specifier, sourceContainingFile, nodeResolutionOptions, ts.sys).resolvedModule;
+        if (bareResolved) {
+            return undefined;
+        }
+        throw new Error(`nmr-compile: aliased import '${specifier}' from ${sourceContainingFile} resolves to ` +
+            `${resolved.resolvedFileName}, outside the package source root ${sourceRoot}, and does not resolve ` +
+            `the way Node will at runtime, which ignores tsconfig 'paths', 'baseUrl', and 'rootDirs'. The ` +
+            `emitted specifier would fail at runtime; re-anchor the alias inside the package.`);
     }
     const relative = toRelativeSpecifier(path.dirname(sourceContainingFile), resolved.resolvedFileName);
     return swapTypeScriptExtension(relative);
@@ -199,17 +207,29 @@ function findNearestNodeModulesHost(startDir) {
     }
     return current;
 }
-async function detectBuildChanges(packageDir, files, emitConfig, cachePath) {
+async function detectBuildChanges(packageDir, files, emitConfig, cachePath, outputPresent) {
     const packageName = path.basename(packageDir);
     const previousHash = existsSync(cachePath) ? readFileSync(cachePath, 'utf8') : undefined;
     const currentHash = await computeBuildHash(packageDir, files, emitConfig);
     if (previousHash === currentHash) {
-        console.info(`${SKIPPED_ICON} ${packageName}: No changes detected. Skipping build.`);
-        return { changed: false, currentHash };
+        if (outputPresent) {
+            console.info(`${SKIPPED_ICON} ${packageName}: No changes detected. Skipping build.`);
+            return { changed: false, currentHash };
+        }
+        console.info(`${PACKAGE_ICON} ${packageName}: Build output is missing. Rebuilding.`);
+        return { changed: true, currentHash };
     }
     console.info(`${PACKAGE_ICON} ${packageName}: Changes detected.`);
     return { changed: true, currentHash };
 }
+function hasExpectedBuildOutput(packageDir, outdir, entryPoints) {
+    const emitsOutput = entryPoints.some((entry) => !entry.endsWith('.d.ts'));
+    if (!emitsOutput) {
+        return true;
+    }
+    const outputDir = path.resolve(packageDir, outdir);
+    return existsSync(outputDir) && readdirSync(outputDir).length > 0;
+}
 async function writeBuildCache(cachePath, hash) {
     await mkdir(path.dirname(cachePath), { recursive: true });
     await writeFile(cachePath, hash);

package/dist/esm/commands/clean.d.ts

@@ -0,0 +1,2 @@
+export declare function cleanPackage(packageDir: string): Promise<void>;
+export declare function runClean(cwd?: string): Promise<void>;

package/dist/esm/commands/clean.js

@@ -0,0 +1,52 @@
+import { rm } from 'node:fs/promises';
+import path from 'node:path';
+import { loadConfig } from "../config.js";
+import { findContainingPackageDir, findMonorepoRoot, getWorkspacePackageDirs } from "../context.js";
+import { applyDevBin, buildWorkspaceRegistry, hasIntegrationTestConfig, resolveScript } from "../resolver.js";
+import { runCommand } from "../runner.js";
+import { resolveBuildCachePath } from "./build.js";
+const CLEAN_ICON = '🧹';
+const CLEAN_COMMAND = 'clean';
+const BUILT_IN_CLEAN = 'nmr-clean';
+const OUTPUT_ROOT = 'dist';
+export async function cleanPackage(packageDir) {
+    await rm(path.resolve(packageDir, OUTPUT_ROOT), { recursive: true, force: true });
+    await rm(resolveBuildCachePath(packageDir), { force: true });
+    console.info(`${CLEAN_ICON} ${path.basename(packageDir)}: Removed build output and cache.`);
+}
+export async function runClean(cwd = process.cwd()) {
+    let monorepoRoot;
+    try {
+        monorepoRoot = findMonorepoRoot(cwd);
+    }
+    catch {
+        await cleanPackage(cwd);
+        return;
+    }
+    const workspacePackageDirs = getWorkspacePackageDirs(monorepoRoot);
+    const packageDir = findContainingPackageDir(cwd, workspacePackageDirs);
+    if (packageDir !== undefined) {
+        await cleanPackage(packageDir);
+        return;
+    }
+    await sweepWorkspace(monorepoRoot, workspacePackageDirs);
+}
+async function sweepWorkspace(monorepoRoot, workspacePackageDirs) {
+    const config = await loadConfig(monorepoRoot);
+    for (const packageDir of workspacePackageDirs) {
+        const registry = buildWorkspaceRegistry(config, hasIntegrationTestConfig(packageDir));
+        const resolved = resolveScript(CLEAN_COMMAND, registry, packageDir, false);
+        if (resolved === undefined || resolved.command === '') {
+            continue;
+        }
+        if (resolved.command === BUILT_IN_CLEAN) {
+            await cleanPackage(packageDir);
+            continue;
+        }
+        const command = applyDevBin(resolved.command, config.devBin, monorepoRoot);
+        const exitCode = runCommand(command, packageDir);
+        if (exitCode !== 0) {
+            throw new Error(`nmr-clean: \`${command}\` failed in ${path.basename(packageDir)} with exit code ${exitCode}.`);
+        }
+    }
+}

package/dist/esm/default-scripts.js

@@ -2,7 +2,7 @@ export const commonWorkspaceScripts = {
     build: ['compile'],
     check: ['typecheck', 'fmt:check', 'lint:check', 'test'],
     'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage'],
-    clean: 'pnpm exec rimraf dist/*',
+    clean: 'nmr-clean',
     compile: 'nmr-compile',
     fix: ['lint', 'fmt'],
     'fix:check': ['fmt:check', 'lint:check'],
@@ -35,7 +35,7 @@ export const rootScripts = {
     'check:agent-files': 'nmr-sync-agent-files --check',
     'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage', 'check:agent-files'],
     ci: ['build', 'check:strict', 'audit'],
-    clean: 'pnpm --recursive exec nmr clean',
+    clean: 'nmr-clean',
     fix: ['lint', 'fmt'],
     'fix:check': ['fmt:check', 'lint:check'],
     fmt: 'sh -c \'prettier --list-different --write "${@:-.}"\' --',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@williamthorsen/nmr",
-  "version": "0.18.0",
+  "version": "0.18.2",
   "private": false,
   "description": "Context-aware script runner for PNPM monorepos",
   "keywords": [
@@ -38,6 +38,7 @@
   "bin": {
     "ensure-prepublish-hooks": "bin/ensure-prepublish-hooks.js",
     "nmr": "bin/nmr.js",
+    "nmr-clean": "bin/nmr-clean.js",
     "nmr-compile": "bin/nmr-compile.js",
     "nmr-report-overrides": "bin/nmr-report-overrides.js",
     "nmr-sync-agent-files": "bin/nmr-sync-agent-files.js",