@williamthorsen/nmr 0.17.2 → 0.18.0

package/README.md

@@ -3,18 +3,13 @@
 Context-aware script runner for PNPM monorepos. Ships an `nmr` (node-monorepo run) binary that provides centralized, consistent script execution across workspace packages and the monorepo root.
 
 <!-- section:release-notes -->
-## Release notes — v0.17.2 (2026-07-06)
+## Release notes — v0.18.0 (2026-07-13)
 
 ### 🐛 Bug fixes
 
-- Replace the raw attw script with an nmr-attw wrapper (#461)
+- Remove the attw check and the nmr-attw binary (#469)
 
-  Fixes the issues that made the default `nmr attw` check fail across monorepos:
-
-  - packages with no published API failed with a false `NoResolution` error;
-  - the check left stray `.tgz` files in the working tree ;
-  - output was a verbose per-package table; now output is terse on success, full diagnostics only on failure (`--verbose` to force full output);
-  - a missing `@arethetypeswrong/cli` gave a raw command-not-found; now a hint is given.
+  Fixes an issue where a repo using nmr's default scripts could not pass `check:strict` without installing `@arethetypeswrong/cli` and conforming to inflexible requirements of questionable value. The `attw` check is removed.
 <!-- /section:release-notes -->
 
 ## Installation
@@ -144,26 +139,25 @@ These scripts are available out of the box. Repo-wide config (tier 2) and per-pa
 
 ### Workspace scripts
 
-| Command         | Runs                                                             |
-| --------------- | ---------------------------------------------------------------- |
-| `attw`          | `nmr-attw`                                                       |
-| `build`         | `compile`                                                        |
-| `check`         | `typecheck`, `fmt:check`, `lint:check`, `test`                   |
-| `check:strict`  | `typecheck`, `fmt:check`, `lint:strict`, `test:coverage`, `attw` |
-| `clean`         | `pnpm exec rimraf dist/*`                                        |
-| `compile`       | `nmr-compile`                                                    |
-| `fix`           | `lint`, `fmt`                                                    |
-| `fix:check`     | `fmt:check`, `lint:check`                                        |
-| `fmt`           | `prettier --list-different --write .`                            |
-| `fmt:check`     | `prettier --check .`                                             |
-| `lint`          | `eslint --fix .`                                                 |
-| `lint:check`    | `eslint .`                                                       |
-| `lint:strict`   | `strict-lint`                                                    |
-| `test`          | `pnpm exec vitest`                                               |
-| `test:coverage` | `pnpm exec vitest --coverage`                                    |
-| `test:watch`    | `pnpm exec vitest --watch`                                       |
-| `typecheck`     | `tsgo --noEmit`                                                  |
-| `view-coverage` | `open coverage/index.html`                                       |
+| Command         | Runs                                                     |
+| --------------- | -------------------------------------------------------- |
+| `build`         | `compile`                                                |
+| `check`         | `typecheck`, `fmt:check`, `lint:check`, `test`           |
+| `check:strict`  | `typecheck`, `fmt:check`, `lint:strict`, `test:coverage` |
+| `clean`         | `pnpm exec rimraf dist/*`                                |
+| `compile`       | `nmr-compile`                                            |
+| `fix`           | `lint`, `fmt`                                            |
+| `fix:check`     | `fmt:check`, `lint:check`                                |
+| `fmt`           | `prettier --list-different --write .`                    |
+| `fmt:check`     | `prettier --check .`                                     |
+| `lint`          | `eslint --fix .`                                         |
+| `lint:check`    | `eslint .`                                               |
+| `lint:strict`   | `strict-lint`                                            |
+| `test`          | `pnpm exec vitest`                                       |
+| `test:coverage` | `pnpm exec vitest --coverage`                            |
+| `test:watch`    | `pnpm exec vitest --watch`                               |
+| `typecheck`     | `tsgo --noEmit`                                          |
+| `view-coverage` | `open coverage/index.html`                               |
 
 #### Integration test variant
 
@@ -189,12 +183,11 @@ A package gets this variant automatically when it contains a `vitest.integration
 
 #### Check and quality
 
-| Command             | Runs                                                                                  |
-| ------------------- | ------------------------------------------------------------------------------------- |
-| `attw`              | `pnpm --recursive exec nmr attw`                                                      |
-| `check`             | `typecheck`, `fmt:check`, `lint:check`, `test`                                        |
-| `check:agent-files` | `nmr-sync-agent-files --check`                                                        |
-| `check:strict`      | `typecheck`, `fmt:check`, `lint:strict`, `test:coverage`, `attw`, `check:agent-files` |
+| Command             | Runs                                                                          |
+| ------------------- | ----------------------------------------------------------------------------- |
+| `check`             | `typecheck`, `fmt:check`, `lint:check`, `test`                                |
+| `check:agent-files` | `nmr-sync-agent-files --check`                                                |
+| `check:strict`      | `typecheck`, `fmt:check`, `lint:strict`, `test:coverage`, `check:agent-files` |
 
 #### Fix
 
@@ -358,20 +351,6 @@ Compile a single package's `src` tree to `dist/esm` with the TypeScript compiler
 nmr-compile
 ```
 
-### `nmr-attw`
-
-Validate a package's published type-resolution surface with [`@arethetypeswrong/cli`](https://github.com/arethetypeswrong/arethetypeswrong.github.io). This is the default `attw` script — run it from a package directory. It wraps attw so that it behaves well across a monorepo:
-
-- **Skips packages with no publishable entry point** (neither `main` nor `exports`) — a message and exit 0, before attw runs. A package with no importable surface has nothing for attw to resolve, so running it would false-positive with `NoResolution`. A private package that _does_ declare `exports` is still checked.
-- **Leaves no `.tgz` in the working tree.** attw analyzes a packed tarball; nmr-attw packs into a temp directory instead of the package directory, so nothing litters the tree.
-- **Condenses output** to a terse per-package result on success and full attw diagnostics only on failure. Pass `--verbose` to print the full attw output on success too.
-
-`@arethetypeswrong/cli` is not bundled — a package that declares an entry point must have it installed; nmr-attw reports an actionable message if it is missing. Any other flags are forwarded to attw (the profile defaults to `esm-only`).
-
-```bash
-nmr-attw
-```
-
 ### `ensure-prepublish-hooks`
 
 Verify that all publishable workspace packages have a `prepublishOnly` script. Exits non-zero if any are missing.

package/dist/esm/default-scripts.js

@@ -1,8 +1,7 @@
 export const commonWorkspaceScripts = {
-    attw: 'nmr-attw',
     build: ['compile'],
     check: ['typecheck', 'fmt:check', 'lint:check', 'test'],
-    'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage', 'attw'],
+    'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage'],
     clean: 'pnpm exec rimraf dist/*',
     compile: 'nmr-compile',
     fix: ['lint', 'fmt'],
@@ -28,14 +27,13 @@ export const standardTestScripts = {
     'test:watch': 'pnpm exec vitest --watch',
 };
 export const rootScripts = {
-    attw: 'pnpm --recursive exec nmr attw',
     audit: ['audit:prod', 'audit:dev'],
     'audit:dev': 'pnpm exec v11y --dev',
     'audit:prod': 'pnpm exec v11y --prod',
     build: 'pnpm --recursive exec nmr build',
     check: ['typecheck', 'fmt:check', 'lint:check', 'test'],
     'check:agent-files': 'nmr-sync-agent-files --check',
-    'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage', 'attw', 'check:agent-files'],
+    'check:strict': ['typecheck', 'fmt:check', 'lint:strict', 'test:coverage', 'check:agent-files'],
     ci: ['build', 'check:strict', 'audit'],
     clean: 'pnpm --recursive exec nmr clean',
     fix: ['lint', 'fmt'],

package/dist/esm/helpers/package-json.d.ts

@@ -3,13 +3,10 @@ export interface PackageJson {
     private?: boolean;
     version?: string;
     packageManager?: string;
-    main?: string;
-    exports?: unknown;
     scripts?: Record<string, string>;
     pnpm?: {
         overrides?: Record<string, string>;
     };
 }
 export declare function readPackageJson(dir: string): PackageJson;
-export declare function hasPublishableEntryPoint(pkg: PackageJson): boolean;
 export declare function getPnpmOverrides(pkg: PackageJson): Record<string, string> | undefined;

package/dist/esm/helpers/package-json.js

@@ -2,8 +2,7 @@ import { readFileSync } from 'node:fs';
 import path from 'node:path';
 import { isObject } from "./type-guards.js";
 export function readPackageJson(dir) {
-    const content = readFileSync(path.join(dir, 'package.json'), 'utf8');
-    const parsed = JSON.parse(content);
+    const parsed = JSON.parse(readFileSync(path.join(dir, 'package.json'), 'utf8'));
     if (!isObject(parsed)) {
         throw new TypeError(`Invalid package.json in ${dir}: expected an object`);
     }
@@ -16,10 +15,6 @@ export function readPackageJson(dir) {
         pkg.version = parsed.version;
     if (typeof parsed.packageManager === 'string')
         pkg.packageManager = parsed.packageManager;
-    if (typeof parsed.main === 'string')
-        pkg.main = parsed.main;
-    if (parsed.exports !== undefined)
-        pkg.exports = parsed.exports;
     if (isObject(parsed.scripts)) {
         const scripts = {};
         for (const [key, val] of Object.entries(parsed.scripts)) {
@@ -41,9 +36,6 @@ export function readPackageJson(dir) {
     }
     return pkg;
 }
-export function hasPublishableEntryPoint(pkg) {
-    return pkg.main !== undefined || pkg.exports !== undefined;
-}
 export function getPnpmOverrides(pkg) {
     if (!isObject(pkg.pnpm))
         return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@williamthorsen/nmr",
-  "version": "0.17.2",
+  "version": "0.18.0",
   "private": false,
   "description": "Context-aware script runner for PNPM monorepos",
   "keywords": [
@@ -22,14 +22,22 @@
   "author": "William Thorsen <william@thorsen.dev> (https://github.com/williamthorsen)",
   "type": "module",
   "exports": {
-    ".": "./dist/esm/index.js",
-    "./scripts": "./dist/esm/scripts.js",
-    "./tests": "./dist/esm/tests/consistency.js"
+    ".": {
+      "types": "./dist/esm/index.d.ts",
+      "default": "./dist/esm/index.js"
+    },
+    "./scripts": {
+      "types": "./dist/esm/scripts.d.ts",
+      "default": "./dist/esm/scripts.js"
+    },
+    "./tests": {
+      "types": "./dist/esm/tests/consistency.d.ts",
+      "default": "./dist/esm/tests/consistency.js"
+    }
   },
   "bin": {
     "ensure-prepublish-hooks": "bin/ensure-prepublish-hooks.js",
     "nmr": "bin/nmr.js",
-    "nmr-attw": "bin/nmr-attw.js",
     "nmr-compile": "bin/nmr-compile.js",
     "nmr-report-overrides": "bin/nmr-report-overrides.js",
     "nmr-sync-agent-files": "bin/nmr-sync-agent-files.js",
@@ -45,7 +53,7 @@
     "jiti": "2.7.0",
     "yaml": "2.9.0",
     "zod": "4.4.3",
-    "@williamthorsen/nmr-core": "0.6.0"
+    "@williamthorsen/nmr-core": "0.7.0"
   },
   "devDependencies": {
     "@williamthorsen/toolbelt.strings": "3.1.4"

package/bin/nmr-attw.js

@@ -1,11 +0,0 @@
-#!/usr/bin/env node
-try {
-  await import('../dist/esm/cli-attw.js');
-} catch (error) {
-  if (error.code === 'ERR_MODULE_NOT_FOUND') {
-    process.stderr.write('nmr-attw: build output not found — run `pnpm run build` first\n');
-  } else {
-    process.stderr.write(`nmr-attw: failed to load: ${error.message}\n`);
-  }
-  process.exit(1);
-}

package/dist/esm/cli-attw.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/esm/cli-attw.js

@@ -1,15 +0,0 @@
-import { reportError } from '@williamthorsen/nmr-core';
-import { runAttw } from "./commands/attw.js";
-try {
-    process.exitCode = runAttw({
-        packageDir: process.cwd(),
-        argv: process.argv.slice(2),
-        stdout: process.stdout,
-        stderr: process.stderr,
-        env: process.env,
-    });
-}
-catch (error) {
-    reportError(error instanceof Error ? error.message : String(error));
-    process.exitCode = 1;
-}

package/dist/esm/commands/attw.d.ts

@@ -1,34 +0,0 @@
-import { type SpawnSyncReturns } from 'node:child_process';
-import type { Writable } from 'node:stream';
-export type SpawnSyncFn = (command: string, args: string[], options: {
-    cwd: string;
-    encoding: 'utf8';
-    env: NodeJS.ProcessEnv;
-}) => Pick<SpawnSyncReturns<string>, 'error' | 'status' | 'stdout' | 'stderr'>;
-export interface RunAttwOptions {
-    packageDir: string;
-    argv: string[];
-    stdout: Writable;
-    stderr: Writable;
-    env: NodeJS.ProcessEnv;
-    spawn?: SpawnSyncFn;
-}
-export declare function runAttw(options: RunAttwOptions): number;
-export declare function buildAttwArgs(argv: string[]): {
-    verbose: boolean;
-    attwArgs: string[];
-};
-interface AttwOutcome {
-    status: number;
-    stdout: string;
-    stderr: string;
-}
-export declare function formatAttwResult(params: {
-    label: string;
-    verbose: boolean;
-    attwStatus: number | null;
-    attwStdout: string;
-    attwStderr: string;
-}): AttwOutcome;
-export declare function attwSpawnErrorMessage(label: string, error: Error): string;
-export {};

package/dist/esm/commands/attw.js

@@ -1,87 +0,0 @@
-import { spawnSync } from 'node:child_process';
-import { mkdtempSync, readdirSync, rmSync } from 'node:fs';
-import { tmpdir } from 'node:os';
-import path from 'node:path';
-import { hasPublishableEntryPoint, readPackageJson } from "../helpers/package-json.js";
-const DEFAULT_PROFILE = 'esm-only';
-export function runAttw(options) {
-    const { packageDir, argv, stdout, stderr, env } = options;
-    const spawn = options.spawn ?? ((command, args, spawnOptions) => spawnSync(command, args, spawnOptions));
-    const pkg = readPackageJson(packageDir);
-    const label = pkg.name ?? path.basename(packageDir);
-    if (!hasPublishableEntryPoint(pkg)) {
-        stdout.write(`⛔ ${label}: No publishable entry point (no "main"/"exports"). Skipping attw.\n`);
-        return 0;
-    }
-    const { verbose, attwArgs } = buildAttwArgs(argv);
-    const tempDir = mkdtempSync(path.join(tmpdir(), 'nmr-attw-'));
-    try {
-        const pack = spawn('npm', ['pack', '--pack-destination', tempDir], { cwd: packageDir, encoding: 'utf8', env });
-        if (pack.error !== undefined) {
-            stderr.write(`nmr-attw: npm pack failed for ${label}: ${pack.error.message}\n`);
-            return 1;
-        }
-        if (pack.status !== 0) {
-            stderr.write(pack.stderr || `nmr-attw: npm pack failed for ${label}\n`);
-            return pack.status ?? 1;
-        }
-        const tarball = readdirSync(tempDir).find((file) => file.endsWith('.tgz'));
-        if (tarball === undefined) {
-            stderr.write(`nmr-attw: npm pack produced no tarball for ${label}\n`);
-            return 1;
-        }
-        const attw = spawn('attw', [path.join(tempDir, tarball), ...attwArgs], {
-            cwd: packageDir,
-            encoding: 'utf8',
-            env,
-        });
-        if (attw.error !== undefined) {
-            stderr.write(attwSpawnErrorMessage(label, attw.error));
-            return 1;
-        }
-        const outcome = formatAttwResult({
-            label,
-            verbose,
-            attwStatus: attw.status,
-            attwStdout: attw.stdout,
-            attwStderr: attw.stderr,
-        });
-        if (outcome.stdout)
-            stdout.write(outcome.stdout);
-        if (outcome.stderr)
-            stderr.write(outcome.stderr);
-        return outcome.status;
-    }
-    finally {
-        rmSync(tempDir, { recursive: true, force: true });
-    }
-}
-export function buildAttwArgs(argv) {
-    let verbose = false;
-    const attwArgs = [];
-    for (const arg of argv) {
-        if (arg === '--verbose' || arg === '-v') {
-            verbose = true;
-            continue;
-        }
-        attwArgs.push(arg);
-    }
-    if (!attwArgs.some((arg) => arg === '--profile' || arg.startsWith('--profile='))) {
-        attwArgs.push('--profile', DEFAULT_PROFILE);
-    }
-    return { verbose, attwArgs };
-}
-export function formatAttwResult(params) {
-    const { label, verbose, attwStatus, attwStdout, attwStderr } = params;
-    const status = attwStatus ?? 1;
-    if (status === 0 && !verbose) {
-        return { status: 0, stdout: `✓ ${label}: types OK\n`, stderr: '' };
-    }
-    return { status, stdout: attwStdout, stderr: attwStderr };
-}
-export function attwSpawnErrorMessage(label, error) {
-    if ('code' in error && error.code === 'ENOENT') {
-        return `⚠ ${label}: attw not found — install @arethetypeswrong/cli to validate published types.\n`;
-    }
-    return `nmr-attw: failed to run attw for ${label}: ${error.message}\n`;
-}